)]}'
{"nova/virt/libvirt/host.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fb43568f56858323f34fc45a38a43321acd7f038","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"                           are private and ephemeral; others are not."},{"line_number":1005,"context_line":"        :param usage_id: name of resource in secret"},{"line_number":1006,"context_line":"        :param password: optional secret value to set"},{"line_number":1007,"context_line":"        :param uuid: optional UUID of the secret; else one is generated by"},{"line_number":1008,"context_line":"            libvirt"},{"line_number":1009,"context_line":"        \"\"\""},{"line_number":1010,"context_line":"        secret_conf \u003d vconfig.LibvirtConfigSecret()"},{"line_number":1011,"context_line":"        secret_conf.ephemeral \u003d usage_type \u003d\u003d \u0027vtpm\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4bf45ef1","line":1008,"range":{"start_line":1007,"start_character":0,"end_line":1008,"end_character":19},"updated":"2020-07-14 11:18:30.000000000","message":"What\u0027s the use case for this?","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bda658af6a9bafbbce84bde3ec601b7d0157be2d","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"                           are private and ephemeral; others are not."},{"line_number":1005,"context_line":"        :param usage_id: name of resource in secret"},{"line_number":1006,"context_line":"        :param password: optional secret value to set"},{"line_number":1007,"context_line":"        :param uuid: optional UUID of the secret; else one is generated by"},{"line_number":1008,"context_line":"            libvirt"},{"line_number":1009,"context_line":"        \"\"\""},{"line_number":1010,"context_line":"        secret_conf \u003d vconfig.LibvirtConfigSecret()"},{"line_number":1011,"context_line":"        secret_conf.ephemeral \u003d usage_type \u003d\u003d \u0027vtpm\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_eb90d2ef","line":1008,"range":{"start_line":1007,"start_character":0,"end_line":1008,"end_character":19},"in_reply_to":"bf51134e_4bf45ef1","updated":"2020-07-14 12:09:40.000000000","message":"This is used in a later patch at [1]. We need the specific UUID so that we know what to lookup when creating the vTPM device [2].\n\n[1] https://review.opendev.org/#/c/631363/49/nova/virt/libvirt/driver.py@6553\n[2] https://review.opendev.org/#/c/631363/49/nova/virt/libvirt/driver.py@5510","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f68eddde81202f27f51c78dccef5e70d926165a0","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"                           are private and ephemeral; others are not."},{"line_number":1005,"context_line":"        :param usage_id: name of resource in secret"},{"line_number":1006,"context_line":"        :param password: optional secret value to set"},{"line_number":1007,"context_line":"        :param uuid: optional UUID of the secret; else one is generated by"},{"line_number":1008,"context_line":"            libvirt"},{"line_number":1009,"context_line":"        \"\"\""},{"line_number":1010,"context_line":"        secret_conf \u003d vconfig.LibvirtConfigSecret()"},{"line_number":1011,"context_line":"        secret_conf.ephemeral \u003d usage_type \u003d\u003d \u0027vtpm\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_66f19701","line":1008,"range":{"start_line":1007,"start_character":0,"end_line":1008,"end_character":19},"in_reply_to":"bf51134e_eb90d2ef","updated":"2020-07-14 12:44:11.000000000","message":"I see thanks, this isn\u0027t how we handle the secrets with encrypted volumes FWIW. We create the secret while connecting the volume and later lookup the libvirt secret using the volume id while building the libvirt config objects :\n\nhttps://github.com/openstack/nova/blob/becca833903e38d8b1c7c983f0c84ebaa13eb62b/nova/virt/libvirt/volume/volume.py#L118-L128\n\nI\u0027m not sure how I feel about using the barbican UUID as the libvirt secret UUID given they are technically different things but I guess it does make debugging failures easier.","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fb43568f56858323f34fc45a38a43321acd7f038","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"            libvirt"},{"line_number":1009,"context_line":"        \"\"\""},{"line_number":1010,"context_line":"        secret_conf \u003d vconfig.LibvirtConfigSecret()"},{"line_number":1011,"context_line":"        secret_conf.ephemeral \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1012,"context_line":"        secret_conf.private \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1013,"context_line":"        secret_conf.usage_id \u003d usage_id"},{"line_number":1014,"context_line":"        secret_conf.uuid \u003d uuid"},{"line_number":1015,"context_line":"        if usage_type in (\u0027rbd\u0027, \u0027ceph\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4bcd7eb5","line":1012,"range":{"start_line":1011,"start_character":0,"end_line":1012,"end_character":50},"updated":"2020-07-14 11:18:30.000000000","message":"These should be kwargs IMHO, I think we can make both default to True in a later change.","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bda658af6a9bafbbce84bde3ec601b7d0157be2d","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"            libvirt"},{"line_number":1009,"context_line":"        \"\"\""},{"line_number":1010,"context_line":"        secret_conf \u003d vconfig.LibvirtConfigSecret()"},{"line_number":1011,"context_line":"        secret_conf.ephemeral \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1012,"context_line":"        secret_conf.private \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1013,"context_line":"        secret_conf.usage_id \u003d usage_id"},{"line_number":1014,"context_line":"        secret_conf.uuid \u003d uuid"},{"line_number":1015,"context_line":"        if usage_type in (\u0027rbd\u0027, \u0027ceph\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_6b44c274","line":1012,"range":{"start_line":1011,"start_character":0,"end_line":1012,"end_character":50},"in_reply_to":"bf51134e_4bcd7eb5","updated":"2020-07-14 12:09:40.000000000","message":"Given that nothing else is using these at the moment, I\u0027m tempted to suggest this should be left until we need it. As it stands, I don\u0027t think there are any use cases where we wouldn\u0027t want these set for vtpm and there are possible implications for other types that we\u0027d need to consider before switching those","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f68eddde81202f27f51c78dccef5e70d926165a0","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"            libvirt"},{"line_number":1009,"context_line":"        \"\"\""},{"line_number":1010,"context_line":"        secret_conf \u003d vconfig.LibvirtConfigSecret()"},{"line_number":1011,"context_line":"        secret_conf.ephemeral \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1012,"context_line":"        secret_conf.private \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1013,"context_line":"        secret_conf.usage_id \u003d usage_id"},{"line_number":1014,"context_line":"        secret_conf.uuid \u003d uuid"},{"line_number":1015,"context_line":"        if usage_type in (\u0027rbd\u0027, \u0027ceph\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_e6e4873e","line":1012,"range":{"start_line":1011,"start_character":0,"end_line":1012,"end_character":50},"in_reply_to":"bf51134e_6b44c274","updated":"2020-07-14 12:44:11.000000000","message":"ACK that\u0027s fine, I might FUP with this later on.","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fb43568f56858323f34fc45a38a43321acd7f038","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        secret_conf.private \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1013,"context_line":"        secret_conf.usage_id \u003d usage_id"},{"line_number":1014,"context_line":"        secret_conf.uuid \u003d uuid"},{"line_number":1015,"context_line":"        if usage_type in (\u0027rbd\u0027, \u0027ceph\u0027):"},{"line_number":1016,"context_line":"            secret_conf.usage_type \u003d \u0027ceph\u0027"},{"line_number":1017,"context_line":"        elif usage_type \u003d\u003d \u0027iscsi\u0027:"},{"line_number":1018,"context_line":"            secret_conf.usage_type \u003d \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_8b94b68c","line":1015,"range":{"start_line":1015,"start_character":8,"end_line":1015,"end_character":41},"updated":"2020-07-14 11:18:30.000000000","message":"nit - we can replace this entire block if we remove the callers using usage_type\u003d\u0027rbd\u0027","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f68eddde81202f27f51c78dccef5e70d926165a0","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        secret_conf.private \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1013,"context_line":"        secret_conf.usage_id \u003d usage_id"},{"line_number":1014,"context_line":"        secret_conf.uuid \u003d uuid"},{"line_number":1015,"context_line":"        if usage_type in (\u0027rbd\u0027, \u0027ceph\u0027):"},{"line_number":1016,"context_line":"            secret_conf.usage_type \u003d \u0027ceph\u0027"},{"line_number":1017,"context_line":"        elif usage_type \u003d\u003d \u0027iscsi\u0027:"},{"line_number":1018,"context_line":"            secret_conf.usage_type \u003d \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_86c2eb83","line":1015,"range":{"start_line":1015,"start_character":8,"end_line":1015,"end_character":41},"in_reply_to":"bf51134e_4b473e78","updated":"2020-07-14 12:44:11.000000000","message":"True but we can add a constant for that with a simple check. Something for a FUP.","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bda658af6a9bafbbce84bde3ec601b7d0157be2d","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"        secret_conf.private \u003d usage_type \u003d\u003d \u0027vtpm\u0027"},{"line_number":1013,"context_line":"        secret_conf.usage_id \u003d usage_id"},{"line_number":1014,"context_line":"        secret_conf.uuid \u003d uuid"},{"line_number":1015,"context_line":"        if usage_type in (\u0027rbd\u0027, \u0027ceph\u0027):"},{"line_number":1016,"context_line":"            secret_conf.usage_type \u003d \u0027ceph\u0027"},{"line_number":1017,"context_line":"        elif usage_type \u003d\u003d \u0027iscsi\u0027:"},{"line_number":1018,"context_line":"            secret_conf.usage_type \u003d \u0027iscsi\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4b473e78","line":1015,"range":{"start_line":1015,"start_character":8,"end_line":1015,"end_character":41},"in_reply_to":"bf51134e_8b94b68c","updated":"2020-07-14 12:09:40.000000000","message":"Agreed, though we\u0027d still need a check to make sure the usage_type is one that we support. Can tackle in a follow-up","commit_id":"29614924259a31127de8d1c8ee47369a6acf9a3c"}]}