)]}'
{"nova/crypto.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"00b4b0be243a6dec8287fbe9b0f679b7ab54fec0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"_VTPM_SECRET_BYTE_LENGTH \u003d 384"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def _get_key_manager():"},{"line_number":58,"context_line":"    global _KEYMGR"},{"line_number":59,"context_line":"    if _KEYMGR is None:"},{"line_number":60,"context_line":"        _KEYMGR \u003d key_manager.API(configuration\u003dCONF)"},{"line_number":61,"context_line":"    return _KEYMGR"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def generate_fingerprint(public_key: str) -\u003e str:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e64d0b9a","line":61,"range":{"start_line":57,"start_character":0,"end_line":61,"end_character":18},"updated":"2020-07-23 11:43:25.000000000","message":"I guess this is a FUP for me to also do this in the actual libvirt driver when fetching encrypted volume secrets.","commit_id":"6ac228782651bc319fa149749e0d229f90f47adc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c80b92391efdf1538cad3609fb16f509269f9e4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            secret \u003d key_mgr.get(context, secret_uuid)"},{"line_number":194,"context_line":"            # assert secret_uuid \u003d\u003d secret.id ?"},{"line_number":195,"context_line":"            LOG.debug("},{"line_number":196,"context_line":"                \"Found existing vTPM secret with UUID %s.\","},{"line_number":197,"context_line":"                secret_uuid, instance\u003dinstance)"},{"line_number":198,"context_line":"            return secret.id, secret.get_encoded()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_58264418","line":195,"updated":"2020-07-24 07:32:04.000000000","message":"this could become very talkative  (and I\u0027m pretty sure operators can look at Castellan API logs for getting this instead), but given it\u0027s a DEBUG level, cool with me.","commit_id":"6ac228782651bc319fa149749e0d229f90f47adc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c80b92391efdf1538cad3609fb16f509269f9e4","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    instance\u0027s emulated TPM."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    This operation is idempotent: if the instance never had a vTPM secret, OR"},{"line_number":231,"context_line":"    if the secret has already been deleted, it is a no-op."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    The ``vtpm_secret_uuid`` member of the instance\u0027s system_metadata is"},{"line_number":234,"context_line":"    cleared as a side effect of this method."}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_f88478d5","line":231,"updated":"2020-07-24 07:32:04.000000000","message":"ack","commit_id":"6ac228782651bc319fa149749e0d229f90f47adc"}],"nova/tests/unit/test_crypto.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2c80b92391efdf1538cad3609fb16f509269f9e4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from castellan.common import exception as castellan_exception"},{"line_number":22,"context_line":"from cryptography.hazmat import backends"},{"line_number":23,"context_line":"from cryptography.hazmat.primitives import serialization"},{"line_number":24,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_984e1cbf","line":21,"updated":"2020-07-24 07:32:04.000000000","message":"Eeek, can\u0027t castellanclient provide this exception without needing us to pull the whole service ?","commit_id":"6ac228782651bc319fa149749e0d229f90f47adc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6ce0d2916eb907a3ea4c774b0b9a970359732aae","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from castellan.common import exception as castellan_exception"},{"line_number":22,"context_line":"from cryptography.hazmat import backends"},{"line_number":23,"context_line":"from cryptography.hazmat.primitives import serialization"},{"line_number":24,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_b8f1606d","line":21,"in_reply_to":"bf51134e_984e1cbf","updated":"2020-07-24 07:36:55.000000000","message":"\u003e Eeek, can\u0027t castellanclient provide this exception without needing\n \u003e us to pull the whole service ?\n\nNevermind, per https://docs.openstack.org/castellan/latest/user/index.html#basic-usage this is the correct usage pattern.","commit_id":"6ac228782651bc319fa149749e0d229f90f47adc"}]}