)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6ea97b9aed5f9d2f2eec9b56455f25aa1c9d201b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use absolute path during qemu img rebase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During volume snapshot delete nova removes the snapshot from the backing"},{"line_number":10,"context_line":"file chain. During that nova checks the existence of such file. However"},{"line_number":11,"context_line":"in some cases (see the bug report) the path is relative and therefore"},{"line_number":12,"context_line":"os.path.exists fails."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_8fd73b50","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":29},"updated":"2020-07-21 10:51:28.000000000","message":"It\u0027s worth pointing out this only happens as part of an assisted volume snapshot deletion which pretty much only means that cinder is using the NFS backend when the instance isn\u0027t running.","commit_id":"567b8c4fa98126345a3c08594dc990927aca6d8a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6ea97b9aed5f9d2f2eec9b56455f25aa1c9d201b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use absolute path during qemu img rebase"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During volume snapshot delete nova removes the snapshot from the backing"},{"line_number":10,"context_line":"file chain. During that nova checks the existence of such file. However"},{"line_number":11,"context_line":"in some cases (see the bug report) the path is relative and therefore"},{"line_number":12,"context_line":"os.path.exists fails."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch makes sure that nova uses the volume absolute path to make"},{"line_number":15,"context_line":"the backing file path absolute as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_efe4f73e","line":12,"range":{"start_line":10,"start_character":64,"end_line":12,"end_character":21},"updated":"2020-07-21 10:51:28.000000000","message":"It\u0027s the removal of the final snapshot in the chain AFAICT.","commit_id":"567b8c4fa98126345a3c08594dc990927aca6d8a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:gate","change_message_id":"a6e0ae3afbed9ffc4f98519ca382f0daf2220788","unresolved":false,"context_lines":[{"line_number":2931,"context_line":"            # explicitly set the backing file format to avoid any security"},{"line_number":2932,"context_line":"            # concerns related to file format auto detection."},{"line_number":2933,"context_line":"            backing_file_name \u003d os.path.basename(rebase_base)  # relative path"},{"line_number":2934,"context_line":"            volume_path \u003d os.path.dirname(active_disk_object.source_path)"},{"line_number":2935,"context_line":"            backing_file \u003d os.path.join(volume_path, backing_file_name)"},{"line_number":2936,"context_line":"            b_file_fmt \u003d images.qemu_img_info(backing_file).file_format"},{"line_number":2937,"context_line":"            qemu_img_extra_arg \u003d [\u0027-F\u0027, b_file_fmt]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1a09d994","line":2934,"updated":"2020-08-11 11:02:10.000000000","message":"pep8: error: Name \u0027active_disk_object\u0027 is not defined","commit_id":"052c5632178081c242ed373b565f68a519ec22b4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6bb373083cff25bc872f8ab31ef6a253d13c1d2a","unresolved":false,"context_lines":[{"line_number":2963,"context_line":"            # explicitly set the backing file format to avoid any security"},{"line_number":2964,"context_line":"            # concerns related to file format auto detection."},{"line_number":2965,"context_line":"            backing_file_name \u003d os.path.basename(rebase_base)  # relative path"},{"line_number":2966,"context_line":"            volume_path \u003d os.path.dirname(active_disk_object.source_path)"},{"line_number":2967,"context_line":"            backing_file \u003d os.path.join(volume_path, backing_file_name)"},{"line_number":2968,"context_line":"            b_file_fmt \u003d images.qemu_img_info(backing_file).file_format"},{"line_number":2969,"context_line":"            qemu_img_extra_arg \u003d [\u0027-F\u0027, b_file_fmt]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_437ee5ae","line":2966,"updated":"2020-08-26 23:09:15.000000000","message":"pep8: error: Name \u0027active_disk_object\u0027 is not defined","commit_id":"81cedcbb40c5b2d11a80f4019a9ea714880eeee7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37c16d0a2428029f4bfa1b0ece22f57cc51bb4d6","unresolved":false,"context_lines":[{"line_number":2963,"context_line":"            # explicitly set the backing file format to avoid any security"},{"line_number":2964,"context_line":"            # concerns related to file format auto detection."},{"line_number":2965,"context_line":"            backing_file_name \u003d os.path.basename(rebase_base)  # relative path"},{"line_number":2966,"context_line":"            volume_path \u003d os.path.dirname(active_disk_object.source_path)"},{"line_number":2967,"context_line":"            backing_file \u003d os.path.join(volume_path, backing_file_name)"},{"line_number":2968,"context_line":"            b_file_fmt \u003d images.qemu_img_info(backing_file).file_format"},{"line_number":2969,"context_line":"            qemu_img_extra_arg \u003d [\u0027-F\u0027, b_file_fmt]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_17ec2bb9","line":2966,"range":{"start_line":2966,"start_character":42,"end_line":2966,"end_character":61},"updated":"2020-08-26 18:22:08.000000000","message":"you need to drop this now","commit_id":"81cedcbb40c5b2d11a80f4019a9ea714880eeee7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"adc5496f258af05ea76c8345fa93295defb3e4d1","unresolved":false,"context_lines":[{"line_number":2963,"context_line":"            # explicitly set the backing file format to avoid any security"},{"line_number":2964,"context_line":"            # concerns related to file format auto detection."},{"line_number":2965,"context_line":"            backing_file_name \u003d os.path.basename(rebase_base)  # relative path"},{"line_number":2966,"context_line":"            volume_path \u003d os.path.dirname(active_disk_object.source_path)"},{"line_number":2967,"context_line":"            backing_file \u003d os.path.join(volume_path, backing_file_name)"},{"line_number":2968,"context_line":"            b_file_fmt \u003d images.qemu_img_info(backing_file).file_format"},{"line_number":2969,"context_line":"            qemu_img_extra_arg \u003d [\u0027-F\u0027, b_file_fmt]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cc6dfd32","line":2966,"in_reply_to":"9f560f44_437ee5ae","updated":"2020-08-27 11:11:41.000000000","message":"Yep, it seems this was the change I17357d85f845d4160cb7c7784772530a1e92af76","commit_id":"81cedcbb40c5b2d11a80f4019a9ea714880eeee7"}]}