)]}'
{"nova/policy.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b28faee5dde829e6c9b793b696f3f27d6d83e668","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                       \u0027credentials\u0027: context.to_policy_values()})"},{"line_number":195,"context_line":"    return result"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":198,"context_line":"    if target is None:"},{"line_number":199,"context_line":"        target \u003d default_target(context)"},{"line_number":200,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_eca4e80a","line":197,"updated":"2020-07-06 11:33:39.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"26085b71e4986ef10dfc82c430df37a70104a9ec"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b28faee5dde829e6c9b793b696f3f27d6d83e668","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":206,"context_line":"    return result"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"def default_target(context):"},{"line_number":209,"context_line":"    return {\u0027project_id\u0027: context.project_id, \u0027user_id\u0027: context.user_id}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_cca7640b","line":208,"updated":"2020-07-06 11:33:39.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"26085b71e4986ef10dfc82c430df37a70104a9ec"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b28faee5dde829e6c9b793b696f3f27d6d83e668","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    init()"},{"line_number":218,"context_line":"    # the target is user-self"},{"line_number":219,"context_line":"    target \u003d default_target(context)"},{"line_number":220,"context_line":"\treturn _authorize(context, target)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"@policy.register(\u0027is_admin\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0ca95cdc","line":220,"updated":"2020-07-06 11:33:39.000000000","message":"pep8: E101 indentation contains mixed spaces and tabs","commit_id":"26085b71e4986ef10dfc82c430df37a70104a9ec"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b28faee5dde829e6c9b793b696f3f27d6d83e668","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    init()"},{"line_number":218,"context_line":"    # the target is user-self"},{"line_number":219,"context_line":"    target \u003d default_target(context)"},{"line_number":220,"context_line":"\treturn _authorize(context, target)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"@policy.register(\u0027is_admin\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_6cb8d829","line":220,"updated":"2020-07-06 11:33:39.000000000","message":"pep8: E113 unexpected indentation","commit_id":"26085b71e4986ef10dfc82c430df37a70104a9ec"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b28faee5dde829e6c9b793b696f3f27d6d83e668","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    init()"},{"line_number":218,"context_line":"    # the target is user-self"},{"line_number":219,"context_line":"    target \u003d default_target(context)"},{"line_number":220,"context_line":"\treturn _authorize(context, target)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"@policy.register(\u0027is_admin\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4cb3544e","line":220,"updated":"2020-07-06 11:33:39.000000000","message":"pep8: E999 TabError: inconsistent use of tabs and spaces in indentation","commit_id":"26085b71e4986ef10dfc82c430df37a70104a9ec"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b28faee5dde829e6c9b793b696f3f27d6d83e668","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    init()"},{"line_number":218,"context_line":"    # the target is user-self"},{"line_number":219,"context_line":"    target \u003d default_target(context)"},{"line_number":220,"context_line":"\treturn _authorize(context, target)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"@policy.register(\u0027is_admin\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2caee0e6","line":220,"updated":"2020-07-06 11:33:39.000000000","message":"pep8: W191 indentation contains tabs","commit_id":"26085b71e4986ef10dfc82c430df37a70104a9ec"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4c7eca644b71a44f3aec0c6a3f6ea99fbaadae45","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                       \u0027credentials\u0027: context.to_policy_values()})"},{"line_number":195,"context_line":"    return result"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"\t"},{"line_number":198,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":199,"context_line":"    \"\"\"Catchs the FileNotFoundError and tries to reinitiate the request."},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a54af023","line":197,"updated":"2020-07-07 10:44:03.000000000","message":"pep8: E101 indentation contains mixed spaces and tabs","commit_id":"2b9882605211f48b7bdf303cb81b41d37a83b82d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4c7eca644b71a44f3aec0c6a3f6ea99fbaadae45","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                       \u0027credentials\u0027: context.to_policy_values()})"},{"line_number":195,"context_line":"    return result"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"\t"},{"line_number":198,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":199,"context_line":"    \"\"\"Catchs the FileNotFoundError and tries to reinitiate the request."},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_4544b41b","line":197,"updated":"2020-07-07 10:44:03.000000000","message":"pep8: W191 indentation contains tabs","commit_id":"2b9882605211f48b7bdf303cb81b41d37a83b82d"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4c7eca644b71a44f3aec0c6a3f6ea99fbaadae45","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                       \u0027credentials\u0027: context.to_policy_values()})"},{"line_number":195,"context_line":"    return result"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"\t"},{"line_number":198,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":199,"context_line":"    \"\"\"Catchs the FileNotFoundError and tries to reinitiate the request."},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_85452c18","line":197,"updated":"2020-07-07 10:44:03.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"2b9882605211f48b7bdf303cb81b41d37a83b82d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"36973979eba484149f65b9b6ede0612112b4fef3","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    try:"},{"line_number":178,"context_line":"        result \u003d _ENFORCER.authorize(action, target, context,"},{"line_number":179,"context_line":"                                     do_raise\u003ddo_raise, exc\u003dexc, action\u003daction)"},{"line_number":180,"context_line":"    except policy.PolicyNotRegistered:"},{"line_number":181,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":182,"context_line":"            LOG.exception(\u0027Policy not registered\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_4115443c","line":179,"updated":"2020-07-15 17:06:38.000000000","message":"This call needs to be replaced with the new _authorize method too","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"36973979eba484149f65b9b6ede0612112b4fef3","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    return result"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":199,"context_line":"    \"\"\"Catchs the FileNotFoundError and tries to reinitiate the request."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_213db0c3","line":198,"range":{"start_line":198,"start_character":15,"end_line":198,"end_character":35},"updated":"2020-07-15 17:06:38.000000000","message":"The signature of _authorize should match the signature of _ENFORCER.authorize so that it may be used as a complete wrapper for all calls","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67b92648014ad6a154fb0b6f21ae86a12d6492e7","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    return result"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":199,"context_line":"    \"\"\"Catchs the FileNotFoundError and tries to reinitiate the request."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e4c6ac48","line":198,"range":{"start_line":198,"start_character":15,"end_line":198,"end_character":35},"in_reply_to":"bf51134e_213db0c3","updated":"2020-07-30 21:58:05.000000000","message":"The idea behind wrapping calls to _ENFORCER.authorize is to handle FileNotFoundError for all callers who call _ENFORCER.authorize. The original _ENFORCER.authorize method supports the following arguments:\n\nhttps://github.com/openstack/oslo.policy/blob/6296fce9f8e3205506f87dd31d0b18f4b7842000/oslo_policy/policy.py#L1055-L1056\n\nSo we need to allow callers to pass the same arguments when they call the wrapper method _authorize.\n\nWhat you can do here actually is have the signature be:\n\n def _authorize(*args, **kwargs)\n\nso that you will support everything support by _ENFORCER.authorize.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"36973979eba484149f65b9b6ede0612112b4fef3","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"def _authorize(context, target\u003dNone):"},{"line_number":199,"context_line":"    \"\"\"Catchs the FileNotFoundError and tries to reinitiate the request."},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    \"\"\""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_21149043","line":199,"range":{"start_line":199,"start_character":7,"end_line":199,"end_character":13},"updated":"2020-07-15 17:06:38.000000000","message":"Catches","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67b92648014ad6a154fb0b6f21ae86a12d6492e7","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    \"\"\""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    if target is None:"},{"line_number":204,"context_line":"        target \u003d default_target(context)"},{"line_number":205,"context_line":"    try:"},{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c4c1e830","line":204,"range":{"start_line":203,"start_character":4,"end_line":204,"end_character":40},"updated":"2020-07-30 21:58:05.000000000","message":"You don\u0027t need this, you can remove it.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67b92648014ad6a154fb0b6f21ae86a12d6492e7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if target is None:"},{"line_number":204,"context_line":"        target \u003d default_target(context)"},{"line_number":205,"context_line":"    try:"},{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_64e8dcb3","line":206,"range":{"start_line":206,"start_character":37,"end_line":206,"end_character":72},"updated":"2020-07-30 21:58:05.000000000","message":"So now that you have support for all *args and **kwargs, here you can just pass them through to the policy authorize method:\n\n result \u003d _ENFORCER.authorize(*args, **kwargs)","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"36973979eba484149f65b9b6ede0612112b4fef3","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        target \u003d default_target(context)"},{"line_number":205,"context_line":"    try:"},{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_c109542b","line":207,"range":{"start_line":207,"start_character":11,"end_line":207,"end_character":20},"updated":"2020-07-15 17:06:38.000000000","message":"This should only catch FileNotFoundError, not all Exception","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"abhishek.mahajan5@tcs.com","username":"mahajan-abhishek"},"change_message_id":"8a145c4d9467be4778d0d53057d1491f55859a24","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    try:"},{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_612cbe01","line":208,"updated":"2020-07-16 07:05:48.000000000","message":"Add LOG.exception log for file not found after catching exception.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"abhishek.mahajan5@tcs.com","username":"mahajan-abhishek"},"change_message_id":"b9fdb66a4f170b60ad6334492ef4037c635d5ff8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    try:"},{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_10265569","line":208,"in_reply_to":"9f560f44_a4faf471","updated":"2020-08-03 08:07:29.000000000","message":"Trace logs as we have in authorize function above.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67b92648014ad6a154fb0b6f21ae86a12d6492e7","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    try:"},{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a4faf471","line":208,"in_reply_to":"bf51134e_612cbe01","updated":"2020-07-30 21:58:05.000000000","message":"IMHO we don\u0027t need to log the entire exception, but if we wanted to we could add a LOG.info that says something like \"Policy file was not found, re-initializing.\"","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"abhishek.mahajan5@tcs.com","username":"mahajan-abhishek"},"change_message_id":"8a145c4d9467be4778d0d53057d1491f55859a24","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_810e3289","line":209,"range":{"start_line":209,"start_character":8,"end_line":209,"end_character":12},"updated":"2020-07-16 07:05:48.000000000","message":"Do we need init() function call here? as it is called from authorise() also!!","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":30910,"name":"Akhil Gudise","email":"gudise.akhil@tcs.com","username":"akhil-g"},"change_message_id":"ec876f9f37cb3d9937b229023df3ba58cbe29474","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_47d183cd","line":209,"range":{"start_line":209,"start_character":8,"end_line":209,"end_character":12},"in_reply_to":"bf51134e_810e3289","updated":"2020-07-30 06:13:45.000000000","message":"Hi Abhishek, without the init() function call the request cannot be re-initiated, so we need to have the init() function.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"abhishek.mahajan5@tcs.com","username":"mahajan-abhishek"},"change_message_id":"8a145c4d9467be4778d0d53057d1491f55859a24","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_014182a6","line":210,"updated":"2020-07-16 07:05:48.000000000","message":"Add a log.debug also in function.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67b92648014ad6a154fb0b6f21ae86a12d6492e7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_242c2401","line":210,"range":{"start_line":210,"start_character":37,"end_line":210,"end_character":72},"updated":"2020-07-30 21:58:05.000000000","message":"Here you\u0027d pass *args and **kwargs again.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"abhishek.mahajan5@tcs.com","username":"mahajan-abhishek"},"change_message_id":"b9fdb66a4f170b60ad6334492ef4037c635d5ff8","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b034c994","line":210,"in_reply_to":"9f560f44_e4222c00","updated":"2020-08-03 08:07:29.000000000","message":"I mean trace logs as we have in authorize function above.","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"67b92648014ad6a154fb0b6f21ae86a12d6492e7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    except Exception:"},{"line_number":208,"context_line":"        reset()"},{"line_number":209,"context_line":"        init()"},{"line_number":210,"context_line":"        result \u003d _ENFORCER.authorize(\u0027context_is_admin\u0027, target, context)"},{"line_number":211,"context_line":"    return result"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e4222c00","line":210,"in_reply_to":"bf51134e_014182a6","updated":"2020-07-30 21:58:05.000000000","message":"\u003e Add a log.debug also in function.\n\nI am not sure what you mean here ... just a LOG.debug saying something like, \"Calling authorize() again after re-initializing.\"?","commit_id":"e508b7866132b9d0d2ac1c46eb40f56797d35fc7"}],"nova/tests/unit/test_policy.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ecdcc41df2804108a9da2fb3648f8c4db8adab7c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                              self.context, action, self.target)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_removed_policy(self):"},{"line_number":69,"context_line":"        with utils.tempdir() as tmpdir:"},{"line_number":70,"context_line":"            tmpfilename \u003d os.path.join(tmpdir, \u0027policy\u0027)"},{"line_number":71,"context_line":"            self.flags(policy_file\u003dtmpfilename, group\u003d\u0027oslo_policy\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_dcb57dd2","line":68,"updated":"2020-08-31 09:33:27.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"570048f8f2d71913b7e519624c25cc714d1f44b3"}]}
