)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bebdcfd5ec13b402417669e24078c2bf41d08ea3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing unicode encoding error in Nova wsgi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modify _to_xml_node function in XMLDictSerializer to"},{"line_number":10,"context_line":"enable the serializer can hanlder unicode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I54f63cbe06d7228ed1e7cbe8a2066554bf293d3d"},{"line_number":13,"context_line":"Fixes: bug #1279172"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2B%2Fgg%3D","line":10,"updated":"2014-03-10 20:26:01.000000000","message":"s/can hanlder/to handle/","commit_id":"c1fee158b699af2b77799b1b0216d28e762a7b13"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"21a0ac382045042df06b1bfac23d04a546991d03","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing unicode encoding error in Nova wsgi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Modify _to_xml_node function in XMLDictSerializer to"},{"line_number":10,"context_line":"enable the serializer can hanlder unicode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I54f63cbe06d7228ed1e7cbe8a2066554bf293d3d"},{"line_number":13,"context_line":"Fixes: bug #1279172"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAVn%2F%2B8ek%3D","line":10,"in_reply_to":"AAAAVn%2F%2B%2Fgg%3D","updated":"2014-03-11 05:24:27.000000000","message":"Thanks for your comments, I\u0027m looking for in-tree API which can reproduce the issue, then I\u0027ll fix this typo when I upload a new patch","commit_id":"c1fee158b699af2b77799b1b0216d28e762a7b13"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0af79be0fdb1f482aabac046e4c56d8bda6a36dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"enable the serializer can handle unicode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I54f63cbe06d7228ed1e7cbe8a2066554bf293d3d"},{"line_number":13,"context_line":"Fixes: bug #1279172"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2Fg5o%3D","line":13,"updated":"2014-03-17 12:36:13.000000000","message":"Closes-Bug: #xxx","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"4066195c01593298c5b60797a68a04fcc12601d1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"enable the serializer can handle unicode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I54f63cbe06d7228ed1e7cbe8a2066554bf293d3d"},{"line_number":13,"context_line":"Fixes: bug #1279172"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2FYF4%3D","line":13,"in_reply_to":"AAAAWH%2F%2Fg5o%3D","updated":"2014-03-18 09:34:50.000000000","message":"Thank you, I\u0027ll update it in my new patch","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d251560b8fe25932efeb1e6118f7927b6e53a0fb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Modify _to_xml_node function in XMLDictSerializer to"},{"line_number":10,"context_line":"enable the serializer can handle unicode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug #1279172"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I54f63cbe06d7228ed1e7cbe8a2066554bf293d3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAW3%2F%2FfR0%3D","line":12,"updated":"2014-04-14 09:12:08.000000000","message":"Sorry it\u0027s a really minor nit if you can update it to have a link from gerrit to the bug in lp.\n\nYou have to follow this rule carefully:\nCloses-Bug: #1279172","commit_id":"cc066a433c91caff591ca076859e4c1fb55b8ccc"}],"nova/api/openstack/wsgi.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0af79be0fdb1f482aabac046e4c56d8bda6a36dd","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                    result.appendChild(node)"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            # Type is atom"},{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fg6U%3D","line":451,"updated":"2014-03-17 12:36:13.000000000","message":"It should be better to use six.text_type instead of unicode","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"696510ce918341db59546dd6f95eb15f43eeaed5","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                    result.appendChild(node)"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            # Type is atom"},{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FGY4%3D","line":451,"in_reply_to":"AAAAWH%2F%2FKak%3D","updated":"2014-03-20 10:22:14.000000000","message":"Thanks for detail explanation and guide, so I can submit the patch without six in stable/grizzly, right?","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e31f288586848afb9c018c57aff2802993ac442e","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                    result.appendChild(node)"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            # Type is atom"},{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FKak%3D","line":451,"in_reply_to":"AAAAWH%2F%2FYBg%3D","updated":"2014-03-19 20:06:34.000000000","message":"You can use six in stable/havana:\n\nhttps://github.com/openstack/nova/blob/stable/havana/requirements.txt#L28\n\nIf it\u0027s not in this module in stable/havana, you\u0027d just have to import it and call it out in the backport commit message as a deviation.\n\nIt\u0027s not in stable/grizzly, but honestly I don\u0027t see this making stable/grizzly before Icehouse is cut, at which point stable/grizzly will be gone anyway since community only supports the last 2 stable releases.","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"4066195c01593298c5b60797a68a04fcc12601d1","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                    result.appendChild(node)"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            # Type is atom"},{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FYBg%3D","line":451,"in_reply_to":"AAAAWH%2F%2Fg6U%3D","updated":"2014-03-18 09:34:50.000000000","message":"I agree, apply six is good than using unicode here, I\u0027d like to explain why I didn\u0027t use six, because this issue exist in stable/havana and stable/grizzly too, six aren\u0027t imported in these previous release, in order to back port the fixing to those release, I submit this fixing. How about merging current fixing to back port into stable/grizzly and stable/havana, then submit a new code review to apply the six? Please let me know your opinion, thank you!","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0af79be0fdb1f482aabac046e4c56d8bda6a36dd","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"},{"line_number":455,"context_line":"            result.appendChild(node)"},{"line_number":456,"context_line":"        return result"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Fg6E%3D","line":454,"updated":"2014-03-17 12:36:13.000000000","message":"Also could be the time to use six.binary_type instead of str","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"696510ce918341db59546dd6f95eb15f43eeaed5","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"},{"line_number":455,"context_line":"            result.appendChild(node)"},{"line_number":456,"context_line":"        return result"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FF6w%3D","line":454,"in_reply_to":"AAAAWH%2F%2FKac%3D","updated":"2014-03-20 10:22:14.000000000","message":"no, I think. It\u0027s good enough to use str for python 2","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e31f288586848afb9c018c57aff2802993ac442e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"},{"line_number":455,"context_line":"            result.appendChild(node)"},{"line_number":456,"context_line":"        return result"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FKac%3D","line":454,"in_reply_to":"AAAAWH%2F%2FYAg%3D","updated":"2014-03-19 20:06:34.000000000","message":"Is it binary data though?","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"4066195c01593298c5b60797a68a04fcc12601d1","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            if isinstance(data, unicode):"},{"line_number":452,"context_line":"                node \u003d doc.createTextNode(data)"},{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                node \u003d doc.createTextNode(str(data))"},{"line_number":455,"context_line":"            result.appendChild(node)"},{"line_number":456,"context_line":"        return result"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FYAg%3D","line":454,"in_reply_to":"AAAAWH%2F%2Fg6E%3D","updated":"2014-03-18 09:34:50.000000000","message":"ditto","commit_id":"f3e0476c558e1d44a1481af1237d9da9d2c1aad2"}]}