)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c8de3ba667ad440deb018cd535450e96081233e2","unresolved":false,"context_lines":[{"line_number":26350,"context_line":"    def test_cold_snapshot_based_on_power_state("},{"line_number":26351,"context_line":"            self, mock_version, mock_get_guest):"},{"line_number":26352,"context_line":"        \"\"\"Tests that a cold snapshot is attempted because the guest power"},{"line_number":26353,"context_line":"        state is SHUTDOWN or PAUSED."},{"line_number":26354,"context_line":"        \"\"\""},{"line_number":26355,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI())"},{"line_number":26356,"context_line":"        image \u003d self._create_image()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_c26db39a","line":26353,"range":{"start_line":26353,"start_character":26,"end_line":26353,"end_character":36},"updated":"2020-07-17 12:08:04.000000000","message":"whoops","commit_id":"307f9e8ebcce6825b8e322ecd809e81c6765bf77"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"44ddf7d7bdac5c4d93ebde5fe8ceca2bebaaa345","unresolved":false,"context_lines":[{"line_number":2361,"context_line":"            source_type !\u003d \u0027lvm\u0027 and"},{"line_number":2362,"context_line":"            not CONF.ephemeral_storage_encryption.enabled and"},{"line_number":2363,"context_line":"            not CONF.workarounds.disable_libvirt_livesnapshot and"},{"line_number":2364,"context_line":"            # NOTE(rmk): We cannot perform live snapshots when a"},{"line_number":2365,"context_line":"            # managedSave file is present, so we will use the cold/legacy"},{"line_number":2366,"context_line":"            # method for instances which are shutdown"},{"line_number":2367,"context_line":"            state !\u003d power_state.SHUTDOWN"},{"line_number":2368,"context_line":"        ):"},{"line_number":2369,"context_line":"            live_snapshot \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_0f7ccbe9","line":2366,"range":{"start_line":2364,"start_character":0,"end_line":2366,"end_character":53},"updated":"2020-07-21 11:25:22.000000000","message":"So this is confusing, if this were previously true we wouldn\u0027t be able to allow power_state.PAUSED now where we do use managedSave right?","commit_id":"307f9e8ebcce6825b8e322ecd809e81c6765bf77"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83a8733baba3c022fc0bfac64465690cba4814b5","unresolved":false,"context_lines":[{"line_number":2361,"context_line":"            source_type !\u003d \u0027lvm\u0027 and"},{"line_number":2362,"context_line":"            not CONF.ephemeral_storage_encryption.enabled and"},{"line_number":2363,"context_line":"            not CONF.workarounds.disable_libvirt_livesnapshot and"},{"line_number":2364,"context_line":"            # NOTE(rmk): We cannot perform live snapshots when a"},{"line_number":2365,"context_line":"            # managedSave file is present, so we will use the cold/legacy"},{"line_number":2366,"context_line":"            # method for instances which are shutdown"},{"line_number":2367,"context_line":"            state !\u003d power_state.SHUTDOWN"},{"line_number":2368,"context_line":"        ):"},{"line_number":2369,"context_line":"            live_snapshot \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e639b9a3","line":2366,"range":{"start_line":2364,"start_character":0,"end_line":2366,"end_character":53},"in_reply_to":"bf51134e_03bc9f6a","updated":"2020-07-21 16:53:21.000000000","message":"Ignore that. I was testing with the below check (state !\u003d power_state.SHUTDOWN) removed. Turns out you can\u0027t live snapshot a stopped/suspended instance. TIL.","commit_id":"307f9e8ebcce6825b8e322ecd809e81c6765bf77"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3652f8f1a0176a6c7db58178c6eee714c8140acd","unresolved":false,"context_lines":[{"line_number":2361,"context_line":"            source_type !\u003d \u0027lvm\u0027 and"},{"line_number":2362,"context_line":"            not CONF.ephemeral_storage_encryption.enabled and"},{"line_number":2363,"context_line":"            not CONF.workarounds.disable_libvirt_livesnapshot and"},{"line_number":2364,"context_line":"            # NOTE(rmk): We cannot perform live snapshots when a"},{"line_number":2365,"context_line":"            # managedSave file is present, so we will use the cold/legacy"},{"line_number":2366,"context_line":"            # method for instances which are shutdown"},{"line_number":2367,"context_line":"            state !\u003d power_state.SHUTDOWN"},{"line_number":2368,"context_line":"        ):"},{"line_number":2369,"context_line":"            live_snapshot \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_03bc9f6a","line":2366,"range":{"start_line":2364,"start_character":0,"end_line":2366,"end_character":53},"in_reply_to":"bf51134e_0f7ccbe9","updated":"2020-07-21 16:38:13.000000000","message":"Not a definitive answer but snapshotting a paused instance does seem to work locally. However, snapshotting a shutdown or suspended instance, using live or not, is totally borked at the moment. Reported a bug [1].\n\n[1] https://bugs.launchpad.net/nova/+bug/1888414","commit_id":"307f9e8ebcce6825b8e322ecd809e81c6765bf77"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a8ef2d098c024033c78ec1220b5151ead6001ce6","unresolved":false,"context_lines":[{"line_number":2361,"context_line":"            source_type !\u003d \u0027lvm\u0027 and"},{"line_number":2362,"context_line":"            not CONF.ephemeral_storage_encryption.enabled and"},{"line_number":2363,"context_line":"            not CONF.workarounds.disable_libvirt_livesnapshot and"},{"line_number":2364,"context_line":"            # NOTE(stephenfin): Live snapshotting doesn\u0027t make sense for"},{"line_number":2365,"context_line":"            # shutdown instances"},{"line_number":2366,"context_line":"            state !\u003d power_state.SHUTDOWN"},{"line_number":2367,"context_line":"        ):"},{"line_number":2368,"context_line":"            live_snapshot \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_52f49b87","line":2365,"range":{"start_line":2364,"start_character":0,"end_line":2365,"end_character":32},"updated":"2020-07-21 21:35:25.000000000","message":"ACK thanks","commit_id":"279f89e320eb3fe9d4b236dc9a97fb6bc08d7421"}]}