)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"435f9acd4419a32d652547ef6a7a1dab25a20ffd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"QEMU \u003c 1.0.3 did not support live snapshots. Bug #1193146 noted that for"},{"line_number":10,"context_line":"this to be used, the version of the QEMU that the instance is running is"},{"line_number":11,"context_line":"important, not the version that it was created with. To test this, it"},{"line_number":12,"context_line":"used a (duplicated) call to \u0027abort_job\u0027 that verified the newer versions"},{"line_number":13,"context_line":"of QEMU was in use. There can\u0027t be any instances still in the wild using"},{"line_number":14,"context_line":"this version of QEMU, since those users would have had to update their"},{"line_number":15,"context_line":"OS (the last version of Ubuntu to provide a suitably old QEMU was 12.04"},{"line_number":16,"context_line":"[1], which is very much EOL), meaning a reboot of the host and possible"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_726a7f1b","line":13,"range":{"start_line":11,"start_character":53,"end_line":13,"end_character":19},"updated":"2020-07-21 21:40:24.000000000","message":"ACK thanks","commit_id":"5964d7e11cdd67ae0e1af2382465d80b8531a94b"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"29dab07f910219a6fc4b447141ea5ede396fd4f3","unresolved":false,"context_lines":[{"line_number":2372,"context_line":"            # confirms the running instance, as opposed to the system as a"},{"line_number":2373,"context_line":"            # whole, has a new enough version of the hypervisor (bug 1193146)."},{"line_number":2374,"context_line":"            try:"},{"line_number":2375,"context_line":"                guest.get_block_device(disk_path).abort_job()"},{"line_number":2376,"context_line":"            except libvirt.libvirtError as ex:"},{"line_number":2377,"context_line":"                error_code \u003d ex.get_error_code()"},{"line_number":2378,"context_line":"                if error_code \u003d\u003d libvirt.VIR_ERR_CONFIG_UNSUPPORTED:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_efe237a0","side":"PARENT","line":2375,"range":{"start_line":2375,"start_character":16,"end_line":2375,"end_character":61},"updated":"2020-07-21 11:30:07.000000000","message":"This isn\u0027t related to the older version of QEMU however right? Aborting failed blockjobs is still something we should continue to do.","commit_id":"307f9e8ebcce6825b8e322ecd809e81c6765bf77"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"29dab07f910219a6fc4b447141ea5ede396fd4f3","unresolved":false,"context_lines":[{"line_number":2375,"context_line":"                guest.get_block_device(disk_path).abort_job()"},{"line_number":2376,"context_line":"            except libvirt.libvirtError as ex:"},{"line_number":2377,"context_line":"                error_code \u003d ex.get_error_code()"},{"line_number":2378,"context_line":"                if error_code \u003d\u003d libvirt.VIR_ERR_CONFIG_UNSUPPORTED:"},{"line_number":2379,"context_line":"                    live_snapshot \u003d False"},{"line_number":2380,"context_line":"                else:"},{"line_number":2381,"context_line":"                    pass"},{"line_number":2382,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_0ff32b75","side":"PARENT","line":2379,"range":{"start_line":2378,"start_character":0,"end_line":2379,"end_character":41},"updated":"2020-07-21 11:30:07.000000000","message":"This should be replaced however.","commit_id":"307f9e8ebcce6825b8e322ecd809e81c6765bf77"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"013e8c8caa765fa9352489648fde95a9b059e1f3","unresolved":false,"context_lines":[{"line_number":2377,"context_line":"                if error_code \u003d\u003d libvirt.VIR_ERR_CONFIG_UNSUPPORTED:"},{"line_number":2378,"context_line":"                    live_snapshot \u003d False"},{"line_number":2379,"context_line":"                else:"},{"line_number":2380,"context_line":"                    pass"},{"line_number":2381,"context_line":"        else:"},{"line_number":2382,"context_line":"            live_snapshot \u003d False"},{"line_number":2383,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_2772817d","side":"PARENT","line":2380,"updated":"2020-07-22 12:04:35.000000000","message":"After this removed the whole if could be translated to an assignment to live_snapshot \u003d \u003ccurrent if condition\u003e","commit_id":"279f89e320eb3fe9d4b236dc9a97fb6bc08d7421"}]}