)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"37135af154d5dc90772a43510dfed4af31ad1ea3","unresolved":false,"context_lines":[{"line_number":2439,"context_line":"            live_snapshot \u003d False"},{"line_number":2440,"context_line":"            # Suspend the guest, so this is no longer a live snapshot"},{"line_number":2441,"context_line":"            self._suspend_guest_for_snapshot("},{"line_number":2442,"context_line":"                context, live_snapshot, state, instance)"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        fileutils.ensure_tree(CONF.libvirt.snapshots_directory)"},{"line_number":2445,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_7c3da6b9","line":2442,"updated":"2020-07-14 14:08:09.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"ccc9d489ea80a71bd016a055046aa97409dd5925"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"37135af154d5dc90772a43510dfed4af31ad1ea3","unresolved":false,"context_lines":[{"line_number":2468,"context_line":"                raise"},{"line_number":2469,"context_line":"            finally:"},{"line_number":2470,"context_line":"                self._resume_guest_after_snapshot("},{"line_number":2471,"context_line":"                    context, live_snapshot, state, instance, guest)"},{"line_number":2472,"context_line":""},{"line_number":2473,"context_line":"            # Upload that image to the image service"},{"line_number":2474,"context_line":"            update_task_state("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_dc48325d","line":2471,"updated":"2020-07-14 14:08:09.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"ccc9d489ea80a71bd016a055046aa97409dd5925"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"37135af154d5dc90772a43510dfed4af31ad1ea3","unresolved":false,"context_lines":[{"line_number":2497,"context_line":"            return False"},{"line_number":2498,"context_line":""},{"line_number":2499,"context_line":"        # ...and neither does a non-running domain"},{"line_number":2500,"context_line":"        return power_state in (power_state.RUNNING, power_state.PAUSED)"},{"line_number":2501,"context_line":""},{"line_number":2502,"context_line":"    def _suspend_guest_for_snapshot("},{"line_number":2503,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_1c78ea8d","line":2500,"updated":"2020-07-14 14:08:09.000000000","message":"pep8: error: \"str\" has no attribute \"PAUSED\"","commit_id":"ccc9d489ea80a71bd016a055046aa97409dd5925"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"37135af154d5dc90772a43510dfed4af31ad1ea3","unresolved":false,"context_lines":[{"line_number":2497,"context_line":"            return False"},{"line_number":2498,"context_line":""},{"line_number":2499,"context_line":"        # ...and neither does a non-running domain"},{"line_number":2500,"context_line":"        return power_state in (power_state.RUNNING, power_state.PAUSED)"},{"line_number":2501,"context_line":""},{"line_number":2502,"context_line":"    def _suspend_guest_for_snapshot("},{"line_number":2503,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_bc43be3e","line":2500,"updated":"2020-07-14 14:08:09.000000000","message":"pep8: error: \"str\" has no attribute \"RUNNING\"","commit_id":"ccc9d489ea80a71bd016a055046aa97409dd5925"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1155e1caf1fc108b411423f5e4a8e7dff48ed50c","unresolved":false,"context_lines":[{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"        direct_snapshot_success \u003d False"},{"line_number":2389,"context_line":""},{"line_number":2390,"context_line":"        if root_disk.SUPPORTS_DIRECT_SNAPSHOT:"},{"line_number":2391,"context_line":"            try:"},{"line_number":2392,"context_line":"                metadata[\u0027location\u0027] \u003d root_disk.direct_snapshot("},{"line_number":2393,"context_line":"                    context, snapshot_name, image_format, image_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_22058f15","line":2390,"range":{"start_line":2390,"start_character":6,"end_line":2390,"end_character":46},"updated":"2020-07-17 12:48:38.000000000","message":"you removed the fall back to doign a normal snapshot by powering off the vm.\n\ni assume you going to readd that.","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffb4ca4a88c295a66b1d31f594df162105d85bb4","unresolved":false,"context_lines":[{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"        direct_snapshot_success \u003d False"},{"line_number":2389,"context_line":""},{"line_number":2390,"context_line":"        if root_disk.SUPPORTS_DIRECT_SNAPSHOT:"},{"line_number":2391,"context_line":"            try:"},{"line_number":2392,"context_line":"                metadata[\u0027location\u0027] \u003d root_disk.direct_snapshot("},{"line_number":2393,"context_line":"                    context, snapshot_name, image_format, image_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_24d8f71c","line":2390,"range":{"start_line":2390,"start_character":6,"end_line":2390,"end_character":46},"in_reply_to":"bf51134e_09450e44","updated":"2020-07-17 17:22:36.000000000","message":"you are right i miss read this see comment below","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bbbdabf2a6a9cbd4183947717ba36a3b66112502","unresolved":false,"context_lines":[{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"        direct_snapshot_success \u003d False"},{"line_number":2389,"context_line":""},{"line_number":2390,"context_line":"        if root_disk.SUPPORTS_DIRECT_SNAPSHOT:"},{"line_number":2391,"context_line":"            try:"},{"line_number":2392,"context_line":"                metadata[\u0027location\u0027] \u003d root_disk.direct_snapshot("},{"line_number":2393,"context_line":"                    context, snapshot_name, image_format, image_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_09450e44","line":2390,"range":{"start_line":2390,"start_character":6,"end_line":2390,"end_character":46},"in_reply_to":"bf51134e_22058f15","updated":"2020-07-17 16:08:39.000000000","message":"I don\u0027t think I have. If direct snapshot isn\u0027t supported or fails, we\u0027ll know by direct_snapshot_success not being set to True. That triggers normal snapshot","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffb4ca4a88c295a66b1d31f594df162105d85bb4","unresolved":false,"context_lines":[{"line_number":2428,"context_line":"                        context, live_snapshot, original_power_state, instance,"},{"line_number":2429,"context_line":"                        guest)"},{"line_number":2430,"context_line":""},{"line_number":2431,"context_line":"        if direct_snapshot_success:"},{"line_number":2432,"context_line":"            LOG.info(\u0027Snapshot image upload complete\u0027, instance\u003dinstance)"},{"line_number":2433,"context_line":"            return"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"        # TODO(nic): possibly abstract this out to the root_disk"},{"line_number":2436,"context_line":"        if source_type \u003d\u003d \u0027rbd\u0027 and live_snapshot:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_e4cd5f5f","line":2433,"range":{"start_line":2431,"start_character":3,"end_line":2433,"end_character":18},"updated":"2020-07-17 17:22:36.000000000","message":"oh sorry this is an early return\ni though the rest of the function was indented under this\nyou dont need this just do a return on line 2400","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71fc39d67528af3f46f1fc335a9e03aab8ae8ed5","unresolved":false,"context_lines":[{"line_number":2439,"context_line":"            live_snapshot \u003d False"},{"line_number":2440,"context_line":"            # Suspend the guest, so this is no longer a live snapshot"},{"line_number":2441,"context_line":"            self._suspend_guest_for_snapshot("},{"line_number":2442,"context_line":"                context, live_snapshot, state, instance)"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        fileutils.ensure_tree(CONF.libvirt.snapshots_directory)"},{"line_number":2445,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_75df3f3a","line":2442,"updated":"2020-07-17 13:07:44.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71fc39d67528af3f46f1fc335a9e03aab8ae8ed5","unresolved":false,"context_lines":[{"line_number":2468,"context_line":"                raise"},{"line_number":2469,"context_line":"            finally:"},{"line_number":2470,"context_line":"                self._resume_guest_after_snapshot("},{"line_number":2471,"context_line":"                    context, live_snapshot, state, instance, guest)"},{"line_number":2472,"context_line":""},{"line_number":2473,"context_line":"            # Upload that image to the image service"},{"line_number":2474,"context_line":"            update_task_state("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_d5e3ab05","line":2471,"updated":"2020-07-17 13:07:44.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71fc39d67528af3f46f1fc335a9e03aab8ae8ed5","unresolved":false,"context_lines":[{"line_number":2497,"context_line":"            return False"},{"line_number":2498,"context_line":""},{"line_number":2499,"context_line":"        # ...and neither does a non-running domain"},{"line_number":2500,"context_line":"        return power_state in (power_state.RUNNING, power_state.PAUSED)"},{"line_number":2501,"context_line":""},{"line_number":2502,"context_line":"    def _suspend_guest_for_snapshot("},{"line_number":2503,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_15eec3ec","line":2500,"updated":"2020-07-17 13:07:44.000000000","message":"pep8: error: \"str\" has no attribute \"PAUSED\"","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71fc39d67528af3f46f1fc335a9e03aab8ae8ed5","unresolved":false,"context_lines":[{"line_number":2497,"context_line":"            return False"},{"line_number":2498,"context_line":""},{"line_number":2499,"context_line":"        # ...and neither does a non-running domain"},{"line_number":2500,"context_line":"        return power_state in (power_state.RUNNING, power_state.PAUSED)"},{"line_number":2501,"context_line":""},{"line_number":2502,"context_line":"    def _suspend_guest_for_snapshot("},{"line_number":2503,"context_line":"        self,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_b5e0b7fa","line":2500,"updated":"2020-07-17 13:07:44.000000000","message":"pep8: error: \"str\" has no attribute \"RUNNING\"","commit_id":"4982e6ab73ee4e53c07cdf408264ccf4b7f42570"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09070a0b55c31179ff20dea55a7f8ca23eb397ae","unresolved":false,"context_lines":[{"line_number":2439,"context_line":"            live_snapshot \u003d False"},{"line_number":2440,"context_line":"            # Suspend the guest, so this is no longer a live snapshot"},{"line_number":2441,"context_line":"            self._suspend_guest_for_snapshot("},{"line_number":2442,"context_line":"                context, live_snapshot, state, instance)"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        fileutils.ensure_tree(CONF.libvirt.snapshots_directory)"},{"line_number":2445,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_79b571d0","line":2442,"updated":"2020-07-18 01:06:39.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"f3ff885d5ff29a3ea3de2261269f29b1a62b9e91"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"09070a0b55c31179ff20dea55a7f8ca23eb397ae","unresolved":false,"context_lines":[{"line_number":2468,"context_line":"                raise"},{"line_number":2469,"context_line":"            finally:"},{"line_number":2470,"context_line":"                self._resume_guest_after_snapshot("},{"line_number":2471,"context_line":"                    context, live_snapshot, state, instance, guest)"},{"line_number":2472,"context_line":""},{"line_number":2473,"context_line":"            # Upload that image to the image service"},{"line_number":2474,"context_line":"            update_task_state("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_59ba2dc0","line":2471,"updated":"2020-07-18 01:06:39.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"f3ff885d5ff29a3ea3de2261269f29b1a62b9e91"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d45dece9a7fda51b1cfb3e6b9ae4c7a3dca74763","unresolved":false,"context_lines":[{"line_number":2438,"context_line":"            live_snapshot \u003d False"},{"line_number":2439,"context_line":"            # Suspend the guest, so this is no longer a live snapshot"},{"line_number":2440,"context_line":"            self._suspend_guest_for_snapshot("},{"line_number":2441,"context_line":"                context, live_snapshot, state, instance)"},{"line_number":2442,"context_line":""},{"line_number":2443,"context_line":"        fileutils.ensure_tree(CONF.libvirt.snapshots_directory)"},{"line_number":2444,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_26444a47","line":2441,"updated":"2020-07-22 00:55:11.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"7d113aad69aa84699256d71341b6d3b873a30175"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d45dece9a7fda51b1cfb3e6b9ae4c7a3dca74763","unresolved":false,"context_lines":[{"line_number":2467,"context_line":"                raise"},{"line_number":2468,"context_line":"            finally:"},{"line_number":2469,"context_line":"                self._resume_guest_after_snapshot("},{"line_number":2470,"context_line":"                    context, live_snapshot, state, instance, guest)"},{"line_number":2471,"context_line":""},{"line_number":2472,"context_line":"            # Upload that image to the image service"},{"line_number":2473,"context_line":"            update_task_state("}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_8674369e","line":2470,"updated":"2020-07-22 00:55:11.000000000","message":"pep8: error: Name \u0027state\u0027 is not defined","commit_id":"7d113aad69aa84699256d71341b6d3b873a30175"}]}