)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"338c93c7e486613459e08a876b6c83f5c43a9e40","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It means that the request to glance is issued only one time."},{"line_number":11,"context_line":"However, other components\u0027 client retries the request when it fails."},{"line_number":12,"context_line":"To reduce an unnecessary exception and failure, we should increase"},{"line_number":13,"context_line":"the default value to 3."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibbd4bd26408328b9e1a1128b3794721405631193"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_4a7ed5af","line":13,"updated":"2020-07-17 18:43:01.000000000","message":"This isn\u0027t really a good reason to change the default IMHO, being that the user can set the config setting to 3 already.\n\nWhat you could argue though is that the default value of 0 is inconsistent with the other service clients default retries.\n\nSo, I would change this reasoning in the commit message to be about bringing the glance default value into consistency with the defaults for the cinder and neutron clients.\n\nAlso, if you plan to backport this, you should open a launchpad bug explaining the reasoning for the desired change and then use \"Closes-Bug: #\u003cbug number\u003e\" to refer to it in the commit message.","commit_id":"385e431ec894cc4640ce94dc399b3abaabddd541"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48e3e47a99b4fb1653e007f21651986c5883fe01","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously, the default value of num_retries for glance is 0."},{"line_number":10,"context_line":"It means that the request to glance is sent only one time."},{"line_number":11,"context_line":"On the other hand, neutron clients set the default value to 3."},{"line_number":12,"context_line":"To align the default value for retry to other components, we"},{"line_number":13,"context_line":"should change the default valule to 3."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_49ca4d6e","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":26},"updated":"2020-07-20 17:10:38.000000000","message":"neutron and cinder","commit_id":"102ed1789b8ac0d872da7135603fb3d6460e4e82"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48e3e47a99b4fb1653e007f21651986c5883fe01","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It means that the request to glance is sent only one time."},{"line_number":11,"context_line":"On the other hand, neutron clients set the default value to 3."},{"line_number":12,"context_line":"To align the default value for retry to other components, we"},{"line_number":13,"context_line":"should change the default valule to 3."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1888168"},{"line_number":16,"context_line":"Change-Id: Ibbd4bd26408328b9e1a1128b3794721405631193"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_e99ec167","line":13,"range":{"start_line":13,"start_character":26,"end_line":13,"end_character":32},"updated":"2020-07-20 17:10:38.000000000","message":"value","commit_id":"102ed1789b8ac0d872da7135603fb3d6460e4e82"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7c483214b2500928c41b33953738d9938748741b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"To align the default value for retry to other components, we"},{"line_number":14,"context_line":"should change the default value to 3."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1888168"},{"line_number":17,"context_line":"Change-Id: Ibbd4bd26408328b9e1a1128b3794721405631193"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_4f979a91","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2020-08-20 00:28:25.000000000","message":"as i mentioned on the bug i dont think this is a valid nova bug. but i think its ok for tracking altering the default config value.\n\nbut to be clear the correct way to fix the issue you are reporting is to fix the haproxy timeout value.\n\nwith that said since we already retry the other servcies as you noted i think there is merit in makeing glace retry too to make them all consitent in there default behavior","commit_id":"c4a477d1175e99055fb9d4bb38a543c5bbfed189"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e70c297f9fe1aff453979529dd9cb56f3baa9a91","unresolved":false,"context_lines":[{"line_number":13,"context_line":"To align the default value for retry to other components, we"},{"line_number":14,"context_line":"should change the default value to 3."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1888168"},{"line_number":17,"context_line":"Change-Id: Ibbd4bd26408328b9e1a1128b3794721405631193"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_eb8ffec9","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"9f560f44_4f979a91","updated":"2020-08-27 20:16:25.000000000","message":"I asked the author to use a bug since we\u0027ll have backports.","commit_id":"c4a477d1175e99055fb9d4bb38a543c5bbfed189"}],"releasenotes/notes/increase_glance_num_retries-ddfcd7053631882b.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7023e431a1352a6134499d90ba17a71a3c97e373","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change num_retries option for glance request from 0 to 3."},{"line_number":5,"context_line":"    The option controls how many times to retry a Glance API call in response"},{"line_number":6,"context_line":"    to a HTTP connection failure. There was a timing issue on a HAproxy used"},{"line_number":7,"context_line":"    deployment that a response to Glance API call couldn\u0027t deliver to the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_9cfe6a03","line":4,"range":{"start_line":4,"start_character":11,"end_line":4,"end_character":22},"updated":"2020-07-27 19:08:51.000000000","message":"Should probably be more specific \"the default for the ``[glance]num_retries`` configuration option\"","commit_id":"e661a8b8f5f50c872b4e51ef1544f36e0b461acc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7023e431a1352a6134499d90ba17a71a3c97e373","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change num_retries option for glance request from 0 to 3."},{"line_number":5,"context_line":"    The option controls how many times to retry a Glance API call in response"},{"line_number":6,"context_line":"    to a HTTP connection failure. There was a timing issue on a HAproxy used"},{"line_number":7,"context_line":"    deployment that a response to Glance API call couldn\u0027t deliver to the"},{"line_number":8,"context_line":"    client because it came to HAproxy just after the idle time. It causes the"},{"line_number":9,"context_line":"    exception and failure of the request. Increasing the default value, Nova"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_3c8e3e78","line":6,"range":{"start_line":6,"start_character":24,"end_line":6,"end_character":32},"updated":"2020-07-27 19:08:51.000000000","message":"The glance option also covers: \", timeout, or ServiceUnavailable failure.\"","commit_id":"e661a8b8f5f50c872b4e51ef1544f36e0b461acc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7c483214b2500928c41b33953738d9938748741b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change num_retries option for glance request from 0 to 3."},{"line_number":5,"context_line":"    The option controls how many times to retry a Glance API call in response"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_8f4a5252","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2020-08-20 00:28:25.000000000","message":"this is not really a bug espcially since it just a default value for a config option that is being changed.\nthis so this shoudl be in the upgrades section","commit_id":"c4a477d1175e99055fb9d4bb38a543c5bbfed189"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7c483214b2500928c41b33953738d9938748741b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change num_retries option for glance request from 0 to 3."},{"line_number":5,"context_line":"    The option controls how many times to retry a Glance API call in response"},{"line_number":6,"context_line":"    to a HTTP connection failure. There was a timing issue on a HAproxy used"},{"line_number":7,"context_line":"    deployment that a response to Glance API call couldn\u0027t deliver to the"},{"line_number":8,"context_line":"    client because it came to HAproxy just after the idle time. It causes the"},{"line_number":9,"context_line":"    exception and failure of the request. Increasing the default value, Nova"},{"line_number":10,"context_line":"    can be more resilient to this scenario and continue the request if a retry"},{"line_number":11,"context_line":"    succeeds."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f560f44_2fa986dc","line":11,"range":{"start_line":6,"start_character":34,"end_line":11,"end_character":13},"updated":"2020-08-20 00:28:25.000000000","message":"so retying is will not nessisarly fix this case but in any case lets rephase this.\n\nWhen deploying Glance behind HAproxy it is possible for a reponce to arrive just after the ha proxy idle time. As a\nresult an exction will be raised by when the connection is closed resulting in a failed request.Increasing the default value, Nova can be more resilient to this scenario were ha proxy is misconfigured by retrying the request.","commit_id":"c4a477d1175e99055fb9d4bb38a543c5bbfed189"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e70c297f9fe1aff453979529dd9cb56f3baa9a91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrades:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default for ``[glance] num_retries`` has changed from ``0`` to ``3``."},{"line_number":5,"context_line":"    The option controls how many times to retry a Glance API call in response"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_ab8986ca","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2020-08-27 20:16:25.000000000","message":"This should be \"upgrade\":\n\nhttps://docs.openstack.org/reno/latest/user/usage.html#editing-a-release-note","commit_id":"1451caa13ed97aeaee33420ff9cea6d7e14bd077"}]}