)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"3655b438da2f783cf6be328bf2f92d0a5f8c8828","unresolved":false,"context_lines":[{"line_number":14,"context_line":"they support the \u0027mixed\u0027 instance CPU allocation policy"},{"line_number":15,"context_line":"once they want to:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - Create a brand-new instance"},{"line_number":18,"context_line":"    - Resize to a mixed instance from a dedicated or shared"},{"line_number":19,"context_line":"instance."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_68c3cf8b","line":17,"updated":"2020-07-20 14:43:43.000000000","message":"Done.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01eb25de8349aa09bf61faf1538ec79043c7189c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"they support the \u0027mixed\u0027 instance CPU allocation policy"},{"line_number":15,"context_line":"once they want to:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    - Create a brand-new instance"},{"line_number":18,"context_line":"    - Resize to a mixed instance from a dedicated or shared"},{"line_number":19,"context_line":"instance."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_1eb37b4f","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"updated":"2020-07-17 22:21:44.000000000","message":"nit","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"3655b438da2f783cf6be328bf2f92d0a5f8c8828","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - Resize to a mixed instance from a dedicated or shared"},{"line_number":19,"context_line":"instance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"And we don\u0027t support to rebuild an instance that changes"},{"line_number":22,"context_line":"the NUMA topology, and changing the CPU policy will"},{"line_number":23,"context_line":"definitely mean changing the NUMA topology, so nova-compute"},{"line_number":24,"context_line":"nodes version will not be check in rebuilding process."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_48c08b7d","line":21,"updated":"2020-07-20 14:43:43.000000000","message":"Done.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01eb25de8349aa09bf61faf1538ec79043c7189c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    - Resize to a mixed instance from a dedicated or shared"},{"line_number":19,"context_line":"instance."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"And we don\u0027t support to rebuild an instance that changes"},{"line_number":22,"context_line":"the NUMA topology, and changing the CPU policy will"},{"line_number":23,"context_line":"definitely mean changing the NUMA topology, so nova-compute"},{"line_number":24,"context_line":"nodes version will not be check in rebuilding process."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_7e81d74d","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":32},"updated":"2020-07-17 22:21:44.000000000","message":"rebuilding","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"3655b438da2f783cf6be328bf2f92d0a5f8c8828","unresolved":false,"context_lines":[{"line_number":21,"context_line":"And we don\u0027t support to rebuild an instance that changes"},{"line_number":22,"context_line":"the NUMA topology, and changing the CPU policy will"},{"line_number":23,"context_line":"definitely mean changing the NUMA topology, so nova-compute"},{"line_number":24,"context_line":"nodes version will not be check in rebuilding process."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is an alternative of change [1], in [1] the nova-compute"},{"line_number":27,"context_line":"service version check is done in conductor layer, while we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_a8bde703","line":24,"updated":"2020-07-20 14:43:43.000000000","message":"Done.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01eb25de8349aa09bf61faf1538ec79043c7189c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"And we don\u0027t support to rebuild an instance that changes"},{"line_number":22,"context_line":"the NUMA topology, and changing the CPU policy will"},{"line_number":23,"context_line":"definitely mean changing the NUMA topology, so nova-compute"},{"line_number":24,"context_line":"nodes version will not be check in rebuilding process."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is an alternative of change [1], in [1] the nova-compute"},{"line_number":27,"context_line":"service version check is done in conductor layer, while we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_3e8f5f76","line":24,"range":{"start_line":24,"start_character":26,"end_line":24,"end_character":54},"updated":"2020-07-17 22:21:44.000000000","message":"checked when rebuilding.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"3655b438da2f783cf6be328bf2f92d0a5f8c8828","unresolved":false,"context_lines":[{"line_number":28,"context_line":"think checking the nova-compute service version in API layer"},{"line_number":29,"context_line":"make more sense."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1]  https://review.opendev.org/716271"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Part of blueprint use-pcpu-and-vcpu-in-one-instance"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_88baa307","line":31,"updated":"2020-07-20 14:43:43.000000000","message":"Dropped.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01eb25de8349aa09bf61faf1538ec79043c7189c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"definitely mean changing the NUMA topology, so nova-compute"},{"line_number":24,"context_line":"nodes version will not be check in rebuilding process."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This is an alternative of change [1], in [1] the nova-compute"},{"line_number":27,"context_line":"service version check is done in conductor layer, while we"},{"line_number":28,"context_line":"think checking the nova-compute service version in API layer"},{"line_number":29,"context_line":"make more sense."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"[1]  https://review.opendev.org/716271"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Part of blueprint use-pcpu-and-vcpu-in-one-instance"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_9ef5cbf0","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":38},"updated":"2020-07-17 22:21:44.000000000","message":"This is useful context but we can drop it from here now, since it won\u0027t really be that beneficial once merged.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"}],"nova/compute/api.py":[{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f805ef6e3f1e45baf8cf0223bfe3aa97320de171","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                \u0027instance_az\u0027: instance_az, \u0027volume_az\u0027: volume_az}"},{"line_number":1178,"context_line":"            raise exception.MismatchVolumeAZException(reason\u003dmsg)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"    def _check_compute_service_for_mixed_instance(self, instance):"},{"line_number":1181,"context_line":"        \"\"\"Check if the nova-compute service is ready to support mixed instance"},{"line_number":1182,"context_line":"        when the CPU allocation policy is \u0027mixed\u0027."},{"line_number":1183,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2ce92fe2","line":1180,"updated":"2020-07-15 12:14:55.000000000","message":"Done. And the same TODO for any code block added in this commit.","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"302aef1d4a433abc6fc771730a88f39671530746","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                \u0027instance_az\u0027: instance_az, \u0027volume_az\u0027: volume_az}"},{"line_number":1178,"context_line":"            raise exception.MismatchVolumeAZException(reason\u003dmsg)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"    def _check_compute_service_for_mixed_instance(self, instance):"},{"line_number":1181,"context_line":"        \"\"\"Check if the nova-compute service is ready to support mixed instance"},{"line_number":1182,"context_line":"        when the CPU allocation policy is \u0027mixed\u0027."},{"line_number":1183,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8b47961d","line":1180,"updated":"2020-07-14 11:20:09.000000000","message":"Needs a TODO to remove this check in W(allaby)","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"46b8e5bc07a8e831181ddf35ff22ec1d2e846f28","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                \u0027instance_az\u0027: instance_az, \u0027volume_az\u0027: volume_az}"},{"line_number":1178,"context_line":"            raise exception.MismatchVolumeAZException(reason\u003dmsg)"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"    def _check_compute_service_for_mixed_instance(self, instance):"},{"line_number":1181,"context_line":"        \"\"\"Check if the nova-compute service is ready to support mixed instance"},{"line_number":1182,"context_line":"        when the CPU allocation policy is \u0027mixed\u0027."},{"line_number":1183,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5d3d32c2","line":1180,"in_reply_to":"bf51134e_8b47961d","updated":"2020-07-15 07:55:29.000000000","message":"Done and will add a TODO for any new code block from this commit.","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"302aef1d4a433abc6fc771730a88f39671530746","unresolved":false,"context_lines":[{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        # catch a request for creating a mixed instance, make sure all"},{"line_number":1194,"context_line":"        # nova-compute services have been upgrade to version after Victoria."},{"line_number":1195,"context_line":"        if (service.get_minimum_version_all_cells("},{"line_number":1196,"context_line":"                nova_context.get_admin_context(), \u0027nova-compute\u0027) \u003c"},{"line_number":1197,"context_line":"                MIN_VER_NOVA_COMPUTE_MIXED_POLICY):"},{"line_number":1198,"context_line":"            raise exception.MixedInstanceNotSupportByComputeService()"},{"line_number":1199,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_cbb86e12","line":1196,"range":{"start_line":1195,"start_character":12,"end_line":1196,"end_character":65},"updated":"2020-07-14 11:20:09.000000000","message":"nit: could you assign this to a variable just to make the check below nicer?","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"46b8e5bc07a8e831181ddf35ff22ec1d2e846f28","unresolved":false,"context_lines":[{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        # catch a request for creating a mixed instance, make sure all"},{"line_number":1194,"context_line":"        # nova-compute services have been upgrade to version after Victoria."},{"line_number":1195,"context_line":"        if (service.get_minimum_version_all_cells("},{"line_number":1196,"context_line":"                nova_context.get_admin_context(), \u0027nova-compute\u0027) \u003c"},{"line_number":1197,"context_line":"                MIN_VER_NOVA_COMPUTE_MIXED_POLICY):"},{"line_number":1198,"context_line":"            raise exception.MixedInstanceNotSupportByComputeService()"},{"line_number":1199,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_620fb536","line":1196,"range":{"start_line":1195,"start_character":12,"end_line":1196,"end_character":65},"in_reply_to":"bf51134e_cbb86e12","updated":"2020-07-15 07:55:29.000000000","message":"Good idea, Done.","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"302aef1d4a433abc6fc771730a88f39671530746","unresolved":false,"context_lines":[{"line_number":3856,"context_line":"        host_name is always None in the resize case."},{"line_number":3857,"context_line":"        host_name can be set in the cold migration case only."},{"line_number":3858,"context_line":"        \"\"\""},{"line_number":3859,"context_line":"        # check if nova-compute notes have been upgraded to Victoria if"},{"line_number":3860,"context_line":"        # resizing an instance with mixed policy."},{"line_number":3861,"context_line":"        allow_cross_cell_resize \u003d self._allow_cross_cell_resize("},{"line_number":3862,"context_line":"            context, instance)"},{"line_number":3863,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0b3c2691","line":3860,"range":{"start_line":3859,"start_character":0,"end_line":3860,"end_character":49},"updated":"2020-07-14 11:20:09.000000000","message":"this isn\u0027t true. Did you forget to add a check here?","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"46b8e5bc07a8e831181ddf35ff22ec1d2e846f28","unresolved":false,"context_lines":[{"line_number":3856,"context_line":"        host_name is always None in the resize case."},{"line_number":3857,"context_line":"        host_name can be set in the cold migration case only."},{"line_number":3858,"context_line":"        \"\"\""},{"line_number":3859,"context_line":"        # check if nova-compute notes have been upgraded to Victoria if"},{"line_number":3860,"context_line":"        # resizing an instance with mixed policy."},{"line_number":3861,"context_line":"        allow_cross_cell_resize \u003d self._allow_cross_cell_resize("},{"line_number":3862,"context_line":"            context, instance)"},{"line_number":3863,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a2054d16","line":3860,"range":{"start_line":3859,"start_character":0,"end_line":3860,"end_character":49},"in_reply_to":"bf51134e_0b3c2691","updated":"2020-07-15 07:55:29.000000000","message":"I forgot to add the checker.\n\n  self._check_compute_service_for_mixed_instance(instance)","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"302aef1d4a433abc6fc771730a88f39671530746","unresolved":false,"context_lines":[{"line_number":4136,"context_line":"    def unshelve(self, context, instance, new_az\u003dNone):"},{"line_number":4137,"context_line":"        # check all nova-compute notes have been upgrade to Victoria if"},{"line_number":4138,"context_line":"        # unshelving an instance with a mixed policy"},{"line_number":4139,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":4140,"context_line":"        \"\"\"Restore a shelved instance.\"\"\""},{"line_number":4141,"context_line":"        request_spec \u003d objects.RequestSpec.get_by_instance_uuid("},{"line_number":4142,"context_line":"            context, instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ab4c1a42","line":4139,"updated":"2020-07-14 11:20:09.000000000","message":"needs to go below the docstring","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"46b8e5bc07a8e831181ddf35ff22ec1d2e846f28","unresolved":false,"context_lines":[{"line_number":4136,"context_line":"    def unshelve(self, context, instance, new_az\u003dNone):"},{"line_number":4137,"context_line":"        # check all nova-compute notes have been upgrade to Victoria if"},{"line_number":4138,"context_line":"        # unshelving an instance with a mixed policy"},{"line_number":4139,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":4140,"context_line":"        \"\"\"Restore a shelved instance.\"\"\""},{"line_number":4141,"context_line":"        request_spec \u003d objects.RequestSpec.get_by_instance_uuid("},{"line_number":4142,"context_line":"            context, instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bd03ae0c","line":4139,"in_reply_to":"bf51134e_ab4c1a42","updated":"2020-07-15 07:55:29.000000000","message":"Done","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d294c098d380c1f3d5b9cd4ff762e2e853685331","unresolved":false,"context_lines":[{"line_number":5589,"context_line":"        # NOTE(danms): Eventually this all_cells nonsense should go away"},{"line_number":5590,"context_line":"        # and we should always iterate over the cells. However, certain"},{"line_number":5591,"context_line":"        # callers need the legacy behavior for now."},{"line_number":5592,"context_line":"        if all_cells:"},{"line_number":5593,"context_line":"            services \u003d []"},{"line_number":5594,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":5595,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2b65aa1e","line":5592,"updated":"2020-07-14 12:06:13.000000000","message":"pep8: F402 import \u0027service\u0027 from line 73 shadowed by loop variable","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"46b8e5bc07a8e831181ddf35ff22ec1d2e846f28","unresolved":false,"context_lines":[{"line_number":5589,"context_line":"        # NOTE(danms): Eventually this all_cells nonsense should go away"},{"line_number":5590,"context_line":"        # and we should always iterate over the cells. However, certain"},{"line_number":5591,"context_line":"        # callers need the legacy behavior for now."},{"line_number":5592,"context_line":"        if all_cells:"},{"line_number":5593,"context_line":"            services \u003d []"},{"line_number":5594,"context_line":"            service_dict \u003d nova_context.scatter_gather_all_cells(context,"},{"line_number":5595,"context_line":"                objects.ServiceList.get_all, disabled, set_zones\u003dset_zones)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_dd29428a","line":5592,"in_reply_to":"bf51134e_2b65aa1e","updated":"2020-07-15 07:55:29.000000000","message":"Fixed by \n\nfrom nova.objects import service as svc","commit_id":"12a1e6a20bf89ddc3168ca0d3900ab843acc4467"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3733505e8824c7b0a621428e0f0e91fcac284b3d","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"                        block_device_mapping, num_instances, i,"},{"line_number":1302,"context_line":"                        shutdown_terminate, create_instance\u003dFalse)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"                # TODO(huaqiang): Remove in Wallaby"},{"line_number":1305,"context_line":"                # check nova-compute notes have been updated to Victoria to"},{"line_number":1306,"context_line":"                # support the instance mixed CPU policy."},{"line_number":1307,"context_line":"                self._check_compute_service_for_mixed_instance(instance)"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"                block_device_mapping \u003d ("},{"line_number":1310,"context_line":"                    self._bdm_validate_set_size_and_instance(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_44d70824","line":1307,"range":{"start_line":1304,"start_character":16,"end_line":1307,"end_character":72},"updated":"2020-07-16 08:06:02.000000000","message":"I think we can call this check right after we get numa topology which is in \u0027_validate_and_build_base_options\u0027 method","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"07d63edb1a2b775991d28949369ef7e6f157906e","unresolved":false,"context_lines":[{"line_number":1304,"context_line":"                # TODO(huaqiang): Remove in Wallaby"},{"line_number":1305,"context_line":"                # check nova-compute notes have been updated to Victoria to"},{"line_number":1306,"context_line":"                # support the instance mixed CPU policy."},{"line_number":1307,"context_line":"                self._check_compute_service_for_mixed_instance(instance)"},{"line_number":1308,"context_line":""},{"line_number":1309,"context_line":"                block_device_mapping \u003d ("},{"line_number":1310,"context_line":"                    self._bdm_validate_set_size_and_instance(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_086b5e84","line":1307,"updated":"2020-07-16 14:49:51.000000000","message":"It\u0027s closer to numa_topology, and a new numa_topology is what I acutally intrested in.\n\nDone","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3733505e8824c7b0a621428e0f0e91fcac284b3d","unresolved":false,"context_lines":[{"line_number":3860,"context_line":"        host_name is always None in the resize case."},{"line_number":3861,"context_line":"        host_name can be set in the cold migration case only."},{"line_number":3862,"context_line":"        \"\"\""},{"line_number":3863,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":3864,"context_line":"        # check if nova-compute notes have been upgraded to Victoria if"},{"line_number":3865,"context_line":"        # resizing an instance with mixed policy."},{"line_number":3866,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":3867,"context_line":"        allow_cross_cell_resize \u003d self._allow_cross_cell_resize("},{"line_number":3868,"context_line":"            context, instance)"},{"line_number":3869,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_24ee54ec","line":3866,"range":{"start_line":3863,"start_character":8,"end_line":3866,"end_character":64},"updated":"2020-07-16 08:06:02.000000000","message":"It is meaningless to check orginal instance is mixed, since the cloud isn\u0027t finish the upgrade, then there is no any mixed instance.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"07d63edb1a2b775991d28949369ef7e6f157906e","unresolved":false,"context_lines":[{"line_number":3863,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":3864,"context_line":"        # check if nova-compute notes have been upgraded to Victoria if"},{"line_number":3865,"context_line":"        # resizing an instance with mixed policy."},{"line_number":3866,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":3867,"context_line":"        allow_cross_cell_resize \u003d self._allow_cross_cell_resize("},{"line_number":3868,"context_line":"            context, instance)"},{"line_number":3869,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e8654ab0","line":3866,"updated":"2020-07-16 14:49:51.000000000","message":"We have talked about this, if it is possible to create a mixed instance through the change of image metadata properties, we should check all nova-compute nodes have finished the upgrade.\n\nI think if the combination \"hw_cpu_policy\u003dmixed\", \"hw_cpu_realtime_mask\u003d^0\u0027, \"hw:cpu_realtime\u003dyes\" is not prevented by some human man rule, we can create mixed instance with it. (I have to say this combination looks ugly.)","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"07d63edb1a2b775991d28949369ef7e6f157906e","unresolved":false,"context_lines":[{"line_number":3934,"context_line":"            # disk size validation was not intended for a volume-backed"},{"line_number":3935,"context_line":"            # resize case."},{"line_number":3936,"context_line":"            if volume_backed:"},{"line_number":3937,"context_line":"                self._validate_flavor_image_numa_pci("},{"line_number":3938,"context_line":"                    image, new_instance_type, validate_pci\u003dTrue)"},{"line_number":3939,"context_line":"            else:"},{"line_number":3940,"context_line":"                self._validate_flavor_image_nostatus("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_4806f6cf","line":3937,"updated":"2020-07-16 14:49:51.000000000","message":"Good please to make the check.\nDone.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"de6ed592ad09803a57ed6944972219f1d8d598e8","unresolved":false,"context_lines":[{"line_number":3934,"context_line":"            # disk size validation was not intended for a volume-backed"},{"line_number":3935,"context_line":"            # resize case."},{"line_number":3936,"context_line":"            if volume_backed:"},{"line_number":3937,"context_line":"                self._validate_flavor_image_numa_pci("},{"line_number":3938,"context_line":"                    image, new_instance_type, validate_pci\u003dTrue)"},{"line_number":3939,"context_line":"            else:"},{"line_number":3940,"context_line":"                self._validate_flavor_image_nostatus("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_1ed54d1c","line":3937,"updated":"2020-07-17 01:05:43.000000000","message":"Later: s/Good please/Good place/","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3733505e8824c7b0a621428e0f0e91fcac284b3d","unresolved":false,"context_lines":[{"line_number":3934,"context_line":"            # disk size validation was not intended for a volume-backed"},{"line_number":3935,"context_line":"            # resize case."},{"line_number":3936,"context_line":"            if volume_backed:"},{"line_number":3937,"context_line":"                self._validate_flavor_image_numa_pci("},{"line_number":3938,"context_line":"                    image, new_instance_type, validate_pci\u003dTrue)"},{"line_number":3939,"context_line":"            else:"},{"line_number":3940,"context_line":"                self._validate_flavor_image_nostatus("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_64bdecd6","line":3937,"range":{"start_line":3937,"start_character":16,"end_line":3937,"end_character":53},"updated":"2020-07-16 08:06:02.000000000","message":"we could check that inside this method.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"07d63edb1a2b775991d28949369ef7e6f157906e","unresolved":false,"context_lines":[{"line_number":4144,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":4145,"context_line":"        # check all nova-compute notes have been upgrade to Victoria if"},{"line_number":4146,"context_line":"        # unshelving an instance with a mixed policy"},{"line_number":4147,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":4148,"context_line":"        request_spec \u003d objects.RequestSpec.get_by_instance_uuid("},{"line_number":4149,"context_line":"            context, instance.uuid)"},{"line_number":4150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_280902dc","line":4147,"updated":"2020-07-16 14:49:51.000000000","message":"Removed.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3733505e8824c7b0a621428e0f0e91fcac284b3d","unresolved":false,"context_lines":[{"line_number":4144,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":4145,"context_line":"        # check all nova-compute notes have been upgrade to Victoria if"},{"line_number":4146,"context_line":"        # unshelving an instance with a mixed policy"},{"line_number":4147,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":4148,"context_line":"        request_spec \u003d objects.RequestSpec.get_by_instance_uuid("},{"line_number":4149,"context_line":"            context, instance.uuid)"},{"line_number":4150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a4b38409","line":4147,"updated":"2020-07-16 08:06:02.000000000","message":"it is meanless for unshelve also, since it won\u0027t change the flavor.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"07d63edb1a2b775991d28949369ef7e6f157906e","unresolved":false,"context_lines":[{"line_number":4924,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":4925,"context_line":"        # check if nova-compute notes have been upgraded to Victoria if"},{"line_number":4926,"context_line":"        # migrating a mixed policy instance"},{"line_number":4927,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":4928,"context_line":""},{"line_number":4929,"context_line":"        if host_name:"},{"line_number":4930,"context_line":"            # Validate the specified host before changing the instance task"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_880c8eec","line":4927,"updated":"2020-07-16 14:49:51.000000000","message":"Understand the reason is migration will not create an instance with a new flavor type. Removed.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3733505e8824c7b0a621428e0f0e91fcac284b3d","unresolved":false,"context_lines":[{"line_number":4924,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":4925,"context_line":"        # check if nova-compute notes have been upgraded to Victoria if"},{"line_number":4926,"context_line":"        # migrating a mixed policy instance"},{"line_number":4927,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":4928,"context_line":""},{"line_number":4929,"context_line":"        if host_name:"},{"line_number":4930,"context_line":"            # Validate the specified host before changing the instance task"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_84b640f8","line":4927,"updated":"2020-07-16 08:06:02.000000000","message":"ditto, we needn\u0027t check for live-migration","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3733505e8824c7b0a621428e0f0e91fcac284b3d","unresolved":false,"context_lines":[{"line_number":5067,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":5068,"context_line":"        # check all nova-compute nodes have been upgrade to Victoria if"},{"line_number":5069,"context_line":"        # instance is requesting a mixed policy"},{"line_number":5070,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":5071,"context_line":""},{"line_number":5072,"context_line":"        inst_host \u003d instance.host"},{"line_number":5073,"context_line":"        service \u003d objects.Service.get_by_compute_host(context, inst_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_c4cb186f","line":5070,"range":{"start_line":5070,"start_character":8,"end_line":5070,"end_character":64},"updated":"2020-07-16 08:06:02.000000000","message":"evacuate needn\u0027t check also. But we should check rebuild, since it changes the image meta","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"07d63edb1a2b775991d28949369ef7e6f157906e","unresolved":false,"context_lines":[{"line_number":5067,"context_line":"        # TODO(huaqiang): Remove in Wallaby"},{"line_number":5068,"context_line":"        # check all nova-compute nodes have been upgrade to Victoria if"},{"line_number":5069,"context_line":"        # instance is requesting a mixed policy"},{"line_number":5070,"context_line":"        self._check_compute_service_for_mixed_instance(instance)"},{"line_number":5071,"context_line":""},{"line_number":5072,"context_line":"        inst_host \u003d instance.host"},{"line_number":5073,"context_line":"        service \u003d objects.Service.get_by_compute_host(context, inst_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_680f7adf","line":5070,"updated":"2020-07-16 14:49:51.000000000","message":"removed.","commit_id":"b375efe1baf232c5ff70bbbe2b171271ebd1d307"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01eb25de8349aa09bf61faf1538ec79043c7189c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"from nova.objects import fields as fields_obj"},{"line_number":72,"context_line":"from nova.objects import keypair as keypair_obj"},{"line_number":73,"context_line":"from nova.objects import quotas as quotas_obj"},{"line_number":74,"context_line":"from nova.objects import service as svc"},{"line_number":75,"context_line":"from nova.pci import request as pci_request"},{"line_number":76,"context_line":"from nova.policies import servers as servers_policies"},{"line_number":77,"context_line":"import nova.policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_ded62354","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":39},"updated":"2020-07-17 22:21:44.000000000","message":"Any reason we need to do this instead of just using \u0027objects.Service\u0027? (\u0027nova.objects\u0027 is imported above)","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"3655b438da2f783cf6be328bf2f92d0a5f8c8828","unresolved":false,"context_lines":[{"line_number":71,"context_line":"from nova.objects import fields as fields_obj"},{"line_number":72,"context_line":"from nova.objects import keypair as keypair_obj"},{"line_number":73,"context_line":"from nova.objects import quotas as quotas_obj"},{"line_number":74,"context_line":"from nova.objects import service as svc"},{"line_number":75,"context_line":"from nova.pci import request as pci_request"},{"line_number":76,"context_line":"from nova.policies import servers as servers_policies"},{"line_number":77,"context_line":"import nova.policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_e834ffae","line":74,"updated":"2020-07-20 14:43:43.000000000","message":"No, I don\u0027t have a particular reason for this, and also, \u0027objects.service.get_minimum_version_all_cells\u0027 is already used in L3793, this import line will be removed.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"5bc89174e254773a83e52239c58d33d2af16d223","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        minimal_version \u003d objects.service.get_minimum_version_all_cells("},{"line_number":735,"context_line":"            nova_context.get_admin_context(), [\u0027nova-compute\u0027])"},{"line_number":736,"context_line":"        if minimal_version \u003c MIN_VER_NOVA_COMPUTE_MIXED_POLICY:"},{"line_number":737,"context_line":"            raise exception.MixedInstanceNotSupportByComputeService()"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"    @staticmethod"},{"line_number":740,"context_line":"    def _validate_flavor_image_numa_pci(image, instance_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_863ba8c6","line":737,"updated":"2020-07-21 07:21:55.000000000","message":"Good catch, we should end up this exception with a HTTP error response!\nThanks.","commit_id":"ee7c643b08bc042293cc0a7e03f6a2518db0b50e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d3a38bc320636a529bf8bc23871cdf5d9a451971","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        minimal_version \u003d objects.service.get_minimum_version_all_cells("},{"line_number":735,"context_line":"            nova_context.get_admin_context(), [\u0027nova-compute\u0027])"},{"line_number":736,"context_line":"        if minimal_version \u003c MIN_VER_NOVA_COMPUTE_MIXED_POLICY:"},{"line_number":737,"context_line":"            raise exception.MixedInstanceNotSupportByComputeService()"},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"    @staticmethod"},{"line_number":740,"context_line":"    def _validate_flavor_image_numa_pci(image, instance_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_201f2371","line":737,"updated":"2020-07-21 07:10:12.000000000","message":"we forget to catch this exception at api layer both for create and resize. And we should return 409.","commit_id":"ee7c643b08bc042293cc0a7e03f6a2518db0b50e"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"3655b438da2f783cf6be328bf2f92d0a5f8c8828","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    @mock.patch(\u0027nova.virt.hardware.get_pci_numa_policy_constraint\u0027,"},{"line_number":369,"context_line":"                return_value\u003dNone)"},{"line_number":370,"context_line":"    def test_create_mixed_instance_compute_version_fail(self, mock_pci):"},{"line_number":371,"context_line":"        \"\"\"Ensure a \u0027\u0027 exception raises when all \u0027nova-compute\u0027 nodes have"},{"line_number":372,"context_line":"        not been upgraded to or after Victoria."},{"line_number":373,"context_line":"        \"\"\""},{"line_number":374,"context_line":"        extra_specs \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_c8393ba4","line":371,"updated":"2020-07-20 14:43:43.000000000","message":"This is a mistake, the concrete exception name is missed :(\nWill be added.","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01eb25de8349aa09bf61faf1538ec79043c7189c","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    @mock.patch(\u0027nova.virt.hardware.get_pci_numa_policy_constraint\u0027,"},{"line_number":369,"context_line":"                return_value\u003dNone)"},{"line_number":370,"context_line":"    def test_create_mixed_instance_compute_version_fail(self, mock_pci):"},{"line_number":371,"context_line":"        \"\"\"Ensure a \u0027\u0027 exception raises when all \u0027nova-compute\u0027 nodes have"},{"line_number":372,"context_line":"        not been upgraded to or after Victoria."},{"line_number":373,"context_line":"        \"\"\""},{"line_number":374,"context_line":"        extra_specs \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_bec9afad","line":371,"range":{"start_line":371,"start_character":20,"end_line":371,"end_character":22},"updated":"2020-07-17 22:21:44.000000000","message":"wuh wuh","commit_id":"533970dacb04c39fa645dccda4fe4f3a017de28a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"6b2de7016209b9be98363506a7a5cc8f71a1c42c","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"    # TODO(huaqiang): Remove in Wallaby"},{"line_number":2368,"context_line":"    # TODO(huaqiang): To be removed when \u0027hw:cpu_dedicated_mask\u0027 could be"},{"line_number":2369,"context_line":"    # parsed from flavor extra spec."},{"line_number":2370,"context_line":"    @mock.patch(\u0027nova.objects.service.get_dedicated_cpu_constraint\u0027,"},{"line_number":2371,"context_line":"                mock.Mock(return_value\u003dset([3])))"},{"line_number":2372,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get_instance_host_status\u0027,"},{"line_number":2373,"context_line":"                new\u003dmock.Mock(return_value\u003dfields_obj.HostStatus.UP))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_6fd58ee5","line":2370,"updated":"2020-07-21 00:00:07.000000000","message":"It is an obvious mistake. fixed.","commit_id":"d362daef17eab5b29e59d59dbb83c0adbc3bd82a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"986eeb87c5f75f09e58546cb3c6ae5f8f47659ba","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"    # TODO(huaqiang): Remove in Wallaby"},{"line_number":2368,"context_line":"    # TODO(huaqiang): To be removed when \u0027hw:cpu_dedicated_mask\u0027 could be"},{"line_number":2369,"context_line":"    # parsed from flavor extra spec."},{"line_number":2370,"context_line":"    @mock.patch(\u0027nova.objects.service.get_dedicated_cpu_constraint\u0027,"},{"line_number":2371,"context_line":"                mock.Mock(return_value\u003dset([3])))"},{"line_number":2372,"context_line":"    @mock.patch(\u0027nova.compute.api.API.get_instance_host_status\u0027,"},{"line_number":2373,"context_line":"                new\u003dmock.Mock(return_value\u003dfields_obj.HostStatus.UP))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_af3046a0","line":2370,"range":{"start_line":2370,"start_character":17,"end_line":2370,"end_character":66},"updated":"2020-07-20 23:24:02.000000000","message":"you mock the wrong path I thnk.","commit_id":"d362daef17eab5b29e59d59dbb83c0adbc3bd82a"}]}