)]}'
{"id":"openstack%2Fnova~741351","triplet_id":"openstack%2Fnova~master~I58b0382c86d4ef798572edb63d311e0e3e6937bb","project":"openstack/nova","branch":"master","topic":"bug/1887735","hashtags":[],"change_id":"I58b0382c86d4ef798572edb63d311e0e3e6937bb","subject":"Refactor and rename test_tcp_rst_no_compute_rpcapi","status":"MERGED","created":"2020-07-16 01:02:44.000000000","updated":"2021-02-23 22:49:13.000000000","submitted":"2021-02-23 22:41:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"741351-bug/1887735","meta_rev_id":"fc16849057b1106e551e96e89e5b803191e2142b","_number":741351,"virtual_id_number":741351,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-23 22:41:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2021-02-23 17:24:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":2,"date":"2021-02-04 14:39:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2021-02-23 17:24:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"CC":[{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-16 01:06:59.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-07-16 01:23:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-16 01:36:12.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-07-16 01:44:38.000000000","updated_by":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"reviewer":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"state":"REVIEWER"},{"updated":"2020-07-16 01:51:53.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-16 02:02:27.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2020-12-18 21:19:59.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2020-12-18 23:49:09.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-02-04 14:39:23.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-02-23 17:24:09.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"0af546abaa80a783f2f10bed5469f0bde3c2fff4","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-07-16 01:02:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"44cb3d780fccf7c921ffc2f650a3d6007542c628","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-07-16 01:06:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"28510975f9dfb2837b4ee5eb2d5c461b5599aaa6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-16 01:23:25.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6ea42a9f8ae34bf29469ba7ee9741aee : SUCCESS in 11m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/22833c3f354a4da88e859b9fa9b13e5c : SUCCESS in 11m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b08d57c04b504186895ec1ea9e44b688 : SUCCESS in 6m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/eb5b591aa9c24f598c581cc016096204 : SUCCESS in 17m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cbcb8c4147074fbf990a5827c7036f9c : FAILURE in 10m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e6cbade662b54b3bac0d58a9a1a18276 : SUCCESS in 8m 21s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/6a02ee8662e6464d81d66880e107f715 : SUCCESS in 12m 49s","accounts_in_message":[],"_revision_number":1},{"id":"3ed1e112a002a6f923bd5a8a6878c993bf80293c","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-07-16 01:33:09.000000000","message":"Patch Set 1: Workflow-1\n\nArgh... something wrong.","accounts_in_message":[],"_revision_number":1},{"id":"d06258f330b962a020e59c827e855496345de696","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-07-16 01:36:12.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/51/741351/1/check/pmem-tempest-plugin-filtered-multi-node/3eced1f/ : FAILURE in 32m 08s","accounts_in_message":[],"_revision_number":1},{"id":"73896543ff1455c31acfdb175e0ad039415a80d1","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2020-07-16 01:44:38.000000000","message":"Patch Set 1:\n\nalways :D","accounts_in_message":[],"_revision_number":1},{"id":"36e46008432b2f249bb8cf29a904c5c791dce723","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-16 01:51:53.000000000","message":"Patch Set 1:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/51/741351/1/check-vote/ext-nova-zuul/277d60c : SUCCESS in 48m 05s","accounts_in_message":[],"_revision_number":1},{"id":"662d613de8f4a4635651e14e2ad9789e4cac9f4e","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-07-16 02:02:27.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-43878 : SUCCESS in 58m 59s","accounts_in_message":[],"_revision_number":1},{"id":"72c636b8d480717158426393e171445b0fd122c5","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-09-25 16:11:47.000000000","message":"Abandoned\n\nThis unit test is prevented from working properly because of a bug in python 3.8 where mock speccing is calling class properties:\n\nhttps://bugs.python.org/issue41768\n\nAbandoning this in favor of the following change which [temporarily] removes the test:\n\nhttps://review.opendev.org/714676\n\nThe only other way to potentially make the test work is if there\u0027s a way we could disable use of the MockAutoSpecFixture [1] only for the one test until if/when the python 3.8 bug is fixed.\n\n[1] https://github.com/openstack/nova/blob/3dbb6c18a58ce42ea515b8ca71e69b0b438ef268/nova/test.py#L273","accounts_in_message":[],"_revision_number":1},{"id":"8b17fa3c23418ec21ca800ca3a06d3e4cca001c5","tag":"autogenerated:gerrit:restore","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-12-18 21:19:23.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"992d04232198fd32bdf0c7714a50f79396a6a5c7","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-12-18 21:19:59.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/51/741351/1/check/EMC_PowerFlex_NOVA/7b9c089/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"43115cd905e25c7aab462716916c735c8333e70d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-18 22:31:49.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/87656b261cca4cd5ae21b6543a0ef7d0 : FAILURE in 16m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/86ebc5d60e1c4b0fb1d47a8795c944a7 : FAILURE in 14m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/10e197c0484a4c5da8c23acff129e296 : SUCCESS in 7m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/db5e020a6a664c6b91ef88db5734099e : SUCCESS in 17m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/30133e2d5735470d88d5942bdb6f4839 : FAILURE in 17m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/097d673f82524d62aa5bc2ada56c6641 : FAILURE in 13m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/17fd72831d844ee187adc76d63a3e934 : SUCCESS in 9m 58s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1c472cde3527450daa7ddfb30ac74f02 : SUCCESS in 18m 50s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/b849862dba81465f8ffa30482b3f014a : SUCCESS in 18m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d1a7eb6df0acc6680287d66be1f1a6c16ca6eae8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-12-18 23:49:09.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/741351/1 : FAILURE in 2h 28m 00s","accounts_in_message":[],"_revision_number":1},{"id":"f23ee59359370957f9cb58ac3d813c2566120eb8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-02-03 22:52:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c5701b20071c4d9146eefb3f32c0ff08d6518d4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-02-03 22:54:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"135d2ef9817cae87216f804aaa36646a5892402d","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-02-03 22:55:33.000000000","message":"Patch Set 3:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"4e2d213e01f1c17a49a11917c6f9fd3559634014","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-02-03 23:01:01.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"47a43c3ba108531ec018de46f9aa3193efa7fa23","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 23:14:52.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4d7474c48b9346c381d51cd86f9696d0 : SUCCESS in 12m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/93a5f366fc6445da9a3f5727e934622d : SUCCESS in 10m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9fcd12f0bf32416fba701b17834ce531 : SUCCESS in 6m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/15eeb3296ac74d57aae03f339ea36a50 : SUCCESS in 11m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ffa74de8c08e4b47b0aa2b201c1f36fb : SUCCESS in 16m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d663d8c54e624029a8a061dfe647e0e9 : SUCCESS in 12m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/728c99fb6981420885cefef7f3fcaef5 : SUCCESS in 8m 18s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/89fe1b61e20b412f83ea9ee2951638f2 : SUCCESS in 17m 39s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/b1121ed264f64d83abb98e5572addf47 : SUCCESS in 15m 05s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b2204bb041c1d049f8569768b7f8496c12169575","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-02-03 23:18:32.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"60eaba87341bd5accda980dea1cfd6f6bf60ea8e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 23:40:21.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/22cc615f375248a19f029eed56cca9ee : SUCCESS in 18m 51s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/f104a74401da41ba8ed159c616936b74 : SUCCESS in 21m 02s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"64de34f20d752720f538a5ddfb8982a17b1c698b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 23:41:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fbae32b3f5c94cbe8077bbe6d7d6966a : SUCCESS in 18m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c447d08e80af4a239aed7d36a0a7f7c4 : SUCCESS in 14m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f9657c108aa54040870ac0f44bc0ebd0 : SUCCESS in 6m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/433810d2359b43d9b0c21dc99d1283a5 : SUCCESS in 12m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1f4a520ca7974e87877b13636226168e : SUCCESS in 13m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f2fa20f4816d4787a46cabaa44588ce0 : SUCCESS in 13m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9383b4f7a58944f5b55e80903028e212 : SUCCESS in 9m 16s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/4160783b7f6e4d3aba2a53e936056d18 : SUCCESS in 14m 15s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/ee4978d1e75e42aab2c1187f2f79ff00 : SUCCESS in 15m 55s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"21e6d78530a3ce6ad9c0c71302e5e5ba78b778cf","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-02-04 02:04:41.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/741351/4/iscsi : FAILURE in 2h 44m 54s","accounts_in_message":[],"_revision_number":4},{"id":"0a4b88c5c34667b743398d34c6c991f035264510","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-02-04 14:39:23.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"4936385b3eaf85ade16746efa0c561a6075af93f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-23 17:24:09.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nI missed this. Nice work","accounts_in_message":[],"_revision_number":4},{"id":"82f8ae8c88795894740da805ecb5f9c885a2ff77","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 19:46:02.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"559f2b8add4dcbd2211c43289ebb376195637485","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 22:41:04.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4078c260093b4216a5dd7411d7d98eba : SUCCESS in 14m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f1b3ce399d5c452eb287895c9b4bd98e : SUCCESS in 8m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/52c0d9d2cd12419d8de145be43b948f9 : SUCCESS in 11m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9f570252b60a4d188837bf4262e0f316 : SUCCESS in 12m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec2dccfcd256468f944fe4f167243e0c : SUCCESS in 9m 20s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1e67005b18c344deb6a02a51db3d925e : SUCCESS in 20m 29s","accounts_in_message":[],"_revision_number":4},{"id":"76bf7cb55e80815aef3afaa0f845f0ebb41cd1b4","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 22:41:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"fc16849057b1106e551e96e89e5b803191e2142b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 22:49:13.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9fadd791701b49a19f3563c636ee8e6e : SUCCESS in 1m 17s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f6bacd3fde9d4f0de638dc2bb3ba2ac2520df874","revisions":{"282a5b69a8dfc7070a8572d5d552a327bb537326":{"kind":"REWORK","_number":1,"created":"2020-07-16 01:02:44.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/51/741351/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/741351/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/741351/1"}}},"commit":{"parents":[{"commit":"e6a015e6e96277cdc91439e363943590cafcb212","subject":"Merge \"crypto: Add type hints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e6a015e6e96277cdc91439e363943590cafcb212"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-07-16 00:55:25.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-07-16 01:02:13.000000000","tz":0},"subject":"Use unittest.mock instead of mock in test_websocketproxy","message":"Use unittest.mock instead of mock in test_websocketproxy\n\nThe NovaProxyRequestHandlerTestCase.test_tcp_rst_no_compute_rpcapi test\nfails with mock\u003d\u003d4.0.2 because mock is calling the\nNovaProxyRequestHandler class\u0027s compute_rpcapi @property while creating\nautospecs. The test asserts that the @property is not called when a TCP\nRST is received, so mock calling the @property itself causes the test\nfail erroneously.\n\nWe can import unittest.mock instead of using the third-party mock\nlibrary to solve this issue instead of potentially blacklisting\nmock\u003d\u003d4.0.2 or working around the bug in our test. Nova is the only\nproject failing one test and since the third-party mock library may not\nbe that comprehensively maintained at this point, this might be the\nbest route forward.\n\nCloses-Bug: #1887735\n\nChange-Id: I58b0382c86d4ef798572edb63d311e0e3e6937bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/282a5b69a8dfc7070a8572d5d552a327bb537326"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/282a5b69a8dfc7070a8572d5d552a327bb537326"}]},"branch":"refs/heads/master"},"c7ac94c95afd7a3b7b09026393674afc447ef1fc":{"kind":"REWORK","_number":2,"created":"2021-02-03 22:52:05.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/51/741351/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/741351/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/741351/2"}}},"commit":{"parents":[{"commit":"e6a015e6e96277cdc91439e363943590cafcb212","subject":"Merge \"crypto: Add type hints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e6a015e6e96277cdc91439e363943590cafcb212"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-07-16 00:55:25.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-02-03 22:50:25.000000000","tz":0},"subject":"Refactor and rename test_tcp_rst_no_compute_rpcapi","message":"Refactor and rename test_tcp_rst_no_compute_rpcapi\n\nThe NovaProxyRequestHandlerTestCase.test_tcp_rst_no_compute_rpcapi test\nfails with mock\u003d\u003d4.0.2 because mock is calling the\nNovaProxyRequestHandler class\u0027s compute_rpcapi @property while creating\nmock autospecs. The test asserts that the @property is not called when a TCP\nRST is received, so mock calling the @property itself causes the test fail\nerroneously.\n\nThis is also the case in the built-in unittest.mock in python 3.8 [1].\n\nWe can refactor (and rename) this unit test to more concisely test the\ndesired behavior when TCP RST or otherwise unvalidated requests are\nhandled by the console proxy request handler. This has the benefit of\n(1) making the test work with mock\u003d\u003d4.0.2 and python 3.8 and (2) removing\nunnecessary and potentionally incorrect assumptions about and dependence on\nthe internal details of websockify.\n\nCloses-Bug: #1887735\n\n[1] https://bugs.python.org/issue41768\n\nChange-Id: I58b0382c86d4ef798572edb63d311e0e3e6937bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c7ac94c95afd7a3b7b09026393674afc447ef1fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c7ac94c95afd7a3b7b09026393674afc447ef1fc"}]},"branch":"refs/heads/master"},"56c8d4cc2827fb44cda3270be6b639c6c58f2085":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2021-02-03 22:54:52.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/51/741351/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/741351/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/741351/3"}}},"commit":{"parents":[{"commit":"fefd984fd1294f23677e3df4390e37c7664883a0","subject":"Merge \"zuul: Mark nova-lvm as voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fefd984fd1294f23677e3df4390e37c7664883a0"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-07-16 00:55:25.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-02-03 22:53:44.000000000","tz":0},"subject":"Refactor and rename test_tcp_rst_no_compute_rpcapi","message":"Refactor and rename test_tcp_rst_no_compute_rpcapi\n\nThe NovaProxyRequestHandlerTestCase.test_tcp_rst_no_compute_rpcapi test\nfails with mock\u003d\u003d4.0.2 because mock is calling the\nNovaProxyRequestHandler class\u0027s compute_rpcapi @property while creating\nmock autospecs. The test asserts that the @property is not called when\na TCP RST is received, so mock calling the @property itself causes the\ntest to fail erroneously.\n\nThis is also the case in the built-in unittest.mock in python 3.8 [1].\n\nWe can refactor (and rename) this unit test to more concisely test the\ndesired behavior when TCP RST or otherwise unvalidated requests are\nhandled by the console proxy request handler. This has the benefit of\n(1) making the test work with mock\u003d\u003d4.0.2 and python 3.8 and (2)\nremoving unnecessary and potentionally incorrect assumptions about and\ndependence on the internal details of websockify.\n\nCloses-Bug: #1887735\n\n[1] https://bugs.python.org/issue41768\n\nChange-Id: I58b0382c86d4ef798572edb63d311e0e3e6937bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56c8d4cc2827fb44cda3270be6b639c6c58f2085"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56c8d4cc2827fb44cda3270be6b639c6c58f2085"}]},"branch":"refs/heads/master"},"f6bacd3fde9d4f0de638dc2bb3ba2ac2520df874":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-02-03 23:18:32.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/51/741351/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/741351/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/741351/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/741351/4"}}},"commit":{"parents":[{"commit":"fefd984fd1294f23677e3df4390e37c7664883a0","subject":"Merge \"zuul: Mark nova-lvm as voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fefd984fd1294f23677e3df4390e37c7664883a0"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2020-07-16 00:55:25.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2021-02-03 23:15:06.000000000","tz":0},"subject":"Refactor and rename test_tcp_rst_no_compute_rpcapi","message":"Refactor and rename test_tcp_rst_no_compute_rpcapi\n\nThe NovaProxyRequestHandlerTestCase.test_tcp_rst_no_compute_rpcapi test\nfails with mock\u003d\u003d4.0.2 because mock is calling the\nNovaProxyRequestHandler class\u0027s compute_rpcapi @property while creating\nmock autospecs. The test asserts that the @property is not called when\na TCP RST is received, so mock calling the @property itself causes the\ntest to fail erroneously.\n\nThis is also the case in the built-in unittest.mock in python 3.8 [1].\n\nWe can refactor (and rename) this unit test to more concisely test the\ndesired behavior when TCP RST or otherwise unvalidated requests are\nhandled by the console proxy request handler. This has the benefit of\n(1) making the test work with mock\u003d\u003d4.0.2 and python 3.8 and (2)\nremoving unnecessary dependency and potentially incorrect assumptions\nabout the internal details of websockify.\n\nCloses-Bug: #1887735\n\n[1] https://bugs.python.org/issue41768\n\nChange-Id: I58b0382c86d4ef798572edb63d311e0e3e6937bb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f6bacd3fde9d4f0de638dc2bb3ba2ac2520df874"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f6bacd3fde9d4f0de638dc2bb3ba2ac2520df874"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}