)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"3b93df69ac1d0e05ebc04137807a0f8620709ec7","unresolved":false,"context_lines":[{"line_number":268,"context_line":"management network."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Related options:"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"* ``live_migration_tunnelled``: The live_migration_inbound_addr value is"},{"line_number":273,"context_line":"  ignored if tunneling is enabled."},{"line_number":274,"context_line":"\"\"\"),"},{"line_number":275,"context_line":"    cfg.StrOpt(\u0027live_migration_uri\u0027,"},{"line_number":276,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_88c29584","side":"PARENT","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":34},"updated":"2020-07-28 15:47:43.000000000","message":"As your testing proves that the combo of `live_migration_tunnelled`  and `live_migration_inbound_addr` works; then deleting this is fine.","commit_id":"057891ac247fadfb9637d3e834f8b1ef3e39bc27"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"3b93df69ac1d0e05ebc04137807a0f8620709ec7","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\"\"\"),"},{"line_number":258,"context_line":"    cfg.HostAddressOpt(\u0027live_migration_inbound_addr\u0027,"},{"line_number":259,"context_line":"                       help\u003d\"\"\""},{"line_number":260,"context_line":"This option is set on the target of the live migration traffic, and is then"},{"line_number":261,"context_line":"used by the source of the traffic when constructing the migration URI."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"If this option is set to None, the hostname of the migration target compute"},{"line_number":264,"context_line":"node will be used."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c8b5ad33","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":70},"updated":"2020-07-28 15:47:43.000000000","message":"It took me a few readings to parse the phrasing.  But I\u0027m unable to suggest better phrasing myself. Maybe Stephen. :)\n\nWhile at it, you might want to call out that the value expected here is an IP address.  (Although \"addr\" should give the hint.)","commit_id":"a6e9572ef8c6aa85213482c9930333fee049255c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"147b5afac6b99e0fe39a5d9effe1434b78f1f1d1","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\"\"\"),"},{"line_number":258,"context_line":"    cfg.HostAddressOpt(\u0027live_migration_inbound_addr\u0027,"},{"line_number":259,"context_line":"                       help\u003d\"\"\""},{"line_number":260,"context_line":"This option indicates the IP address which should be used as the target for"},{"line_number":261,"context_line":"live migration traffic when migrating to this hypervisor. This metadata is then"},{"line_number":262,"context_line":"used by the source of the live migration traffic to construct a migration URI."},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c1f38872","line":260,"updated":"2020-07-31 14:29:00.000000000","message":"Could we get a summary line for this. Something like:\n\n  IP address used as the live migration address for this host.\n\n  This option indicates...","commit_id":"823efe44d091e22fab9fc1508c973bfc6f93dd64"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8c6bda60151aef74703baf1726f13d212f51cdf9","unresolved":true,"context_lines":[{"line_number":257,"context_line":"\"\"\"),"},{"line_number":258,"context_line":"    cfg.HostAddressOpt(\u0027live_migration_inbound_addr\u0027,"},{"line_number":259,"context_line":"                       help\u003d\"\"\""},{"line_number":260,"context_line":"IP address used as the live migration address for this host."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"This option indicates the IP address which should be used as the target for"},{"line_number":263,"context_line":"live migration traffic when migrating to this hypervisor. This metadata is then"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b5c3e4e_e99b635c","line":260,"updated":"2021-02-01 14:51:47.000000000","message":"I could be a hostname also, but this is clearer than what we had before.","commit_id":"b6e9023751de396888c8547ae4c8af0f2c6e752d"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"f9ba8d100be5ae15ba1f3e1fd1141ef3c04c35eb","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                       help\u003d\"\"\""},{"line_number":260,"context_line":"IP address used as the live migration address for this host."},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"This option indicates the IP address which should be used as the target for"},{"line_number":263,"context_line":"live migration traffic when migrating to this hypervisor. This metadata is then"},{"line_number":264,"context_line":"used by the source of the live migration traffic to construct a migration URI."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"If this option is set to None, the hostname of the migration target compute"},{"line_number":267,"context_line":"node will be used."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5caf5be2","line":264,"range":{"start_line":262,"start_character":0,"end_line":264,"end_character":78},"updated":"2020-07-31 14:41:57.000000000","message":"Reads _much_ clearer; thanks, Andrew!","commit_id":"b6e9023751de396888c8547ae4c8af0f2c6e752d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8c6bda60151aef74703baf1726f13d212f51cdf9","unresolved":true,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"Override the default libvirt live migration target URI (which is dependent"},{"line_number":286,"context_line":"on virt_type). Any included \"%s\" is replaced with the migration target"},{"line_number":287,"context_line":"hostname, or `live_migration_inbound_addr` if set."},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"If this option is set to None (which is the default), Nova will automatically"},{"line_number":290,"context_line":"generate the `live_migration_uri` value based on only 4 supported `virt_type`"}],"source_content_type":"text/x-python","patch_set":3,"id":"d532d2e5_d78a0dca","line":287,"updated":"2021-02-01 14:51:47.000000000","message":"nice add, thank you.","commit_id":"b6e9023751de396888c8547ae4c8af0f2c6e752d"}]}