)]}'
{"id":"openstack%2Fnova~741557","triplet_id":"openstack%2Fnova~master~I0777e037fbc82c0ea0256f4ed5b71b26f93326af","project":"openstack/nova","branch":"master","hashtags":[],"change_id":"I0777e037fbc82c0ea0256f4ed5b71b26f93326af","subject":"WIP libvirt: Check if device is listed in the inactive config during detach","status":"ABANDONED","created":"2020-07-16 23:12:09.000000000","updated":"2020-07-29 12:19:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"65e6c492e6255879516fe698f20607598cda68ce","_number":741557,"virtual_id_number":741557,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-07-17 01:33:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-07-17 01:46:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"date":"2020-07-16 23:55:38.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:jenkins-gerrit-trigger","date":"2020-07-17 06:25:49.000000000","_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"date":"2020-07-17 05:33:41.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-07-16 23:45:46.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-16 23:55:38.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-07-17 01:33:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-17 01:46:25.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2020-07-17 05:33:41.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-17 06:25:49.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"06d84572fce2ded3a998dbe84bc527ac10c5417b","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-07-16 23:12:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7327e265c9bc0184e795960740bafcde0de9270d","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-07-16 23:45:46.000000000","message":"Patch Set 1: Workflow-1\n\nThere\u0027s an easier fix.","accounts_in_message":[],"_revision_number":1},{"id":"ceedaee5437f43c0e8fb21b647fe85fe06a66751","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-07-16 23:55:38.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/57/741557/1/check/pmem-tempest-plugin-filtered-multi-node/370d9b6/ : FAILURE in 41m 47s","accounts_in_message":[],"_revision_number":1},{"id":"531e7c9142f1b3595ec909534c4a0679662b98e0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-17 01:33:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/9216297917dc4d56b93017f8155d22df : FAILURE in 1h 13m 26s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/97fcc316d84747f6ad59594b74c4be16 : FAILURE in 1h 02m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7e95f33d27af4cfdb92351e669449252 : FAILURE in 14m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d3c01a9e1e9b43c5990b082be8a8bd80 : FAILURE in 35m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/df0d72c999524b84bcf547855fb73334 : FAILURE in 7m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8eb0088dff854709b66d467aa45995f5 : FAILURE in 34m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/14b0c59355944cd883bda8d55f14706f : FAILURE in 34m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0feac131483e413995d61750b5afa09b : SUCCESS in 29m 00s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/07c545560206487482c56d3b06fe64e9 : SUCCESS in 1h 46m 02s (non-voting)\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/058af28fd7284335bcbafc8769ce9c6f : FAILURE in 1h 40m 56s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/433c72412240407a91637fe2a6e7a6ff : FAILURE in 1h 49m 59s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/757d854a31d040ba8f8be8d57924c8b2 : FAILURE in 1h 21m 35s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/11deb0807efd498b9c6f0336b472b520 : FAILURE in 1h 31m 00s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/98503fe4f5ab4699a4ef8186762b182f : FAILURE in 2h 11m 11s\n- nova-next https://zuul.opendev.org/t/openstack/build/5722b4ca2893484eb70dc64e562ad52b : FAILURE in 2h 17m 44s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/da4898e390184dfe9cc271e4789616b0 : SUCCESS in 36m 10s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/41991e20886143d58574fcc501a14a8f : FAILURE in 1h 37m 35s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/564beae67d4f492db558b48b41cb09e1 : SUCCESS in 1h 29m 33s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/7c2c5b6758d244bf81bea921f4f7f74b : SUCCESS in 47m 23s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/d1684fa92b0d4fe98b54914a21ae5a7b : FAILURE in 43m 12s (non-voting)\n\nWarning:\n  Comments left for invalid file nova/virt/libvirt/driver.py\n  Comments left for invalid file nova/virt/libvirt/volume/libvirt_iscsi.py","accounts_in_message":[],"_revision_number":1},{"id":"2e2c4a24eb2f73785a6a4a82901687ff3489b022","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-07-17 01:46:25.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-43927 : SUCCESS in 1h 30m 03s","accounts_in_message":[],"_revision_number":1},{"id":"6f55aceb01f4258a497a3196efc25fd03e4046be","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-17 05:33:41.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/57/741557/1/check-vote/ext-nova-zuul/2d46b6a : FAILURE in 3h 52m 26s","accounts_in_message":[],"_revision_number":1},{"id":"a7bac425a5f1d338f5499722c115b2c1298dc258","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2020-07-17 06:25:49.000000000","message":"Patch Set 1:\n\nBuild Successful \n\n* SRIOV-nova-direct http://13.74.249.42/refs/changes/57/741557/1/SRIOV-nova-direct : SUCCESS\n\n* SRIOV-nova-macvtap http://13.74.249.42/refs/changes/57/741557/1/SRIOV-nova-macvtap : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"65e6c492e6255879516fe698f20607598cda68ce","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-07-29 12:19:21.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c31c629278ea399e5a72b7c9556c4173a5d14bd8","revisions":{"c31c629278ea399e5a72b7c9556c4173a5d14bd8":{"kind":"REWORK","_number":1,"created":"2020-07-16 23:12:09.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/57/741557/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/57/741557/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/57/741557/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/57/741557/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/57/741557/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/57/741557/1"}}},"commit":{"parents":[{"commit":"214feb8a3687ec3da0c11be5f4d843b8f127745a","subject":"WIP libvirt: Reintroduce native QEMU iSCSI volume support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/214feb8a3687ec3da0c11be5f4d843b8f127745a"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-16 23:02:02.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-16 23:07:26.000000000","tz":60},"subject":"WIP libvirt: Check if device is listed in the inactive config during detach","message":"WIP libvirt: Check if device is listed in the inactive config during detach\n\nNova would previously assume that persistent domains always had the\ndevice listed in the inactive config. However this isn\u0027t the case if\nprevious attempts to detach a device from the live config had failed.\nSubsequent attempts to detach the device would first start by attempting\nto detach the device from both the live *and* inactive persistent\nconfig. This would result in an uncaught failure as the device is no\nlonger persent in the inactive config thanks to the initial attempt to\ndetach.\n\nThis change corrects this by removing the use of the domain wide\nhas_persistent_configuration check and instead wires up the ability to\ncheck for the specific device in the inactive config.\n\nCloses-Bug: #TODO\nChange-Id: I0777e037fbc82c0ea0256f4ed5b71b26f93326af\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c31c629278ea399e5a72b7c9556c4173a5d14bd8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c31c629278ea399e5a72b7c9556c4173a5d14bd8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}