)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"193d2947b5a180d94a19248c61bc5a8bca6c5822","unresolved":false,"context_lines":[{"line_number":4380,"context_line":"                       \u0027migration_uuid\u0027: migration.uuid})"},{"line_number":4381,"context_line":"            raise"},{"line_number":4382,"context_line":""},{"line_number":4383,"context_line":"    def _delete_stashed_migration_information(self, instance):"},{"line_number":4384,"context_line":"        \"\"\"Remove information about the flavor change after a resize.\"\"\""},{"line_number":4385,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4386,"context_line":"        instance.new_flavor \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8c50e960","line":4383,"updated":"2020-07-21 10:09:30.000000000","message":"I don\u0027t know why I didn\u0027t add hints to this :-\\ Will add if/when I respin","commit_id":"9a3f19a62708ce23912b8e4285337c3ae9811049"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"193d2947b5a180d94a19248c61bc5a8bca6c5822","unresolved":false,"context_lines":[{"line_number":4703,"context_line":"        :param migration: Migration object whose status is \"reverting\"."},{"line_number":4704,"context_line":"        \"\"\""},{"line_number":4705,"context_line":"        # Get stashed old_vm_state information to determine if guest should"},{"line_number":4706,"context_line":"        # be powered on after spawn; we default to ACTIVE for backwards"},{"line_number":4707,"context_line":"        # compatibility if old_vm_state is not set"},{"line_number":4708,"context_line":"        old_vm_state \u003d instance.system_metadata.pop("},{"line_number":4709,"context_line":"            \u0027old_vm_state\u0027, vm_states.ACTIVE)"},{"line_number":4710,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_cc4ae1aa","line":4707,"range":{"start_line":4706,"start_character":37,"end_line":4707,"end_character":50},"updated":"2020-07-21 10:09:30.000000000","message":"TODO: Drop this since it\u0027ll always be set now (it\u0027s a bug if it isn\u0027t)","commit_id":"9a3f19a62708ce23912b8e4285337c3ae9811049"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3cea298c436cbf626af392d4e36a4cdfbb1b9f39","unresolved":false,"context_lines":[{"line_number":4924,"context_line":"        :param migration: Migration object"},{"line_number":4925,"context_line":"        \"\"\""},{"line_number":4926,"context_line":"        self._set_instance_info(instance, instance.old_flavor)"},{"line_number":4927,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4928,"context_line":"        instance.new_flavor \u003d None"},{"line_number":4929,"context_line":"        instance.host \u003d migration.source_compute"},{"line_number":4930,"context_line":"        instance.node \u003d migration.source_node"},{"line_number":4931,"context_line":"        instance.save(expected_task_state\u003d[task_states.RESIZE_REVERTING])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_8e8e0b25","side":"PARENT","line":4928,"range":{"start_line":4927,"start_character":0,"end_line":4928,"end_character":34},"updated":"2020-08-17 12:47:56.000000000","message":"Couldn\u0027t you just refactor this by removing these two lines?","commit_id":"ccf617ccb5d2363f75893b1fc0218877872a8a73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dd51cc0fa70444dbd1baf33d36f08b2ff80c2fc8","unresolved":false,"context_lines":[{"line_number":4924,"context_line":"        :param migration: Migration object"},{"line_number":4925,"context_line":"        \"\"\""},{"line_number":4926,"context_line":"        self._set_instance_info(instance, instance.old_flavor)"},{"line_number":4927,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4928,"context_line":"        instance.new_flavor \u003d None"},{"line_number":4929,"context_line":"        instance.host \u003d migration.source_compute"},{"line_number":4930,"context_line":"        instance.node \u003d migration.source_node"},{"line_number":4931,"context_line":"        instance.save(expected_task_state\u003d[task_states.RESIZE_REVERTING])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_01d460bc","side":"PARENT","line":4928,"range":{"start_line":4927,"start_character":0,"end_line":4928,"end_character":34},"in_reply_to":"9f560f44_8e8e0b25","updated":"2020-08-19 17:25:07.000000000","message":"I was going to say I thought I\u0027d done that. I had...in a different patch [1] \\o/. I\u0027ll rebase onto that once it merges\n\n[1] https://review.opendev.org/#/c/744958/","commit_id":"ccf617ccb5d2363f75893b1fc0218877872a8a73"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cf8dfcadf5c90c7546adc594f43eaccac89ec204","unresolved":false,"context_lines":[{"line_number":5326,"context_line":"            # not re-scheduling"},{"line_number":5327,"context_line":"            if exc_info[1] is None:"},{"line_number":5328,"context_line":"                exc_info[1] \u003d exc_info[0]()"},{"line_number":5329,"context_line":"            if exc_info[1].__traceback__ is not exc_info[2]:"},{"line_number":5330,"context_line":"                raise exc_info[1].with_traceback(exc_info[2])"},{"line_number":5331,"context_line":"            raise exc_info[1]"},{"line_number":5332,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_f2b9eecb","line":5329,"updated":"2020-08-24 21:25:35.000000000","message":"pep8: error: Item \"None\" of \"Optional[Any]\" has no attribute \"__traceback__\"","commit_id":"cc1f84f23262f0b02c465e2d9a00e3a1d99b8b5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cf8dfcadf5c90c7546adc594f43eaccac89ec204","unresolved":false,"context_lines":[{"line_number":5327,"context_line":"            if exc_info[1] is None:"},{"line_number":5328,"context_line":"                exc_info[1] \u003d exc_info[0]()"},{"line_number":5329,"context_line":"            if exc_info[1].__traceback__ is not exc_info[2]:"},{"line_number":5330,"context_line":"                raise exc_info[1].with_traceback(exc_info[2])"},{"line_number":5331,"context_line":"            raise exc_info[1]"},{"line_number":5332,"context_line":""},{"line_number":5333,"context_line":"    # TODO(stephenfin): Remove unused request_spec parameter in API v6.0"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_d2bcaabc","line":5330,"updated":"2020-08-24 21:25:35.000000000","message":"pep8: error: Item \"None\" of \"Optional[Any]\" has no attribute \"with_traceback\"","commit_id":"cc1f84f23262f0b02c465e2d9a00e3a1d99b8b5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cf8dfcadf5c90c7546adc594f43eaccac89ec204","unresolved":false,"context_lines":[{"line_number":5328,"context_line":"                exc_info[1] \u003d exc_info[0]()"},{"line_number":5329,"context_line":"            if exc_info[1].__traceback__ is not exc_info[2]:"},{"line_number":5330,"context_line":"                raise exc_info[1].with_traceback(exc_info[2])"},{"line_number":5331,"context_line":"            raise exc_info[1]"},{"line_number":5332,"context_line":""},{"line_number":5333,"context_line":"    # TODO(stephenfin): Remove unused request_spec parameter in API v6.0"},{"line_number":5334,"context_line":"    @messaging.expected_exceptions(exception.MigrationPreCheckError)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_32b086dd","line":5331,"updated":"2020-08-24 21:25:35.000000000","message":"pep8: error: Exception must be derived from BaseException","commit_id":"cc1f84f23262f0b02c465e2d9a00e3a1d99b8b5a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e05fc58de13c927188addb953fb22b599e3328e2","unresolved":false,"context_lines":[{"line_number":4928,"context_line":"        :param migration: Migration object"},{"line_number":4929,"context_line":"        \"\"\""},{"line_number":4930,"context_line":"        self._set_instance_info(instance, instance.old_flavor)"},{"line_number":4931,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4932,"context_line":"        instance.new_flavor \u003d None"},{"line_number":4933,"context_line":"        instance.host \u003d migration.source_compute"},{"line_number":4934,"context_line":"        instance.node \u003d migration.source_node"},{"line_number":4935,"context_line":"        instance.save(expected_task_state\u003d[task_states.RESIZE_REVERTING])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_3ef67690","side":"PARENT","line":4932,"range":{"start_line":4931,"start_character":0,"end_line":4932,"end_character":34},"updated":"2020-08-26 09:44:25.000000000","message":"Why is this unnecessary in the new impl?","commit_id":"953b49ee1211d285c9b4cb0cc7827c740362f77f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"74072a79fc3ab9970e211cab68811db27ecb4b84","unresolved":false,"context_lines":[{"line_number":4928,"context_line":"        :param migration: Migration object"},{"line_number":4929,"context_line":"        \"\"\""},{"line_number":4930,"context_line":"        self._set_instance_info(instance, instance.old_flavor)"},{"line_number":4931,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4932,"context_line":"        instance.new_flavor \u003d None"},{"line_number":4933,"context_line":"        instance.host \u003d migration.source_compute"},{"line_number":4934,"context_line":"        instance.node \u003d migration.source_node"},{"line_number":4935,"context_line":"        instance.save(expected_task_state\u003d[task_states.RESIZE_REVERTING])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_be3566f9","side":"PARENT","line":4932,"range":{"start_line":4931,"start_character":0,"end_line":4932,"end_character":34},"in_reply_to":"9f560f44_1e9d7209","updated":"2020-08-26 09:55:51.000000000","message":"Basically for all but cross-cell resize, we\u0027ve added a finally call to do the unset as the very last operation, ensuring we still have access to this attributes when tearing things down in the virt driver","commit_id":"953b49ee1211d285c9b4cb0cc7827c740362f77f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d73f253a42ae0d88451a6f09ba1473889a7466f7","unresolved":false,"context_lines":[{"line_number":4928,"context_line":"        :param migration: Migration object"},{"line_number":4929,"context_line":"        \"\"\""},{"line_number":4930,"context_line":"        self._set_instance_info(instance, instance.old_flavor)"},{"line_number":4931,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4932,"context_line":"        instance.new_flavor \u003d None"},{"line_number":4933,"context_line":"        instance.host \u003d migration.source_compute"},{"line_number":4934,"context_line":"        instance.node \u003d migration.source_node"},{"line_number":4935,"context_line":"        instance.save(expected_task_state\u003d[task_states.RESIZE_REVERTING])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_1e9d7209","side":"PARENT","line":4932,"range":{"start_line":4931,"start_character":0,"end_line":4932,"end_character":34},"in_reply_to":"9f560f44_3ef67690","updated":"2020-08-26 09:54:43.000000000","message":"It\u0027s not unnecessary. It\u0027s just done last now. See [1] for same-cell confirm, [2] for cross-cell revert, [3] for same-cell confirm. There\u0027s no change for cross-cell confirm since that\u0027s already done last (via \u0027nova.conductor.tasks.cross_cell_migrate.ConfirmResizeTask._finish_confirm_in_target_cell\u0027)\n\n[1] https://review.opendev.org/#/c/741995/10/nova/compute/manager.py@4297\n[2] https://review.opendev.org/#/c/741995/10/nova/compute/manager.py@4710\n[3] https://review.opendev.org/#/c/741995/10/nova/compute/manager.py@4946","commit_id":"953b49ee1211d285c9b4cb0cc7827c740362f77f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"db60a300d5c784cbadbdf106494c4b6d4d839986","unresolved":false,"context_lines":[{"line_number":4928,"context_line":"        :param migration: Migration object"},{"line_number":4929,"context_line":"        \"\"\""},{"line_number":4930,"context_line":"        self._set_instance_info(instance, instance.old_flavor)"},{"line_number":4931,"context_line":"        instance.old_flavor \u003d None"},{"line_number":4932,"context_line":"        instance.new_flavor \u003d None"},{"line_number":4933,"context_line":"        instance.host \u003d migration.source_compute"},{"line_number":4934,"context_line":"        instance.node \u003d migration.source_node"},{"line_number":4935,"context_line":"        instance.save(expected_task_state\u003d[task_states.RESIZE_REVERTING])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_fe14fe4e","side":"PARENT","line":4932,"range":{"start_line":4931,"start_character":0,"end_line":4932,"end_character":34},"in_reply_to":"9f560f44_be3566f9","updated":"2020-08-26 09:57:09.000000000","message":"Thanks for the explanation. it makes sense now.","commit_id":"953b49ee1211d285c9b4cb0cc7827c740362f77f"}]}