)]}'
{"id":"openstack%2Fnova~742181","triplet_id":"openstack%2Fnova~stable%2Fpike~Id687e11e235fd6c2f99bb647184310dfdce9a08d","project":"openstack/nova","branch":"stable/pike","topic":"bug/1774249","hashtags":[],"change_id":"Id687e11e235fd6c2f99bb647184310dfdce9a08d","subject":"libvirt: Do not reraise DiskNotFound exceptions during resize","status":"MERGED","created":"2020-07-21 13:01:27.000000000","updated":"2020-07-23 10:47:53.000000000","submitted":"2020-07-23 10:47:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"742181-1595501273320-bd5f39d8","meta_rev_id":"115f7a76b9686061c579b86fecf6061f8c88cd80","_number":742181,"virtual_id_number":742181,"owner":{"_account_id":31575,"name":"Sasha Andonov","email":"sandonov@suse.com","username":"sandonov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2020-07-21 15:04:23.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-23 10:47:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2020-07-23 08:36:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2020-07-22 13:48:01.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2020-07-23 08:36:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-07-21 13:01:27.000000000","_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-21 13:01:27.000000000","updated_by":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"reviewer":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"state":"REVIEWER"},{"updated":"2020-07-21 15:04:23.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-07-22 13:48:01.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-07-23 08:36:51.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-07-23 10:47:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b551dd2b5509161fbab59cdc4c7a0147b97c75d1","author":{"_account_id":31575,"name":"Sasha Andonov","email":"sandonov@suse.com","username":"sandonov"},"date":"2020-07-21 13:01:27.000000000","message":"Patch Set 1: Cherry Picked from branch stable/queens.","accounts_in_message":[],"_revision_number":1},{"id":"62d982ee538d17f5a670b24fd520da15d82c0599","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-07-21 15:04:23.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/81/742181/1/check/pmem-tempest-plugin-filtered-multi-node/19c929c/ : RETRY_LIMIT in 4m 35s","accounts_in_message":[],"_revision_number":1},{"id":"5dcc7dac257c41a37550aa8dcec7d098e4c154b1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 18:17:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4be14ad04f464361acee0e00cb756625 : SUCCESS in 9m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1db93176c4924dc3832c64c0f67300d8 : SUCCESS in 16m 00s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1e124d0b3fde4c829dacae976f571bef : SUCCESS in 14m 51s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/cb80d9557be74ffd831644723b9e1263 : SUCCESS in 8m 10s\n- tempest-full https://zuul.opendev.org/t/openstack/build/345ed2f47a3a4dc4be4ef9dda218cb4a : SUCCESS in 1h 30m 37s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/0de3073f20f942c2af26aaa31432a98a : FAILURE in 36m 41s (non-voting)\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/204e232b717b4bfb81424522bc7a38a4 : FAILURE in 41m 20s (non-voting)\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/5b1167930d0d4e5b86cae74df578a0a2 : FAILURE in 48m 38s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/9b9c0fd9e9e244ddad1421c08219818a : SUCCESS in 50m 48s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/2aeae7749f1246be96fdb1e8d58a6826 : SUCCESS in 2h 07m 51s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/7ba5e5f9c8fa45e68b6c690eb90f3964 : SUCCESS in 19m 33s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/2deb153668d14282856752ebd877f627 : SUCCESS in 19m 48s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/a27bc3f5f2cf407b9cfd30eba52aa40b : FAILURE in 42m 31s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/ced7f55637f14f12b82fb03b518aab91 : SUCCESS in 1h 46m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5ff88b5d4c92d046a034489a697ac7b137f8e782","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-07-22 13:48:01.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, clean to stable/pike somehow and already in stable/queens.","accounts_in_message":[],"_revision_number":1},{"id":"082b6f9284515c074c85c0a212f8bf9735cba0fd","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-07-23 08:36:51.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean cherry pick, indeed. Thanks for backporting, Sasha! LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"7829ba1056a71136ca7730a106ed313d2244da50","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-07-23 08:37:06.000000000","message":"Topic changed from bug/1774249-stable/pike to bug/1774249","accounts_in_message":[],"_revision_number":1},{"id":"1b49de4febf523e150570c4b9535ba24f03d83c9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-23 08:37:19.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"150064633229bc2ac83a70e40a168acdab30ac0b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-23 10:47:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/927da3dd1b154f28af99d11f992d297b : SUCCESS in 9m 49s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a786678e2c434a40b5af1c45f7d1c319 : SUCCESS in 13m 03s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/472e9a36410e41d3b1f3a2d1333f814f : SUCCESS in 12m 11s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/823923c304a3482f85dd7d2fd421c5f6 : SUCCESS in 8m 02s\n- tempest-full https://zuul.opendev.org/t/openstack/build/21607d80665f426eb1baea3ac03c4d80 : SUCCESS in 1h 34m 45s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/c2bd69d37f9944e08d921b448f426b16 : FAILURE in 34m 16s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/9c7720d608134f198e3ba0df634d0d8c : SUCCESS in 53m 05s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/28964f5360b146ed9b52033bbccd9d63 : SUCCESS in 2h 04m 37s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/267a39edb57141aaa6a938f346da6e7d : SUCCESS in 19m 39s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/35003945b99e405cab3994e4a9087cf2 : SUCCESS in 19m 19s","accounts_in_message":[],"_revision_number":1},{"id":"115f7a76b9686061c579b86fecf6061f8c88cd80","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-23 10:47:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9202b2e6cfeb5dd67b54d7eaa6187725a34aeae6","revisions":{"9202b2e6cfeb5dd67b54d7eaa6187725a34aeae6":{"kind":"REWORK","_number":1,"created":"2020-07-21 13:01:27.000000000","uploader":{"_account_id":31575,"name":"Sasha Andonov","email":"sandonov@suse.com","username":"sandonov"},"ref":"refs/changes/81/742181/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/81/742181/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/81/742181/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/81/742181/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/81/742181/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/81/742181/1"}}},"commit":{"parents":[{"commit":"89312275607ea21e1c35a393ad1b00fe5591e30a","subject":"Clean up allocation if unshelve fails due to neutron","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/89312275607ea21e1c35a393ad1b00fe5591e30a"}]}],"author":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2018-05-20 18:03:51.000000000","tz":480},"committer":{"name":"Sasha Andonov","email":"sandonov@suse.com","date":"2020-07-21 13:01:27.000000000","tz":0},"subject":"libvirt: Do not reraise DiskNotFound exceptions during resize","message":"libvirt: Do not reraise DiskNotFound exceptions during resize\n\nWhen an instance has VERIFY_RESIZE status, the instance disk on the\nsource compute host has moved to \u003cinstance_path\u003e/\u003cinstance_uuid\u003e_resize\nfolder, which leads to disk not found errors if the update available\nresource periodic task on the source compute runs before resize is\nactually confirmed.\n\nIcec2769bf42455853cbe686fb30fda73df791b25 almost fixed this issue but it\nwill only set reraise to False when task_state is not None, that isn\u0027t\nthe case when an instance is resized but resize is not yet confirmed.\nThis patch adds a condition based on vm_state to ensure we don\u0027t\nreraise DiskNotFound exceptions while resize is not confirmed.\n\nCloses-Bug: 1774249\nCo-Authored-By: Vladyslav Drok \u003cvdrok@mirantis.com\u003e\nChange-Id: Id687e11e235fd6c2f99bb647184310dfdce9a08d\n(cherry picked from commit 966192704c20d1b4e9faf384c8dafac8ea6e06ea)\n(cherry picked from commit f1280ab849d20819791f7c4030f570a917d3e91d)\n(cherry picked from commit fd5c45473823105d8572d7940980163c6f09169c)\n(cherry picked from commit d3bdeb26155c2d3b53850b790d3800a2dd78cada)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9202b2e6cfeb5dd67b54d7eaa6187725a34aeae6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9202b2e6cfeb5dd67b54d7eaa6187725a34aeae6"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}