)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8995901fb75edf4efff5b3f056efbe3c361c7b67","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            except libvirt.libvirtError as ex:"},{"line_number":394,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":395,"context_line":"                    errcode \u003d ex.get_error_code()"},{"line_number":396,"context_line":"                    # TODO(lyarwood): Remove libvirt.VIR_ERR_OPERATION_FAILED"},{"line_number":397,"context_line":"                    # and libvirt.VIR_ERR_INTERNAL_ERROR once"},{"line_number":398,"context_line":"                    # MIN_LIBVIRT_VERSION is \u003e\u003d 4.1.0"},{"line_number":399,"context_line":"                    if errcode in (libvirt.VIR_ERR_OPERATION_FAILED,"},{"line_number":400,"context_line":"                                   libvirt.VIR_ERR_INTERNAL_ERROR,"},{"line_number":401,"context_line":"                                   libvirt.VIR_ERR_DEVICE_MISSING):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f1ef86e6","line":398,"range":{"start_line":396,"start_character":0,"end_line":398,"end_character":53},"updated":"2020-07-23 09:54:05.000000000","message":"If I am not mistaken MIN_LIBVIRT_VERSION won\u0027t change on stable branches (or just very unlikely?) and if that is true, then altough the cherry-pick cleanly applies, I think this TODOs shouldn\u0027t be backported. (Or it would have been slightly better if those were added as a separate follow-up patch)","commit_id":"93058ae1b8bc1b1728f08b9e606b68318751fc3b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8585fb3cf70a14c9663b5fe970a802c66ad44987","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            except libvirt.libvirtError as ex:"},{"line_number":394,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctx:"},{"line_number":395,"context_line":"                    errcode \u003d ex.get_error_code()"},{"line_number":396,"context_line":"                    # TODO(lyarwood): Remove libvirt.VIR_ERR_OPERATION_FAILED"},{"line_number":397,"context_line":"                    # and libvirt.VIR_ERR_INTERNAL_ERROR once"},{"line_number":398,"context_line":"                    # MIN_LIBVIRT_VERSION is \u003e\u003d 4.1.0"},{"line_number":399,"context_line":"                    if errcode in (libvirt.VIR_ERR_OPERATION_FAILED,"},{"line_number":400,"context_line":"                                   libvirt.VIR_ERR_INTERNAL_ERROR,"},{"line_number":401,"context_line":"                                   libvirt.VIR_ERR_DEVICE_MISSING):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_06047fc5","line":398,"range":{"start_line":396,"start_character":0,"end_line":398,"end_character":53},"in_reply_to":"bf51134e_f1ef86e6","updated":"2020-07-23 10:58:27.000000000","message":"I appreciate that but on the other hand these comments are harmless and their removal and/or move into a separate patch in master would cause future backports in this area to conflict needlessly.","commit_id":"93058ae1b8bc1b1728f08b9e606b68318751fc3b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8995901fb75edf4efff5b3f056efbe3c361c7b67","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                    if errcode in (libvirt.VIR_ERR_OPERATION_FAILED,"},{"line_number":400,"context_line":"                                   libvirt.VIR_ERR_INTERNAL_ERROR,"},{"line_number":401,"context_line":"                                   libvirt.VIR_ERR_DEVICE_MISSING):"},{"line_number":402,"context_line":"                        # TODO(lyarwood): Remove the following error message"},{"line_number":403,"context_line":"                        # check once we only care about VIR_ERR_DEVICE_MISSING"},{"line_number":404,"context_line":"                        errmsg \u003d ex.get_error_message()"},{"line_number":405,"context_line":"                        if \u0027not found\u0027 in errmsg:"},{"line_number":406,"context_line":"                            # This will be raised if the live domain"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_31bbbee5","line":403,"range":{"start_line":402,"start_character":23,"end_line":403,"end_character":78},"updated":"2020-07-23 09:54:05.000000000","message":"same as above","commit_id":"93058ae1b8bc1b1728f08b9e606b68318751fc3b"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8995901fb75edf4efff5b3f056efbe3c361c7b67","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                            # detach fails because the device is not found"},{"line_number":408,"context_line":"                            raise exception.DeviceNotFound("},{"line_number":409,"context_line":"                                device\u003dalternative_device_name)"},{"line_number":410,"context_line":"                    # TODO(lyarwood): Remove libvirt.VIR_ERR_INVALID_ARG once"},{"line_number":411,"context_line":"                    # MIN_LIBVIRT_VERSION is \u003e\u003d 4.1.0"},{"line_number":412,"context_line":"                    elif errcode \u003d\u003d libvirt.VIR_ERR_INVALID_ARG:"},{"line_number":413,"context_line":"                        errmsg \u003d ex.get_error_message()"},{"line_number":414,"context_line":"                        if \u0027no target device\u0027 in errmsg:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_b1ceae80","line":411,"range":{"start_line":410,"start_character":20,"end_line":411,"end_character":53},"updated":"2020-07-23 09:54:05.000000000","message":"and here, too","commit_id":"93058ae1b8bc1b1728f08b9e606b68318751fc3b"}]}