)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"c57e0999564d0a3f9074c68b393586d75ddaabbc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Changes:"},{"line_number":27,"context_line":"\tnova/tests/functional/regressions/test_bug_1843708.py"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"NOTE(stephenfin): The \u0027IntegratedTestBase\u0027 and \u0027InstanceHelperMixin\u0027"},{"line_number":30,"context_line":"base classes for functional tests are not fully integrated yet in"},{"line_number":31,"context_line":"stable/train, which requires reinventing the wheel somewhat."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I8a2726b39d0444de8c35480024078a97430f5d0c"},{"line_number":34,"context_line":"Closes-Bug: #1843708"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_cbf630fa","line":31,"range":{"start_line":29,"start_character":0,"end_line":31,"end_character":60},"updated":"2020-07-29 16:42:16.000000000","message":"It\u0027s public knowledge that RH will be supporting stable/train until 2024/2025 with ELS [1]. Do we want to bite the bullet and start backporting useful functional refactors like this from stable/ussuri and master to keep things as easy as possible moving forward?\n\nElod, would you be against that from a non-RH upstream stable core point of view?\n\n[1] https://access.redhat.com/support/policy/updates/openstack/platform/","commit_id":"b971dc82cb524fe86284c95ec671e2bad1c2874f"}],"nova/tests/functional/regressions/test_bug_1843708.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e144fd702dfcf4f96c45a95fff4aa7df4bf99460","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class RebuildWithKeypairTestCase("},{"line_number":26,"context_line":"    test.TestCase, integrated_helpers.InstanceHelperMixin,"},{"line_number":27,"context_line":"):"},{"line_number":28,"context_line":"    \"\"\"Regression test for bug 1843708."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1224f90c","line":26,"updated":"2020-07-28 11:05:53.000000000","message":"in Ussuri the integrated_helpers._IntegratedTestBase class was used. In Train we don\u0027t have I0d21cb94c932e6e556eca964c57868c705b2d120 yet so need to use both test.TestCase and InstanceHelperMixin.","commit_id":"b971dc82cb524fe86284c95ec671e2bad1c2874f"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e144fd702dfcf4f96c45a95fff4aa7df4bf99460","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    This tests a rebuild scenario with new key pairs."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"},{"line_number":34,"context_line":"        super(RebuildWithKeypairTestCase, self).setUp()"},{"line_number":35,"context_line":"        # Start standard fixtures."},{"line_number":36,"context_line":"        self.useFixture(func_fixtures.PlacementFixture())"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_52731116","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":13},"updated":"2020-07-28 11:05:53.000000000","message":"setUp needed to be added (due to not having the above mentioned patch in Train) to set all fixtures, api and start the services. Looks OK to me.","commit_id":"b971dc82cb524fe86284c95ec671e2bad1c2874f"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e144fd702dfcf4f96c45a95fff4aa7df4bf99460","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        keypair_req[\u0027keypair\u0027][\u0027name\u0027] \u003d \u0027test-key2\u0027"},{"line_number":59,"context_line":"        keypair2 \u003d self.api.post_keypair(keypair_req)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        server \u003d self._build_minimal_create_server_request("},{"line_number":62,"context_line":"            self.api, \u0027test-rebuild-with-keypair\u0027,"},{"line_number":63,"context_line":"            image_uuid\u003dfake_image.get_valid_image_id(),"},{"line_number":64,"context_line":"            networks\u003d\u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f234e54c","line":61,"updated":"2020-07-28 11:05:53.000000000","message":"this was \n  self._build_server(networks\u003d\u0027none\u0027)\nin Ussuri. Change is due to not having I91fa2f73185fef48e9aae9b7f61389c374e06676 in Train.","commit_id":"b971dc82cb524fe86284c95ec671e2bad1c2874f"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e144fd702dfcf4f96c45a95fff4aa7df4bf99460","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Create a server with keypair \u0027test-key1\u0027"},{"line_number":68,"context_line":"        server \u003d self.api.post_server({\u0027server\u0027: server})"},{"line_number":69,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Check keypairs"},{"line_number":72,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_52c2f134","line":69,"range":{"start_line":69,"start_character":36,"end_line":69,"end_character":44},"updated":"2020-07-28 11:05:53.000000000","message":"self.api needs to be added due to not having I8c96b337f32148f8f5899c9b87af331b1fa41424","commit_id":"b971dc82cb524fe86284c95ec671e2bad1c2874f"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e144fd702dfcf4f96c45a95fff4aa7df4bf99460","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        }"},{"line_number":85,"context_line":"        self.api.api_post(\u0027servers/%s/action\u0027 % server[\u0027id\u0027], body)"},{"line_number":86,"context_line":"        fake_notifier.wait_for_versioned_notifications(\u0027instance.rebuild.end\u0027)"},{"line_number":87,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Check keypairs changed"},{"line_number":90,"context_line":"        instance \u003d objects.Instance.get_by_uuid("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_92e129d4","line":87,"range":{"start_line":87,"start_character":36,"end_line":87,"end_character":44},"updated":"2020-07-28 11:05:53.000000000","message":"same as above","commit_id":"b971dc82cb524fe86284c95ec671e2bad1c2874f"}]}