)]}'
{"nova/privsep/path.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0c64ae7270aa8e2761a8a28b7cc2bc94da076eeb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return os.chown(path, uid, gid)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for root, dirs, files in os.walk(path):"},{"line_number":62,"context_line":"        os.chown(root, uid, gid)"},{"line_number":63,"context_line":"        for item in dirs:"},{"line_number":64,"context_line":"            os.chown(os.path.join(root, item), uid, gid)"},{"line_number":65,"context_line":"        for item in files:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_940043ad","line":62,"updated":"2020-08-26 10:59:38.000000000","message":"this require numeric user and group ids but the caller provides strings at https://review.opendev.org/#/c/639934/50/nova/virt/libvirt/utils.py@735","commit_id":"e5ba74a64c0086e1a7493f015ed0b669979fa591"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"efe510798a2b3ca30c5a6b50bb9db96939a3d967","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return os.chown(path, uid, gid)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for root, dirs, files in os.walk(path):"},{"line_number":62,"context_line":"        os.chown(root, uid, gid)"},{"line_number":63,"context_line":"        for item in dirs:"},{"line_number":64,"context_line":"            os.chown(os.path.join(root, item), uid, gid)"},{"line_number":65,"context_line":"        for item in files:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_a37b7c78","line":62,"in_reply_to":"9f560f44_00005e01","updated":"2020-08-27 08:07:56.000000000","message":"It really would. I\u0027m going to debug this further but I suspect I\u0027ll have to add mypy to oslo.privsep for this to work \\o/","commit_id":"e5ba74a64c0086e1a7493f015ed0b669979fa591"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"715fa0bc3fedc796a1a7301a2dd29714aec68971","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return os.chown(path, uid, gid)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for root, dirs, files in os.walk(path):"},{"line_number":62,"context_line":"        os.chown(root, uid, gid)"},{"line_number":63,"context_line":"        for item in dirs:"},{"line_number":64,"context_line":"            os.chown(os.path.join(root, item), uid, gid)"},{"line_number":65,"context_line":"        for item in files:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_00005e01","line":62,"in_reply_to":"9f560f44_1f96074d","updated":"2020-08-27 07:57:54.000000000","message":"It would have been a nice catch from mypy :/","commit_id":"e5ba74a64c0086e1a7493f015ed0b669979fa591"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c6edf88c43d4e53ed1542b51918ff919c45c8461","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        return os.chown(path, uid, gid)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    for root, dirs, files in os.walk(path):"},{"line_number":62,"context_line":"        os.chown(root, uid, gid)"},{"line_number":63,"context_line":"        for item in dirs:"},{"line_number":64,"context_line":"            os.chown(os.path.join(root, item), uid, gid)"},{"line_number":65,"context_line":"        for item in files:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_1f96074d","line":62,"in_reply_to":"9f560f44_940043ad","updated":"2020-08-26 14:41:32.000000000","message":"I\u0027ve addressed that now. Looks like the privsep decorator is screwing with type hints here :-(","commit_id":"e5ba74a64c0086e1a7493f015ed0b669979fa591"}]}