)]}'
{"nova/virt/libvirt/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76d62d3f00d10c4b13b19ec9f7f68bac956fe300","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova.virt.libvirt.volume import remotefs"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"if ty.TYPE_CHECKING:"},{"line_number":47,"context_line":"    from nova.virt.libvirt import guest as libvirt_guest"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_d9a2f4ad","line":47,"updated":"2020-08-26 10:36:22.000000000","message":"can we just add this import directly?","commit_id":"f89db92c79f86afb5710ec729b852dd906335a0a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cc5c42ffe0aed0216ad5fa6c52ce7c2fa1e0109b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova.virt.libvirt.volume import remotefs"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"if ty.TYPE_CHECKING:"},{"line_number":47,"context_line":"    from nova.virt.libvirt import guest as libvirt_guest"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_4e2c57ab","line":47,"in_reply_to":"9f560f44_d9a2f4ad","updated":"2020-08-26 13:18:07.000000000","message":"I was going to say there\u0027s a circular import here, but I can\u0027t see it now so hopefully yes","commit_id":"f89db92c79f86afb5710ec729b852dd906335a0a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"76d62d3f00d10c4b13b19ec9f7f68bac956fe300","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return open(*args, **kwargs)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def find_disk(guest: \u0027libvirt_guest.Guest\u0027) -\u003e ty.Tuple[str, ty.Optional[str]]:"},{"line_number":376,"context_line":"    \"\"\"Find root device path for instance"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    May be file or device"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_5996e44d","line":375,"range":{"start_line":375,"start_character":21,"end_line":375,"end_character":42},"updated":"2020-08-26 10:36:22.000000000","message":"can we make this explicit? (without the quotes) I tried and for me mypy and the tests are happy with that too.","commit_id":"f89db92c79f86afb5710ec729b852dd906335a0a"}]}
