)]}'
{"nova/virt/vmwareapi/ds_util.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5b11ee35867971698f8aa661d64f138577388351","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"ALL_SUPPORTED_DS_TYPES \u003d frozenset([\u0027VMFS\u0027, \u0027NFS\u0027, \u0027vsan\u0027])"},{"line_number":31,"context_line":"NON_STREAMABLE_DS_TYPES \u003d frozenset([\u0027VMFS\u0027, \u0027NFS\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Datastore(object):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_e8fcddb7","line":31,"updated":"2014-12-01 13:42:57.000000000","message":"Would prefer to keep the constant \"positive\"... How about this instead:\n\nSTREAMABLE_DS_TYPES \u003d frozenset([\u0027vsan\u0027])\n\nAlso, are \u0027VMFS\u0027, \u0027NFS\u0027, and \u0027vsan\u0027 strings defined as constants somewhere? If not, might be good to do that.","commit_id":"fea36f42c8d95ce801b11639cd77ebb00363597c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"2d357235e898cc2dc8d0dfcbbcbef4751f3e34f8","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"ALL_SUPPORTED_DS_TYPES \u003d frozenset([\u0027VMFS\u0027, \u0027NFS\u0027, \u0027vsan\u0027])"},{"line_number":31,"context_line":"NON_STREAMABLE_DS_TYPES \u003d frozenset([\u0027VMFS\u0027, \u0027NFS\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Datastore(object):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_0d8c88d6","line":31,"in_reply_to":"5a890539_e8fcddb7","updated":"2014-12-03 12:29:32.000000000","message":"Done","commit_id":"fea36f42c8d95ce801b11639cd77ebb00363597c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5b11ee35867971698f8aa661d64f138577388351","unresolved":false,"context_lines":[{"line_number":340,"context_line":"def get_allowed_datastore_types(disk_type):"},{"line_number":341,"context_line":"    if disk_type \u003d\u003d constants.DISK_TYPE_STREAM_OPTIMIZED:"},{"line_number":342,"context_line":"        return ALL_SUPPORTED_DS_TYPES"},{"line_number":343,"context_line":"    return NON_STREAMABLE_DS_TYPES"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"def file_delete(session, ds_path, dc_ref):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_082be933","line":343,"updated":"2014-12-01 13:42:57.000000000","message":"return ALL_SUPPORTED_DS_TYPES - STREAMABLE_DS_TYPES","commit_id":"fea36f42c8d95ce801b11639cd77ebb00363597c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"2d357235e898cc2dc8d0dfcbbcbef4751f3e34f8","unresolved":false,"context_lines":[{"line_number":340,"context_line":"def get_allowed_datastore_types(disk_type):"},{"line_number":341,"context_line":"    if disk_type \u003d\u003d constants.DISK_TYPE_STREAM_OPTIMIZED:"},{"line_number":342,"context_line":"        return ALL_SUPPORTED_DS_TYPES"},{"line_number":343,"context_line":"    return NON_STREAMABLE_DS_TYPES"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"def file_delete(session, ds_path, dc_ref):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a890539_6db26c97","line":343,"in_reply_to":"5a890539_082be933","updated":"2014-12-03 12:29:32.000000000","message":"Done","commit_id":"fea36f42c8d95ce801b11639cd77ebb00363597c"}]}