)]}'
{"nova/virt/libvirt/migration.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"30fb739d41f032df521ec9d48a3b87d6084280cf","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    if \u0027sched_vcpus\u0027 and \u0027sched_priority\u0027 in info:"},{"line_number":126,"context_line":"        cputune \u003d xml_doc.find(\u0027./cputune\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # delete the old variant(s)"},{"line_number":129,"context_line":"        for elem in cputune.findall(\u0027./vcpusched\u0027):"},{"line_number":130,"context_line":"            elem.getparent().remove(elem)"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_88d3a338","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":35},"updated":"2020-07-29 12:35:55.000000000","message":"Some more context here regarding why we need to do this would be appreciated but there\u0027s plenty in the associated commit message so meh.","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6145838c3e5242f5d4ec09533b08bdbdf115b7b1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    if \u0027sched_vcpus\u0027 and \u0027sched_priority\u0027 in info:"},{"line_number":126,"context_line":"        cputune \u003d xml_doc.find(\u0027./cputune\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # delete the old variant(s)"},{"line_number":129,"context_line":"        for elem in cputune.findall(\u0027./vcpusched\u0027):"},{"line_number":130,"context_line":"            elem.getparent().remove(elem)"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6b3604e9","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":35},"in_reply_to":"9f560f44_88d3a338","updated":"2020-07-29 16:40:58.000000000","message":"I\u0027m personnally in favor of writing large and fat sections of comments in the code directly so that people get noticed without needing to git blame.\n\n@Stephen, please follow-up with a patch that will provide enough information in a comment here and explaining this is only because real-time.\n\n\nI\u0027d even be in favor of addings comments to the LibvirtConfigGuestCPUTuneVCPUSched object so people wanting to use it for other things but RT would know they would have more homework than they originally planned.","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c428c7d407ce014511bd40d6fe4cb1185294dc4c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        cputune \u003d xml_doc.find(\u0027./cputune\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # delete the old variant(s)"},{"line_number":129,"context_line":"        for elem in cputune.findall(\u0027./vcpusched\u0027):"},{"line_number":130,"context_line":"            elem.getparent().remove(elem)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # ...and create a new, shiny one"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_085b0e54","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":51},"updated":"2020-07-29 16:28:16.000000000","message":"are we 100% sure that vcpusched attribute is only in use with realtime users ?\n\nI don\u0027t want us to trample non-realtime users based on RT expectations we could make later in the code.","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6145838c3e5242f5d4ec09533b08bdbdf115b7b1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        cputune \u003d xml_doc.find(\u0027./cputune\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # delete the old variant(s)"},{"line_number":129,"context_line":"        for elem in cputune.findall(\u0027./vcpusched\u0027):"},{"line_number":130,"context_line":"            elem.getparent().remove(elem)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # ...and create a new, shiny one"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cb0c703d","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":51},"in_reply_to":"9f560f44_085b0e54","updated":"2020-07-29 16:40:58.000000000","message":"OK, after a few findings, the only occurrence I found where we generate a LibvirtConfigGuestCPUTuneVCPUSched element is in https://github.com/openstack/nova/blob/49c3ac7dfa7aca5504f9d19958ff82a40e47f5a1/nova/virt/libvirt/driver.py#L5111-L5117\n\nSo, technically, we can absolutely make an assumption that the bug is only hitted by realtime users and the bugfix will only fix the issue for them, so there shouldn\u0027t be any side impact.","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f356dee22b61320ec6509220e2777a16175fd421","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        vcpusched \u003d vconfig.LibvirtConfigGuestCPUTuneVCPUSched()"},{"line_number":134,"context_line":"        vcpusched.vcpus \u003d info.sched_vcpus"},{"line_number":135,"context_line":"        vcpusched.priority \u003d info.sched_priority"},{"line_number":136,"context_line":"        # TODO(stephenfin): Stop assuming scheduler type. We currently only"},{"line_number":137,"context_line":"        # create these elements for real-time instances and \u0027fifo\u0027 is the only"},{"line_number":138,"context_line":"        # scheduler policy we currently support so this is reasonably safe to"},{"line_number":139,"context_line":"        # assume, but it\u0027s still unnecessary"},{"line_number":140,"context_line":"        vcpusched.scheduler \u003d \u0027fifo\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        cputune.append(vcpusched.format_dom())"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0e94cd36","line":139,"range":{"start_line":136,"start_character":7,"end_line":139,"end_character":44},"updated":"2020-07-28 17:17:56.000000000","message":"so i agree with your statement that we should not need to hardcode. as we discussed on irc i dont think the way your follow up patch adresses removing the hardcodeing is the right way to do that. i still need to think about that but i think this patch is correct as written.","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d90a6a1154fc1e9d605635a97aae7f6b1f72de57","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # assume, but it\u0027s still unnecessary"},{"line_number":140,"context_line":"        vcpusched.scheduler \u003d \u0027fifo\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        cputune.append(vcpusched.format_dom())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    LOG.debug(\u0027_update_numa_xml output xml\u003d%s\u0027,"},{"line_number":145,"context_line":"              etree.tostring(xml_doc, encoding\u003d\u0027unicode\u0027, pretty_print\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_881e150a","line":142,"updated":"2020-07-28 15:56:11.000000000","message":"Doesn\u0027t append() need an Element? And doesn\u0027t format_dom() return a string?\n\nThe unit test passed, but I don\u0027t actually understand how...","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99017563e4f0acc168222a7d98df0b61ae0fc76","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # assume, but it\u0027s still unnecessary"},{"line_number":140,"context_line":"        vcpusched.scheduler \u003d \u0027fifo\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        cputune.append(vcpusched.format_dom())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    LOG.debug(\u0027_update_numa_xml output xml\u003d%s\u0027,"},{"line_number":145,"context_line":"              etree.tostring(xml_doc, encoding\u003d\u0027unicode\u0027, pretty_print\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_88c8d555","line":142,"in_reply_to":"9f560f44_881e150a","updated":"2020-07-28 16:01:22.000000000","message":"Nope, it returns an Element [1]\n\n[1] https://github.com/openstack/nova/blob/ccecb507ff4bdcdd23d90e7b5b02a22c5a46ecc3/nova/virt/libvirt/config.py#L66-L67","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"28d8aeb2e62be977b8b4a9aae0873f4b029b9e4b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # assume, but it\u0027s still unnecessary"},{"line_number":140,"context_line":"        vcpusched.scheduler \u003d \u0027fifo\u0027"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        cputune.append(vcpusched.format_dom())"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    LOG.debug(\u0027_update_numa_xml output xml\u003d%s\u0027,"},{"line_number":145,"context_line":"              etree.tostring(xml_doc, encoding\u003d\u0027unicode\u0027, pretty_print\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_48407d57","line":142,"in_reply_to":"9f560f44_88c8d555","updated":"2020-07-28 16:17:41.000000000","message":"Doh, that made me look lazy, a Ctrl-] would not have been that hard.","commit_id":"b6aef1ec4f9848f85e1f367e560c2bdb703fa110"}]}