)]}'
{"nova/conf/compute.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8e90a0347fdf5ef7e4276ea82edf010778132039","unresolved":false,"context_lines":[{"line_number":986,"context_line":"    ``True``, the power state in the database will be updated to indicate the"},{"line_number":987,"context_line":"    guests are shutdown. Thus, they will not be resumed during host boot even"},{"line_number":988,"context_line":"    when ``resume_guests_state_on_host_boot`` is set to ``True``. In summary,"},{"line_number":989,"context_line":"    these two options are mutually exclusive."},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"Possible values:"},{"line_number":992,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_528dad79","line":989,"range":{"start_line":989,"start_character":4,"end_line":989,"end_character":44},"updated":"2020-07-29 21:59:30.000000000","message":"Would be more correct to say \"enablement of these two options is mutually exclusive.\"","commit_id":"7cddda8725d4f96f01dbb24bebb594f15c807cb0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4d81684dce243f91baa95d4cb9f0865332876987","unresolved":false,"context_lines":[{"line_number":986,"context_line":"    ``True``, the power state in the database will be updated to indicate the"},{"line_number":987,"context_line":"    guests are shutdown. Thus, they will not be resumed during host boot even"},{"line_number":988,"context_line":"    when ``resume_guests_state_on_host_boot`` is set to ``True``. In summary,"},{"line_number":989,"context_line":"    these two options are mutually exclusive."},{"line_number":990,"context_line":""},{"line_number":991,"context_line":"Possible values:"},{"line_number":992,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8ef6f4f8","line":989,"range":{"start_line":989,"start_character":4,"end_line":989,"end_character":44},"in_reply_to":"9f560f44_528dad79","updated":"2020-07-30 15:44:13.000000000","message":"Not really - IMO if this option is set, resume_guests_state_on_host_boot becomes a noop, but it can still be set (not that it would make sense to have it set - why would you want to waste time nooping every instance on host boot?).\n\nIf we want to enforce them being mutually exclusive, wouldn\u0027t it make more sense to combine them into a single option (though if you intend on backporting this, that\u0027s a dead idea from the start).\n\nSo something like instance_power_state_authority, and the values can be \"hypervisor\" or \"nova\". If \"hypervisor\", we sync state on stop and don\u0027t do anything on start, and if \"nova\" we don\u0027t do anything on stop, and start instances on host host boot.","commit_id":"7cddda8725d4f96f01dbb24bebb594f15c807cb0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8e90a0347fdf5ef7e4276ea82edf010778132039","unresolved":false,"context_lines":[{"line_number":998,"context_line":"Related options:"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"* ``sync_power_state_during_shutdown_timeout``"},{"line_number":1001,"context_line":"* ``resume_guests_state_on_host_boot``"},{"line_number":1002,"context_line":"\"\"\"),"},{"line_number":1003,"context_line":"]"},{"line_number":1004,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_92ec652a","line":1001,"range":{"start_line":1001,"start_character":0,"end_line":1001,"end_character":38},"updated":"2020-07-29 21:59:30.000000000","message":"Should this be here or no?","commit_id":"7cddda8725d4f96f01dbb24bebb594f15c807cb0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"4d81684dce243f91baa95d4cb9f0865332876987","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"* A positive integer or 0 (default value is 60)."},{"line_number":1329,"context_line":"\"\"\"),"},{"line_number":1330,"context_line":"    cfg.IntOpt(\"sync_power_state_during_shutdown_timeout\","},{"line_number":1331,"context_line":"        default\u003d60,"},{"line_number":1332,"context_line":"        min\u003d0,"},{"line_number":1333,"context_line":"        help\u003d\"\"\""},{"line_number":1334,"context_line":"Total time to wait in seconds for ``nova-compute`` to sync instance power"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cec0ec7f","line":1331,"updated":"2020-07-30 15:44:13.000000000","message":"This might have deployement impact, if this timeout is longer than systemd\u0027s for example. IIRC systemd will kill the process if it doesn\u0027t exit gracefully on its after after the configured timeout.","commit_id":"7cddda8725d4f96f01dbb24bebb594f15c807cb0"}]}