)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af8641a30eb3312f9404bcc2cd281cd840a2e44b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removed the host FQDN from the exception message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deletion of an instance after disabling the hypervisor by a non-admin"},{"line_number":10,"context_line":" user leaks the host fqdn in fault msg of instance.Removing the"},{"line_number":11,"context_line":"\u0027host\u0027 field from the error message of HypervisorUnavaiable"},{"line_number":12,"context_line":"cause it\u0027s leaking host fqdn to non-admin users. The admin user will"},{"line_number":13,"context_line":"see the Hypervisor unavailable exception msg but will be able to figure"},{"line_number":14,"context_line":"on which compute host the guest is on and that the connection is broken."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I0eae19399670f59c17c9a1a24e1bfcbf1b514e7b"},{"line_number":17,"context_line":"Closes-Bug: #1851587"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_20f37e75","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":72},"updated":"2020-07-30 11:10:23.000000000","message":"this is generally not how we adress this.\n\nwe should proably keep the fqdn in the exception for logging but only return the excecption name to the enduser.\n\nwe do this already for externall excpetion from ceph or libvirt and we do it is some cases for nova too.","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"}],"nova/exception.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"efec680717a080e914f86c871165ae86aefb9fbe","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    msg_fmt \u003d _(\"Insufficient compute resources: %(reason)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class HypervisorUnavailable(NovaException):"},{"line_number":509,"context_line":"    msg_fmt \u003d _(\"Connection to the hypervisor is broken on host\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2066de2a","line":508,"range":{"start_line":508,"start_character":0,"end_line":508,"end_character":43},"updated":"2020-07-30 11:19:40.000000000","message":"looking at the code this is only raised in two places.\n\nhttps://github.com/openstack/nova/blob/e3b0412dda2c070e9d4d3341de22d9845b84b7c6/nova/virt/libvirt/host.py#L512\nwere it the exception is alredy logged and\nhere where it is not \nhttps://github.com/openstack/nova/blob/6f6b63ee5f7ae180d5f81e61f04332f7aa14f9be/nova/virt/libvirt/volume/mount.py#L88\n\n\nperhaps the host is not needed since it is only ever raised in the virt driver on the affected host.\nso for that reason ill change my -1 to +1","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"},{"author":{"_account_id":30905,"name":"Harshavardhan Metla","email":"harshavardhan.metla@tcs.com","username":"harsha24"},"change_message_id":"e35bcee9a4ff78ad7c4c7a0d7ed18b1b822846aa","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    msg_fmt \u003d _(\"Insufficient compute resources: %(reason)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class HypervisorUnavailable(NovaException):"},{"line_number":509,"context_line":"    msg_fmt \u003d _(\"Connection to the hypervisor is broken on host\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6b0c373b","line":508,"range":{"start_line":508,"start_character":0,"end_line":508,"end_character":43},"in_reply_to":"9f560f44_2066de2a","updated":"2020-07-30 16:32:48.000000000","message":"Done","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"206fd98c31a7c508321efd3af0951750b9e6af31","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    msg_fmt \u003d _(\"Insufficient compute resources: %(reason)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class HypervisorUnavailable(NovaException):"},{"line_number":509,"context_line":"    msg_fmt \u003d _(\"Connection to the hypervisor is broken on host\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_eb720749","line":508,"range":{"start_line":508,"start_character":0,"end_line":508,"end_character":43},"in_reply_to":"9f560f44_2066de2a","updated":"2020-07-30 12:01:34.000000000","message":"You need to update the two callers to remove the \u0027host\u0027 argument. We should also add a log, as Sean suggests, to ensure the operator has more information to go debug the issue","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"},{"author":{"_account_id":30905,"name":"Harshavardhan Metla","email":"harshavardhan.metla@tcs.com","username":"harsha24"},"change_message_id":"e35bcee9a4ff78ad7c4c7a0d7ed18b1b822846aa","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    msg_fmt \u003d _(\"Insufficient compute resources: %(reason)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class HypervisorUnavailable(NovaException):"},{"line_number":509,"context_line":"    msg_fmt \u003d _(\"Connection to the hypervisor is broken on host\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_89e0aefc","line":508,"range":{"start_line":508,"start_character":0,"end_line":508,"end_character":43},"in_reply_to":"9f560f44_eb4327ae","updated":"2020-07-30 16:32:48.000000000","message":"Are you suggesting not to remove the host argument form the exception msg and add a log on the two files where exceptions are raised","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22e7c072749595728b24fcd34c237f5aa3a55f8d","unresolved":false,"context_lines":[{"line_number":505,"context_line":"    msg_fmt \u003d _(\"Insufficient compute resources: %(reason)s.\")"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"class HypervisorUnavailable(NovaException):"},{"line_number":509,"context_line":"    msg_fmt \u003d _(\"Connection to the hypervisor is broken on host\")"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_eb4327ae","line":508,"range":{"start_line":508,"start_character":0,"end_line":508,"end_character":43},"in_reply_to":"9f560f44_eb720749","updated":"2020-07-30 12:07:05.000000000","message":"oh right i totally forgot about removeing passing host","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"206fd98c31a7c508321efd3af0951750b9e6af31","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"class ComputeServiceInUse(NovaException):"},{"line_number":517,"context_line":"    msg_fmt \u003d _(\"Compute service of %(host)s is still in use.\")"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"class UnableToMigrateToSelf(Invalid):"},{"line_number":521,"context_line":"    msg_fmt \u003d _(\"Unable to migrate instance (%(instance_id)s) \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0bdbfb1a","line":518,"updated":"2020-07-30 12:01:34.000000000","message":"We probably have more issues like this. The above two exceptions also print the hostname. These are raised during live migration and evacuation, respectively, both of which are admin only ops, but I doubt these are the only ones.","commit_id":"4b3053a332de9848b6cfc5458230ca679b0eb87c"}]}