)]}'
{"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c63221d4e11a1476ae4e683be71f9fd92ec2388","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        }"},{"line_number":374,"context_line":"        flavor_id \u003d self._create_flavor(vcpu\u003d2, extra_spec\u003dextra_spec)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # FIXME(stephenfin): This should go to error status since there should"},{"line_number":377,"context_line":"        # be a host available"},{"line_number":378,"context_line":"        expected_usage \u003d {"},{"line_number":379,"context_line":"            \u0027DISK_GB\u0027: 20, \u0027MEMORY_MB\u0027: 2048, \u0027PCPU\u0027: 0, \u0027VCPU\u0027: 2}"},{"line_number":380,"context_line":"        self._run_build_test(flavor_id, expected_usage\u003dexpected_usage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1fb96c2d","side":"PARENT","line":377,"range":{"start_line":376,"start_character":8,"end_line":377,"end_character":29},"updated":"2020-07-30 18:09:29.000000000","message":"waith there was an existing FIXME for this :(","commit_id":"4a8134923bea9a580fb7cc20c5e31bfa2cf6bab8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fd8a15ccf8ec43dec7ae19a3cc465733807b4f8","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        }"},{"line_number":374,"context_line":"        flavor_id \u003d self._create_flavor(vcpu\u003d2, extra_spec\u003dextra_spec)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # FIXME(stephenfin): This should go to error status since there should"},{"line_number":377,"context_line":"        # be a host available"},{"line_number":378,"context_line":"        expected_usage \u003d {"},{"line_number":379,"context_line":"            \u0027DISK_GB\u0027: 20, \u0027MEMORY_MB\u0027: 2048, \u0027PCPU\u0027: 0, \u0027VCPU\u0027: 2}"},{"line_number":380,"context_line":"        self._run_build_test(flavor_id, expected_usage\u003dexpected_usage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_04664052","side":"PARENT","line":377,"range":{"start_line":376,"start_character":8,"end_line":377,"end_character":29},"in_reply_to":"9f560f44_1fb96c2d","updated":"2020-07-30 21:59:57.000000000","message":"oh this is from the repoducer :)","commit_id":"4a8134923bea9a580fb7cc20c5e31bfa2cf6bab8"}],"nova/virt/hardware.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2028220418ccc0bca839136f4c8714afc3f9f028","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # TODO(stephenfin): Drop this when we drop support for \u0027vcpu_pin_set\u0027"},{"line_number":922,"context_line":"        # NOTE(stephenfin): This is total hack. We\u0027re relying on the fact that"},{"line_number":923,"context_line":"        # the libvirt driver, which is the only one that currently supports"},{"line_number":924,"context_line":"        # pinned CPUs, will set cpuset and pcpuset to the same value if using"},{"line_number":925,"context_line":"        # legacy configuration, i.e. \u0027vcpu_pin_set\u0027, as part of"},{"line_number":926,"context_line":"        # \u0027_get_host_numa_topology\u0027. If these are equal, the host that this"},{"line_number":927,"context_line":"        # cell corresponds to is using legacy configuration and it\u0027s okay to"},{"line_number":928,"context_line":"        # to use the old, \"pin a core and reserve its siblings\" implementation"},{"line_number":929,"context_line":"        # of the \u0027isolate\u0027 policy. If they\u0027re not, the host is using new-style"},{"line_number":930,"context_line":"        # configuration and we\u0027ve just hit bug #1889633"},{"line_number":931,"context_line":"        if threads_per_core !\u003d 1 and host_cell.pcpuset !\u003d host_cell.cpuset:"},{"line_number":932,"context_line":"            LOG.warning("},{"line_number":933,"context_line":"                \"Host supports hyperthreads, but instance requested no \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_df125458","line":930,"range":{"start_line":922,"start_character":8,"end_line":930,"end_character":55},"updated":"2020-07-30 18:08:29.000000000","message":"we are also relyign on the fact that we currently enforce that the cpu_shared_set and cpu_dedicated_set must be disjoint\nso the only way the can be equal is if vcpu_pin_set was used.\n\nif you use cpu_shared_set and vcpu_pin_set before we also enforce that requirement so cpu_shared_set must be disjoint when compaured to cpu_dediccated_set or vcpu_pin_set.\n\nso if they are not disjoint and are equal then yes the old config value had to be used.\n\nwhat i would proably do is convert this into a property on the host_cell object\n\nso add \n\n@property\ndef uses_legacy_pin_set(self):\nreturn self.pcpuset \u003d\u003d self.cpuset\n\nthen change the if to \n\nif threads_per_core !\u003d 1 and not host_cell.uses_legacy_pin_set:\n  LOG.warning()\n  return None\n\nthat is cleaner in my view and adding properties to an ovo does not change it comptablity on the wire so that is just as backportable.","commit_id":"f298ef80f58bf6e3444a147c03a3e83308ce12a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e1f4b91be946f89f64fa11969bb226a5ad0672c","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # TODO(stephenfin): Drop this when we drop support for \u0027vcpu_pin_set\u0027"},{"line_number":922,"context_line":"        # NOTE(stephenfin): This is total hack. We\u0027re relying on the fact that"},{"line_number":923,"context_line":"        # the libvirt driver, which is the only one that currently supports"},{"line_number":924,"context_line":"        # pinned CPUs, will set cpuset and pcpuset to the same value if using"},{"line_number":925,"context_line":"        # legacy configuration, i.e. \u0027vcpu_pin_set\u0027, as part of"},{"line_number":926,"context_line":"        # \u0027_get_host_numa_topology\u0027. If these are equal, the host that this"},{"line_number":927,"context_line":"        # cell corresponds to is using legacy configuration and it\u0027s okay to"},{"line_number":928,"context_line":"        # to use the old, \"pin a core and reserve its siblings\" implementation"},{"line_number":929,"context_line":"        # of the \u0027isolate\u0027 policy. If they\u0027re not, the host is using new-style"},{"line_number":930,"context_line":"        # configuration and we\u0027ve just hit bug #1889633"},{"line_number":931,"context_line":"        if threads_per_core !\u003d 1 and host_cell.pcpuset !\u003d host_cell.cpuset:"},{"line_number":932,"context_line":"            LOG.warning("},{"line_number":933,"context_line":"                \"Host supports hyperthreads, but instance requested no \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e4ad0c89","line":930,"range":{"start_line":922,"start_character":8,"end_line":930,"end_character":55},"in_reply_to":"9f560f44_615d6e79","updated":"2020-07-30 21:49:29.000000000","message":"well we need to backport it to train and keep it until W\nso given we will be maintianing 16.1 downstream for 5 years i would prefer if it was not ugly.\n\nits a nit since ya i think the code as written is valid.\nbut it would be nice to clean up i think.","commit_id":"f298ef80f58bf6e3444a147c03a3e83308ce12a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c52730b15d308bbe5e482022b2292ce38d150af","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # TODO(stephenfin): Drop this when we drop support for \u0027vcpu_pin_set\u0027"},{"line_number":922,"context_line":"        # NOTE(stephenfin): This is total hack. We\u0027re relying on the fact that"},{"line_number":923,"context_line":"        # the libvirt driver, which is the only one that currently supports"},{"line_number":924,"context_line":"        # pinned CPUs, will set cpuset and pcpuset to the same value if using"},{"line_number":925,"context_line":"        # legacy configuration, i.e. \u0027vcpu_pin_set\u0027, as part of"},{"line_number":926,"context_line":"        # \u0027_get_host_numa_topology\u0027. If these are equal, the host that this"},{"line_number":927,"context_line":"        # cell corresponds to is using legacy configuration and it\u0027s okay to"},{"line_number":928,"context_line":"        # to use the old, \"pin a core and reserve its siblings\" implementation"},{"line_number":929,"context_line":"        # of the \u0027isolate\u0027 policy. If they\u0027re not, the host is using new-style"},{"line_number":930,"context_line":"        # configuration and we\u0027ve just hit bug #1889633"},{"line_number":931,"context_line":"        if threads_per_core !\u003d 1 and host_cell.pcpuset !\u003d host_cell.cpuset:"},{"line_number":932,"context_line":"            LOG.warning("},{"line_number":933,"context_line":"                \"Host supports hyperthreads, but instance requested no \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_89609c03","line":930,"range":{"start_line":922,"start_character":8,"end_line":930,"end_character":55},"in_reply_to":"9f560f44_df125458","updated":"2020-07-31 12:07:08.000000000","message":"\u003e we are also relyign on the fact that we currently enforce that the\n \u003e cpu_shared_set and cpu_dedicated_set must be disjoint\n \u003e so the only way the can be equal is if vcpu_pin_set was used.\n \u003e \n \u003e if you use cpu_shared_set and vcpu_pin_set before we also enforce\n \u003e that requirement so cpu_shared_set must be disjoint when compaured\n \u003e to cpu_dediccated_set or vcpu_pin_set.\n\nNot sure it\u0027s entirely relevant but done.","commit_id":"f298ef80f58bf6e3444a147c03a3e83308ce12a3"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e610bc69228703a8f3b28305d9fc47b32c309218","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # TODO(stephenfin): Drop this when we drop support for \u0027vcpu_pin_set\u0027"},{"line_number":922,"context_line":"        # NOTE(stephenfin): This is total hack. We\u0027re relying on the fact that"},{"line_number":923,"context_line":"        # the libvirt driver, which is the only one that currently supports"},{"line_number":924,"context_line":"        # pinned CPUs, will set cpuset and pcpuset to the same value if using"},{"line_number":925,"context_line":"        # legacy configuration, i.e. \u0027vcpu_pin_set\u0027, as part of"},{"line_number":926,"context_line":"        # \u0027_get_host_numa_topology\u0027. If these are equal, the host that this"},{"line_number":927,"context_line":"        # cell corresponds to is using legacy configuration and it\u0027s okay to"},{"line_number":928,"context_line":"        # to use the old, \"pin a core and reserve its siblings\" implementation"},{"line_number":929,"context_line":"        # of the \u0027isolate\u0027 policy. If they\u0027re not, the host is using new-style"},{"line_number":930,"context_line":"        # configuration and we\u0027ve just hit bug #1889633"},{"line_number":931,"context_line":"        if threads_per_core !\u003d 1 and host_cell.pcpuset !\u003d host_cell.cpuset:"},{"line_number":932,"context_line":"            LOG.warning("},{"line_number":933,"context_line":"                \"Host supports hyperthreads, but instance requested no \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_615d6e79","line":930,"range":{"start_line":922,"start_character":8,"end_line":930,"end_character":55},"in_reply_to":"9f560f44_df125458","updated":"2020-07-30 20:59:19.000000000","message":"I agree with that on principle, but given that this check will get removed, and is indeed a total hack, perhaps keeping it fugly is actually more honest, in this case.","commit_id":"f298ef80f58bf6e3444a147c03a3e83308ce12a3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c52730b15d308bbe5e482022b2292ce38d150af","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # TODO(stephenfin): Drop this when we drop support for \u0027vcpu_pin_set\u0027"},{"line_number":922,"context_line":"        # NOTE(stephenfin): This is total hack. We\u0027re relying on the fact that"},{"line_number":923,"context_line":"        # the libvirt driver, which is the only one that currently supports"},{"line_number":924,"context_line":"        # pinned CPUs, will set cpuset and pcpuset to the same value if using"},{"line_number":925,"context_line":"        # legacy configuration, i.e. \u0027vcpu_pin_set\u0027, as part of"},{"line_number":926,"context_line":"        # \u0027_get_host_numa_topology\u0027. If these are equal, the host that this"},{"line_number":927,"context_line":"        # cell corresponds to is using legacy configuration and it\u0027s okay to"},{"line_number":928,"context_line":"        # to use the old, \"pin a core and reserve its siblings\" implementation"},{"line_number":929,"context_line":"        # of the \u0027isolate\u0027 policy. If they\u0027re not, the host is using new-style"},{"line_number":930,"context_line":"        # configuration and we\u0027ve just hit bug #1889633"},{"line_number":931,"context_line":"        if threads_per_core !\u003d 1 and host_cell.pcpuset !\u003d host_cell.cpuset:"},{"line_number":932,"context_line":"            LOG.warning("},{"line_number":933,"context_line":"                \"Host supports hyperthreads, but instance requested no \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e9667829","line":930,"range":{"start_line":922,"start_character":8,"end_line":930,"end_character":55},"in_reply_to":"9f560f44_e4ad0c89","updated":"2020-07-31 12:07:08.000000000","message":"\u003e well we need to backport it to train and keep it until W\n \u003e so given we will be maintianing 16.1 downstream for 5 years i would\n \u003e prefer if it was not ugly.\n\nThere\u0027s no reason to maintain this until W. I\u0027m hoping to remove all of this fallback code this cycle. Had simply been holding off until all the mixed CPU policy work was complete, which it finally is now.\n\n \u003e its a nit since ya i think the code as written is valid.\n \u003e but it would be nice to clean up i think.\n\nI\u0027d prefer keep this inline given it\u0027s hacky nature. It will be blasted one we drop support for \u0027vcpu_pin_set\u0027 (again, this cycle I hope)","commit_id":"f298ef80f58bf6e3444a147c03a3e83308ce12a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f40c60f73e161f165eb0814aa4c50c02bd7be7d1","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            return"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        # TODO(stephenfin): Drop this when we drop support for \u0027vcpu_pin_set\u0027"},{"line_number":922,"context_line":"        # NOTE(stephenfin): This is total hack. We\u0027re relying on the fact that"},{"line_number":923,"context_line":"        # the libvirt driver, which is the only one that currently supports"},{"line_number":924,"context_line":"        # pinned CPUs, will set cpuset and pcpuset to the same value if using"},{"line_number":925,"context_line":"        # legacy configuration, i.e. \u0027vcpu_pin_set\u0027, as part of"},{"line_number":926,"context_line":"        # \u0027_get_host_numa_topology\u0027. If these are equal, the host that this"},{"line_number":927,"context_line":"        # cell corresponds to is using legacy configuration and it\u0027s okay to"},{"line_number":928,"context_line":"        # to use the old, \"pin a core and reserve its siblings\" implementation"},{"line_number":929,"context_line":"        # of the \u0027isolate\u0027 policy. If they\u0027re not, the host is using new-style"},{"line_number":930,"context_line":"        # configuration and we\u0027ve just hit bug #1889633"},{"line_number":931,"context_line":"        if threads_per_core !\u003d 1 and host_cell.pcpuset !\u003d host_cell.cpuset:"},{"line_number":932,"context_line":"            LOG.warning("},{"line_number":933,"context_line":"                \"Host supports hyperthreads, but instance requested no \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3015704b","line":930,"range":{"start_line":922,"start_character":8,"end_line":930,"end_character":55},"in_reply_to":"9f560f44_e9667829","updated":"2020-07-31 12:19:47.000000000","message":"ah i tought you were going to wait for W for that.\nif your removing the fallback this cycle then inline is fine.","commit_id":"f298ef80f58bf6e3444a147c03a3e83308ce12a3"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"82d25ffca933a76a265a8016acc91d3b216d5a94","unresolved":false,"context_lines":[{"line_number":936,"context_line":"                \"hyperthreads. This should have been rejected by the \""},{"line_number":937,"context_line":"                \"scheduler but we likely got here due to the fallback VCPU \""},{"line_number":938,"context_line":"                \"query. Consider setting \u0027[workarounds] \""},{"line_number":939,"context_line":"                \"disable_fallback_pcpu_query\u0027 to \u0027True\u0027 once hosts are no \""},{"line_number":940,"context_line":"                \"longer using \u0027vcpu_pin_set\u0027. Refer to bug #1889633 for more \""},{"line_number":941,"context_line":"                \"information.\""},{"line_number":942,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9890a345","line":939,"range":{"start_line":939,"start_character":17,"end_line":939,"end_character":44},"updated":"2020-08-05 12:36:12.000000000","message":"That has been deprecated for removal since 20.0.0, does this situation change that as I guess we need it around until vcpu_pin_set is dropped?","commit_id":"9c270332041d6b98951c0b57d7b344fd551a413c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cee482da166b88ce87b6a433b155234d92ccf490","unresolved":false,"context_lines":[{"line_number":936,"context_line":"                \"hyperthreads. This should have been rejected by the \""},{"line_number":937,"context_line":"                \"scheduler but we likely got here due to the fallback VCPU \""},{"line_number":938,"context_line":"                \"query. Consider setting \u0027[workarounds] \""},{"line_number":939,"context_line":"                \"disable_fallback_pcpu_query\u0027 to \u0027True\u0027 once hosts are no \""},{"line_number":940,"context_line":"                \"longer using \u0027vcpu_pin_set\u0027. Refer to bug #1889633 for more \""},{"line_number":941,"context_line":"                \"information.\""},{"line_number":942,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3beeb1b3","line":939,"range":{"start_line":939,"start_character":17,"end_line":939,"end_character":44},"in_reply_to":"9f560f44_7b34a993","updated":"2020-08-05 13:26:41.000000000","message":"this change will be backported to train too so the warning is more usful there as ideally in Victoria Stephen will manage to kill both options as he said.","commit_id":"9c270332041d6b98951c0b57d7b344fd551a413c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e5d31f191d6ef9a8eff8ecb63b822c05e131f4b","unresolved":false,"context_lines":[{"line_number":936,"context_line":"                \"hyperthreads. This should have been rejected by the \""},{"line_number":937,"context_line":"                \"scheduler but we likely got here due to the fallback VCPU \""},{"line_number":938,"context_line":"                \"query. Consider setting \u0027[workarounds] \""},{"line_number":939,"context_line":"                \"disable_fallback_pcpu_query\u0027 to \u0027True\u0027 once hosts are no \""},{"line_number":940,"context_line":"                \"longer using \u0027vcpu_pin_set\u0027. Refer to bug #1889633 for more \""},{"line_number":941,"context_line":"                \"information.\""},{"line_number":942,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7b34a993","line":939,"range":{"start_line":939,"start_character":17,"end_line":939,"end_character":44},"in_reply_to":"9f560f44_9890a345","updated":"2020-08-05 13:13:54.000000000","message":"\u0027vcpu_pin_set\u0027 is also deprecated. The two should be removed at the same time. I\u0027m aiming to do it this cycle, though we\u0027ll see how review bandwidth is","commit_id":"9c270332041d6b98951c0b57d7b344fd551a413c"}]}