)]}'
{"id":"openstack%2Fnova~744160","triplet_id":"openstack%2Fnova~stable%2Fussuri~If1a45886adfc6448a626a54449ff66f400879b83","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1889108","hashtags":[],"change_id":"If1a45886adfc6448a626a54449ff66f400879b83","subject":"func: Add live migration rollback volume attachment tests","status":"MERGED","created":"2020-07-31 13:10:23.000000000","updated":"2020-08-08 19:41:53.000000000","submitted":"2020-08-08 00:39:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"744160-1596847156895-5080a3ed","meta_rev_id":"f058517d1af1f56d4b91c2f44d85a80f07c247b9","_number":744160,"virtual_id_number":744160,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2020-07-31 15:36:17.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2020-07-31 14:11:13.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-08 00:39:16.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2020-08-07 23:11:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2020-08-07 15:40:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2020-08-07 23:11:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-31 14:11:13.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-07-31 15:36:17.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-08-07 15:40:19.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-08-07 23:11:31.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2020-08-08 00:39:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d9b8f5b90428dccda128e2ff49b2cbe15d289a10","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-07-31 13:10:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"df4c66234c8035f2bebf63d11f0ee940ccabe9f6","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-07-31 14:11:13.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/60/744160/1/check/pmem-tempest-plugin-filtered-multi-node/1734413/ : SUCCESS in 48m 53s","accounts_in_message":[],"_revision_number":1},{"id":"b12a949ad9f9c68b8dccc387ee8fffb6e447a0f1","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-07-31 15:36:17.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744160/1 : FAILURE in 2h 21m 57s","accounts_in_message":[],"_revision_number":1},{"id":"a0700464fbc6c04c1fbe1ac29f555eaf9a85e0f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-31 17:45:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0d4fb4ae61e34938b569f91734d7fa2d : SUCCESS in 17m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c68a8883742b47eab2d605702dd69d05 : SUCCESS in 22m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf6ff2dacfa2420fb5639e21b2fe0382 : SUCCESS in 8m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/02b4187d032e4f418b8848026cca3ec0 : SUCCESS in 13m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1e91f8ea82ad41eabf0e4b8ad14d1f9e : SUCCESS in 12m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8c8d59f796c34404bb42ed43454d6833 : SUCCESS in 11m 58s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/ee58ca263ee34ef79dd3e6dbcf3bf6f9 : SUCCESS in 20m 13s","accounts_in_message":[],"_revision_number":1},{"id":"3f322d9a90c28c7b54b7e0b4f2d8cf657bde3508","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-08-07 15:40:19.000000000","message":"Patch Set 1: Code-Review+2\n\nThis is not directly connected to bug/1889108, at least it\u0027s not really needed to make the bugfix backport clean, if I\u0027m not mistaken. But I guess it makes the testing complete, maybe it\u0027s not a big issue to backport this patch together with the bugfix.\n\nAnyway, this is a clean cherry pick from master, where the patch has merged. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"8e0f634aa755d54ad942a362e0767bc3e7f0b03d","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-07 23:11:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport, useful test coverage for stable, LGTM","accounts_in_message":[],"_revision_number":1},{"id":"49a0f422d37f067abb6e6a310717542938cabfe1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-08 00:16:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cdc18ecd5d5be1d5b4c35aa7cd713a5d569dbe0c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-08 00:39:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"dea1b66585ce42aa092eb19188f6674892c6934c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-08 00:39:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/34a7b08584ce48d485c68a24fe650d0d : SUCCESS in 14m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f8be5b64bb8043f0bf2526c297fe8429 : SUCCESS in 8m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3e88c621cdda4becae33201284132bfd : SUCCESS in 18m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bc44a304682a4a74b18f05c267532733 : SUCCESS in 19m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3d512e981d51406ca4bdf836857d7af0 : SUCCESS in 14m 36s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/4753e9d353674bb6921acc330dd84c45 : SUCCESS in 20m 58s","accounts_in_message":[],"_revision_number":1},{"id":"95dda4adb50f2f200e5a5c5dcea76fb21216ed69","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-08 19:41:53.000000000","message":"Patch Set 1:\n\n\u003e This is not directly connected to bug/1889108, at least it\u0027s not\n \u003e really needed to make the bugfix backport clean, if I\u0027m not\n \u003e mistaken. But I guess it makes the testing complete, maybe it\u0027s not\n \u003e a big issue to backport this patch together with the bugfix.\n \u003e \n \u003e Anyway, this is a clean cherry pick from master, where the patch\n \u003e has merged. LGTM.\n\nApologies I forgot to reply to this, this is required as it asserts the failure behaviour of the main live_migration compute method. We wanted to ensure this didn\u0027t change with the fix in I9edb36c4df1cc0d8b529e669f06540de71766085 to the pre_live_migration rollback logic that is also used here.\n\nHappy to provide this context as a NOTE in the next set of backports to stable/train if it would help reviewers.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6070c55793d184bb3484b6af8ccadded0a907cbb","revisions":{"6070c55793d184bb3484b6af8ccadded0a907cbb":{"kind":"REWORK","_number":1,"created":"2020-07-31 13:10:23.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/60/744160/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/60/744160/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/60/744160/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/60/744160/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/60/744160/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/60/744160/1"}}},"commit":{"parents":[{"commit":"726ca4aec5ccea96748de88b2c2a2fd1a078cfc5","subject":"func: Add _live_migrate helper to InstanceHelperMixin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/726ca4aec5ccea96748de88b2c2a2fd1a078cfc5"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-28 12:57:21.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-31 13:08:55.000000000","tz":60},"subject":"func: Add live migration rollback volume attachment tests","message":"func: Add live migration rollback volume attachment tests\n\nThis test asserts that the original source host volume attachments\nremain intact after a failure and rollback during the main live\nmigration flow on the virt driver.\n\nChange-Id: If1a45886adfc6448a626a54449ff66f400879b83\n(cherry picked from commit e6c2a863286bae6a8a8caff0d6a54c001e0a2ffb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6070c55793d184bb3484b6af8ccadded0a907cbb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6070c55793d184bb3484b6af8ccadded0a907cbb"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}