)]}'
{"nova/virt/libvirt/config.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d2eddc10c5544661b55168f2c1f48401b820a4a2","unresolved":false,"context_lines":[{"line_number":1663,"context_line":"        if isinstance(other, LibvirtConfigGuestInterface):"},{"line_number":1664,"context_line":"            # NOTE(arches) Skip checking target_dev for vhostuser"},{"line_number":1665,"context_line":"            # vif type; target_dev is not a valid value for vhostuser."},{"line_number":1666,"context_line":"            return (self.mac_addr \u003d\u003d other.mac_addr and"},{"line_number":1667,"context_line":"                    self.net_type \u003d\u003d other.net_type and"},{"line_number":1668,"context_line":"                    self.source_dev \u003d\u003d other.source_dev and"},{"line_number":1669,"context_line":"                    (self.net_type \u003d\u003d \u0027vhostuser\u0027 or"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_46076083","line":1666,"updated":"2020-08-04 16:22:25.000000000","message":"nit: any chance you could drop things down a line to remove the hanging indent?\n\n  return (\n      self.mac_addr \u003d\u003d other.mac_addr and\n      ...\n      self.vhostuser_path \u003d\u003d other.vhostuser_path)","commit_id":"872b36574080c887a5277bc359f015b83c86df2e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"522899a5ce7230782ece46db53b3e788fded204d","unresolved":false,"context_lines":[{"line_number":1663,"context_line":"        if isinstance(other, LibvirtConfigGuestInterface):"},{"line_number":1664,"context_line":"            # NOTE(arches) Skip checking target_dev for vhostuser"},{"line_number":1665,"context_line":"            # vif type; target_dev is not a valid value for vhostuser."},{"line_number":1666,"context_line":"            return (self.mac_addr \u003d\u003d other.mac_addr and"},{"line_number":1667,"context_line":"                    self.net_type \u003d\u003d other.net_type and"},{"line_number":1668,"context_line":"                    self.source_dev \u003d\u003d other.source_dev and"},{"line_number":1669,"context_line":"                    (self.net_type \u003d\u003d \u0027vhostuser\u0027 or"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e68cb4d8","line":1666,"in_reply_to":"9f560f44_46076083","updated":"2020-08-04 16:31:09.000000000","message":"or flip this\n\nif not isinstance(other, LibvirtConfigGuestInterface):\n  return false\nreturn (...)","commit_id":"872b36574080c887a5277bc359f015b83c86df2e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7cef4f08cc1637ff0d57db91a89645f3861b0358","unresolved":false,"context_lines":[{"line_number":1663,"context_line":"        if isinstance(other, LibvirtConfigGuestInterface):"},{"line_number":1664,"context_line":"            # NOTE(arches) Skip checking target_dev for vhostuser"},{"line_number":1665,"context_line":"            # vif type; target_dev is not a valid value for vhostuser."},{"line_number":1666,"context_line":"            return (self.mac_addr \u003d\u003d other.mac_addr and"},{"line_number":1667,"context_line":"                    self.net_type \u003d\u003d other.net_type and"},{"line_number":1668,"context_line":"                    self.source_dev \u003d\u003d other.source_dev and"},{"line_number":1669,"context_line":"                    (self.net_type \u003d\u003d \u0027vhostuser\u0027 or"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8a004503","line":1666,"in_reply_to":"9f560f44_e68cb4d8","updated":"2020-08-05 16:39:04.000000000","message":"Done both, and recovered two levels of indent! :)","commit_id":"872b36574080c887a5277bc359f015b83c86df2e"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5215f2983263557b024944e38a64e9c0ab2aa75c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                # NOTE(leehom) LibvirtConfigGuestInterface get from domain and"},{"line_number":229,"context_line":"                # LibvirtConfigGuestInterface generated by"},{"line_number":230,"context_line":"                # nova.virt.libvirt.vif.get_config must be identical."},{"line_number":231,"context_line":"                # NOTE(gibi): LibvirtConfigGuestInterface does a custom"},{"line_number":232,"context_line":"                # equality check based on available information on nova side"},{"line_number":233,"context_line":"                if cfg \u003d\u003d interface:"},{"line_number":234,"context_line":"                    return interface"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get_vcpus_info(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_57537117","line":233,"range":{"start_line":231,"start_character":16,"end_line":233,"end_character":36},"updated":"2020-08-05 20:22:41.000000000","message":"this is slightly magic but you left a comment so im good with this.","commit_id":"e6d71fe7ea1e499106bf86d67e4ffa75dfb22b94"}]}