)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-06 12:50:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove deprecated schduler filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The retry filter was deprecated in train."},{"line_number":10,"context_line":"The Aggregate[core|ram|disk] filters were also deprecated in train."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_643eb8b8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2020-08-06 13:22:04.000000000","message":"R","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-06 12:50:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove deprecated schduler filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The retry filter was deprecated in train."},{"line_number":10,"context_line":"The Aggregate[core|ram|disk] filters were also deprecated in train."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_0479bc92","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"updated":"2020-08-06 13:22:04.000000000","message":"scheduler","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove deprecated schduler filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The retry filter was deprecated in train."},{"line_number":10,"context_line":"The Aggregate[core|ram|disk] filters were also deprecated in train."},{"line_number":11,"context_line":"This change removes all four deprecated filters and there docs."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_e47be888","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":16},"updated":"2020-08-06 13:22:04.000000000","message":"RetryFilter","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove deprecated schduler filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The retry filter was deprecated in train."},{"line_number":10,"context_line":"The Aggregate[core|ram|disk] filters were also deprecated in train."},{"line_number":11,"context_line":"This change removes all four deprecated filters and there docs."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_446f34c4","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":40},"updated":"2020-08-06 13:22:04.000000000","message":"Train (capitalisation is a thing, you know :P)","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The retry filter was deprecated in train."},{"line_number":10,"context_line":"The Aggregate[core|ram|disk] filters were also deprecated in train."},{"line_number":11,"context_line":"This change removes all four deprecated filters and there docs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idc29c759632850d3d767a261c9f385af71348f65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_846cacce","line":11,"range":{"start_line":11,"start_character":52,"end_line":11,"end_character":57},"updated":"2020-08-06 13:22:04.000000000","message":"their","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"}],"nova/scheduler/filters/core_filter.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3103acd6422856b89413f53d26ea9a4da80d2aa8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # Only provide a VCPU limit to compute if the virt driver is reporting"},{"line_number":74,"context_line":"        # an accurate count of installed VCPUs. (XenServer driver does not)"},{"line_number":75,"context_line":"        if vcpus_total \u003e 0:"},{"line_number":76,"context_line":"            host_state.limits[\u0027vcpu\u0027] \u003d vcpus_total"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            # Do not allow an instance to overcommit against itself, only"},{"line_number":79,"context_line":"            # against other instances."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2e6dedcb","side":"PARENT","line":76,"range":{"start_line":76,"start_character":23,"end_line":76,"end_character":37},"updated":"2020-08-21 09:56:25.000000000","message":"there also some cleanup can do https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L1052","commit_id":"8ecc29bfccc64e6036d068f9bcbeb0d8e0748776"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5789e42260869f1fc15e769d32e65c3caeea5b3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # Only provide a VCPU limit to compute if the virt driver is reporting"},{"line_number":74,"context_line":"        # an accurate count of installed VCPUs. (XenServer driver does not)"},{"line_number":75,"context_line":"        if vcpus_total \u003e 0:"},{"line_number":76,"context_line":"            host_state.limits[\u0027vcpu\u0027] \u003d vcpus_total"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            # Do not allow an instance to overcommit against itself, only"},{"line_number":79,"context_line":"            # against other instances."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ae51fddb","side":"PARENT","line":76,"range":{"start_line":76,"start_character":23,"end_line":76,"end_character":37},"in_reply_to":"9f560f44_2e6dedcb","updated":"2020-08-21 10:07:29.000000000","message":"i think this is used by weighers and it could be used by the json filter so not sure i actully can remove anything form host state. the SchedulerLimits i might be able to remove but i dont really know if they are used any where else. i can take a look","commit_id":"8ecc29bfccc64e6036d068f9bcbeb0d8e0748776"}],"nova/scheduler/filters/ram_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a927a3f9d8a10aa9826dc1c79d3548461ab5539","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                       \u0027usable_ram\u0027: usable_ram})"},{"line_number":85,"context_line":"            return False"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # save oversubscription limit for compute node to test against:"},{"line_number":88,"context_line":"        host_state.limits[\u0027memory_mb\u0027] \u003d memory_mb_limit"},{"line_number":89,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_4e0b0129","side":"PARENT","line":88,"range":{"start_line":87,"start_character":7,"end_line":88,"end_character":56},"updated":"2020-08-21 11:10:37.000000000","message":"so the ram filter also updates teh limis in the host state object but the disk filter does not\nso i feel like the SchedulerLimits probably do not work right today especially since these filteres are already not typeicaly used anymore","commit_id":"8ecc29bfccc64e6036d068f9bcbeb0d8e0748776"}],"releasenotes/notes/remove-retry-and-aggregate[core|ram|disk]-filters-f872a85d0b815982.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following deprecated scheduler filters have been removed."},{"line_number":5,"context_line":"    RetryFilter - deprecated in train (20.0.0), the RetryFilter has"},{"line_number":6,"context_line":"    not been requied since Queens following the completion of the"},{"line_number":7,"context_line":"    return-alternate-hosts blueprint"},{"line_number":8,"context_line":"    Aggregate[core|ram|disk] filters - these filters have not worked"},{"line_number":9,"context_line":"    correctly since the introduction of placement in ocata, these"},{"line_number":10,"context_line":"    Aggregate[core|ram|disk] were deprecated in train (20.0.0)."},{"line_number":11,"context_line":"    On upgrade operators should ensure they have not configured"},{"line_number":12,"context_line":"    any of the new removed filters and instead should use placement"},{"line_number":13,"context_line":"    to control cpu, ram and disk allocation ratios. see:"},{"line_number":14,"context_line":"    https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_e452c812","line":12,"range":{"start_line":5,"start_character":4,"end_line":12,"end_character":67},"updated":"2020-08-06 13:22:04.000000000","message":"Can we format this a little better? Something like a definition list?\n\n  The following deprecated scheduler filters have been removed.\n\n  RetryFilter\n    Deprecated since Train (20.0.0). The RetryFilter has ...\n\n  AggregateCoreFilter, AggregateRAMFilter, AggregateDiskFilter\n    Deprecated since Train (20.0.0). These filters has no worked\n    correctly since ...","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"452f118958355bcb352191a2fa2f378a8ca6e2a9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following deprecated scheduler filters have been removed."},{"line_number":5,"context_line":"    RetryFilter - deprecated in train (20.0.0), the RetryFilter has"},{"line_number":6,"context_line":"    not been requied since Queens following the completion of the"},{"line_number":7,"context_line":"    return-alternate-hosts blueprint"},{"line_number":8,"context_line":"    Aggregate[core|ram|disk] filters - these filters have not worked"},{"line_number":9,"context_line":"    correctly since the introduction of placement in ocata, these"},{"line_number":10,"context_line":"    Aggregate[core|ram|disk] were deprecated in train (20.0.0)."},{"line_number":11,"context_line":"    On upgrade operators should ensure they have not configured"},{"line_number":12,"context_line":"    any of the new removed filters and instead should use placement"},{"line_number":13,"context_line":"    to control cpu, ram and disk allocation ratios. see:"},{"line_number":14,"context_line":"    https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_24868014","line":12,"range":{"start_line":5,"start_character":4,"end_line":12,"end_character":67},"in_reply_to":"9f560f44_e452c812","updated":"2020-08-06 13:36:18.000000000","message":"yes i kind of forgot if we were allowed to have spaces in this or not. i wanted to split this however so ya ill do as you suggest.","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e87007443a63151ddbfe94650e3daf7f37fc0c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Aggregate[core|ram|disk] were deprecated in train (20.0.0)."},{"line_number":11,"context_line":"    On upgrade operators should ensure they have not configured"},{"line_number":12,"context_line":"    any of the new removed filters and instead should use placement"},{"line_number":13,"context_line":"    to control cpu, ram and disk allocation ratios. see:"},{"line_number":14,"context_line":"    https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_84430c42","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":96},"updated":"2020-08-06 13:22:04.000000000","message":"Or\n\n  Refer to the `config reference documentation`__ for more information.\n\n  .. __: https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"452f118958355bcb352191a2fa2f378a8ca6e2a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Aggregate[core|ram|disk] were deprecated in train (20.0.0)."},{"line_number":11,"context_line":"    On upgrade operators should ensure they have not configured"},{"line_number":12,"context_line":"    any of the new removed filters and instead should use placement"},{"line_number":13,"context_line":"    to control cpu, ram and disk allocation ratios. see:"},{"line_number":14,"context_line":"    https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_c476a43e","line":14,"range":{"start_line":13,"start_character":52,"end_line":14,"end_character":96},"in_reply_to":"9f560f44_84430c42","updated":"2020-08-06 13:36:18.000000000","message":"ya i can do that","commit_id":"4ae48e910381247ea03a0daa7518e1e4e4cfab02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d8217bb5b1a8d317a04a1cc45e173adb7503d879","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    On upgrade operators should ensure they have not configured"},{"line_number":16,"context_line":"    any of the new removed filters and instead should use placement"},{"line_number":17,"context_line":"    to control cpu, ram and disk allocation ratios."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Refer to the `config reference documentation`__ for more information."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_79e928e1","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":18},"updated":"2020-08-26 10:21:33.000000000","message":"CPU","commit_id":"4939d0d1e27f8acf76985c978919da0fd5ad0a0f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d8217bb5b1a8d317a04a1cc45e173adb7503d879","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    On upgrade operators should ensure they have not configured"},{"line_number":16,"context_line":"    any of the new removed filters and instead should use placement"},{"line_number":17,"context_line":"    to control cpu, ram and disk allocation ratios."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Refer to the `config reference documentation`__ for more information."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_b9c0e051","line":17,"range":{"start_line":17,"start_character":20,"end_line":17,"end_character":23},"updated":"2020-08-26 10:21:33.000000000","message":"RAM","commit_id":"4939d0d1e27f8acf76985c978919da0fd5ad0a0f"}]}