)]}'
{"id":"openstack%2Fnova~744958","triplet_id":"openstack%2Fnova~master~I4760b01b695c94fa371b72216d398388cf981d28","project":"openstack/nova","branch":"master","topic":"bug/1879878","hashtags":[],"change_id":"I4760b01b695c94fa371b72216d398388cf981d28","subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","status":"MERGED","created":"2020-08-05 17:51:08.000000000","updated":"2020-09-02 21:50:14.000000000","submitted":"2020-09-02 21:43:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":67,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"744958-1599083016691-941d6ed0","meta_rev_id":"798c26f872cce6db47f69f82b880c43cc4adea4a","_number":744958,"virtual_id_number":744958,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"date":"2020-09-01 16:31:23.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-09-01 23:04:22.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2020-09-01 15:55:14.000000000","_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-02 21:43:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-09-01 20:15:07.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-09-02 00:02:51.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2020-09-01 18:43:06.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"recommended":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2020-09-01 15:20:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":2,"date":"2020-09-02 15:27:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2020-09-02 11:49:13.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":1,"date":"2020-09-02 15:27:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-11 15:23:32.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2020-08-11 18:55:20.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2020-08-12 02:03:49.000000000","updated_by":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"reviewer":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"state":"REVIEWER"},{"updated":"2020-08-19 17:58:26.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2020-08-20 08:30:50.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2020-08-25 17:21:37.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-08-25 19:17:44.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-27 18:30:23.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2020-09-01 15:55:14.000000000","updated_by":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-01 16:31:23.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-01 18:43:06.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-09-01 20:15:07.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-01 23:04:22.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-02 00:02:51.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-02 11:49:13.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-09-02 15:27:18.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2020-09-02 21:43:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ee91ee84e3500b91b2637cbe742517c4d31c8b4e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-05 17:51:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3aa79190752229a03e17d5e7524b58fec96896b5","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-05 17:53:54.000000000","message":"Patch Set 1:\n\nfwiw, this is effectively the same patch as https://review.opendev.org/#/c/741995/, which I need for vTPM stuff. That\u0027s why all the type hints are there","accounts_in_message":[],"_revision_number":1},{"id":"debbfbbfca0dfd7b2de42f6f347df9298acb72f4","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-05 17:54:21.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/1 : FAILURE in 1m 28s","accounts_in_message":[],"_revision_number":1},{"id":"f96af3ad6c2857b8c0553f0e70f1c207936af449","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-05 18:33:23.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/744958/1/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/1c38223 : FAILURE in 41m 26s","accounts_in_message":[],"_revision_number":1},{"id":"d4ee6007e7b7a653d1ffe0a6ddc321536c190748","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-05 18:36:41.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/1/check/pmem-tempest-plugin-filtered-multi-node/fbde75d/ : SUCCESS in 43m 22s","accounts_in_message":[],"_revision_number":1},{"id":"0ff3cc5ed224910236f7cb9bd14aee578dedb921","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-05 18:48:53.000000000","message":"Patch Set 1:\n\n* pci-test http://52.27.155.124/pci/744958/1 : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"a1fdac01b65f8b324b5a8c754c0b9229d64e5c7a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-05 20:50:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/6afe6ce242af46e69c2a66db23b9cfe1 : SUCCESS in 1h 04m 51s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/7858707cdbad45a899245a3c39a157c3 : SUCCESS in 1h 18m 07s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8bea708d015a403783ab70747c51e182 : SUCCESS in 19m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/94673600838f42bd993fca85f57c12f3 : SUCCESS in 21m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a421614550744b9194dd9741c423092f : SUCCESS in 8m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aeddf56299f74a8db0b8d5253ad72b60 : SUCCESS in 12m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9e123093303b427482f9456a38c7dafc : SUCCESS in 14m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9a7e87bc0cf246bca5d4d5a01dfe8ade : SUCCESS in 13m 32s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/44eaa308d000432285c03abc2c40b215 : SUCCESS in 1h 34m 48s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/04d1397b96d94e259e1d7d3acd7c63e0 : SUCCESS in 1h 29m 54s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/d7f22d92d2cb497ab51a8a8d9bf58dc9 : SUCCESS in 1h 17m 05s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/a730daa2408b4bab8089fefa7396cf26 : SUCCESS in 53m 33s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/81943f8306804482bee0def97bef74cf : SUCCESS in 1h 34m 08s\n- nova-next https://zuul.opendev.org/t/openstack/build/bdfc15076be84e51837d1f9b2fcae72d : SUCCESS in 1h 30m 04s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/58749f91be1c49998305e99357beec24 : SUCCESS in 23m 00s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5bac61c7fcf44a889757457eddf42910 : SUCCESS in 56m 29s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/ca80ce73fd5b4870b1c31f46d665e6d6 : SUCCESS in 1h 09m 43s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/38cdf7fa08f9403e8e3923b1579d9a15 : SUCCESS in 44m 42s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/89ded063383a4fe296e44c7c47bda3fd : SUCCESS in 45m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2e7eddc7c9232c79a2d477cc56c6ad6be015a27b","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-08-05 20:50:46.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/58/744958/1/check/EMC_PowerFlex_NOVA/9dddf70/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":1},{"id":"f5726e60be007e8b6f87637fb1e795222824eed0","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-08-05 21:19:43.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-58-744958-1 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":1},{"id":"53ad3366b04a49756707cae058480a4ee609687b","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-08-05 22:17:17.000000000","message":"Patch Set 1:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-44183 : SUCCESS in 1h 27m 57s","accounts_in_message":[],"_revision_number":1},{"id":"fda90c37854d2a47b4c3676f005b7d1266700c81","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-05 23:45:43.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"179b78b5ba67b7f7212fc49bc01348638467d91f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-06 02:32:43.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic finger://zuul-v3-executor.novalocal/0a7d5f12070e4774b5444fcfeb0d88d3 : DISK_FULL in 45m 50s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/1/check/tempest-dsvm-full-bionic-py3/f1f5247/ : SUCCESS in 1h 37m 01s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/1/check/grenade-dsvm-bionic/aee06ce/ : SUCCESS in 2h 14m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"960165779cde5ef1a3df94d77e94e02a8726bd82","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-06 09:52:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"76da80bff88bd8473a0796793a80f5295d9916c1","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-06 09:53:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"225c55137d01bee0be47dfc31416462eb10b7900","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-06 10:25:33.000000000","message":"Patch Set 2:\n\n* pci-test http://52.27.155.124/pci/744958/2 : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"af55b0f5b2ff27f8f46edc239fa0655985437898","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-06 10:34:19.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/744958/2/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/3e66d55 : FAILURE in 41m 48s","accounts_in_message":[],"_revision_number":2},{"id":"578f1b9de569d66ed5db8cc097cc5319ea7d3805","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-06 10:40:01.000000000","message":"Patch Set 2:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/2/check/pmem-tempest-plugin-filtered-multi-node/77d25b7/ : SUCCESS in 46m 31s","accounts_in_message":[],"_revision_number":2},{"id":"c1cfbe6d597a449b9645d786e6079ac21392c9d1","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-08-06 10:58:29.000000000","message":"Patch Set 2:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-44196 : SUCCESS in 1h 05m 08s","accounts_in_message":[],"_revision_number":2},{"id":"9f9ac2f29e5c2d079d90a54802421d57b53a58af","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-06 12:25:16.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/744958/2 : SUCCESS in 2h 31m 54s","accounts_in_message":[],"_revision_number":2},{"id":"592b24c8592c29dbf0056fbf75da7dc131e40643","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-06 13:53:47.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/15e1fd0b9bd74b9181f5ace761d31d62 : SUCCESS in 1h 02m 01s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/a27f73c386d541c2966d5af9543be4b0 : SUCCESS in 1h 25m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/06482d8959d44b8e8ed96df4497e49bd : SUCCESS in 15m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/02fa8f5be64545fb8ac84326932a79ef : SUCCESS in 16m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/51b95a1c040c41609ca249c93518c1c7 : SUCCESS in 8m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b7d046cb4b0b425d81c1b191f844d243 : SUCCESS in 12m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b2d484b90f7d4eff92953a4702a5261a : SUCCESS in 15m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/287efd9c50d54856b3dfc5e6547dc503 : SUCCESS in 9m 27s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7b67c1abb126429db74002b69137a801 : SUCCESS in 1h 16m 51s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/f871daa74508474c9b9e8e5c724d0a22 : SUCCESS in 1h 09m 37s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/33e520bbb3694019b9ffbdf5b887e8ef : SUCCESS in 1h 18m 37s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/1c43b8327fe44820b5f7e21c5ae6e717 : FAILURE in 2h 59m 47s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/002cb25680994687b90b89d9ad76fbc4 : SUCCESS in 1h 25m 23s\n- nova-next https://zuul.opendev.org/t/openstack/build/d4b9c94dd55a40f39e88737b7e0e6282 : SUCCESS in 1h 32m 23s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2d07197268b9438497fb63ebd668d979 : SUCCESS in 19m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/805698418d8747b0baf5d5d8342777c3 : SUCCESS in 56m 27s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f78cd86a9da947298e83de7df6daf0d3 : SUCCESS in 53m 56s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/91e9187874294e97b45c4d54b7785c96 : SUCCESS in 30m 02s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/f9c01d0646ab47f9af70f1fab6070ff3 : SUCCESS in 38m 42s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0c2e1800ae02b176f49d39dbfbcceba4bb892f90","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-06 14:11:26.000000000","message":"Patch Set 2:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/2/check/tempest-dsvm-full-bionic/be4aace/ : SUCCESS in 1h 36m 50s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/2/check/tempest-dsvm-full-bionic-py3/4765157/ : SUCCESS in 1h 37m 03s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/2/check/grenade-dsvm-bionic/88f6dd8/ : SUCCESS in 2h 15m 02s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"414b13ce5f7d2dd67d4e70096fab4a9599e32393","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-06 16:08:10.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/2/check-vote/ext-nova-zuul/14bff34 : SUCCESS in 54m 09s","accounts_in_message":[],"_revision_number":2},{"id":"bc659cc744d358ffa09a4a51a84432dce155f5e0","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-06 18:29:33.000000000","message":"Patch Set 2: Code-Review-1\n\nI can\u0027t find any existing typing stuff in Train - which, knowing the Red Hat buzgilla that this is coming from, is how far we\u0027d want to backport this. I agree that it\u0027s useful, but I\u0027m not sure it belongs in a backportable bugfix.\n\nMore comments to come, this is just my initial reaction.","accounts_in_message":[],"_revision_number":2},{"id":"f13169c732d579c617a60a69a6d5d4437b94cb44","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-06 18:59:46.000000000","message":"Patch Set 2:\n\n(6 comments)\n\nThe functional test demonstrates that this works, but I have to admit not understanding how or why. See questions inline. Maybe a video call with all interested reviewers at some point, if I\u0027m not the only thicko who doesn\u0027t grok this...","accounts_in_message":[],"_revision_number":2},{"id":"81080ca61b94726690f49a73821c925d074d53bd","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-06 19:07:47.000000000","message":"Patch Set 2:\n\n\u003e I can\u0027t find any existing typing stuff in Train - which, knowing\n \u003e the Red Hat buzgilla that this is coming from, is how far we\u0027d want\n \u003e to backport this. I agree that it\u0027s useful, but I\u0027m not sure it\n \u003e belongs in a backportable bugfix.\n \u003e \n \u003e More comments to come, this is just my initial reaction.\n\nThis is a duplicate of https://review.opendev.org/#/c/741995/ which is why the type hints exist (I probably wouldn\u0027t have bothered were I starting from scratch). However, we\u0027ve discussed this before and agreed that we shouldn\u0027t _not_ use something just because it\u0027s not backportable. master is the most important branch and minor modifications to e.g. add Python 2.7 support are acceptable.\n\nHaven\u0027t looked at the other comments yet, mind, but I don\u0027t think this one is a blocker.","accounts_in_message":[],"_revision_number":2},{"id":"ebd9db4360bfa66856af82e3a62488cd385cea49","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-06 19:19:04.000000000","message":"Patch Set 2: -Code-Review\n\n\u003e \u003e I can\u0027t find any existing typing stuff in Train - which, knowing\n \u003e \u003e the Red Hat buzgilla that this is coming from, is how far we\u0027d\n \u003e want\n \u003e \u003e to backport this. I agree that it\u0027s useful, but I\u0027m not sure it\n \u003e \u003e belongs in a backportable bugfix.\n \u003e \u003e\n \u003e \u003e More comments to come, this is just my initial reaction.\n \u003e \n \u003e This is a duplicate of https://review.opendev.org/#/c/741995/ which\n \u003e is why the type hints exist (I probably wouldn\u0027t have bothered were\n \u003e I starting from scratch). However, we\u0027ve discussed this before and\n \u003e agreed that we shouldn\u0027t _not_ use something just because it\u0027s not\n \u003e backportable. master is the most important branch and minor\n \u003e modifications to e.g. add Python 2.7 support are acceptable.\n\nWe\u0027ve discussed this on IRC - just editing out the typing stuff when backporting to a release that can\u0027t support them it fine.\n\nI don\u0027t really like mixing typing with \"real\" fixes, but I can see how having them both in the same patch helps with understanding, so no objections from me on that front.","accounts_in_message":[],"_revision_number":2},{"id":"c23d46bf622b5dd85f2380b7af51f1b5267bd1cc","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-06 19:19:12.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ce5f9d5bd0029ab08afa996745fd504e2c2577db","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-06 19:22:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dbce7d11ab42987d8892591b0d76b7c071c77606","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-06 22:03:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(8 comments)\n\n\u003e \u003e I can\u0027t find any existing typing stuff in Train - which, knowing\n \u003e \u003e the Red Hat buzgilla that this is coming from, is how far we\u0027d\n \u003e want\n \u003e \u003e to backport this. I agree that it\u0027s useful, but I\u0027m not sure it\n \u003e \u003e belongs in a backportable bugfix.\n \u003e \u003e\n \u003e \u003e More comments to come, this is just my initial reaction.\n \u003e \n \u003e This is a duplicate of https://review.opendev.org/#/c/741995/ which\n \u003e is why the type hints exist (I probably wouldn\u0027t have bothered were\n \u003e I starting from scratch). However, we\u0027ve discussed this before and\n \u003e agreed that we shouldn\u0027t _not_ use something just because it\u0027s not\n \u003e backportable. master is the most important branch and minor\n \u003e modifications to e.g. add Python 2.7 support are acceptable.\n \u003e \n \u003e Haven\u0027t looked at the other comments yet, mind, but I don\u0027t think\n \u003e this one is a blocker.\n\nFWIW I don\u0027t agree that we should co-locate type annotation additions with bug fixes intended for backport. Master is the most important branch *but* I think the type additions are unrelated to the bug fix in probably all cases, unrelated to the review of the bug fix, and should be a separate change on top of the bug fix. The change would be \"Add type annotations to \u003cfile\u003e\" or something like that.\n\nAside from the type annotations, I think the approach here makes sense. -1 for the change from pop() to get(), removal of the helper function, removal of the expected_task_state from the unit test (?), and inclusion of the type annotations in a fix, particularly one destined for backport.","accounts_in_message":[],"_revision_number":2},{"id":"a6b48cd868e12da88e02f5e5908c56cc20af859d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-07 13:38:08.000000000","message":"Patch Set 2:\n\n(3 comments)\n\n\u003e (8 comments)\n \u003e \n \u003e \u003e \u003e I can\u0027t find any existing typing stuff in Train - which,\n \u003e knowing\n \u003e \u003e \u003e the Red Hat buzgilla that this is coming from, is how far we\u0027d\n \u003e \u003e want\n \u003e \u003e \u003e to backport this. I agree that it\u0027s useful, but I\u0027m not sure it\n \u003e \u003e \u003e belongs in a backportable bugfix.\n \u003e \u003e \u003e\n \u003e \u003e \u003e More comments to come, this is just my initial reaction.\n \u003e \u003e\n \u003e \u003e This is a duplicate of https://review.opendev.org/#/c/741995/\n \u003e which\n \u003e \u003e is why the type hints exist (I probably wouldn\u0027t have bothered\n \u003e were\n \u003e \u003e I starting from scratch). However, we\u0027ve discussed this before\n \u003e and\n \u003e \u003e agreed that we shouldn\u0027t _not_ use something just because it\u0027s\n \u003e not\n \u003e \u003e backportable. master is the most important branch and minor\n \u003e \u003e modifications to e.g. add Python 2.7 support are acceptable.\n \u003e \u003e\n \u003e \u003e Haven\u0027t looked at the other comments yet, mind, but I don\u0027t think\n \u003e \u003e this one is a blocker.\n \u003e \n \u003e FWIW I don\u0027t agree that we should co-locate type annotation\n \u003e additions with bug fixes intended for backport. Master is the most\n \u003e important branch *but* I think the type additions are unrelated to\n \u003e the bug fix in probably all cases, unrelated to the review of the\n \u003e bug fix, and should be a separate change on top of the bug fix. The\n \u003e change would be \"Add type annotations to \u003cfile\u003e\" or something like\n \u003e that.\n\nI really don\u0027t like having to write code without type hints just because it\u0027s being backported, and I was initially tempted to kick the type hints for existing function signatures to a separate patch but keep them for new functions (which should be written in the best approach in mind). That seemed silly when there was already a follow-up planned though, so I\u0027ve moved them all out.\n\nWith that said, I\u0027d really like the \"put type hints in a separate patch\" request to be a rare one, because such requests make the goal of getting to a fully typed codebase (which I think is a pretty desirable goal) an tougher bordering on impossible one. We say one shouldn\u0027t be making wildly unrelated changes in a patch, but there\u0027s a general antipathy towards refactor-only changes that don\u0027t contribute to an immediate bug fix or RFE. In a lot of the RFE stuff I\u0027ve been doing lately, I\u0027ve been using a strategy of \"if you touch the function in a meaningful way, add hints\" because they ultimately improve the code and help with review. I want to keep doing that because it seems far better for both me and the reviewer than type hint-only changes which I need to annoy people for reviews for [1].\n\n \u003e Aside from the type annotations, I think the approach here makes\n \u003e sense. -1 for the change from pop() to get(),\n\nDone (no change needed)\n\n \u003e removal of the helper\n \u003e function,\n\nDone (re-added)\n\n \u003e removal of the expected_task_state from the unit test\n \u003e (?),\n\nDone (re-added)\n\n \u003e and inclusion of the type annotations in a fix, particularly\n \u003e one destined for backport.\n\nSee above.\n\n[1] https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:mypy-integration","accounts_in_message":[],"_revision_number":2},{"id":"d9d7203fce8ee65527db142265ed609fd4c9ae4f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-07 14:07:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"abf3739348865415da65262b622c17ef00ddffa4","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-07 14:51:54.000000000","message":"Patch Set 3:\n\n* pci-test http://52.27.155.124/pci/744958/3 : FAILURE","accounts_in_message":[],"_revision_number":3},{"id":"4a258adc9cb9ad625555961beeecc10beac4fb81","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-07 15:04:14.000000000","message":"Patch Set 3:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/3/check/pmem-tempest-plugin-filtered-multi-node/16c8feb/ : SUCCESS in 48m 03s","accounts_in_message":[],"_revision_number":3},{"id":"58232b82bfcc2c0132aea4010895eb51b906b855","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-08-07 15:44:50.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-44234 : SUCCESS in 1h 25m 58s","accounts_in_message":[],"_revision_number":3},{"id":"05db4e0dc6b1ca44ad3f90757ea3edcd0c4a8d8f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-07 16:27:13.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/bead01cb6e4140c98bd70fb890461edf : SUCCESS in 1h 07m 58s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/a0b3b43d9cbf44488f944c45a019cf18 : SUCCESS in 1h 32m 36s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b1e93db8a12c47baae68f5705d7575fa : SUCCESS in 18m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5fe8a7e42ec7463985de48679c3bfc07 : SUCCESS in 12m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44436cff8b304c6dae99053f2190d973 : SUCCESS in 9m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/521c3caab92641a7920b484ca9e30ecf : SUCCESS in 11m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d20bad0f1c574ebb9602afeedaf9e147 : SUCCESS in 13m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf56f231038948c196afba8032f80a97 : SUCCESS in 12m 25s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/072d641282264fae8fbb7b48a99ffca1 : SUCCESS in 1h 06m 18s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/bd15a18fb531417db039b132695a0d69 : SUCCESS in 59m 58s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/f4b74c45773445409a3f52865736235e : SUCCESS in 50m 20s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/400bbaf3f9a040aba2f850fd760dbfc2 : SUCCESS in 1h 03m 45s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/aa3329853c8a4c27b1e316fdf0724235 : FAILURE in 1h 52m 38s\n- nova-next https://zuul.opendev.org/t/openstack/build/152cc5e9f5ca4478906701c18ac76eb9 : SUCCESS in 1h 48m 34s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/0b24e4f25cc34bba83aa3eabb0e27fdd : SUCCESS in 19m 06s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8ed166c4109443c88d5dbd06f84605db : FAILURE in 14m 52s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/d40c31255a8941d084a08fef8f382153 : POST_FAILURE in 13m 26s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/97754e3c8e904e7cb0d14fb41b9e5fcb : SUCCESS in 27m 31s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/b15250b410b842cabb2b16af6e27e3d7 : SUCCESS in 36m 32s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"df3fa21b7ced3f1d7b522bc7a6edb3c7b5a7f2d3","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-07 16:52:45.000000000","message":"Patch Set 3:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/744958/3 : SUCCESS in 2h 43m 43s","accounts_in_message":[],"_revision_number":3},{"id":"0b55056ee9f3811182859771f87cd38026f90092","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-07 16:56:31.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"135b92fa8357eb13eb99af4e41208fc0dfd47163","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-07 18:00:13.000000000","message":"Patch Set 3:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/3/check/pmem-tempest-plugin-filtered-multi-node/7365de1/ : SUCCESS in 49m 06s","accounts_in_message":[],"_revision_number":3},{"id":"32310931d18d99a6f9df63502488f5201befd4f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-07 18:31:57.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/114760e170874d8db1cd0f0ce3b98a95 : SUCCESS in 55m 09s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/bbb3b3824a5e4835b4f17145d5f92e6c : SUCCESS in 1h 21m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f8459384b2ee492186fc2787cc7857d8 : SUCCESS in 19m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1dd577878fe34085986bdd64a384902e : SUCCESS in 18m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/806e5c0a72d1400197805f951e6532b4 : SUCCESS in 11m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/36d89b0a318744f1b1cbc4e152d5a98a : SUCCESS in 16m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/09ef402b0a8d4b849ad61fdf8e25a398 : SUCCESS in 15m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e01e1fada8ac4e5ebe505795a7ace70d : SUCCESS in 16m 13s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/f92d745ec527442eadd53c4401d57a01 : SUCCESS in 1h 20m 55s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/d56ad3fbd8a54ccd9ba7a35ff6756c7f : SUCCESS in 1h 12m 14s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/3fa3118433a046fd9251893f51175d20 : SUCCESS in 1h 15m 48s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/c89f452e909a43df81210186a3ff59fe : SUCCESS in 1h 00m 19s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/8a96439d30314b4d8c0b9f8d5225d631 : SUCCESS in 1h 27m 40s\n- nova-next https://zuul.opendev.org/t/openstack/build/c49315666963411e9ab9cb230516d8e7 : SUCCESS in 1h 24m 40s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b964bd020cf0432d83b98a292bdfef1d : SUCCESS in 12m 53s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/900d2e29ca544213b0c42c67eddee731 : SUCCESS in 1h 00m 31s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c6dfa23245aa40868e732274d6ceb48c : SUCCESS in 56m 27s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/73789723dd024c25acc5c78e21e2e678 : SUCCESS in 32m 57s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/a4025a75089e4b38bbde917245e47178 : SUCCESS in 42m 04s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b5068db097d18311eb6026e892f584baed514640","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-08-07 18:57:30.000000000","message":"Patch Set 3:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-58-744958-3 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":3},{"id":"3108d183380a652682903bd4fc8eadfdb35df4a4","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-08-07 19:14:27.000000000","message":"Patch Set 3:\n\nTesting completed on the zVM Driver CI system check-nova pipeline.  To recheck only the zVM driver plugins, submit a comment with only zvm: recheck in the comment. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-44246 : SUCCESS in 2h 12m 26s","accounts_in_message":[],"_revision_number":3},{"id":"903a24f0df613e8fb5a347765e242ace441e668a","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-07 19:18:49.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/3 : FAILURE in 32m 21s","accounts_in_message":[],"_revision_number":3},{"id":"f891debf828daf2c85bed8b14c54600926ad3e47","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-08 00:05:52.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/3/check/tempest-dsvm-full-bionic/acbb8a6/ : SUCCESS in 1h 38m 15s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/3/check/tempest-dsvm-full-bionic-py3/513c3e4/ : SUCCESS in 1h 31m 45s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/3/check/grenade-dsvm-bionic/e7437f2/ : SUCCESS in 2h 04m 23s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"548a7f6f1d7022073ff465d8fce77eb172bea362","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-08 11:22:50.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/3/check-vote/ext-nova-zuul/b9c0af6 : FAILURE in 1h 10m 24s","accounts_in_message":[],"_revision_number":3},{"id":"a88255adcb6bd85fa9c9951a9529211bc9d45bf2","author":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"date":"2020-08-09 10:05:40.000000000","message":"Patch Set 3:\n\nvmware-recheck-patch","accounts_in_message":[],"_revision_number":3},{"id":"48e6d0875180ee1439ebf1093018895ed98fd6fc","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-09 11:10:37.000000000","message":"Patch Set 3:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/3/check-vote/ext-nova-zuul/2290a14 : SUCCESS in 58m 05s","accounts_in_message":[],"_revision_number":3},{"id":"cf695b55ed23e4c084a2ea28233c179df917882e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-10 17:06:39.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)\n\nI think this is gratuitous change for something we want to backport. I\u0027d really like to see if we can avoid de-indenting that entire method for the backport part, because it really seems like it should be doable.","accounts_in_message":[],"_revision_number":3},{"id":"6dba8c5e987f8c23464d81ed0e2db8e2a9849c83","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-10 17:07:27.000000000","message":"Patch Set 3:\n\nOops, meant to say also that I _think_ the intent here (to unset the old/new_flavor later) is probably a fine thing to do.","accounts_in_message":[],"_revision_number":3},{"id":"9ab871a3540ea67dde0c6ab4435dad1b672b31eb","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-10 19:15:04.000000000","message":"Patch Set 3:\n\n(5 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ee297850bb1b0f57f570608b1a0b7f7b33e4e4c4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-11 10:34:21.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"5c73cd1ab19acf8ee30cba2cfa2980275254ac46","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-11 13:38:19.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"915d9bbe9ef752d6cf8f77fdace53cff73377c88","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-11 13:40:42.000000000","message":"Patch Set 4:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"6ca9aaf02b70da6ca7c980744784be3c6417d6e9","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-11 13:41:01.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"5fba9002f2ac62135f98e952f786480de5a6683f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-11 13:41:25.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2b169765a648dfc8b25c9cc82ad614e8270bd15d","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-11 14:20:07.000000000","message":"Patch Set 4:\n\n* pci-test http://52.27.155.124/pci/744958/4 : FAILURE","accounts_in_message":[],"_revision_number":4},{"id":"0f93463a615d61214928fa6394ccabd8556030c9","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-11 14:30:12.000000000","message":"Patch Set 4:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/4/check/pmem-tempest-plugin-filtered-multi-node/5932304/ : SUCCESS in 49m 47s","accounts_in_message":[],"_revision_number":4},{"id":"31a3e48ab2561aeee55720bb2abee5462df4a616","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-11 15:14:25.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/6d53c412cbad4d0fb7ddf2664ee6ca34 : SUCCESS in 1h 02m 30s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/49b7d1029f6b4f52919a100bb2c66090 : SUCCESS in 1h 18m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4fc3421c8e414fe8a4d5d4969cc5510d : SUCCESS in 18m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7f6a2c4d40c1478c9ad7c785622564b3 : SUCCESS in 16m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/25ebeddf03e94ba08939fd871584ac0d : SUCCESS in 7m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cebff480d6c54b4eb613ac9659be56c3 : SUCCESS in 18m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2ae4f57e2fd0426ab286fde4470d50e3 : SUCCESS in 13m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a58b8488c8d4043a4e877e1bc9c1971 : SUCCESS in 11m 16s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/609f036927e64b10a378db01db1f5759 : SUCCESS in 1h 14m 38s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/3fd35bae2fc14e1ab2511a15d020c35c : SUCCESS in 49m 17s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/316ecf4d0b69480e95f3c71ceed60690 : FAILURE in 1h 05m 55s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/165ef57e5c224e7cbf40b916c3f8c1b9 : SUCCESS in 49m 15s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/80e50c155cff4c19a4f0f830fa8f5d07 : SUCCESS in 1h 20m 44s\n- nova-next https://zuul.opendev.org/t/openstack/build/b9f4b8cddf5d48cabf3c2bf3b4f9ef06 : SUCCESS in 1h 25m 41s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a1b96fff70b84c13a8d6b7e0c0e4c7fe : SUCCESS in 22m 09s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7a93ca3f21544cb183edd0dd59873d67 : SUCCESS in 1h 08m 12s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/36fdea449b2c465999be7ec1ae84129d : SUCCESS in 1h 08m 22s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/7e5e5490218749bfbc2fc8ce161c8432 : SUCCESS in 31m 31s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/5461805aee374694bdfe2347bd234dbc : SUCCESS in 26m 44s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"dab611d30df806d33eaa74106085822c742dd509","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-08-11 15:23:32.000000000","message":"Patch Set 4:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-44320 : FAILURE in 1h 40m 02s","accounts_in_message":[],"_revision_number":4},{"id":"301a8065a03094f9709b3916aa2103088a8bb581","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-11 15:36:01.000000000","message":"Patch Set 4:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/tempest-dsvm-full-bionic/8fe313a/ : SUCCESS in 1h 33m 37s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/tempest-dsvm-full-bionic-py3/2a284fb/ : SUCCESS in 1h 18m 22s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/grenade-dsvm-bionic/c4f9755/ : SUCCESS in 1h 46m 08s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"6804cd1cdf50119d2532df424a7a4861ab80c8c8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-11 16:06:53.000000000","message":"Patch Set 4:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/744958/4 : SUCCESS in 2h 26m 38s","accounts_in_message":[],"_revision_number":4},{"id":"eafeefd5bc6958fb78f241b4a2a5b7d0dc539f80","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-11 18:55:20.000000000","message":"Patch Set 4:\n\nrecheck keystone ServiceUnavailable","accounts_in_message":[],"_revision_number":4},{"id":"e6f4e231a9070ea95b49d319dae18267bbb38d2c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-11 18:58:47.000000000","message":"Patch Set 4:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"b131145d5cccc4335d2efdcbfd7057e11802af89","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-11 19:42:55.000000000","message":"Patch Set 4:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/4/check/pmem-tempest-plugin-filtered-multi-node/716b25c/ : SUCCESS in 46m 07s","accounts_in_message":[],"_revision_number":4},{"id":"8cb6e074e70d0e087ad3d263e5410c3d0429b1a4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-11 20:41:38.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/850b160df5fc482bb8e3f57ee2c02fc5 : SUCCESS in 1h 01m 23s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/321c9aad56ac4bf3b9f91a5fe5a1bb27 : SUCCESS in 1h 13m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/baf8f647de754a06b41f28d1fe516307 : SUCCESS in 18m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/39ac8bce00084b299ee31afa0b1f54a6 : SUCCESS in 15m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d14a864ad8d347488a4c05c35cc0de8a : SUCCESS in 8m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c56cf98988354d0f93a99b89d7141dbd : SUCCESS in 17m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7f1887c4e6a742adbe51ecd1416e18bb : SUCCESS in 13m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eb8ca37fbd584c58bc3a7380e786d4ef : SUCCESS in 14m 23s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/1967ee68916f4e84835203c1e1abd581 : SUCCESS in 1h 30m 30s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/36ea2098ce9e43d2906193de9b3c7ecf : SUCCESS in 1h 04m 06s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/5be7b7525d9a4498be23486f5f7cde61 : FAILURE in 1h 08m 46s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/385687df35ee4a59a1e0402e36e6ee7f : SUCCESS in 1h 05m 14s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/9d24dda2c9164c2780bab2a56a74e4a3 : SUCCESS in 1h 23m 30s\n- nova-next https://zuul.opendev.org/t/openstack/build/bc92fa2d19b84ced864fa7b2c13e8a8a : FAILURE in 1h 29m 57s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2a7cb905eac0410f994015d71e4660b5 : SUCCESS in 18m 11s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ddcdb60de9804132a388eb08605a2efc : SUCCESS in 1h 03m 50s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e7b3410c12d2408d9967cde68c082689 : SUCCESS in 54m 25s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5daf78fe0b2843e5aa57dec6d48e04df : SUCCESS in 29m 14s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/0de5601881b545fab33536d58da83053 : SUCCESS in 36m 56s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"7cbd08cbf815036214d5439fc8ac0c666e3005a4","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-11 21:25:19.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/4 : FAILURE in 2h 28m 55s","accounts_in_message":[],"_revision_number":4},{"id":"72e9b0f6cf9aa52bf481f2b42c2ab11e117be276","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-11 21:27:11.000000000","message":"Patch Set 4:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/tempest-dsvm-full-bionic/4f2b474/ : SUCCESS in 1h 37m 40s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/tempest-dsvm-full-bionic-py3/89dcd3f/ : SUCCESS in 1h 39m 26s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/grenade-dsvm-bionic/5413016/ : SUCCESS in 2h 04m 37s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"354d8d246e9df2f7c32372aea413dc0aaf278a45","author":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"date":"2020-08-12 02:03:49.000000000","message":"Patch Set 4:\n\nvmware-recheck-patch","accounts_in_message":[],"_revision_number":4},{"id":"2bbfb9ec1661b926c251501af286ed39b0ff1341","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-12 02:57:40.000000000","message":"Patch Set 4:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/4/check-vote/ext-nova-zuul/710d3c2 : SUCCESS in 52m 35s","accounts_in_message":[],"_revision_number":4},{"id":"aa773c7c05d6014b7b9f5cd59c2f26a299bbd860","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-17 13:30:39.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"512b90a1b85b58299c79cffd336738fc03113c65","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-17 13:48:48.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/4 : FAILURE in 16m 59s","accounts_in_message":[],"_revision_number":4},{"id":"e12ddc5c5919295b8b8a0d9f3257e60dbeb4869a","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-17 14:22:32.000000000","message":"Patch Set 4:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/4/check/pmem-tempest-plugin-filtered-multi-node/85a6d5c/ : SUCCESS in 50m 10s","accounts_in_message":[],"_revision_number":4},{"id":"d918461b059ecc92a8b580dd05d61c92dc9054fb","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-17 15:46:33.000000000","message":"Patch Set 4:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/4/check-vote/ext-nova-zuul/a812466 : SUCCESS in 1h 04m 20s","accounts_in_message":[],"_revision_number":4},{"id":"6b0f66277d4c9d563b2c537b69e8ff6b7bf4ab19","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-17 16:04:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/f38571955c384e5eac89c7acdf572b8c : SUCCESS in 1h 09m 37s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/4421bf9e544443e7834f21131cb287e5 : SUCCESS in 1h 29m 28s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bb19a4d9ae5e44698016f65627303ee3 : SUCCESS in 19m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d6f08cbde9f04e40bc3da4140a74034b : SUCCESS in 15m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf40ec80aa744112a52bb9403f7f1159 : SUCCESS in 8m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/723061407fb14052b1b83032b42722bd : SUCCESS in 13m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f34ddfc03e0a4c7f891b2b9a4087b533 : SUCCESS in 10m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/12ef9e1dffae432bb4398b94e45266c0 : SUCCESS in 11m 47s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/e3b659409d1345b29bd511f4850d89db : SUCCESS in 1h 17m 12s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/1974c8b060be46b08975bf3166cf3a39 : SUCCESS in 1h 01m 21s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4d55756983eb491bb608b56283480497 : SUCCESS in 1h 03m 32s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ccedd3fcfa77440999e117d1ed5b5986 : SUCCESS in 36m 42s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/8a15ef46b8494d30a940955b0de8f7ad : SUCCESS in 1h 29m 25s\n- nova-next https://zuul.opendev.org/t/openstack/build/fbd9e0f1068648c5b4bdf2083c463437 : SUCCESS in 1h 49m 24s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/39815902a4624a29bf5174bc9f025dea : SUCCESS in 17m 45s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ac4b3a70ecd14f6bb4df4c7b5f8780f8 : SUCCESS in 53m 32s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/b1b7f8e5f7de4b6fbeea01758f221491 : SUCCESS in 53m 00s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/d66ab309c61d4069a7e10b54b08440a6 : SUCCESS in 34m 07s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/2e42bbb04c884ac3bad22608b16d4f1e : SUCCESS in 40m 10s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"9f4346fbd2881077deb5554a5ab467f81a43dfe9","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-08-17 16:04:41.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/58/744958/4/check/EMC_PowerFlex_NOVA/ff69b30/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":4},{"id":"c0697f34ae9762c3a3aa81c1c4d33cbd99e78ec3","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-17 16:20:43.000000000","message":"Patch Set 4:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/tempest-dsvm-full-bionic/644427a/ : SUCCESS in 1h 27m 22s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/tempest-dsvm-full-bionic-py3/ed0516f/ : SUCCESS in 1h 52m 49s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/4/check/grenade-dsvm-bionic/fc4bda9/ : SUCCESS in 2h 06m 54s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"51e2285df3a3e0a8643f2ed8b4ce0f7d1a1f0002","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-08-17 16:24:28.000000000","message":"Patch Set 4:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-58-744958-4 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":4},{"id":"7bee80e86d81a33f632be9c1936a2e197e7269f3","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-19 17:58:26.000000000","message":"Patch Set 4: Code-Review-1\n\n(5 comments)\n\nThe -1 is for reformatting unchanged lines, but otherwise I think this is good.","accounts_in_message":[],"_revision_number":4},{"id":"bff7700684a43120c516abb452347843f1a93779","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-19 19:32:22.000000000","message":"Patch Set 4:\n\n(4 comments)","accounts_in_message":[],"_revision_number":4},{"id":"702efd0ff82217c6e7b6fdad25135739b0c6050e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-19 19:32:50.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7d11809ad2a1a60d5bdafeea99f9ca807179f5af","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-19 21:43:49.000000000","message":"Patch Set 5:\n\n* pci-test http://52.27.155.124/pci/744958/5 : FAILURE","accounts_in_message":[],"_revision_number":5},{"id":"51bd78124c91b3a7f5e0e69550b30d2905d2b886","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-19 21:43:56.000000000","message":"Patch Set 5:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/5/check/pmem-tempest-plugin-filtered-multi-node/889e0e9/ : SUCCESS in 53m 38s","accounts_in_message":[],"_revision_number":5},{"id":"4c95ab0fab0abc303ec6c040e953d0491fb39d1c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-19 22:05:55.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/654da77d6eda462c96bc35ebfa54f646 : SUCCESS in 1h 09m 25s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/85abbba5a0a6427dab2359969c18074d : SUCCESS in 1h 11m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8123926aa9e04ec7bc74dd33070800cb : SUCCESS in 14m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cea0962cf6bc4e4d8cb2dac824266343 : SUCCESS in 15m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dbaf679845d7436980701e9e8b191adb : SUCCESS in 11m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ccb5931869c74db0a068dd55d353dd21 : SUCCESS in 14m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a3d9b8bd0ea14518853ad726d478f756 : SUCCESS in 16m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd6c991927f04506b78ef6584f074d1d : SUCCESS in 10m 22s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/131822e4774d4a629c7ad6b1c77230c5 : SUCCESS in 1h 26m 05s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/7a29d74daec94828a5df78d6f1466ad2 : SUCCESS in 1h 12m 57s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/b8036cdccddd47d3be170a33d8091f9f : FAILURE in 1h 07m 46s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/55e9938908cf4d0eb1d42324349f6896 : SUCCESS in 45m 52s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/96db25df79a54a398864323eb6639899 : SUCCESS in 1h 27m 51s\n- nova-next https://zuul.opendev.org/t/openstack/build/2e66e5c00bec4985abad6814c8f78336 : SUCCESS in 1h 23m 41s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f01a7c01549a462e85a00a77f3634474 : SUCCESS in 18m 28s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d751d3f2604946f4be785538136f774a : SUCCESS in 42m 30s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/a61dda4af9564496a994ef616d0ab9e2 : SUCCESS in 59m 12s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/8493211bf5334853a5f6105527c9575b : SUCCESS in 42m 01s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/5c9d4bd9419340718a81c406876db3e9 : SUCCESS in 35m 03s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"724228e216b3df5cd561dbd4c08180cca554ecb4","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-19 22:15:05.000000000","message":"Patch Set 5:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/744958/5 : SUCCESS in 2h 40m 12s","accounts_in_message":[],"_revision_number":5},{"id":"30ea66a6f7822d27c79fee3d4c384d942767d881","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-20 03:32:56.000000000","message":"Patch Set 5:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/5/check/tempest-dsvm-full-bionic/9567ac0/ : SUCCESS in 1h 24m 09s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/5/check/tempest-dsvm-full-bionic-py3/2ec7cec/ : SUCCESS in 1h 34m 02s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/5/check/grenade-dsvm-bionic/7f99f04/ : POST_FAILURE in 1h 46m 41s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"1c0848a254acb4cf570dcda2d77d0d5144a9bb43","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-20 08:17:51.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"4b8e5aa8ad9f37a71188acd3ac83fcedc6b46969","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2020-08-20 08:30:50.000000000","message":"Patch Set 5: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"6d6b9bb51659635fa3527e29dbd950c17145926f","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-20 09:03:29.000000000","message":"Patch Set 5:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/5/check/pmem-tempest-plugin-filtered-multi-node/c64e821/ : SUCCESS in 44m 14s","accounts_in_message":[],"_revision_number":5},{"id":"8677218b11cffcb7403e36965e99d703a2c83e52","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-20 09:32:29.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"a15ed64337bcfc08803059cc5fdc68c1951d21f2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-20 09:51:46.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/d172ac7cd45a4136ae140a76f8fe73ae : SUCCESS in 54m 50s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/56b08f118f714cea9d4c11e5997fd094 : SUCCESS in 1h 15m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/41204038f2fa409791450dd99050338a : SUCCESS in 14m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5f01737a6473465fbb788727bbefa31d : SUCCESS in 17m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7a34e9b6a6d142cebfcef8fafba880eb : SUCCESS in 8m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cf05c27e568c4ed7b2cbfbbf11b07597 : SUCCESS in 13m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/03d8a49b293a459d9adf54ad985911cb : SUCCESS in 13m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/40317c8818b7481183683cc5885fe408 : SUCCESS in 12m 55s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/9a7468f6eeb843f1b3911aab4cae1a34 : SUCCESS in 1h 16m 48s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/7cc66aea7fd34e98a84d55bd1ea428a9 : SUCCESS in 1h 05m 08s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4b491771fe8648558ead5e5c0cf96d65 : SUCCESS in 1h 25m 20s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/9a40b6fd067a4be2b4d67ab75267cd81 : SUCCESS in 58m 31s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/c92359be49ce4dfab56767e11a2c0b5b : SUCCESS in 1h 20m 00s\n- nova-next https://zuul.opendev.org/t/openstack/build/79e26fa35de14fc49826266d767e9ad4 : SUCCESS in 1h 30m 26s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5368636823714833b162b09d50093617 : SUCCESS in 18m 06s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3e881c0e471841d29171ea9dbb6757cb : SUCCESS in 1h 00m 25s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7886bc07e7d640819d8542b2a6e574a1 : SUCCESS in 1h 00m 27s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/41e31620fef24a2f867f6ccf90351b39 : SUCCESS in 27m 22s (non-voting)\n- barbican-simple-crypto-devstack-tempest https://zuul.opendev.org/t/openstack/build/02f35bed1e684e208e2cca380f05bf25 : SUCCESS in 39m 31s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"50aada44982eace92d013f31132876c08c0c963a","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-08-20 10:15:40.000000000","message":"Patch Set 5:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-58-744958-5 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":5},{"id":"a254fb8335faf4ef323c1f03411102d7bccf42eb","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-20 10:21:46.000000000","message":"Patch Set 5:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/5/check/tempest-dsvm-full-bionic/5e29de7/ : SUCCESS in 1h 37m 24s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/5/check/tempest-dsvm-full-bionic-py3/ddbac8d/ : SUCCESS in 1h 36m 00s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/5/check/grenade-dsvm-bionic/84e1a1b/ : POST_FAILURE in 1h 40m 55s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"5f3495444819da88a61e22f16214cffd36a7c4a4","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-20 11:01:58.000000000","message":"Patch Set 5:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/744958/5 : SUCCESS in 2h 42m 56s","accounts_in_message":[],"_revision_number":5},{"id":"0743db0e0d1b07389b6e91a83895981d40c43239","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2020-08-20 11:23:08.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"8d13a5d44a91a622db947ab5451e37421d0aa008","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-20 12:16:38.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"9d098d34f8cc43487afa28dc5cf2fee22e6a1088","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2020-08-20 12:57:59.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"19541ad64ce3913bd15bb9589cbbeed3020bb02c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-22 16:42:22.000000000","message":"Patch Set 5:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/5/check-vote/ext-nova-zuul/e808ddd : SUCCESS in 58m 30s","accounts_in_message":[],"_revision_number":5},{"id":"5edc1f08fc2169729816f2e3b9ad31f6022427ab","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-24 10:16:49.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"fd44401fc34bccbe8f56a7cb71491409a3985954","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-24 14:55:42.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"2f0224bb1ae845b8f178b254ab29dcfd5ebf024f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-24 14:58:29.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"1ed3495baaf5aee2eb42a4a8d2512f9132133393","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-24 15:46:04.000000000","message":"Patch Set 6:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/6/check/pmem-tempest-plugin-filtered-multi-node/3a8bac8/ : SUCCESS in 48m 04s","accounts_in_message":[],"_revision_number":6},{"id":"2d7517c3860a3367819d74f96cba5f101199b4b5","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-24 15:46:33.000000000","message":"Patch Set 6:\n\n* pci-test http://52.27.155.124/pci/744958/6 : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"0bf8c6bac956edd7411989ed1e010c5a33349080","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-24 15:47:58.000000000","message":"Patch Set 6:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/6 : FAILURE in 50m 20s","accounts_in_message":[],"_revision_number":6},{"id":"c5006733f9ff382cbf4480b24faa3f12d7c304c8","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-24 15:57:11.000000000","message":"Patch Set 6:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/6/check-vote/ext-nova-zuul/9ac78a1 : FAILURE in 1h 00m 09s","accounts_in_message":[],"_revision_number":6},{"id":"606ca822b79c71d73885c92cf826c8b274bfea95","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-24 16:33:31.000000000","message":"Patch Set 6:\n\nTesting succeeded on ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/744958/6/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/f7bd41a : SUCCESS in 1h 37m 00s","accounts_in_message":[],"_revision_number":6},{"id":"1edcf1139f9912632715d0027277f63cb41d8f3b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-24 17:07:35.000000000","message":"Patch Set 6:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/6/check/tempest-dsvm-full-bionic/f223598/ : SUCCESS in 1h 32m 44s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/6/check/tempest-dsvm-full-bionic-py3/ac5d83b/ : SUCCESS in 1h 17m 21s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/6/check/grenade-dsvm-bionic/de319c1/ : POST_FAILURE in 1h 48m 36s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"08a974cdd67a7c68bc3d369e9446a9cde15e4ea4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 17:59:41.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/b10d9cc0066f4f649f01041ea4be5c1b : SUCCESS in 59m 38s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/3c59aef7d40945d1b971a6428b0c841e : FAILURE in 1h 21m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/38914db0f8dd49aca435b1827365c281 : SUCCESS in 18m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/eb1de449a74147048b615db269101b19 : SUCCESS in 15m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c673720ecd3f44bab5af45444def13eb : SUCCESS in 8m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f7049063875b4b48a2433f4affe12285 : SUCCESS in 13m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3055f96c611441609d1509ffb26cba7f : SUCCESS in 14m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6646b44ec0e1493abdaa40b18ffb76c1 : SUCCESS in 16m 30s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/c09c78f2e7a34db78d087778daf2ac45 : SUCCESS in 1h 21m 12s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/4b02ab3ee7bb4757b42c0b1077e04a50 : SUCCESS in 1h 08m 03s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/2eeac36b30bc4a798c3e6dafc8ce119b : SUCCESS in 1h 09m 48s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/0f54ac9d6ec44e1a8afc8c8eeacdc751 : SUCCESS in 49m 48s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/17a93fbda9314d3d9eb81b945fb72812 : SUCCESS in 1h 17m 13s\n- nova-next https://zuul.opendev.org/t/openstack/build/7a42545fd19b49aea9871d12645414fd : SUCCESS in 1h 29m 07s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f85cf6c3eec846f4acc77a6ebf504680 : FAILURE in 17m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6c1688e184af4744b2c274a511795cc3 : SUCCESS in 55m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6550edf4d8d94606872018dacca8343e : SUCCESS in 55m 24s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/2ff8d60b20344f8da346ddefe2bb0b1c : SUCCESS in 30m 00s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/8319f063ddb94519a8990793f3385957 : SUCCESS in 40m 47s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"f04e324ae7abeee4ada11e0a47e43468d2c9eb5a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-25 15:08:25.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"73038d4b919c3b8a8dd4f83098b0b63baba96ac8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-25 16:34:08.000000000","message":"Patch Set 7:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/7 : FAILURE in 52m 44s","accounts_in_message":[],"_revision_number":7},{"id":"9894731ebc516a44f03521415b7091f1e24edbda","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-08-25 16:53:25.000000000","message":"Patch Set 7:\n\n* pci-test http://52.27.155.124/pci/744958/7 : SUCCESS","accounts_in_message":[],"_revision_number":7},{"id":"64148ca457bf1a7bc00813a1d08b19fdf935fde0","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-25 17:21:37.000000000","message":"Patch Set 7:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/58/744958/7/check/pmem-tempest-plugin-filtered-multi-node/67c8398/ : SUCCESS in 52m 57s","accounts_in_message":[],"_revision_number":7},{"id":"d053248dfb5fd9538e907a43da683aa32de9bfba","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-25 18:08:27.000000000","message":"Patch Set 7:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/744958/7/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/9ecaa86 : FAILURE in 1h 40m 04s","accounts_in_message":[],"_revision_number":7},{"id":"6c651c5b2266cd88cbf3d5b0aa01df34b0887a8b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-25 19:17:06.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/2e60022ddfb244e49e5c0bfc1da359db : SUCCESS in 1h 01m 54s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1bf0cde4b8b4418d8785ab9c5f37adac : SUCCESS in 1h 14m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dc2364a785d24eb4977032a214d02515 : SUCCESS in 15m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ce95d61bc93c437fa12c360e59d0f4f0 : SUCCESS in 15m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b1285892c0f24758a3c490b3dc2db8ca : SUCCESS in 7m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/70cdfd0859844669a5be380c77dcee79 : SUCCESS in 13m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/461cf66a513a474b8705342c8ab222f5 : SUCCESS in 17m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2f951f971c36424cb0d8895a1fa974a5 : SUCCESS in 19m 09s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/22c22e3bd7fb45118cbfb54015594dd8 : SUCCESS in 1h 17m 03s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/0a9ae2fe501842acbe4598e5f56265bb : SUCCESS in 1h 01m 47s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a369f9e2a6c54e1598c35d8f4c94fed5 : SUCCESS in 1h 14m 02s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ce23c88e2e7f40cb81c57bc64d7709c9 : SUCCESS in 35m 49s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/6c19ecd52b0d45aca381cdd5f95e8a24 : SUCCESS in 57m 20s\n- nova-next https://zuul.opendev.org/t/openstack/build/0f9f4a1cf15e4f6186f9bb4c61d701e2 : SUCCESS in 1h 42m 23s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1f6db6b39fca42bcbb2778dc685860d9 : SUCCESS in 18m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7c70e5815c1246b2bf186aedfa093df2 : SUCCESS in 1h 00m 23s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3401989e69064c429e2c056cd117eca1 : SUCCESS in 54m 57s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/2aaf993d09404eb482f4620c1d1f164f : SUCCESS in 26m 05s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/e49b2c4db1144e8a90626d7468d4a12a : SUCCESS in 50m 33s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"75662c5201d6747ef58c36c3891a6526e408dca2","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-08-25 19:17:44.000000000","message":"Patch Set 7:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_PowerFlex_NOVA http://publiclogs.emc.com/58/744958/7/check/EMC_PowerFlex_NOVA/1b2b176/EMC_PowerFlex_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC PowerFlex CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerFlex_CI","accounts_in_message":[],"_revision_number":7},{"id":"049c182dedd92d5a40b9956f821d281cfb4da6d5","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-25 19:41:25.000000000","message":"Patch Set 7:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/7/check/tempest-dsvm-full-bionic/2c53a2a/ : SUCCESS in 1h 38m 21s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/7/check/tempest-dsvm-full-bionic-py3/9d24d92/ : SUCCESS in 1h 39m 36s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/7/check/grenade-dsvm-bionic/fc09926/ : POST_FAILURE in 1h 36m 50s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"858d4b4014d7ed4a570abe38e09203d437010fb0","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-08-25 19:54:39.000000000","message":"Patch Set 7:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-58-744958-7 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":7},{"id":"ea9209d7deff608b4f73cccb322190de6bd43df4","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-26 02:22:31.000000000","message":"Patch Set 7:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/7/check-vote/ext-nova-zuul/2909b79 : SUCCESS in 1h 04m 38s","accounts_in_message":[],"_revision_number":7},{"id":"179955113210632c38dff08691489648a8950c40","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-27 18:30:23.000000000","message":"Patch Set 7: Code-Review+1\n\n(10 comments)\n\nCautious +1. I\u0027m always afraid of races when changing ordering, but I think it should be OK? My own review notes inline...","accounts_in_message":[],"_revision_number":7},{"id":"2ab6e2c8bef73bd871c336525428f7cb5c4f691b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-01 15:20:20.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"1737503932610e8ef488a3e92b5a3230719bcfe1","author":{"_account_id":15751,"name":"Intel PCI CI","email":"pci-ci@intel.com","username":"intelpcici","tags":["SERVICE_USER"]},"date":"2020-09-01 15:55:14.000000000","message":"Patch Set 8:\n\n* pci-test http://52.27.155.124/pci/744958/8 : FAILURE","accounts_in_message":[],"_revision_number":8},{"id":"3ee5618a2fcc5b58fb87dcbeab0b2b7b508d38bc","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-09-01 16:31:23.000000000","message":"Patch Set 8:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/744958/8/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/976da5e : FAILURE in 13m 33s","accounts_in_message":[],"_revision_number":8},{"id":"988522220469fe0e7a38c00eb2629891a6850062","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-01 18:43:06.000000000","message":"Patch Set 8:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/744958/8 : FAILURE in 56m 23s","accounts_in_message":[],"_revision_number":8},{"id":"5133de1ca2ad941190b3037782e6b022653002b6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-01 19:44:11.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/5f860f021def42bba9da251975979a89 : SUCCESS in 42m 57s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/9b3e647e3c2349f5b8eb4ef3b18ba8c8 : SUCCESS in 53m 25s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fe4a68e2e00b4f8db758676fce24700f : SUCCESS in 16m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/14f2e59ee06d4f31ae6301ee7fcfcdc9 : SUCCESS in 14m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba3da54bec8e4b90bbe3033cc99df9b1 : SUCCESS in 7m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d050c1dabc794b4983d2f5b648e5bc56 : SUCCESS in 10m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/502c682cd3f742fb938b771cab6a6a5e : SUCCESS in 12m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25e9a668c8144cbe85beabd8a2aa68b0 : SUCCESS in 13m 31s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/8bcb345313bd4bf297c0f1ac14ad8e30 : SUCCESS in 1h 16m 22s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/6e06e68aa1b047d68cefae5f9dfc455a : SUCCESS in 55m 48s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4533e24668254f0ab1971556fa8261e1 : SUCCESS in 1h 14m 59s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/db93ae445df74eebb31d3d41e3244905 : SUCCESS in 49m 20s\n- nova-multinode-live-migration https://zuul.opendev.org/t/openstack/build/3406e6bc258b40f888dca508a31373fc : SUCCESS in 33m 06s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/26a6da840aab47e38471b205b91ba767 : SUCCESS in 1h 33m 27s\n- nova-next https://zuul.opendev.org/t/openstack/build/9db9a6ba188649fba5b77a5e67b6a1fe : SUCCESS in 1h 29m 53s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d228f1ea3a8d461fb6665480b55fe3ce : SUCCESS in 16m 21s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2fe419acabfd4d19aa108b24b2ef2091 : SUCCESS in 1h 02m 36s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3f086ceb09cd403284b91f407b2a6ca8 : SUCCESS in 53m 01s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/b1a813b2a47c4ae696776d5126dae050 : SUCCESS in 35m 44s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/7891df3e68fe4dca94f443de5624c16f : SUCCESS in 34m 57s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"f77803ced6c40183ced8c211fc3c82bbcdd1f4af","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-09-01 20:15:07.000000000","message":"Patch Set 8:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-58-744958-8 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":8},{"id":"9cebdf1e4d932177343abdbc85d346ad482f8ae4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-01 23:04:22.000000000","message":"Patch Set 8:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/8/check/tempest-dsvm-full-bionic/5f43c1a/ : SUCCESS in 1h 39m 05s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/8/check/tempest-dsvm-full-bionic-py3/84d3b11/ : SUCCESS in 1h 36m 21s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/58/744958/8/check/grenade-dsvm-bionic/a03f043/ : POST_FAILURE in 1h 39m 44s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"18c14c5bb333280b0be311aa4ec4bdf6e9333b58","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-09-02 00:02:51.000000000","message":"Patch Set 8:\n\nBuild failed\n\n- dsvm-nova http://207.189.188.190/logs/58/744958/8/check-vote/ext-nova-zuul/d7bede1 : FAILURE in 18m 46s","accounts_in_message":[],"_revision_number":8},{"id":"37537108a0c617dfdf83cd5128638e11574a70f5","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-02 11:49:13.000000000","message":"Patch Set 8: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":8},{"id":"e90deed9f0f202f86bfed3a4a10049b884b68019","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-09-02 15:27:14.000000000","message":"Patch Set 8: Code-Review+2\n\nI was +2 on https://review.opendev.org/#/c/741995 which was an identical copy of this before.","accounts_in_message":[],"_revision_number":8},{"id":"e007c8c74d9b1cef2d971f4dc8473c4fd324e219","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-09-02 15:27:18.000000000","message":"Patch Set 8: Workflow+1","accounts_in_message":[],"_revision_number":8},{"id":"e12f0580e6a9219d0dbf19cf09035a4b5e1869b7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 15:28:12.000000000","message":"Patch Set 8: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":8},{"id":"d8b862d437880dafd0cb488485f3c5f1608e8cc0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 21:43:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":8},{"id":"c59998eed1b05e292ece42120e5777ce45ef9b5b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 21:43:36.000000000","message":"Patch Set 8: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/470c8465c5ed427a88b6f3f8780fca23 : SUCCESS in 1h 14m 03s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/69d9200d62dd40969c665ca218a7c07b : SUCCESS in 1h 25m 23s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f7ec4b4c49e649ef98d6ee3eb431405c : SUCCESS in 14m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce07d6e6d8d443fc87f3c0b12af5ed6f : SUCCESS in 9m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e434d9a6af364dd79b46cf4fd916994f : SUCCESS in 13m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3e346dc9840b435aa8bc18ef4adfb3fe : SUCCESS in 12m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/462e29ce6ee64a15955cd994a7a923a6 : SUCCESS in 15m 27s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4222c511046e4f30a6487213eb142602 : SUCCESS in 1h 30m 16s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/080ee56791d34e79b76123ad8bb0d923 : SUCCESS in 50m 11s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/586f823951f444ba990c7b95e3dea27a : SUCCESS in 14m 32s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ccbf682faa744a7eb224bd19b8619457 : SUCCESS in 1h 38m 16s\n- nova-next https://zuul.opendev.org/t/openstack/build/b795a0367a2d47e3967da2cc010dd5ad : SUCCESS in 1h 26m 08s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a89a3a04960d4701b49482d0082ba2ae : SUCCESS in 1h 06m 13s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7f9fb9cdb5a34b75a8a3001038b68ab5 : SUCCESS in 1h 17m 31s","accounts_in_message":[],"_revision_number":8},{"id":"afc14817a1b2bc6385208ffa9093769e61736b80","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 21:50:14.000000000","message":"Patch Set 8:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/200f081bdb834a07b852abdb4aafe62d : SUCCESS in 1m 22s","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"44376d2e212e0f9405a58dc7fc4d5b38d70ac42e","revisions":{"a851ebd45846480e2817741739b955ab493049d2":{"kind":"REWORK","_number":1,"created":"2020-08-05 17:51:08.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/1"}}},"commit":{"parents":[{"commit":"b2306d1d72dd21d61c6ac87feea1ec82c34ce5b1","subject":"tests: Add reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b2306d1d72dd21d61c6ac87feea1ec82c34ce5b1"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 17:50:41.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresources usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource trackers\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that in the process of being completed. The root\ncause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a variable amount of time to return, before finally dropping the\nmove claim. If the periodic task ran between the clearing of the stashed\nflavor and the return of the virt driver, it would find a migration\nrecord with no stashed flavor and would therefore ignore this record for\naccounting purposes [4]. This results in an incorrect record for the\ncompute node, and an exception when the \u0027drop_move_claim\u0027 attempts to\nfree up the resources that aren\u0027t being tracked.\n\nThe solution is pretty simple. Instead of unsetting the old flavor\nrecord from the migration at the start of the various move operations,\ndo it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a851ebd45846480e2817741739b955ab493049d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a851ebd45846480e2817741739b955ab493049d2"}]},"branch":"refs/heads/master"},"1c55102ea0408143106254eba6fd12063f19e205":{"kind":"REWORK","_number":2,"created":"2020-08-06 09:52:00.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/2"}}},"commit":{"parents":[{"commit":"b2306d1d72dd21d61c6ac87feea1ec82c34ce5b1","subject":"tests: Add reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b2306d1d72dd21d61c6ac87feea1ec82c34ce5b1"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-06 09:48:26.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1c55102ea0408143106254eba6fd12063f19e205"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1c55102ea0408143106254eba6fd12063f19e205"}]},"branch":"refs/heads/master"},"ba4bab2e1eff1efb4cd30eea0260e132b70d8c51":{"kind":"REWORK","_number":3,"created":"2020-08-07 14:07:07.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/3"}}},"commit":{"parents":[{"commit":"d76efdf7e0b429c0156c7bf980780634f3d6d993","subject":"tests: Add reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d76efdf7e0b429c0156c7bf980780634f3d6d993"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-07 13:41:46.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba4bab2e1eff1efb4cd30eea0260e132b70d8c51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba4bab2e1eff1efb4cd30eea0260e132b70d8c51"}]},"branch":"refs/heads/master"},"f2a0fc6974fe51bdc2bc8f2e7a3dfb2c582d2bd7":{"kind":"REWORK","_number":4,"created":"2020-08-11 13:38:19.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/4"}}},"commit":{"parents":[{"commit":"013d64bb8d4dc8b0438eca5edb542cde5350234d","subject":"tests: Add reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/013d64bb8d4dc8b0438eca5edb542cde5350234d"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-11 11:06:58.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2a0fc6974fe51bdc2bc8f2e7a3dfb2c582d2bd7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f2a0fc6974fe51bdc2bc8f2e7a3dfb2c582d2bd7"}]},"branch":"refs/heads/master"},"29d2b5c9591ccccfcd6f694ad72757ce32e13690":{"kind":"REWORK","_number":5,"created":"2020-08-19 19:32:50.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/5"}}},"commit":{"parents":[{"commit":"10f0a42de162c90c701f70c9c28dc31bfada87db","subject":"tests: Add reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/10f0a42de162c90c701f70c9c28dc31bfada87db"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-19 19:26:42.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29d2b5c9591ccccfcd6f694ad72757ce32e13690"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/29d2b5c9591ccccfcd6f694ad72757ce32e13690"}]},"branch":"refs/heads/master"},"bd44e12cf6dde5b60c07b8c939b5e449d238ff40":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2020-08-24 14:55:42.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/6"}}},"commit":{"parents":[{"commit":"0a15bb2cb0b49b10d6ffdb100abf7c5544e9b1d7","subject":"Add generic reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0a15bb2cb0b49b10d6ffdb100abf7c5544e9b1d7"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-24 14:21:16.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nPartial-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bd44e12cf6dde5b60c07b8c939b5e449d238ff40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bd44e12cf6dde5b60c07b8c939b5e449d238ff40"}]},"branch":"refs/heads/master"},"312e47d5df9ac7bb781d71552b5a06a2323146f4":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2020-08-25 15:08:25.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/7"}}},"commit":{"parents":[{"commit":"e1adbced92453329f7285ec38c1dc7821ebb52c7","subject":"Add generic reproducer for bug #1879878","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e1adbced92453329f7285ec38c1dc7821ebb52c7"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-25 14:59:10.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nPartial-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/312e47d5df9ac7bb781d71552b5a06a2323146f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/312e47d5df9ac7bb781d71552b5a06a2323146f4"}]},"branch":"refs/heads/master"},"44376d2e212e0f9405a58dc7fc4d5b38d70ac42e":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2020-09-01 15:20:20.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/58/744958/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/58/744958/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/58/744958/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/58/744958/8"}}},"commit":{"parents":[{"commit":"662398a1a4bb69c11a08fa5fa7196a89ed1acc87","subject":"Merge \"fakelibvirt: Remove nova-network remnants\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/662398a1a4bb69c11a08fa5fa7196a89ed1acc87"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-05 13:27:06.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-09-01 15:19:27.000000000","tz":60},"subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","message":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary\n\nSince change Ia6d8a7909081b0b856bd7e290e234af7e42a2b38, the resource\ntracker\u0027s \u0027drop_move_claim\u0027 method has been capable of freeing up\nresource usage. However, this relies on accurate resource reporting.\nIt transpires that there\u0027s a race whereby the resource tracker\u0027s\n\u0027update_available_resource\u0027 periodic task can end up not accounting for\nusage from migrations that are in the process of being completed. The\nroot cause is the resource tracker\u0027s reliance on the stashed flavor in a\ngiven migration record [1]. Previously, this information was deleted by\nthe compute manager at the start of the confirm migration operation [2].\nThe compute manager would then call the virt driver [3], which could\ntake a not insignificant amount of time to return, before finally\ndropping the move claim. If the periodic task ran between the clearing\nof the stashed flavor and the return of the virt driver, it would find a\nmigration record with no stashed flavor and would therefore ignore this\nrecord for accounting purposes [4], resulting in an incorrect record for\nthe compute node, and an exception when the \u0027drop_move_claim\u0027 attempts\nto free up the resources that aren\u0027t being tracked.\n\nThe solution to this issue is pretty simple. Instead of unsetting the\nold flavor record from the migration at the start of the various move\noperations, do it afterwards.\n\n[1] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1288\n[2] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4310-L4315\n[3] https://github.com/openstack/nova/blob/6557d67/nova/compute/manager.py#L4330-L4331\n[4] https://github.com/openstack/nova/blob/6557d67/nova/compute/resource_tracker.py#L1300\n\nChange-Id: I4760b01b695c94fa371b72216d398388cf981d28\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nPartial-Bug: #1879878\nRelated-Bug: #1834349\nRelated-Bug: #1818914\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/44376d2e212e0f9405a58dc7fc4d5b38d70ac42e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/44376d2e212e0f9405a58dc7fc4d5b38d70ac42e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}