)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This should yield more realistic functional tests. We need to update"},{"line_number":10,"context_line":"some tests to use admin APIs where policy dictates they are necessary."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia3dea78f16cb3c7081714c4db36e20d5ee76ed7d"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_19b85074","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2020-08-19 22:47:31.000000000","message":"it will be more clear if you can add this is to move towards legacy real policy not the new one. We can switch to new policy later when we will remove the legacy one.","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This should yield more realistic functional tests. We need to update"},{"line_number":10,"context_line":"some tests to use admin APIs where policy dictates they are necessary."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia3dea78f16cb3c7081714c4db36e20d5ee76ed7d"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_a98b89bd","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"9f560f44_19b85074","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"}],"doc/api_samples/os-rescue/server-get-resp-rescue.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \"user_id\": \"fake\","},{"line_number":55,"context_line":"        \"config_drive\": \"\","},{"line_number":56,"context_line":"        \"OS-DCF:diskConfig\": \"AUTO\","},{"line_number":57,"context_line":"        \"OS-EXT-AZ:availability_zone\": \"us-west\","},{"line_number":58,"context_line":"        \"OS-EXT-STS:power_state\": 4,"},{"line_number":59,"context_line":"        \"OS-EXT-STS:task_state\": null,"},{"line_number":60,"context_line":"        \"OS-EXT-STS:vm_state\": \"rescued\","}],"source_content_type":"application/json","patch_set":2,"id":"9f560f44_f66f6bf9","line":57,"range":{"start_line":57,"start_character":48,"end_line":57,"end_character":49},"updated":"2020-08-19 22:47:31.000000000","message":"Note for the reviewer, this sample file is for internal verification in rescue tests to check if server is back to active state or not. we could just check the state and remove this sample file itself but anyways removing the admin field is ok here which were not used for test verification.\n\nditto for other sample file changes where admin fields are removed.","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"}],"doc/api_samples/os-rescue/server-unrescue-req.json":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8142c8147dad85d53ec0d86f280baffb79e25bda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"unrescue\": null"},{"line_number":3,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"9f560f44_399274a0","line":3,"updated":"2020-08-19 21:47:56.000000000","message":"This is happening because I opened the file, which didn\u0027t have a newline, and saving it with vim added that newline. I can rework to drop the change but I don\u0027t think it\u0027s worth it IMO","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"}],"nova/tests/fixtures.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a22371cad8f95161527f22dcba76877df49891aa","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        root.setLevel(std_logging.DEBUG)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # supports collecting debug level for local runs"},{"line_number":156,"context_line":"        if os.environ.get(\u0027OS_DEBUG\u0027) in (\u0027True\u0027, \u0027true\u0027, \u00271\u0027, \u0027yes\u0027):"},{"line_number":157,"context_line":"            level \u003d std_logging.DEBUG"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            level \u003d std_logging.INFO"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_bfa6a9aa","line":157,"range":{"start_line":156,"start_character":0,"end_line":157,"end_character":37},"updated":"2020-09-16 14:26:58.000000000","message":"unrelated","commit_id":"8750c4e173b94313948be9e7112902615ad750df"}],"nova/tests/functional/api_sample_tests/test_server_tags.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ServerTagsJsonTest(test_servers.ServersSampleBase):"},{"line_number":21,"context_line":"    # Many of the \u0027os_compute_api:os-server-tags:*\u0027 policies are admin-only"},{"line_number":22,"context_line":"    ADMIN_API \u003d True"},{"line_number":23,"context_line":"    sample_dir \u003d \u0027os-server-tags\u0027"},{"line_number":24,"context_line":"    microversion \u003d \u00272.26\u0027"},{"line_number":25,"context_line":"    scenarios \u003d [(\u0027v2_26\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b6333313","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"these are admin_or_owner by default in legacy. it should pass with non-admin user also.\n\nI debugged locally on why these tests were failing and that is because of different project_id in context and instance_mapping. this API started checking project_id since- https://review.opendev.org/#/c/717947/\n\nReason for different project_id in IM is- https://github.com/openstack/nova/blob/c9421a32485cdc0c47d8af51791265f74d592886/nova/tests/fixtures.py#L299\n\nwe need to make SingleCellSimple fixture to use the same project_id what OSAPIFixture use then we can say we moved to real policy usage.\n\nI am fine to add a TODO for this in this patch and fix later but let\u0027s remove \"# Many of the \u0027os_compute_api:os-server-tags:*\u0027 policies are admin-only\" which is confusing.","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ServerTagsJsonTest(test_servers.ServersSampleBase):"},{"line_number":21,"context_line":"    # Many of the \u0027os_compute_api:os-server-tags:*\u0027 policies are admin-only"},{"line_number":22,"context_line":"    ADMIN_API \u003d True"},{"line_number":23,"context_line":"    sample_dir \u003d \u0027os-server-tags\u0027"},{"line_number":24,"context_line":"    microversion \u003d \u00272.26\u0027"},{"line_number":25,"context_line":"    scenarios \u003d [(\u0027v2_26\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_690a1126","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":20},"in_reply_to":"9f560f44_b6333313","updated":"2020-08-25 09:42:53.000000000","message":"Great sleuthing. Done!","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class ServersSampleJson232Test(ServersSampleBase):"},{"line_number":205,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":206,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":207,"context_line":"    ADMIN_API \u003d True"},{"line_number":208,"context_line":"    microversion \u003d \u00272.32\u0027"},{"line_number":209,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":210,"context_line":"    scenarios \u003d [(\u0027v2_32\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f6164b55","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"it has only post server tests no GET or any other admin API call so should not require admin.","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class ServersSampleJson232Test(ServersSampleBase):"},{"line_number":205,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":206,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":207,"context_line":"    ADMIN_API \u003d True"},{"line_number":208,"context_line":"    microversion \u003d \u00272.32\u0027"},{"line_number":209,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":210,"context_line":"    scenarios \u003d [(\u0027v2_32\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_84c78c96","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":20},"in_reply_to":"9f560f44_f6164b55","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class ServersSampleJson237Test(ServersSampleBase):"},{"line_number":217,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":218,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":219,"context_line":"    ADMIN_API \u003d True"},{"line_number":220,"context_line":"    microversion \u003d \u00272.37\u0027"},{"line_number":221,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":222,"context_line":"    scenarios \u003d [(\u0027v2_37\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_560d773c","line":219,"range":{"start_line":217,"start_character":0,"end_line":219,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class ServersSampleJson237Test(ServersSampleBase):"},{"line_number":217,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":218,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":219,"context_line":"    ADMIN_API \u003d True"},{"line_number":220,"context_line":"    microversion \u003d \u00272.37\u0027"},{"line_number":221,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":222,"context_line":"    scenarios \u003d [(\u0027v2_37\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_24cde0b6","line":219,"range":{"start_line":217,"start_character":0,"end_line":219,"end_character":20},"in_reply_to":"9f560f44_560d773c","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class ServersSampleJson242Test(ServersSampleBase):"},{"line_number":229,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":230,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":231,"context_line":"    ADMIN_API \u003d True"},{"line_number":232,"context_line":"    microversion \u003d \u00272.42\u0027"},{"line_number":233,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":234,"context_line":"    scenarios \u003d [(\u0027v2_42\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_96070f1d","line":231,"range":{"start_line":229,"start_character":0,"end_line":231,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class ServersSampleJson242Test(ServersSampleBase):"},{"line_number":229,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":230,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":231,"context_line":"    ADMIN_API \u003d True"},{"line_number":232,"context_line":"    microversion \u003d \u00272.42\u0027"},{"line_number":233,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":234,"context_line":"    scenarios \u003d [(\u0027v2_42\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_44ca94a0","line":231,"range":{"start_line":229,"start_character":0,"end_line":231,"end_character":20},"in_reply_to":"9f560f44_96070f1d","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"class ServersSampleJson267Test(ServersSampleBase):"},{"line_number":385,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":386,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":387,"context_line":"    ADMIN_API \u003d True"},{"line_number":388,"context_line":"    microversion \u003d \u00272.67\u0027"},{"line_number":389,"context_line":"    scenarios \u003d [(\u0027v2_67\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b9016407","line":387,"range":{"start_line":385,"start_character":0,"end_line":387,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"class ServersSampleJson267Test(ServersSampleBase):"},{"line_number":385,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":386,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":387,"context_line":"    ADMIN_API \u003d True"},{"line_number":388,"context_line":"    microversion \u003d \u00272.67\u0027"},{"line_number":389,"context_line":"    scenarios \u003d [(\u0027v2_67\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a4b8d010","line":387,"range":{"start_line":385,"start_character":0,"end_line":387,"end_character":20},"in_reply_to":"9f560f44_b9016407","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"class ServerSortKeysJsonTests(ServersSampleBase):"},{"line_number":680,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":681,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":682,"context_line":"    ADMIN_API \u003d True"},{"line_number":683,"context_line":"    sample_dir \u003d \u0027servers-sort\u0027"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def test_servers_list(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_79306ce9","line":682,"range":{"start_line":680,"start_character":0,"end_line":682,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"list should not require admin, response in both case is same for list server","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":677,"context_line":""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"class ServerSortKeysJsonTests(ServersSampleBase):"},{"line_number":680,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":681,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":682,"context_line":"    ADMIN_API \u003d True"},{"line_number":683,"context_line":"    sample_dir \u003d \u0027servers-sort\u0027"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def test_servers_list(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_844cac42","line":682,"range":{"start_line":680,"start_character":0,"end_line":682,"end_character":20},"in_reply_to":"9f560f44_79306ce9","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                 _ServersActionsJsonTestMixin):"},{"line_number":943,"context_line":"    \"\"\"Tests the createImage server action API against 2.1.\"\"\""},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":946,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":947,"context_line":"    ADMIN_API \u003d True"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def test_server_create_image(self):"},{"line_number":950,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_59400836","line":947,"range":{"start_line":945,"start_character":0,"end_line":947,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto, createImage is admin-or-owner APIs.","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                 _ServersActionsJsonTestMixin):"},{"line_number":943,"context_line":"    \"\"\"Tests the createImage server action API against 2.1.\"\"\""},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":946,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":947,"context_line":"    ADMIN_API \u003d True"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def test_server_create_image(self):"},{"line_number":950,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e40ac887","line":947,"range":{"start_line":945,"start_character":0,"end_line":947,"end_character":20},"in_reply_to":"9f560f44_59400836","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":973,"context_line":""},{"line_number":974,"context_line":"class ServerStartStopJsonTest(ServersSampleBase):"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":977,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":978,"context_line":"    ADMIN_API \u003d True"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    def _test_server_action(self, uuid, action, req_tpl):"},{"line_number":981,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_197050a5","line":978,"range":{"start_line":976,"start_character":0,"end_line":978,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto, start/stop are admin-or-owner.","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":973,"context_line":""},{"line_number":974,"context_line":"class ServerStartStopJsonTest(ServersSampleBase):"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":977,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":978,"context_line":"    ADMIN_API \u003d True"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    def _test_server_action(self, uuid, action, req_tpl):"},{"line_number":981,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_04089c8f","line":978,"range":{"start_line":976,"start_character":0,"end_line":978,"end_character":20},"in_reply_to":"9f560f44_197050a5","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"class ServersSampleMultiStatusJsonTest(ServersSampleBase):"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":1000,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":1001,"context_line":"    ADMIN_API \u003d True"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    def test_servers_list(self):"},{"line_number":1004,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_396434e5","line":1001,"range":{"start_line":998,"start_character":0,"end_line":1001,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":""},{"line_number":997,"context_line":"class ServersSampleMultiStatusJsonTest(ServersSampleBase):"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":1000,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":1001,"context_line":"    ADMIN_API \u003d True"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"    def test_servers_list(self):"},{"line_number":1004,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c4aa246f","line":1001,"range":{"start_line":998,"start_character":0,"end_line":1001,"end_character":20},"in_reply_to":"9f560f44_396434e5","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"65877b9674a00ee1404891100727a8a5eb8f185d","unresolved":false,"context_lines":[{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"class ServerTriggerCrashDumpJsonTest(ServersSampleBase):"},{"line_number":1011,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":1012,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":1013,"context_line":"    ADMIN_API \u003d True"},{"line_number":1014,"context_line":"    microversion \u003d \u00272.17\u0027"},{"line_number":1015,"context_line":"    scenarios \u003d [(\u0027v2_17\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9963c0dc","line":1013,"range":{"start_line":1011,"start_character":0,"end_line":1013,"end_character":20},"updated":"2020-08-19 22:47:31.000000000","message":"ditto","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c7d585cf69739680fe144d5c3a43c1a422351cd3","unresolved":false,"context_lines":[{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"class ServerTriggerCrashDumpJsonTest(ServersSampleBase):"},{"line_number":1011,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":1012,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":1013,"context_line":"    ADMIN_API \u003d True"},{"line_number":1014,"context_line":"    microversion \u003d \u00272.17\u0027"},{"line_number":1015,"context_line":"    scenarios \u003d [(\u0027v2_17\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":1016,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a4d3b000","line":1013,"range":{"start_line":1011,"start_character":0,"end_line":1013,"end_character":20},"in_reply_to":"9f560f44_9963c0dc","updated":"2020-08-25 09:42:53.000000000","message":"Done","commit_id":"fec585134cace39b8460ecc78bd173a8b950fa90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0d90f00304a4cb2a73519957ac747438369d330a","unresolved":false,"context_lines":[{"line_number":973,"context_line":""},{"line_number":974,"context_line":"class ServersSampleMultiStatusJsonTest(ServersSampleBase):"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":977,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":978,"context_line":"    ADMIN_API \u003d True"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    def test_servers_list(self):"},{"line_number":981,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ba38add4","line":978,"range":{"start_line":976,"start_character":0,"end_line":978,"end_character":20},"updated":"2020-08-27 21:58:47.000000000","message":"you forgot to remove this.","commit_id":"7b246df2773da3b03aaa2fcfa3d506af196e3841"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"91391200a1f484b9626de2637496abcf4cddfa08","unresolved":false,"context_lines":[{"line_number":973,"context_line":""},{"line_number":974,"context_line":"class ServersSampleMultiStatusJsonTest(ServersSampleBase):"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    # Many of the \u0027os_compute_api:servers:*\u0027 policies are admin-only, and we"},{"line_number":977,"context_line":"    # want to get admin-style (complete) responses even for those aren\u0027t"},{"line_number":978,"context_line":"    ADMIN_API \u003d True"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    def test_servers_list(self):"},{"line_number":981,"context_line":"        uuid \u003d self._post_server()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_26c92825","line":978,"range":{"start_line":976,"start_character":0,"end_line":978,"end_character":20},"in_reply_to":"9f560f44_ba38add4","updated":"2020-08-28 08:18:13.000000000","message":"Damn, sorry. Done","commit_id":"7b246df2773da3b03aaa2fcfa3d506af196e3841"}]}