)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab246a92da3127f2eb310e896b1dd93bbe2df16c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"source host(source host is different from dest host), Nova will timeout"},{"line_number":11,"context_line":"waiting for the vif-plugged external event, and never finish the revert."},{"line_number":12,"context_line":"This happens because Nova wait the vif-plugged external event which the"},{"line_number":13,"context_line":"vif status is inactive from the network info[2]. But the network_info is"},{"line_number":14,"context_line":"too old, although the vif status is inactive in network_info, actually"},{"line_number":15,"context_line":"it maybe active. If the vif status is active actually, Nova will"},{"line_number":16,"context_line":"timeout."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b9b877e5","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":47},"updated":"2020-08-17 13:40:03.000000000","message":"Did you forget to add this reference?","commit_id":"f69c8550772bb8bccfb808c34396ca1078abfb1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c11243c3060bc16c6870d0f6d22da517a6ac16b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"it maybe active. If the vif status is active actually, Nova will"},{"line_number":16,"context_line":"timeout."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So we should get the lasted network info before get events"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I5dd5d1021ec8d27d4cbb0385ae0a96d8b773ffdc"},{"line_number":21,"context_line":"Closes-bug: 1891420"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_546b4bb5","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":27},"updated":"2020-08-26 10:50:24.000000000","message":"update the","commit_id":"f69c8550772bb8bccfb808c34396ca1078abfb1e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c11243c3060bc16c6870d0f6d22da517a6ac16b","unresolved":false,"context_lines":[{"line_number":21982,"context_line":"                               mock_inject_data,"},{"line_number":21983,"context_line":"                               mock_alloc_mdevs,"},{"line_number":21984,"context_line":"                               power_on\u003dTrue, resize_instance\u003dFalse):"},{"line_number":21985,"context_line":"        \"\"\"Test for nova.virt.libvirt.libvirt_driver.LivirtConnection"},{"line_number":21986,"context_line":"        .finish_migration."},{"line_number":21987,"context_line":"        \"\"\""},{"line_number":21988,"context_line":"        self.flags(use_cow_images\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_946163d6","line":21985,"range":{"start_line":21985,"start_character":38,"end_line":21985,"end_character":52},"updated":"2020-08-26 10:50:24.000000000","message":"nit: while you\u0027re here, s/libvirt_driver/driver/","commit_id":"f69c8550772bb8bccfb808c34396ca1078abfb1e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ab246a92da3127f2eb310e896b1dd93bbe2df16c","unresolved":false,"context_lines":[{"line_number":10379,"context_line":"                                  instance.image_meta,"},{"line_number":10380,"context_line":"                                  block_device_info\u003dblock_device_info,"},{"line_number":10381,"context_line":"                                  mdevs\u003dmdevs)"},{"line_number":10382,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(context, instance)"},{"line_number":10383,"context_line":"        # NOTE(artom) In some Neutron or port configurations we\u0027ve already"},{"line_number":10384,"context_line":"        # waited for vif-plugged events in the compute manager\u0027s"},{"line_number":10385,"context_line":"        # _finish_revert_resize_network_migrate_finish(), right after updating"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_99a013a8","line":10382,"range":{"start_line":10382,"start_character":0,"end_line":10382,"end_character":79},"updated":"2020-08-17 13:40:03.000000000","message":"Shouldn\u0027t we do this in the compute layer and ensure the network_info provided to the driver is up to date?\n\nLater, looks like we are already doing this in the compute layer.\n\nhttps://github.com/openstack/nova/blob/4963069220ace20881497465b4976e865b6d7987/nova/compute/manager.py#L4964-L4982","commit_id":"f69c8550772bb8bccfb808c34396ca1078abfb1e"},{"author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"change_message_id":"3a0354b7521f488292350d7187a429d9249ee769","unresolved":false,"context_lines":[{"line_number":10379,"context_line":"                                  instance.image_meta,"},{"line_number":10380,"context_line":"                                  block_device_info\u003dblock_device_info,"},{"line_number":10381,"context_line":"                                  mdevs\u003dmdevs)"},{"line_number":10382,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(context, instance)"},{"line_number":10383,"context_line":"        # NOTE(artom) In some Neutron or port configurations we\u0027ve already"},{"line_number":10384,"context_line":"        # waited for vif-plugged events in the compute manager\u0027s"},{"line_number":10385,"context_line":"        # _finish_revert_resize_network_migrate_finish(), right after updating"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_56a0d791","line":10382,"range":{"start_line":10382,"start_character":0,"end_line":10382,"end_character":79},"in_reply_to":"9f560f44_54deab6c","updated":"2020-09-21 07:34:43.000000000","message":"yeah, we should call it in this.","commit_id":"f69c8550772bb8bccfb808c34396ca1078abfb1e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a8f553dd2f8542f797c832ee9f3f9656a74fab68","unresolved":false,"context_lines":[{"line_number":10379,"context_line":"                                  instance.image_meta,"},{"line_number":10380,"context_line":"                                  block_device_info\u003dblock_device_info,"},{"line_number":10381,"context_line":"                                  mdevs\u003dmdevs)"},{"line_number":10382,"context_line":"        network_info \u003d self.network_api.get_instance_nw_info(context, instance)"},{"line_number":10383,"context_line":"        # NOTE(artom) In some Neutron or port configurations we\u0027ve already"},{"line_number":10384,"context_line":"        # waited for vif-plugged events in the compute manager\u0027s"},{"line_number":10385,"context_line":"        # _finish_revert_resize_network_migrate_finish(), right after updating"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_54deab6c","line":10382,"range":{"start_line":10382,"start_character":0,"end_line":10382,"end_character":79},"in_reply_to":"9f560f44_99a013a8","updated":"2020-08-26 10:54:10.000000000","message":"Good spot. That call was added (or rather, moved there) in commit 9a6fd30d2d8 which is present since at least newton. Sounds like we\u0027ve a race.","commit_id":"f69c8550772bb8bccfb808c34396ca1078abfb1e"}]}