)]}'
{"id":"openstack%2Fnova~746527","triplet_id":"openstack%2Fnova~stable%2Fussuri~Ie0852a89fc9423a92baa7c29a8806c0628cae220","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1879787","hashtags":[],"change_id":"Ie0852a89fc9423a92baa7c29a8806c0628cae220","subject":"func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate","status":"MERGED","created":"2020-08-17 14:53:39.000000000","updated":"2020-09-10 18:52:54.000000000","submitted":"2020-09-10 18:52:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"746527-1599763974464-06ebbb73","meta_rev_id":"6eb34037cc6c6eae8981287cb6895b0a0262dbd2","_number":746527,"virtual_id_number":746527,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2020-08-17 16:12:54.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-10 18:52:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2020-09-10 17:47:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2020-09-10 15:47:42.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2020-09-10 17:47:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-17 16:12:54.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-09-10 15:47:42.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-09-10 17:47:00.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-09-10 18:52:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a76cfe8203d813463dae3ec10534dd74f564ee05","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-08-17 14:53:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b35b07f251cec59ab4e055939bbf531d5adf673","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-17 16:12:54.000000000","message":"Patch Set 1:\n\nBuild SUCCESSFUL (check pipeline).\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/27/746527/1/check/pmem-tempest-plugin-filtered-multi-node/dcfdb76/ : SUCCESS in 44m 51s","accounts_in_message":[],"_revision_number":1},{"id":"453c9901e8c466ea89165ee6202324f422a6a0e8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-17 17:27:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5135ba0a1e3c4a48ba7bb1d94ccde7b5 : SUCCESS in 18m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/858d0ae3556f460eae778338e5db24b0 : SUCCESS in 13m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/adb91e860d2a44f8a65611243a80b485 : SUCCESS in 6m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e119472505ff405e935c0aa836e0a092 : SUCCESS in 10m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f00cfd3592e44d61b912cf2c481f378e : SUCCESS in 12m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eb33acaca5ef4d78ad6c30279a3c856b : SUCCESS in 9m 38s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/1d90f90a47984246832e413addb3994d : SUCCESS in 12m 32s","accounts_in_message":[],"_revision_number":1},{"id":"52a8419ae9f95564ff36543b0ae6fa8d79ce7043","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-17 19:14:15.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM, this is technically my change so I\u0027m not going to +2 this but I do believe it\u0027s valid so wanted to vote.","accounts_in_message":[],"_revision_number":1},{"id":"ddb512054eb6627a6d16b3d0840de734bc6e61cb","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-08-20 08:04:20.000000000","message":"Topic set to bug/1879787","accounts_in_message":[],"_revision_number":1},{"id":"7808958bf68b583f314aacfd35b72d364e6644aa","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-10 15:47:42.000000000","message":"Patch Set 1: Code-Review+2\n\nThis isn\u0027t getting enough review attention so I\u0027m upgrading to +2","accounts_in_message":[],"_revision_number":1},{"id":"969461b3c0545bc463da6c2911dba967e2d30b7b","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-09-10 17:47:00.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean cherry pick of a test-only change that helps with the testing of the bugfix for bug/1879787. Also, merged in master. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"81e3c490871367a3d2a54e8835015160a38e3351","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-10 17:49:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cba386bf612b63e58c3640ca1e1d07a4fbf537a4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-10 18:52:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6cea25080b444643b7cd90f8bef6c6da : SUCCESS in 15m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/16a22fc950c34653a8d5368648986025 : SUCCESS in 8m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f05cfebefd8e44c2b69232a27b0d777a : SUCCESS in 14m 55s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/41f620ae8d624c14b255ded6f5ee4ad4 : SUCCESS in 14m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6acbfd1c155c496d9a33a0f9a898d1d1 : SUCCESS in 7m 51s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/5486ea409e0a48c09cd7e5a3afcc122e : SUCCESS in 21m 14s","accounts_in_message":[],"_revision_number":1},{"id":"6eb34037cc6c6eae8981287cb6895b0a0262dbd2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-10 18:52:54.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2b0cf8edf88c5f81696d72b04098aa12d1137e90","revisions":{"2b0cf8edf88c5f81696d72b04098aa12d1137e90":{"kind":"REWORK","_number":1,"created":"2020-08-17 14:53:39.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/27/746527/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/27/746527/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/27/746527/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/27/746527/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/27/746527/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/27/746527/1"}}},"commit":{"parents":[{"commit":"30ee639b6292b006bbbfe9843b17739c0b8441e7","subject":"[Trivial] Remove wrong format_message() conversion","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/30ee639b6292b006bbbfe9843b17739c0b8441e7"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-29 09:51:34.000000000","tz":60},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-08-17 14:46:55.000000000","tz":-240},"subject":"func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate","message":"func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate\n\nUseful when testing live migration failures that leave the server in an\nnon ACTIVE state. This change also renames the migration_final_status\narg to migration_expected_state within the method to keep it in line\nwith _create_server.\n\nNOTE(artom): This is to facilitate subsequent backports of live\nmigration regression tests and bug fixes.\n\nChange-Id: Ie0852a89fc9423a92baa7c29a8806c0628cae220\n(cherry picked from commit e70ddd621cb59a8845a4241387d8a49e443b7b69)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b0cf8edf88c5f81696d72b04098aa12d1137e90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b0cf8edf88c5f81696d72b04098aa12d1137e90"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}