)]}'
{"id":"openstack%2Fnova~746798","triplet_id":"openstack%2Fnova~stable%2Ftrain~I23ac1cc79482d0fabb359486a4b934463854cae5","project":"openstack/nova","branch":"stable/train","topic":"bug/1842149","hashtags":[],"change_id":"I23ac1cc79482d0fabb359486a4b934463854cae5","subject":"Allow TLS ciphers/protocols to be configurable for console proxies","status":"ABANDONED","created":"2020-08-18 21:06:34.000000000","updated":"2020-10-02 20:50:50.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b3d8cc2cee6406064475e8ad7d010c47cf3b9af4","_number":746798,"virtual_id_number":746798,"owner":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"date":"2020-08-18 23:38:59.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2020-08-19 00:03:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"date":"2020-08-18 21:25:07.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-08-18 23:37:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":-1,"date":"2020-08-18 22:39:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2020-08-18 21:06:34.000000000","_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-18 21:06:34.000000000","updated_by":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"reviewer":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"state":"REVIEWER"},{"updated":"2020-08-18 21:25:07.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-08-18 22:39:40.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2020-08-18 23:37:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-18 23:38:59.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-08-19 00:03:57.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"390d6c46861384072432610b88db8717a15c19e7","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2020-08-18 21:06:34.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"8ba4227345bfaee5af7f9fddf62b7872965d9b4d","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-08-18 21:25:07.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/98/746798/1/check/pmem-tempest-plugin-filtered-multi-node/5130ba2/ : RETRY_LIMIT in 5m 16s","accounts_in_message":[],"_revision_number":1},{"id":"e98c34ad4f258c0425b8c9f2d9965aeaa7d0fa4c","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-18 22:39:40.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nUnfortunately this is not something that we can backport to a stable branch upstream because of the increase in minimum required version.\n\nAs discussed on the original review on the master branch, the patch would have had to have been designed to tolerate the older version of websockify on the stable branch and have the code detect 0.9.0 and do the better thing if it\u0027s available and then bump the upper constraint on stable to 0.9.0.\n\nBut that was nack\u0027ed on the original review. So, at this point this patch would have to be modified for stable-only to do what I described ^ and it\u0027s not guaranteed that the rest of the stable team would agree about it.\n\nIf they do not, then this must be a downstream-only backport.\n\nSince this patch would allow users on stable releases to opt-in to enhanced security for the client \u003d\u003e console proxy communication, I would personally be OK with a stable-only modification for the backport + an upper constraint bump of websockify to openstack/requirements (looks like stable/train is already at 0.9.0 for the upper constraint but stable/stein and stable/queens are 0.8.0).\n\nWe will need to get consensus before proceeding with a stable-only modification approach.","accounts_in_message":[],"_revision_number":1},{"id":"ea8b11fbddc5cdc0375f45bfd4f5103c5e8fcbb6","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-08-18 22:41:37.000000000","message":"Topic changed from bug/1842149-stable/train to bug/1842149","accounts_in_message":[],"_revision_number":1},{"id":"a730a1ffde941ee9f34c0bda5031e550ffc81737","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 23:37:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/4ced847c50bb4a399cc8c0d4d6350d36 : SUCCESS in 4m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/300eb1346f954e9e9e6fae55168221c4 : SUCCESS in 56m 00s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/4e1d891c49cf46ee9828fbf133900c83 : SUCCESS in 1h 13m 36s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fdcee53e67b9477692bf5d58ef7f7ca9 : SUCCESS in 14m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d080498325a5461c8157e8335edc3e1a : SUCCESS in 17m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b2ae25450c94429845747a0181310cb : SUCCESS in 11m 47s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0013517b2ad841208c3ec1638080605a : SUCCESS in 9m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/50c9ff990a1347b68450d06133ece3e4 : SUCCESS in 12m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6245de60c5d64e1f85da1b1f8ef6ff1d : SUCCESS in 9m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7b904791d92a4b73819ff623176a0a49 : SUCCESS in 13m 14s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/393eff436e8f4dc7b8b8bf3770c9ea4d : SUCCESS in 15m 40s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d49121f0c41546328c1a3448424266ee : FAILURE in 1h 32m 48s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/aed0a1d84e2746b48177a311b754bacb : SUCCESS in 1h 16m 53s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/a6953ba74fab49a3a4183f79197085c0 : SUCCESS in 1h 13m 23s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/1615413b279948ea8a91b8f4da560adb : SUCCESS in 1h 07m 42s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6876ae89ec604c2d80bbe2f1c606f586 : SUCCESS in 52m 26s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/bb9450a09c204cf2987d14bb8a0bb07c : SUCCESS in 1h 25m 34s\n- nova-next https://zuul.opendev.org/t/openstack/build/b92e34f3f6404aaeacd6269e7bb93e24 : SUCCESS in 1h 13m 11s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/be4ca7d21e884379925db94e421a402d : SUCCESS in 20m 13s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6cf33463100a4f1aaf1d948ed7966088 : SUCCESS in 17m 43s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/f9c398f34dd5408695133f46a26aef7c : FAILURE in 2h 23m 55s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/8c66afe3066d4a948bb7c6b40282189c : SUCCESS in 59m 18s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f61e8a4006694990a2767cfcea2e58ac : SUCCESS in 56m 18s","accounts_in_message":[],"_revision_number":1},{"id":"ea982d1ca9b12df518ef874ea4e81925203de4ee","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-18 23:38:59.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/746798/1 : SUCCESS in 2h 31m 27s","accounts_in_message":[],"_revision_number":1},{"id":"584391a8467db0c63c0a11dcec39c1f7c0e2a041","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-19 00:03:57.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/98/746798/1/check/tempest-dsvm-full-bionic/b73a9b5/ : TIMED_OUT in 2h 36m 29s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/98/746798/1/check/tempest-dsvm-full-bionic-py3/bed3f35/ : SUCCESS in 1h 33m 32s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/98/746798/1/check/grenade-dsvm-bionic/49adf04/ : POST_FAILURE in 1h 26m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b3d8cc2cee6406064475e8ad7d010c47cf3b9af4","author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"date":"2020-10-02 20:50:50.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"25dda9ea76b6faa096a11ccf8f2a61020af607d0","revisions":{"25dda9ea76b6faa096a11ccf8f2a61020af607d0":{"kind":"REWORK","_number":1,"created":"2020-08-18 21:06:34.000000000","uploader":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"ref":"refs/changes/98/746798/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/98/746798/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/746798/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/746798/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/746798/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/98/746798/1"}}},"commit":{"parents":[{"commit":"2442344fa1afd8d0a4c58b4df35f1b896129a0a1","subject":"catch libvirt exception when nodedev not found.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2442344fa1afd8d0a4c58b4df35f1b896129a0a1"}]}],"author":{"name":"Nathan Kinder","email":"nkinder@redhat.com","date":"2019-08-30 19:24:03.000000000","tz":-420},"committer":{"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","date":"2020-08-18 21:06:34.000000000","tz":0},"subject":"Allow TLS ciphers/protocols to be configurable for console proxies","message":"Allow TLS ciphers/protocols to be configurable for console proxies\n\nThe console proxies (VNC, SPICE, etc) currently don\u0027t allow the\nallowed TLS ciphers and protocol versions to be configurable.  This\nresults in the defaults being used from the underlying system,\nwhich may not be secure enough for many deployments.  This patch\nallows for the ciphers and minimum SSL/TLS protocol version for\neach console proxy to be configured in nova\u0027s config.\n\nWe utilize websockify underneath our console proxies, which added\nsupport for allowed ciphers and the SSL/TLS version to be\nconfigurable as of version 0.9.0.  This change updates the lower\nconstraint for this dependency.\n\nCloses-Bug: #1842149\nRelated-Bug: #1771773\nChange-Id: I23ac1cc79482d0fabb359486a4b934463854cae5\n(cherry picked from commit 08bdcdb5b6866c2b6bf084344cca4dd07b960133)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/25dda9ea76b6faa096a11ccf8f2a61020af607d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/25dda9ea76b6faa096a11ccf8f2a61020af607d0"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}