)]}'
{"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25d71885241790a913cec08786d8efc1abe94c1f","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        port \u003d copy.deepcopy(port)"},{"line_number":356,"context_line":"        port.update(body[\u0027port\u0027])"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # the tenant ID is normally extracted from credentials in the request"},{"line_number":359,"context_line":"        # and is not present in the body"},{"line_number":360,"context_line":"        if \u0027tenant_id\u0027 not in port:"},{"line_number":361,"context_line":"            port[\u0027tenant_id\u0027] \u003d nova_fixtures.NeutronFixture.tenant_id"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3a24100d","line":359,"range":{"start_line":358,"start_character":0,"end_line":359,"end_character":40},"updated":"2020-09-07 12:42:51.000000000","message":"I think tenant_id is in the response body. openstackclient -f json does not list it but when I use --debug I see it in the response. Also it is documented in https://docs.openstack.org/api-ref/network/v2/?expanded\u003dshow-port-details-detail#ports\n\nOr do you mean that we should simulate to send back the tenant_id that was in the request?","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1c72c3363d2ea7ce2a1cba8faf0e6cbfd80481","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        port \u003d copy.deepcopy(port)"},{"line_number":356,"context_line":"        port.update(body[\u0027port\u0027])"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # the tenant ID is normally extracted from credentials in the request"},{"line_number":359,"context_line":"        # and is not present in the body"},{"line_number":360,"context_line":"        if \u0027tenant_id\u0027 not in port:"},{"line_number":361,"context_line":"            port[\u0027tenant_id\u0027] \u003d nova_fixtures.NeutronFixture.tenant_id"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3c0b6bd5","line":359,"range":{"start_line":358,"start_character":0,"end_line":359,"end_character":40},"in_reply_to":"9f560f44_3a24100d","updated":"2020-09-07 15:13:06.000000000","message":"I\u0027m referring to the *request* body. What I\u0027m saying (badly) here is that we\u0027ve got to include the \u0027tenant_id\u0027 in the response, and we can\u0027t simply take it from the body of the request.","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2730c0f347422603e0540ee285b8e5ff3b39c87e","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        port \u003d copy.deepcopy(port)"},{"line_number":356,"context_line":"        port.update(body[\u0027port\u0027])"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # the tenant ID is normally extracted from credentials in the request"},{"line_number":359,"context_line":"        # and is not present in the body"},{"line_number":360,"context_line":"        if \u0027tenant_id\u0027 not in port:"},{"line_number":361,"context_line":"            port[\u0027tenant_id\u0027] \u003d nova_fixtures.NeutronFixture.tenant_id"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_2576aba5","line":359,"range":{"start_line":358,"start_character":0,"end_line":359,"end_character":40},"in_reply_to":"9f560f44_3c0b6bd5","updated":"2020-09-08 08:00:30.000000000","message":"OK, got it","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25d71885241790a913cec08786d8efc1abe94c1f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            elem \u003d tree.find(\u0027./devices/interface/source/address\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            # compare address"},{"line_number":180,"context_line":"            expected \u003d (\u00270x81\u0027, \u00270x00\u0027, \u00270x2\u0027)"},{"line_number":181,"context_line":"            actual \u003d ("},{"line_number":182,"context_line":"                elem.get(\u0027bus\u0027), elem.get(\u0027slot\u0027), elem.get(\u0027function\u0027),"},{"line_number":183,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_5a55844f","line":180,"range":{"start_line":180,"start_character":22,"end_line":180,"end_character":46},"updated":"2020-09-07 12:42:51.000000000","message":"where these are coming form? if this is hardcode in a fixture somewhere then it would be nice to use the value from the fixture.","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1c72c3363d2ea7ce2a1cba8faf0e6cbfd80481","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            elem \u003d tree.find(\u0027./devices/interface/source/address\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"            # compare address"},{"line_number":180,"context_line":"            expected \u003d (\u00270x81\u0027, \u00270x00\u0027, \u00270x2\u0027)"},{"line_number":181,"context_line":"            actual \u003d ("},{"line_number":182,"context_line":"                elem.get(\u0027bus\u0027), elem.get(\u0027slot\u0027), elem.get(\u0027function\u0027),"},{"line_number":183,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_1c102700","line":180,"range":{"start_line":180,"start_character":22,"end_line":180,"end_character":46},"in_reply_to":"9f560f44_5a55844f","updated":"2020-09-07 15:13:06.000000000","message":"Yup, these are from the fakelibvirt fixture. I don\u0027t have any easy way to link to them though :-\\\n\n[1] https://github.com/openstack/nova/blob/662398a1a4bb69c11a08fa5fa7196a89ed1acc87/nova/tests/unit/virt/libvirt/fakelibvirt.py#L259","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"25d71885241790a913cec08786d8efc1abe94c1f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":223,"context_line":"            },"},{"line_number":224,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":225,"context_line":"        )"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def test_get_server_diagnostics_server_with_VF(self):"},{"line_number":228,"context_line":"        \"\"\"Ensure server disagnostics include info on VF-type PCI devices.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_3ad7f0c1","line":225,"updated":"2020-09-07 12:42:51.000000000","message":"You could assert that the pci device is claimed with assertPCIDeviceCounts()","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1c72c3363d2ea7ce2a1cba8faf0e6cbfd80481","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":223,"context_line":"            },"},{"line_number":224,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":225,"context_line":"        )"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def test_get_server_diagnostics_server_with_VF(self):"},{"line_number":228,"context_line":"        \"\"\"Ensure server disagnostics include info on VF-type PCI devices.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_9c1437eb","line":225,"in_reply_to":"9f560f44_3ad7f0c1","updated":"2020-09-07 15:13:06.000000000","message":"Good idea","commit_id":"e5eeb08537a8ea07c8dc5da01e21acd902c02973"}]}