)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3498da0b595dcf059f18c00510cb72a7ef4c8582","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-19 17:24:19 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8e349849db0b1a540d295c903f1470917b82fd97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b04cce9e","line":8,"updated":"2020-08-20 12:30:29.000000000","message":"can you add depens-on: https://review.opendev.org/#/c/747123 \nthat might fix some of the test failures.\napparently nova is still using bionic by default in most of its jobs so you need it since apparently its currently getting 4.0.0\n\nhttps://zuul.opendev.org/t/openstack/build/15e457ecc9f04636950c2da6d2188e5b/log/job-output.txt#9121\n\nit looks like the ubuntu cloud archive is not beeing used at all.","commit_id":"12234e54bb72caa80870820c8ca14167d53e6ce4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b2e8af6ddd3fccd270c9a83374801c15da71b6e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-19 17:24:19 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8e349849db0b1a540d295c903f1470917b82fd97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_9c30c158","line":8,"in_reply_to":"9f560f44_b04cce9e","updated":"2020-08-20 15:03:55.000000000","message":"you also need to add an upgrade release note to this patch\nto record the new minium version and tell operators","commit_id":"12234e54bb72caa80870820c8ca14167d53e6ce4"}],"nova/tests/functional/libvirt/test_vtpm.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"316f4a48fbc4026f97a8b7a741701156098d69b6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"FAKE_LIBVIRT_VERSION \u003d versionutils.convert_version_to_int("},{"line_number":39,"context_line":"    driver.MIN_LIBVIRT_VTPM)"},{"line_number":40,"context_line":"FAKE_QEMU_VERSION \u003d versionutils.convert_version_to_int(driver.MIN_QEMU_VTPM)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FakeKeyManager(key_manager.KeyManager):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_99f2a099","side":"PARENT","line":40,"range":{"start_line":38,"start_character":0,"end_line":40,"end_character":77},"updated":"2020-09-04 13:56:04.000000000","message":"Oh, this is unused hangover from an earlier vTPM patch revision /o\\ It\u0027s not entirely related but you could drop _both_ of these here.","commit_id":"6e3443d004146d1bb68e62a1e0fbb8c294f6c24f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d996f1cdc312611b235a0b4241fab66fc40e3bb8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"FAKE_LIBVIRT_VERSION \u003d versionutils.convert_version_to_int("},{"line_number":39,"context_line":"    driver.MIN_LIBVIRT_VTPM)"},{"line_number":40,"context_line":"FAKE_QEMU_VERSION \u003d versionutils.convert_version_to_int(driver.MIN_QEMU_VTPM)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class FakeKeyManager(key_manager.KeyManager):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_8227b212","side":"PARENT","line":40,"range":{"start_line":38,"start_character":0,"end_line":40,"end_character":77},"in_reply_to":"9f560f44_99f2a099","updated":"2020-09-08 08:03:47.000000000","message":"Done","commit_id":"6e3443d004146d1bb68e62a1e0fbb8c294f6c24f"}],"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79c2e5f044ffdb67a1c2f60691ea1d92dc6d4391","unresolved":false,"context_lines":[{"line_number":179,"context_line":"VIR_SECRET_USAGE_TYPE_ISCSI \u003d 3"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"# Libvirt version to match MIN_LIBVIRT_VERSION in driver.py"},{"line_number":182,"context_line":"FAKE_LIBVIRT_VERSION \u003d 5000000"},{"line_number":183,"context_line":"# Libvirt version to match MIN_QEMU_VERSION in driver.py"},{"line_number":184,"context_line":"FAKE_QEMU_VERSION \u003d 4000000"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b0f04e69","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":30},"updated":"2020-08-20 12:23:23.000000000","message":"why do we do this difreently here by the way\n\nwe should either just use \n\nFAKE_LIBVIRT_VERSION \u003d versionutils.convert_version_to_int(\n            libvirt_driver.MIN_LIBVIRT_VERSION)\n\nor we shoudl proably just use the tuples instead of an int","commit_id":"12234e54bb72caa80870820c8ca14167d53e6ce4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79c2e5f044ffdb67a1c2f60691ea1d92dc6d4391","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# Libvirt version to match MIN_LIBVIRT_VERSION in driver.py"},{"line_number":182,"context_line":"FAKE_LIBVIRT_VERSION \u003d 5000000"},{"line_number":183,"context_line":"# Libvirt version to match MIN_QEMU_VERSION in driver.py"},{"line_number":184,"context_line":"FAKE_QEMU_VERSION \u003d 4000000"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"PCI_VEND_ID \u003d \u00278086\u0027"},{"line_number":187,"context_line":"PCI_VEND_NAME \u003d \u0027Intel Corporation\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b095eee6","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":27},"updated":"2020-08-20 12:23:23.000000000","message":"same just do \nFAKE_QEMU_VERSION \u003d versionutils.convert_version_to_int(\n            libvirt_driver.MIN_QEMU_VERSION)","commit_id":"12234e54bb72caa80870820c8ca14167d53e6ce4"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79c2e5f044ffdb67a1c2f60691ea1d92dc6d4391","unresolved":false,"context_lines":[{"line_number":218,"context_line":"# versions. Over time, this will become a common min version"},{"line_number":219,"context_line":"# for all architectures/hypervisors, as this value rises to"},{"line_number":220,"context_line":"# meet them."},{"line_number":221,"context_line":"MIN_LIBVIRT_VERSION \u003d (5, 0, 0)"},{"line_number":222,"context_line":"MIN_QEMU_VERSION \u003d (4, 0, 0)"},{"line_number":223,"context_line":"# TODO(berrange): Re-evaluate this at start of each release cycle"},{"line_number":224,"context_line":"# to decide if we want to plan a future min version bump."},{"line_number":225,"context_line":"# MIN_LIBVIRT_VERSION can be updated to match this after"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3089dec9","line":222,"range":{"start_line":221,"start_character":0,"end_line":222,"end_character":28},"updated":"2020-08-20 12:23:23.000000000","message":"yep these were the announced version from ussuri","commit_id":"12234e54bb72caa80870820c8ca14167d53e6ce4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"79c2e5f044ffdb67a1c2f60691ea1d92dc6d4391","unresolved":false,"context_lines":[{"line_number":225,"context_line":"# MIN_LIBVIRT_VERSION can be updated to match this after"},{"line_number":226,"context_line":"# NEXT_MIN_LIBVIRT_VERSION  has been at a higher value for"},{"line_number":227,"context_line":"# one cycle"},{"line_number":228,"context_line":"NEXT_MIN_LIBVIRT_VERSION \u003d (6, 0, 0)"},{"line_number":229,"context_line":"NEXT_MIN_QEMU_VERSION \u003d (4, 2, 0)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"# Virtuozzo driver support"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_708fd6cc","line":229,"range":{"start_line":228,"start_character":0,"end_line":229,"end_character":33},"updated":"2020-08-20 12:23:23.000000000","message":"and i think this also is a good candiate set for wallaby","commit_id":"12234e54bb72caa80870820c8ca14167d53e6ce4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"316f4a48fbc4026f97a8b7a741701156098d69b6","unresolved":false,"context_lines":[{"line_number":785,"context_line":"                \"\u0027kvm\u0027; found %s.\")"},{"line_number":786,"context_line":"            raise exception.InvalidConfiguration(msg % CONF.libvirt.virt_type)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        if not self._host.has_min_version("},{"line_number":789,"context_line":"            lv_ver\u003dMIN_LIBVIRT_VTPM,"},{"line_number":790,"context_line":"        ):"},{"line_number":791,"context_line":"            msg \u003d _("},{"line_number":792,"context_line":"                \u0027vTPM support requires QEMU version %(qemu)s or greater and \u0027"},{"line_number":793,"context_line":"                \u0027Libvirt version %(libvirt)s or greater.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b92cc401","line":790,"range":{"start_line":788,"start_character":0,"end_line":790,"end_character":10},"updated":"2020-09-04 13:56:04.000000000","message":"nit: this could fit on one line now","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d996f1cdc312611b235a0b4241fab66fc40e3bb8","unresolved":false,"context_lines":[{"line_number":785,"context_line":"                \"\u0027kvm\u0027; found %s.\")"},{"line_number":786,"context_line":"            raise exception.InvalidConfiguration(msg % CONF.libvirt.virt_type)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        if not self._host.has_min_version("},{"line_number":789,"context_line":"            lv_ver\u003dMIN_LIBVIRT_VTPM,"},{"line_number":790,"context_line":"        ):"},{"line_number":791,"context_line":"            msg \u003d _("},{"line_number":792,"context_line":"                \u0027vTPM support requires QEMU version %(qemu)s or greater and \u0027"},{"line_number":793,"context_line":"                \u0027Libvirt version %(libvirt)s or greater.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_427f5ade","line":790,"range":{"start_line":788,"start_character":0,"end_line":790,"end_character":10},"in_reply_to":"9f560f44_b92cc401","updated":"2020-09-08 08:03:47.000000000","message":"Done","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"316f4a48fbc4026f97a8b7a741701156098d69b6","unresolved":false,"context_lines":[{"line_number":789,"context_line":"            lv_ver\u003dMIN_LIBVIRT_VTPM,"},{"line_number":790,"context_line":"        ):"},{"line_number":791,"context_line":"            msg \u003d _("},{"line_number":792,"context_line":"                \u0027vTPM support requires QEMU version %(qemu)s or greater and \u0027"},{"line_number":793,"context_line":"                \u0027Libvirt version %(libvirt)s or greater.\u0027)"},{"line_number":794,"context_line":"            raise exception.InvalidConfiguration(msg % {"},{"line_number":795,"context_line":"                \u0027libvirt\u0027: libvirt_utils.version_to_string(MIN_LIBVIRT_VTPM),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_1934d049","line":792,"range":{"start_line":792,"start_character":39,"end_line":792,"end_character":76},"updated":"2020-09-04 13:56:04.000000000","message":"drop this","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d996f1cdc312611b235a0b4241fab66fc40e3bb8","unresolved":false,"context_lines":[{"line_number":789,"context_line":"            lv_ver\u003dMIN_LIBVIRT_VTPM,"},{"line_number":790,"context_line":"        ):"},{"line_number":791,"context_line":"            msg \u003d _("},{"line_number":792,"context_line":"                \u0027vTPM support requires QEMU version %(qemu)s or greater and \u0027"},{"line_number":793,"context_line":"                \u0027Libvirt version %(libvirt)s or greater.\u0027)"},{"line_number":794,"context_line":"            raise exception.InvalidConfiguration(msg % {"},{"line_number":795,"context_line":"                \u0027libvirt\u0027: libvirt_utils.version_to_string(MIN_LIBVIRT_VTPM),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_2284e6d2","line":792,"range":{"start_line":792,"start_character":39,"end_line":792,"end_character":76},"in_reply_to":"9f560f44_1934d049","updated":"2020-09-08 08:03:47.000000000","message":"Done","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"}],"releasenotes/notes/victoria-libvirt-version-bump-e1a09b3a72ee56a4.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"316f4a48fbc4026f97a8b7a741701156098d69b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  The libvirt virt driver now requires as a minimum QEMU ``4.0.0`` and libvirt"},{"line_number":5,"context_line":"  ``v5.0.0``. These minimums will be increased again during the next"},{"line_number":6,"context_line":"  development cycle (Wallaby) to QEMU ``4.2.0`` and libvirt ``v6.0.0``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f9363c51","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"updated":"2020-09-04 13:56:04.000000000","message":"Needs two more spaces.","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d996f1cdc312611b235a0b4241fab66fc40e3bb8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  The libvirt virt driver now requires as a minimum QEMU ``4.0.0`` and libvirt"},{"line_number":5,"context_line":"  ``v5.0.0``. These minimums will be increased again during the next"},{"line_number":6,"context_line":"  development cycle (Wallaby) to QEMU ``4.2.0`` and libvirt ``v6.0.0``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_4258fa88","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":2},"in_reply_to":"9f560f44_f9363c51","updated":"2020-09-08 08:03:47.000000000","message":"Done","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"316f4a48fbc4026f97a8b7a741701156098d69b6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  The libvirt virt driver now requires as a minimum QEMU ``4.0.0`` and libvirt"},{"line_number":5,"context_line":"  ``v5.0.0``. These minimums will be increased again during the next"},{"line_number":6,"context_line":"  development cycle (Wallaby) to QEMU ``4.2.0`` and libvirt ``v6.0.0``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_994740bd","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":5},"updated":"2020-09-04 13:56:04.000000000","message":"I assume this difference is based on how libvirt and QEMU do their git tagging? If not, maybe use/don\u0027t use v for both?","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d996f1cdc312611b235a0b4241fab66fc40e3bb8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  The libvirt virt driver now requires as a minimum QEMU ``4.0.0`` and libvirt"},{"line_number":5,"context_line":"  ``v5.0.0``. These minimums will be increased again during the next"},{"line_number":6,"context_line":"  development cycle (Wallaby) to QEMU ``4.2.0`` and libvirt ``v6.0.0``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_e2666e51","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":5},"in_reply_to":"9f560f44_994740bd","updated":"2020-09-08 08:03:47.000000000","message":"Done","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"316f4a48fbc4026f97a8b7a741701156098d69b6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  The libvirt virt driver now requires as a minimum QEMU ``4.0.0`` and libvirt"},{"line_number":5,"context_line":"  ``v5.0.0``. These minimums will be increased again during the next"},{"line_number":6,"context_line":"  development cycle (Wallaby) to QEMU ``4.2.0`` and libvirt ``v6.0.0``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f9a0fc44","line":6,"range":{"start_line":5,"start_character":14,"end_line":6,"end_character":71},"updated":"2020-09-04 13:56:04.000000000","message":"I\u0027d back away from making such guarantees, tbh, as we haven\u0027t been great at bumping this stuff in the past /o\\ How about copying the text from past release notes for Pike [1] and Rocky [2] (we didn\u0027t include release notes for the Stein [3] or Ussuri [4] bumps and forgot to bump it in Queens and Train).\n\n  The minimum required version of libvirt used by the `nova-compute`\n  service is now 5.0.0. The minimum required version of QEMU used by the\n  `nova-compute` service is now 4.0.0. Failing to meet these minimum versions\n  when using the libvirt compute driver will result in the `nova-compute`\n  service not starting.\n\n[1] releasenotes/notes/pike-libvirt-min-version-bb7f43020995ac10.yaml\n[2] releasenotes/notes/rocky-libvirt-qemu-min-versions-56412048c12f1f52.yaml\n[3] Ia18e9be4d07b732afd9db0007c541253f3cdaf82\n[4] I408baef12358a83921c4693b847a692f6c19e36f","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"d996f1cdc312611b235a0b4241fab66fc40e3bb8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"  The libvirt virt driver now requires as a minimum QEMU ``4.0.0`` and libvirt"},{"line_number":5,"context_line":"  ``v5.0.0``. These minimums will be increased again during the next"},{"line_number":6,"context_line":"  development cycle (Wallaby) to QEMU ``4.2.0`` and libvirt ``v6.0.0``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_0262823e","line":6,"range":{"start_line":5,"start_character":14,"end_line":6,"end_character":71},"in_reply_to":"9f560f44_f9a0fc44","updated":"2020-09-08 08:03:47.000000000","message":"Done","commit_id":"627a5d90a38cde368c97ef2db06b1bfbbe6d9e0c"}]}