)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8396c132cb5e14acafd79fb775259855a9e7abd8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"API allows a port to be bound to two hosts (source and destination),"},{"line_number":19,"context_line":"with the binding being active on only one. Not all versions and"},{"line_number":20,"context_line":"configurations of Neutron support the extended port binding API, so"},{"line_number":21,"context_line":"Nova needed a sentinel to determine whether the extened port binding"},{"line_number":22,"context_line":"API was in use during a live migration. The migrate_data.vifs OVO"},{"line_number":23,"context_line":"field was that sentinel [2]. Its presence indicated that Neutron\u0027s"},{"line_number":24,"context_line":"extended port binding API was being used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_17a42b4a","line":21,"range":{"start_line":21,"start_character":48,"end_line":21,"end_character":55},"updated":"2020-08-26 18:41:11.000000000","message":"extended","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9552567d989b0b775fc517362873823fbd1bc965","unresolved":false,"context_lines":[{"line_number":18,"context_line":"API allows a port to be bound to two hosts (source and destination),"},{"line_number":19,"context_line":"with the binding being active on only one. Not all versions and"},{"line_number":20,"context_line":"configurations of Neutron support the extended port binding API, so"},{"line_number":21,"context_line":"Nova needed a sentinel to determine whether the extened port binding"},{"line_number":22,"context_line":"API was in use during a live migration. The migrate_data.vifs OVO"},{"line_number":23,"context_line":"field was that sentinel [2]. Its presence indicated that Neutron\u0027s"},{"line_number":24,"context_line":"extended port binding API was being used."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_c28f4173","line":21,"range":{"start_line":21,"start_character":48,"end_line":21,"end_character":55},"in_reply_to":"9f560f44_17a42b4a","updated":"2020-09-01 21:11:53.000000000","message":"Done","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8396c132cb5e14acafd79fb775259855a9e7abd8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"with the binding being active on only one. Not all versions and"},{"line_number":20,"context_line":"configurations of Neutron support the extended port binding API, so"},{"line_number":21,"context_line":"Nova needed a sentinel to determine whether the extened port binding"},{"line_number":22,"context_line":"API was in use during a live migration. The migrate_data.vifs OVO"},{"line_number":23,"context_line":"field was that sentinel [2]. Its presence indicated that Neutron\u0027s"},{"line_number":24,"context_line":"extended port binding API was being used."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_377e8fae","line":22,"range":{"start_line":22,"start_character":44,"end_line":22,"end_character":61},"updated":"2020-08-26 18:41:11.000000000","message":"super nit: surrounding these with quotes makes it easier distinguish (at least for me)","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9552567d989b0b775fc517362873823fbd1bc965","unresolved":false,"context_lines":[{"line_number":19,"context_line":"with the binding being active on only one. Not all versions and"},{"line_number":20,"context_line":"configurations of Neutron support the extended port binding API, so"},{"line_number":21,"context_line":"Nova needed a sentinel to determine whether the extened port binding"},{"line_number":22,"context_line":"API was in use during a live migration. The migrate_data.vifs OVO"},{"line_number":23,"context_line":"field was that sentinel [2]. Its presence indicated that Neutron\u0027s"},{"line_number":24,"context_line":"extended port binding API was being used."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_022c9948","line":22,"range":{"start_line":22,"start_character":44,"end_line":22,"end_character":61},"in_reply_to":"9f560f44_377e8fae","updated":"2020-09-01 21:11:53.000000000","message":"Done","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8396c132cb5e14acafd79fb775259855a9e7abd8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"extended port binding API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"How is any of this relevant to the fix for bug 1879787, which is"},{"line_number":41,"context_line":"what\u0027s being reverted here? First, come context refresher."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In bug 1879787, the call to network_api.get_instance_nw_info() in"},{"line_number":44,"context_line":"_post_live_migration() on the source compute manager eventually calls"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_976ddb04","line":41,"range":{"start_line":41,"start_character":35,"end_line":41,"end_character":39},"updated":"2020-08-26 18:41:11.000000000","message":"some?","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9552567d989b0b775fc517362873823fbd1bc965","unresolved":false,"context_lines":[{"line_number":38,"context_line":"extended port binding API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"How is any of this relevant to the fix for bug 1879787, which is"},{"line_number":41,"context_line":"what\u0027s being reverted here? First, come context refresher."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"In bug 1879787, the call to network_api.get_instance_nw_info() in"},{"line_number":44,"context_line":"_post_live_migration() on the source compute manager eventually calls"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_4226916a","line":41,"range":{"start_line":41,"start_character":35,"end_line":41,"end_character":39},"in_reply_to":"9f560f44_976ddb04","updated":"2020-09-01 21:11:53.000000000","message":"Done","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8396c132cb5e14acafd79fb775259855a9e7abd8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"post_live_migration_at_destination()."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The network_info variable obtained from get_instance_nw_info() is used"},{"line_number":52,"context_line":"for 2 things: notifications - which aren\u0027t critical - and unplugging"},{"line_number":53,"context_line":"the instance\u0027s vifs on the source - which is very important!"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"The latter is done in a call to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_774da798","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":5},"updated":"2020-08-26 18:41:11.000000000","message":"two","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8396c132cb5e14acafd79fb775259855a9e7abd8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"[1] https://review.opendev.org/#/c/522537/"},{"line_number":65,"context_line":"[2] https://review.opendev.org/#/c/522537/35/nova/conductor/tasks/live_migrate.py@255"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[3] https://review.opendev.org/#/c/620115/"},{"line_number":68,"context_line":"[4] https://review.opendev.org/#/c/620115/35/nova/compute/manager.py@6227"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_72620340","line":66,"updated":"2020-08-26 18:41:11.000000000","message":"your editor is inserting newline rather than wrapping, ima guess","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9552567d989b0b775fc517362873823fbd1bc965","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"[1] https://review.opendev.org/#/c/522537/"},{"line_number":65,"context_line":"[2] https://review.opendev.org/#/c/522537/35/nova/conductor/tasks/live_migrate.py@255"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[3] https://review.opendev.org/#/c/620115/"},{"line_number":68,"context_line":"[4] https://review.opendev.org/#/c/620115/35/nova/compute/manager.py@6227"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_82926957","line":66,"in_reply_to":"9f560f44_72620340","updated":"2020-09-01 21:11:53.000000000","message":"Yeah - not yours?","commit_id":"809fe7f4f58c4af6cad1eb6b2b0626a117139a53"}]}
