)]}'
{"id":"openstack%2Fnova~748251","triplet_id":"openstack%2Fnova~stable%2Fussuri~I87cd4d14192b1a40cbdca6e3af0f818f2cab613e","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1889633","hashtags":[],"change_id":"I87cd4d14192b1a40cbdca6e3af0f818f2cab613e","subject":"tests: Add reproducer for bug #1889633","status":"MERGED","created":"2020-08-26 14:54:30.000000000","updated":"2020-08-28 03:36:43.000000000","submitted":"2020-08-28 03:34:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748251-1598585695738-1d2acb16","meta_rev_id":"fe37ffcd551946d2453c02dea16560e4f1461c0a","_number":748251,"virtual_id_number":748251,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-08-26 15:20:36.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-28 03:34:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2020-08-27 16:28:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2020-08-26 15:08:36.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2020-08-27 16:28:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-26 15:08:36.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-08-26 15:20:36.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-08-27 16:28:17.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-08-28 03:34:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"74d3cfff15fd00532098bb6ae15166108f93380d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-08-26 14:54:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de5e8d1086a0678c04ab81bf63a7dee4bab9c5f7","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-26 15:08:36.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, clean, merged in master and required by the following bugfix.","accounts_in_message":[],"_revision_number":1},{"id":"7a60239559bb18eb0692afb04531d92a05ebe484","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-26 15:20:36.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748251/1 : FAILURE in 24m 34s","accounts_in_message":[],"_revision_number":1},{"id":"9f849d4538071ed5c9b49339384c3793c5a0637e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-26 20:25:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7c75f5bf24e34b5d91fc80dbd89fe136 : SUCCESS in 28m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ead40c34f8024bf7aab2e5b55008d6dc : SUCCESS in 26m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4fa727fef7ef4584a4d7c1fb091821ee : SUCCESS in 10m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e40b987fe00e47eca7ea2ebffdaf1a77 : SUCCESS in 24m 34s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/22f74d8912c446b6a13f680d67afb704 : SUCCESS in 13m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fd1fadb91f474bb59b1f4c2098203de7 : SUCCESS in 12m 02s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/86f9e879819648abb900ede968b7b391 : SUCCESS in 17m 56s","accounts_in_message":[],"_revision_number":1},{"id":"fc68852e9ae6f2290ef655c0fd156fc0948df02d","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-08-27 16:28:17.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean cherry pick of a test-only change, proposed together with a bugfix, and merged on master. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"92b8b3716bd9c1308f1b90166cc4b67cdd0939f1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 19:40:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cb773fe377086ac46d5a719f59a176344f7c28d3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-28 03:34:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a1329f897b6844e68d8795321e895662 : SUCCESS in 16m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4cf5d9ab276742cfad0e0b8803ec9da4 : SUCCESS in 10m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c3edfa8529c04e9088d347348d0cf13f : SUCCESS in 14m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8b8b6c030709478bb3549924577f4b11 : SUCCESS in 13m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4192bc0cd5e84e82bfe9f8c042055540 : SUCCESS in 11m 14s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f10dac38d6c74f938feebee2631eb972 : SUCCESS in 19m 34s","accounts_in_message":[],"_revision_number":1},{"id":"e3f5d75ef60795ef7acf5ebc4e426e93a8410abc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-28 03:34:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b7c9cd3878217fa04d6a0623deb2f550839f7c11","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-28 03:36:43.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/697bdc2943d747989a3ec857cc42c0fd : SUCCESS in 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"49a793c8ee7a9be26e4e3d6ddd097a6ee6fea29d","revisions":{"49a793c8ee7a9be26e4e3d6ddd097a6ee6fea29d":{"kind":"REWORK","_number":1,"created":"2020-08-26 14:54:30.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/51/748251/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/51/748251/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/748251/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/748251/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/51/748251/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/51/748251/1"}}},"commit":{"parents":[{"commit":"87b7c6685c8fa745a2999c00c8e136a82c9fa486","subject":"Merge \"compute: Do not allow rescue attempts using volume snapshot images\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/87b7c6685c8fa745a2999c00c8e136a82c9fa486"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-07-30 16:37:38.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-26 14:45:43.000000000","tz":60},"subject":"tests: Add reproducer for bug #1889633","message":"tests: Add reproducer for bug #1889633\n\nWith the introduction of the cpu-resources work [1], (libvirt) hosts can\nnow report \u0027PCPU\u0027 inventory separate from \u0027VCPU\u0027 inventory, which is\nconsumed by instances with pinned CPUs (\u0027hw:cpu_policy\u003ddedicated\u0027). As\npart of that effort, we had to drop support for the ability to boot\ninstances with \u0027hw:cpu_thread_policy\u003disolate\u0027 (i.e. I don\u0027t want\nhyperthreads) on hosts with hyperthreading. This had been previously\nimplemented by marking thread siblings of the host cores used by such an\ninstance as reserved and unusable by other instances, but such a design\nwasn\u0027t possible in world where we had to track resource consumption in\nplacement before landing in the host. Instead, the \u0027isolate\u0027 policy now\nsimply means \"give me a host without hyperthreads\". This is enforced by\nhosts with hyperthreads reporting the \u0027HW_CPU_HYPERTHREADING\u0027 trait, and\ninstances with the \u0027isolate\u0027 policy requesting\n\u0027HW_CPU_HYPERTHREADING\u003dforbidden\u0027.\n\nOr at least, that\u0027s how it should work. We also have a fallback query\nfor placement to find hosts with \u0027VCPU\u0027 inventory and that doesn\u0027t care\nabout the \u0027HW_CPU_HYPERTHREADING\u0027 trait. This was envisioned to ensure\nhosts with old style configuration (\u0027[DEFAULT] vcpu_pin_set\u0027) could\ncontinue to be scheduled to. We figured that this second fallback query\ncould accidentally pick up hosts with new-style configuration, but we\nare also tracking the available and used cores from those listed in the\n\u0027[compute] cpu_dedicated_set\u0027 as part of the host \u0027NUMATopology\u0027 objects\n(specifically, via the \u0027pcpuset\u0027 and \u0027cpu_pinning\u0027 fields of the\n\u0027NUMACell\u0027 child objects). These are validated by both the\n\u0027NUMATopologyFilter\u0027 and the virt driver itself, which means hosts with\nnew style configuration that got caught up in this second query would be\nrejected by this filter or by a late failure on the host. (Hint: there\u0027s\nmuch more detail on this in the spec).\n\nUnfortunately we didn\u0027t think about hyperthreading. If a host gets\npicked up in the second request, it might well have enough PCPU\ninventory but simply be rejected in the first query since it had\nhyperthreads. In this case, because it has enough free cores available\nfor pinning, neither the filter nor the virt driver will reject the\nrequest, resulting in a situation whereby the instance ends up falling\nback to the old code paths and consuming $flavor.vcpu host cores, plus\nthe thread siblings for each of these cores. Despite this, it will be\nmarked as consuming $flavor.vcpu VCPU (not PCPU) inventory in placement.\n\nThis patch proves this to be the case, allowing us to resolve the issue\nlater.\n\n[1] https://specs.openstack.org/openstack/nova-specs/specs/train/approved/cpu-resources.html\n\nChange-Id: I87cd4d14192b1a40cbdca6e3af0f818f2cab613e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nRelated-Bug: #1889633\n(cherry picked from commit 737e0c0111acd364d1481bdabd9d23bc8d5d6a2e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/49a793c8ee7a9be26e4e3d6ddd097a6ee6fea29d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/49a793c8ee7a9be26e4e3d6ddd097a6ee6fea29d"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}