)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4ea38e6759717a1a154e8833dfd07831895b12e3","unresolved":false,"context_lines":[{"line_number":10427,"context_line":"                                  instance.image_meta,"},{"line_number":10428,"context_line":"                                  block_device_info\u003dblock_device_info,"},{"line_number":10429,"context_line":"                                  mdevs\u003dmdevs)"},{"line_number":10430,"context_line":""},{"line_number":10431,"context_line":"        # NOTE(sean-k-mooney): we do not tear down the source networking"},{"line_number":10432,"context_line":"        # until the end of confirm resize when it calls"},{"line_number":10433,"context_line":"        # driver.confrim_migration which unplugs them as part of"},{"line_number":10434,"context_line":"        # _cleanup_resize. So the vifs should still be plugged at this point,"},{"line_number":10435,"context_line":"        # as such we always pass vifs_already_plugged for reverts."},{"line_number":10436,"context_line":"        self._create_guest_with_network("},{"line_number":10437,"context_line":"            context, xml, instance, network_info, block_device_info,"},{"line_number":10438,"context_line":"            power_on\u003dpower_on, vifs_already_plugged\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3952fede","line":10435,"range":{"start_line":10430,"start_character":0,"end_line":10435,"end_character":66},"updated":"2020-08-27 01:38:42.000000000","message":"... no this is not right\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5589-L5593\n\n\nwe do\n\n   disk_info \u003d self.driver.migrate_disk_and_power_off(\n                    context, instance, migration.dest_host,\n                    instance_type, network_info,\n                    block_device_info,\n                    timeout, retry_interval)\n\nin  _resize_instance\n\nso we power off the vm on the source node instead of pausing it\n\npower off will unplug the vifs\n\nso we wont rebind the port on revert but we will re-plug the ports on revert.\n\nso the issue is like that neutron is not sending the vif when we expect it too.","commit_id":"2f81f8e4bafc8214709d638a9f54edba4078bc23"}]}