)]}'
{"id":"openstack%2Fnova~748496","triplet_id":"openstack%2Fnova~stable%2Ftrain~I9edb36c4df1cc0d8b529e669f06540de71766085","project":"openstack/nova","branch":"stable/train","topic":"bug/1889108","hashtags":[],"change_id":"I9edb36c4df1cc0d8b529e669f06540de71766085","subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","status":"MERGED","created":"2020-08-27 17:32:04.000000000","updated":"2020-09-03 01:30:53.000000000","submitted":"2020-09-03 01:27:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748496-1599096438903-b29784c5","meta_rev_id":"b4f52c43652d27e55d4ae3cb87b48b29645c5ea8","_number":748496,"virtual_id_number":748496,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-03 01:27:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2020-08-28 02:21:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-27 19:35:49.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-27 19:40:04.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-02 10:01:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":2,"date":"2020-09-02 17:05:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":1,"date":"2020-09-02 17:05:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-27 19:35:49.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-27 19:40:04.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-08-28 02:21:48.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-02 10:01:01.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2020-09-02 17:05:12.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-09-03 01:27:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a23724d18c414cdda46d9616a910dae6a3e19148","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-27 17:32:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ccd0b29fff69b4340c881930fff09fdb012bae4a","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-27 18:00:06.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/748496/1/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/7274ea1 : FAILURE in 26m 47s","accounts_in_message":[],"_revision_number":1},{"id":"b9d9456dd8a6d7008f483d3b65f26647d4127f83","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-27 18:04:17.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748496/1 : FAILURE in 28m 23s","accounts_in_message":[],"_revision_number":1},{"id":"571a630bff59b63ee83daddb2339baa2d18a48ac","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-27 19:07:47.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"deb09a100bb52aed6c94513f56754ac98e1f12af","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-27 19:35:49.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/748496/2/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/7966120 : FAILURE in 26m 48s","accounts_in_message":[],"_revision_number":2},{"id":"225d48e1a22f9eae7cdff74459f6ad06443b2ac8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-27 19:40:04.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748496/2 : FAILURE in 28m 17s","accounts_in_message":[],"_revision_number":2},{"id":"eaf8b183b39bcd0f97b30cf317632ee879f14d9d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 21:20:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/a58b43c232ba4a9e8de6ec5029a76bed : SUCCESS in 1h 10m 53s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/02ec19e648c34d099401b1c7dc1efcc6 : SUCCESS in 1h 14m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/13dd19f5df4b4419b60cd2eabd3f2d0d : SUCCESS in 16m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bb96780c05ac441897d6a5d07694b6e0 : SUCCESS in 16m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/11215cb8eaf94144b25ba38ec6c10ad6 : SUCCESS in 9m 59s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/adef4bbdaec64e4b8ad8870d6106abbe : SUCCESS in 17m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1780c0db7fc64a48b3bf673063074e77 : SUCCESS in 12m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b4ffc5f60b784e7a9969ec5ec37d8dc8 : SUCCESS in 13m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0e800fcee57b47fe91c69ccb2d402835 : SUCCESS in 10m 07s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2c411e11ee7a4ac5b76c174b1186230f : SUCCESS in 1h 19m 24s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/8dede7fd4bec484da9d3abc5b552508d : SUCCESS in 1h 12m 23s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/c97305cd6fd4418a85e4b1e3d4abf942 : SUCCESS in 1h 11m 47s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/1ef217e76c664b888b4ba21203777ef3 : SUCCESS in 1h 08m 20s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4b801332edd646818e651b666f1f8f03 : SUCCESS in 49m 23s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/79a4fe13a1954355b0c5c0ead63cd720 : SUCCESS in 1h 19m 28s\n- nova-next https://zuul.opendev.org/t/openstack/build/98d88be1ff8c4d73adb82606aa5856ad : SUCCESS in 1h 14m 30s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/4767bd8995ee4bc9b890f0ee0eb6dc91 : SUCCESS in 20m 40s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/eac3721c209341a6bf417b3753403dfe : SUCCESS in 17m 06s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/d1b2cebc361d4b7bb0008a3ef1eb3b02 : SUCCESS in 2h 03m 47s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/326f4aaed85d4dbe8dbd9421b6ac6251 : SUCCESS in 1h 00m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6f5328d8909c4196876d667b1e7ead39 : SUCCESS in 55m 45s","accounts_in_message":[],"_revision_number":2},{"id":"7c56e02a7cea84564ff1bb6017d9d80b913afa60","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-28 02:21:48.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/96/748496/2/check/tempest-dsvm-full-bionic/c20a7bc/ : TIMED_OUT in 2h 38m 12s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/96/748496/2/check/tempest-dsvm-full-bionic-py3/d2b105c/ : SUCCESS in 1h 51m 58s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/96/748496/2/check/grenade-dsvm-bionic/f70e26a/ : POST_FAILURE in 1h 28m 38s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9a2cba669a2e0e410e644c0512499865ab181523","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2020-09-02 10:01:01.000000000","message":"Patch Set 2: Code-Review+2\n\nEasy backport to review, coming straight from Ussuri.","accounts_in_message":[],"_revision_number":2},{"id":"bb523a2b24390cf83519d21dd35861a84797268c","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-09-02 17:05:12.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nClean backport from Ussuri. Looks OK with the two other patches.","accounts_in_message":[],"_revision_number":2},{"id":"4028dbc1073e5727a201c90d55bbbae36f1dba43","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 17:06:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b48620c58f1eb218809a5cae6c96538c49b9ce46","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 01:27:18.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/162807ad119948e7b7bcb785ca6bbfcd : SUCCESS in 58m 50s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0f4a747f30ad41dab1a6c0e916b12d35 : SUCCESS in 1h 19m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d752568c31a04a12b68affc758118364 : SUCCESS in 15m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5478621558974f3da347d1126915a8f4 : SUCCESS in 12m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4f965e51a3a543058e6426d4dced0a13 : SUCCESS in 13m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cd2963e3377b466e8a20064e2c51c5bb : SUCCESS in 13m 39s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2d2fb526caaa4d28a2148ce95bb18830 : SUCCESS in 15m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae667f7b9a4d47cfbe4a13ed7dbd07e0 : SUCCESS in 11m 39s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/532321e968694217be7e82e2d4c8b55c : SUCCESS in 1h 09m 46s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/858d74aa48ff4b38b20130ac10484116 : SUCCESS in 51m 07s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/5fe67148096e4539964628608e062e7d : SUCCESS in 20m 23s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/bb936078587f4a49b4f5a345d7899ee6 : SUCCESS in 19m 19s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/6b26e4479a884ce6a0e1351c26332772 : SUCCESS in 1h 25m 19s\n- nova-next https://zuul.opendev.org/t/openstack/build/0ee37df60b474515bc3b6748c71de519 : SUCCESS in 1h 46m 40s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/ad2cb7297f864a23b0cb132eb5b55c7e : SUCCESS in 1h 59m 54s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/4d186917444c4790ad480be1929f4fbe : SUCCESS in 1h 05m 55s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8b83b07e6cdc408ca280ec4f667417b4 : SUCCESS in 1h 33m 26s","accounts_in_message":[],"_revision_number":2},{"id":"9468127780601f5c5cf654a13e65cc263324ecc1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 01:27:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5501ff5d1e787a5f3c81ea8c712a9c689b417e7a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 01:30:53.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d666b9c3a3445f8bb48a8404611f5e8 : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c6c3483a41c2a53bcfafdfe3475283b0379f7f1d","revisions":{"fa707a508220c76dba87a62dd0fc0eac302d859e":{"kind":"REWORK","_number":1,"created":"2020-08-27 17:32:04.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/96/748496/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/96/748496/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/748496/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/748496/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/748496/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/96/748496/1"}}},"commit":{"parents":[{"commit":"4569cb9071cdb3a12a65f8e59c51d8053a268463","subject":"compute: refactor volume bdm rollback error handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4569cb9071cdb3a12a65f8e59c51d8053a268463"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-27 18:27:24.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-08-27 17:31:10.000000000","tz":60},"subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","message":"compute: Don\u0027t delete the original attachment during pre LM rollback\n\nI0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live\nmigration with cinderv3 volume attachments during Queens. This initial\nsupport handled failures in pre_live_migration directly by removing any\nattachments created on the destination and reverting to the original\nattachment ids before re-raising the caught exception to the source\ncompute. It also added rollback code within the main\n_rollback_live_migration method but missed that this would also be\ncalled during a pre_live_migration rollback.\n\nAs a result after a failure in pre_live_migration\n_rollback_live_migration will attempt to delete the source host volume\nattachments referenced by the bdm before updating the bdms with the now\nnon-existent attachment ids, leaving the volumes in an `available` state\nin Cinder as they have no attachment records associated with them\nanymore.\n\nThis change aims to resolve this within _rollback_volume_bdms by\nensuring that the current and original attachment_ids are not equal\nbefore requesting that the current attachment referenced by the bdm is\ndeleted. When called after a failure in pre_live_migration this should\nresult in no attempt being made to remove the original source host\nattachments from Cinder.\n\nNote that the following changes muddy the waters slightly here but\nintroduced no actual changes to the logic within\n_rollback_live_migration:\n\n* I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error\n  handling in Rocky but isn\u0027t the source of the issue here.\n\n* Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked\n  _rollback_live_migration to use the provided source_bdms.\n\n* I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored\n  _rollback_live_migration, moving the logic into a self contained\n  _rollback_volume_bdms method.\n\nCloses-Bug: #1889108\nChange-Id: I9edb36c4df1cc0d8b529e669f06540de71766085\n(cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)\n(cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa707a508220c76dba87a62dd0fc0eac302d859e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa707a508220c76dba87a62dd0fc0eac302d859e"}]},"branch":"refs/heads/stable/train"},"c6c3483a41c2a53bcfafdfe3475283b0379f7f1d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-08-27 19:07:47.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/96/748496/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/96/748496/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/748496/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/748496/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/96/748496/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/96/748496/2"}}},"commit":{"parents":[{"commit":"377dc5bda9369e50c0c4a893564fc218b4b31fb1","subject":"compute: refactor volume bdm rollback error handling","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/377dc5bda9369e50c0c4a893564fc218b4b31fb1"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-27 18:27:24.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-08-27 19:07:02.000000000","tz":60},"subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","message":"compute: Don\u0027t delete the original attachment during pre LM rollback\n\nI0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live\nmigration with cinderv3 volume attachments during Queens. This initial\nsupport handled failures in pre_live_migration directly by removing any\nattachments created on the destination and reverting to the original\nattachment ids before re-raising the caught exception to the source\ncompute. It also added rollback code within the main\n_rollback_live_migration method but missed that this would also be\ncalled during a pre_live_migration rollback.\n\nAs a result after a failure in pre_live_migration\n_rollback_live_migration will attempt to delete the source host volume\nattachments referenced by the bdm before updating the bdms with the now\nnon-existent attachment ids, leaving the volumes in an `available` state\nin Cinder as they have no attachment records associated with them\nanymore.\n\nThis change aims to resolve this within _rollback_volume_bdms by\nensuring that the current and original attachment_ids are not equal\nbefore requesting that the current attachment referenced by the bdm is\ndeleted. When called after a failure in pre_live_migration this should\nresult in no attempt being made to remove the original source host\nattachments from Cinder.\n\nNote that the following changes muddy the waters slightly here but\nintroduced no actual changes to the logic within\n_rollback_live_migration:\n\n* I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error\n  handling in Rocky but isn\u0027t the source of the issue here.\n\n* Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked\n  _rollback_live_migration to use the provided source_bdms.\n\n* I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored\n  _rollback_live_migration, moving the logic into a self contained\n  _rollback_volume_bdms method.\n\nCloses-Bug: #1889108\nChange-Id: I9edb36c4df1cc0d8b529e669f06540de71766085\n(cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)\n(cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6c3483a41c2a53bcfafdfe3475283b0379f7f1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c6c3483a41c2a53bcfafdfe3475283b0379f7f1d"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}