)]}'
{"id":"openstack%2Fnova~748509","triplet_id":"openstack%2Fnova~stable%2Fstein~If6a36d23768877bfa820ed44b610bfb113df5464","project":"openstack/nova","branch":"stable/stein","topic":"bug/1889108","hashtags":[],"change_id":"If6a36d23768877bfa820ed44b610bfb113df5464","subject":"Improve CinderFixtureNewAttachFlow","status":"MERGED","created":"2020-08-27 18:39:05.000000000","updated":"2020-09-04 22:06:29.000000000","submitted":"2020-09-04 22:04:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748509-1599257045883-941d6ed0","meta_rev_id":"21e906743461bd45e37d41a1cd535a0d55fa56f8","_number":748509,"virtual_id_number":748509,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2020-09-01 19:51:54.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2020-09-01 19:40:25.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-04 22:04:05.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2020-09-04 21:00:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2020-09-04 10:07:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2020-09-04 21:00:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2020-08-27 18:39:05.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-27 18:39:05.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2020-09-01 19:51:54.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-09-04 10:07:03.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-09-04 21:00:48.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2020-09-04 22:04:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"14443f262e2b6a51b50c21b3284827d877978e64","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-27 18:39:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"62f456f22c0c74885a529fd151837805f45179d2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-27 18:49:14.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748509/1 : FAILURE in 8m 56s","accounts_in_message":[],"_revision_number":1},{"id":"adb5f7e20ec20982d82dd03fa6a7c34de0294a5b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 19:04:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8e38e69808724549ae60be915c80c13c : SUCCESS in 15m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4654a186353f462ebe5ce4071ac0b133 : SUCCESS in 13m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b59fafb2cc6b4a26b6cf3c8769ebc6c0 : SUCCESS in 10m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5f6de81abc3c45488f7d406a35b3c31e : SUCCESS in 14m 49s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/f91418ddf19544d9a5631843b968b1f3 : SUCCESS in 22m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/27026bd235544034bb9027b4a894eb33 : SUCCESS in 15m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/68260619e6be4330b18227e6c7fcba80 : SUCCESS in 22m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/818927faa0c3476da2b4758f9bb8dde5 : SUCCESS in 11m 01s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/43ddf01c50d34eeeb3e4b26e1a828c2f : SUCCESS in 19m 42s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/fec087ee910c4da2857bdbb61de51b15 : SUCCESS in 17m 21s","accounts_in_message":[],"_revision_number":1},{"id":"0745800bd7a182ed915768650f1782a02e4a1b2d","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-01 19:40:25.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e68f3776714c902d9ef78f45f8a13922a0f9bf37","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-01 19:51:54.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748509/1 : FAILURE in 10m 38s","accounts_in_message":[],"_revision_number":1},{"id":"a5476fe1d5d77562462cd547dd4eabd4596f3f81","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-01 20:37:36.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/750098225d6f40a98f25d7c8dce98dc0 : SUCCESS in 15m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/359551147f0e457fa75d5fa4d5d385d9 : SUCCESS in 14m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/35a6911259c74bb4898ff85ae3c3a1cd : SUCCESS in 8m 51s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1cd2989fab014ca0817eed5bc038669e : SUCCESS in 11m 48s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1bd149e7f571471db66862cffd6e2fe5 : SUCCESS in 20m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d149b37c93ca49c1946f6da6c0ecdb6d : SUCCESS in 11m 50s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0ea38a55e80b42ab81d5a1cdfbbbcfd6 : SUCCESS in 12m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1b2d941f1ae44a28af7926e0cc4770ad : SUCCESS in 9m 36s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/e8e79942c0c645219c08d3feda657085 : SUCCESS in 20m 38s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/06d00f41bafd4ee897d2d28113952b81 : SUCCESS in 18m 39s","accounts_in_message":[],"_revision_number":1},{"id":"b28739908c1c091798907677b1f255dd075c66e3","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-09-04 10:07:03.000000000","message":"Patch Set 1: Code-Review+2\n\nThis and the patch on top of this were not part of the bugfix originally, but as I\u0027ve discussed with Lee on IRC, these are helping the proper testing of the fix for bug/1889108.\n\nNevertheless, the patch is a clean backport of a test-only patch, that was merged in Train (master at that time). LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"1395ac501d3f9abdd0bdfe143e4a20dc6fef8650","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-09-04 21:00:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport of a test fixture improvement that originally landed in train, LGTM. Nice to have enhanced testing available on stable, will also support future bug fix backports if needed","accounts_in_message":[],"_revision_number":1},{"id":"189dc3dc01194a49baeb8404ec21083a6da3c7f7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 21:01:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"bd167acd997d91b885351bded90f46682acd8018","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 22:04:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fabe54bca058bf1594829d426563dc90d0f69258","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 22:04:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/efc6839180354fafb4b27d6b84ceba25 : SUCCESS in 19m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/449de62336ce453db65615545bfff40c : SUCCESS in 12m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/eca864e0cb5c4379bc333e0aead77f03 : SUCCESS in 25m 46s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c6156510c0cc44d3b3f1a6174b1a92fc : SUCCESS in 26m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5e984adec3494b6292c97930ac9b4ee9 : SUCCESS in 23m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e090a50e3ec8413697769e19a5b1df2b : SUCCESS in 26m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/177848780e2f4b298a992b826b446b58 : SUCCESS in 8m 32s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/b02f6c7d23ea453284eb8b9c79707ebb : SUCCESS in 31m 02s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/01b6838eee804a03adc0537950457abd : SUCCESS in 31m 18s","accounts_in_message":[],"_revision_number":1},{"id":"43e4128610b5d35e703f73806e879d7e8bca3073","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 22:06:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/65afbc5dd4c345c9bc16d23fa13cf1fc : SUCCESS in 1m 16s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f81d1a5ce400e756836497d26ea5bd5f7c7c14a9","revisions":{"f81d1a5ce400e756836497d26ea5bd5f7c7c14a9":{"kind":"REWORK","_number":1,"created":"2020-08-27 18:39:05.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/09/748509/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/09/748509/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/748509/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/748509/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/09/748509/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/09/748509/1"}}},"commit":{"parents":[{"commit":"042dc4f2706cf845996ee0bb359be3345fa54863","subject":"Merge \"Should not skip volume_size check for bdm.image_id \u003d\u003d image_ref case\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/042dc4f2706cf845996ee0bb359be3345fa54863"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-02-25 23:52:41.000000000","tz":-300},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-08-27 18:30:45.000000000","tz":60},"subject":"Improve CinderFixtureNewAttachFlow","message":"Improve CinderFixtureNewAttachFlow\n\nThis does three things:\n\n1. Implements the attachment_complete method in order to\n   fail if code is trying to complete an attachment that\n   does not exist.\n\n2. Adds logging in the various attachment CRUD methods to\n   aid in debugging test failures.\n\n3. Mirrors the method signature for is_microversion_supported\n   to make sure code is at least calling it properly.\n\nChange-Id: If6a36d23768877bfa820ed44b610bfb113df5464\n(cherry picked from commit 576a4e5260c4bc813474dead4eec19bd2a1cc680)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f81d1a5ce400e756836497d26ea5bd5f7c7c14a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f81d1a5ce400e756836497d26ea5bd5f7c7c14a9"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}