)]}'
{"id":"openstack%2Fnova~748510","triplet_id":"openstack%2Fnova~stable%2Fstein~I369f82245465e96fc15d4fc71a79a8a71f6f2c6d","project":"openstack/nova","branch":"stable/stein","topic":"bug/1889108","hashtags":[],"change_id":"I369f82245465e96fc15d4fc71a79a8a71f6f2c6d","subject":"Robustify attachment tracking in CinderFixtureNewAttachFlow","status":"MERGED","created":"2020-08-27 18:39:05.000000000","updated":"2020-09-04 22:07:48.000000000","submitted":"2020-09-04 22:04:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748510-1599257051245-42a114cc","meta_rev_id":"10db3d942906b1caed4d20b306affa66149eb94e","_number":748510,"virtual_id_number":748510,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2020-08-27 18:50:30.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-04 22:04:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2020-09-04 20:58:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2020-09-04 10:09:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2020-09-04 20:58:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2020-08-27 18:39:05.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-27 18:39:05.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2020-08-27 18:50:30.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-09-04 10:09:21.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-09-04 20:58:36.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2020-09-04 22:04:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f602a394fcaa05cb7651a43d849a97a4dde533be","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-27 18:39:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"950232d15cdc1e10f0f591631bce35f97c321da9","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-27 18:50:30.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748510/1 : FAILURE in 9m 10s","accounts_in_message":[],"_revision_number":1},{"id":"ddea5449cae2b570a2111425683f489e0e46d0ac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 19:05:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f940628246c84d8d85a2496418d28c1f : SUCCESS in 24m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3dceefef47424e3c95025cff0b2650e5 : SUCCESS in 22m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/131e3c45065f4315a0a6641ba2ac3e41 : SUCCESS in 10m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fcddc181e4f54519a0829ac6ea3391e1 : SUCCESS in 20m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/5ef8914c816041f49c751e4dad2bc3ec : SUCCESS in 14m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b3acd8d5719140b8b8dd1a1b6ec32b7d : SUCCESS in 21m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/06f9b47041c94ecd9ae3d4f7df665121 : SUCCESS in 12m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/483bc5d9d0d44353b992b82789867918 : SUCCESS in 8m 52s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/16c97a3e550b4c26a6a208683aa4798e : SUCCESS in 18m 38s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/1c03e3b2c89f404e84f770f93e953194 : SUCCESS in 18m 19s","accounts_in_message":[],"_revision_number":1},{"id":"cc27c0995cc95125efd8a6513d9b39d0ee5ec3af","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-09-04 10:09:21.000000000","message":"Patch Set 1: Code-Review+2\n\nSimilarly like the parent patch, this was not part of the bugfix originally, but as I\u0027ve discussed with Lee on IRC, these are helping the proper testing of the fix for bug/1889108.\n\nThe patch is a clean backport of a test-only patch, that was merged in Train (master at that time). LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"707c09940f20aef3d1c84792fcb0089caee1f535","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-09-04 20:58:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport of a refactor that originally landed in train. Helps in the backport of the bug fix at the end of the series and is anyway nice to have a more accurate fixture for testing on the stable branch","accounts_in_message":[],"_revision_number":1},{"id":"838be53b43f296e9ec21e359e1604669e87b8867","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 21:01:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8b278953c957aaafe22f69370fc748fdc66cd8f9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 22:04:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fd65e81d59e24fb99b81b821d61159eb : SUCCESS in 16m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c82aab5da3644da3b6b26b709c50e04e : SUCCESS in 13m 56s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0857d555a7854b9bb737f2617fbed2b9 : SUCCESS in 24m 58s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/b6b4130a4f484039a96cf4753b5eeeee : SUCCESS in 26m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6bc2430362214f5fa90b35f7e955cf87 : SUCCESS in 22m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5b2a489df0e64c3e8e143a96df03badd : SUCCESS in 24m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa2417aa61564568b77753e1819763f4 : SUCCESS in 9m 16s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/464784a6997543de83a6f7570d931cce : SUCCESS in 26m 44s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/c03975a95aa245b1b449b326a42a080d : SUCCESS in 27m 18s","accounts_in_message":[],"_revision_number":1},{"id":"9359d4264bf5fd36bdae01b476dceaf628ed2e10","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 22:04:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"39f12d0003947a950cbab9e69af0d9c2454b75c4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 22:07:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8fa33836c2974f659a71e2769c528d1f : SUCCESS in 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1e1bbdc4cdd0104c214134ef964e8621eab3de9c","revisions":{"1e1bbdc4cdd0104c214134ef964e8621eab3de9c":{"kind":"REWORK","_number":1,"created":"2020-08-27 18:39:05.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/10/748510/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/10/748510/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/748510/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/748510/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/10/748510/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/10/748510/1"}}},"commit":{"parents":[{"commit":"f81d1a5ce400e756836497d26ea5bd5f7c7c14a9","subject":"Improve CinderFixtureNewAttachFlow","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f81d1a5ce400e756836497d26ea5bd5f7c7c14a9"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-13 18:42:25.000000000","tz":-240},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-08-27 18:30:45.000000000","tz":60},"subject":"Robustify attachment tracking in CinderFixtureNewAttachFlow","message":"Robustify attachment tracking in CinderFixtureNewAttachFlow\n\nCinder allows more than one attachment record on a non-multiattach\nvolume as long as only one attachment is \"connected\" (has a host\nconnector).\n\nWhen you create an empty (no connector) attachment for an in-use\nvolume, the volume status changes to \"attaching\". If you try to\nupdate the empty attachment before deleting the previous attachment,\nCinder will return a 400 like:\n\n  Invalid volume: Volume b2aba195-6570-40c4-82bb-46d3557fceeb status\n  must be available or downloading to reserve, but the current status\n  is attaching.\n\nThis change refactors the attachment tracking in the\nCinderFixtureNewAttachFlow fixture to be able to track the connector\nper attachment and if code tries to update an attachment on an\nalready connected volume it will fail.\n\nChange-Id: I369f82245465e96fc15d4fc71a79a8a71f6f2c6d\n(cherry picked from commit 1d3ca5a3a07fdfff0d61ac11c390dfd4acab23d7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1e1bbdc4cdd0104c214134ef964e8621eab3de9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1e1bbdc4cdd0104c214134ef964e8621eab3de9c"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}