)]}'
{"id":"openstack%2Fnova~748514","triplet_id":"openstack%2Fnova~stable%2Fstein~I9edb36c4df1cc0d8b529e669f06540de71766085","project":"openstack/nova","branch":"stable/stein","topic":"bug/1889108","hashtags":[],"change_id":"I9edb36c4df1cc0d8b529e669f06540de71766085","subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","status":"MERGED","created":"2020-08-27 18:39:05.000000000","updated":"2020-09-04 23:36:21.000000000","submitted":"2020-09-04 23:33:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748514-1599262406840-87da3b05","meta_rev_id":"3834a7c0aeaa3cbdaa3e1210e8569a4d121b11a3","_number":748514,"virtual_id_number":748514,"owner":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2020-09-04 10:59:08.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2020-09-04 13:43:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2020-09-04 11:05:37.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-04 23:33:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":2,"date":"2020-09-04 20:44:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-04 10:44:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":1,"date":"2020-09-04 20:44:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-27 19:38:00.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-04 10:44:44.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2020-09-04 10:59:08.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-09-04 11:05:37.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-09-04 13:43:20.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-04 20:44:08.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2020-09-04 23:33:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e21ed51b7b7592035dfc67e858b43219aa96e56d","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-27 18:39:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28d130ab2017882e977838bccde287d1924473cd","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-27 19:00:32.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748514/1 : FAILURE in 9m 38s","accounts_in_message":[],"_revision_number":1},{"id":"b3f79e976ec00c8b2f8ee0d90bd9cc4f8029368a","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-27 19:07:33.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/748514/1/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/389e644 : FAILURE in 25m 13s","accounts_in_message":[],"_revision_number":1},{"id":"a0faaa4ca284c606a55f4a181dee05200219eeb8","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-08-27 19:11:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2e48857048b3c9f1f2343725e177b7b385199546","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-08-27 19:28:38.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748514/2 : FAILURE in 10m 18s","accounts_in_message":[],"_revision_number":2},{"id":"2cd6c5db45d5ee9c01c7fd6921c38ea34b02a0c1","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-08-27 19:38:00.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/748514/2/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/d9297f5 : FAILURE in 24m 47s","accounts_in_message":[],"_revision_number":2},{"id":"6ab010bcf85df0d8c756b2c22a55f5da89c19e50","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-27 21:37:07.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2df8649e83014bfabc81a15e46013fad : SUCCESS in 1h 15m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e3cd83cf9d884981a2e51423c42ee47b : SUCCESS in 33m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c1c244ea9e1f4446bad422f093e1959d : SUCCESS in 11m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b61ead2a2a047d78eb84481ad603535 : FAILURE in 10m 10s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/428b245f3ed14d98855a21370b624b77 : SUCCESS in 13m 12s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a5e1168447b947ec8c96c1340292933d : SUCCESS in 25m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b59d1c4b3c9742c9b70c6eedb28467c2 : SUCCESS in 12m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/84e1458142da4d2ba4c37c6f965e060b : SUCCESS in 12m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ce60f3d0facb4473a973b2e8f7b86c50 : SUCCESS in 13m 03s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ba0af1ca1b8f466bace0776ec59ee9ac : SUCCESS in 49m 41s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/df38b71b8bc84e5db9eccfae8af8fee1 : SUCCESS in 1h 15m 55s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/9263462a19594b9f8d7bbaa1b65fdf93 : SUCCESS in 1h 27m 53s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/55f49f6de1564a95b428d2efed2740dd : SUCCESS in 1h 31m 28s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/78df64936d0340ffa786a35201d49b03 : SUCCESS in 43m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/cb584c5519b54e7796f0454757942bf8 : SUCCESS in 1h 09m 50s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/17520d0522b54694bc09f822b1611d44 : SUCCESS in 18m 32s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/29fdaa44bb3b4875a413c173d1af3aba : SUCCESS in 17m 18s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/8222ff1915b04b80b64f85e6442305ab : SUCCESS in 1h 34m 01s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/9a1d100783dc41739a7831b945d43698 : SUCCESS in 2h 19m 42s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/ca2219755dc34471a17eef9f69158f10 : SUCCESS in 1h 04m 41s","accounts_in_message":[],"_revision_number":2},{"id":"c2c2f7777cc1c428f12d0637f8b26784bd03f81b","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-08-28 02:42:10.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/2/check/tempest-dsvm-full-bionic/ffb2efe/ : TIMED_OUT in 2h 39m 14s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/2/check/tempest-dsvm-full-bionic-py3/92d32a5/ : SUCCESS in 1h 44m 56s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/2/check/grenade-dsvm-bionic/727a2fd/ : POST_FAILURE in 1h 37m 55s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d5245539f5af713a7fda7ed1c73429c23d156e02","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-03 14:03:21.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"ea3015879a45169a6863edce785d9eb244baa9cc","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-03 14:22:55.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748514/2 : FAILURE in 11m 03s","accounts_in_message":[],"_revision_number":2},{"id":"08b0ace8b6d29ffa27c484dc59769364b5421b87","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-09-03 15:26:29.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/14/748514/2/check/pmem-tempest-plugin-filtered-multi-node/6f47b15/ : RETRY_LIMIT in 5m 25s\n- devstack-networking-ovs-dpdk http://52.27.155.124/14/748514/2/check/devstack-networking-ovs-dpdk/026af23/ : RETRY_LIMIT in 1m 50s","accounts_in_message":[],"_revision_number":2},{"id":"0e07bdf4b8c8acb5d437401ca69d3d4489bd4d95","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 17:15:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e116b988f4274f3994e0a8d7a8c96969 : SUCCESS in 1h 15m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dd4ca23cbb68424c85e8a6d44d149e49 : SUCCESS in 15m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/730b7101fa22402a9d3d5a414dd8cbd6 : SUCCESS in 16m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/20138ceff0a8459b8cb194e03ae097d6 : SUCCESS in 11m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/9706697c37d84e33bd84600d1e7c6f22 : SUCCESS in 11m 10s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a6377c4064c8493397853d9a72aa829c : SUCCESS in 10m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0441751a784e44db9e85fdbefc14a4aa : SUCCESS in 9m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/85dd5476c2fb465ab552dd41c980a929 : SUCCESS in 12m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c23c388b686d4ff4a0a2613fd5438cf3 : SUCCESS in 9m 52s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/072dbb52cf7940379a6ec9184b186dec : SUCCESS in 52m 06s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/b8af067c645c4a2aacb5f5d71cb42d9c : SUCCESS in 1h 33m 32s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/59b544b579b0485ab5cfa61cdb56eae2 : SUCCESS in 1h 08m 54s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/fcd780b67b75493a814f2c37fb67e2b7 : SUCCESS in 1h 14m 11s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/c5913d0dc983420dbf0c69a23c976301 : SUCCESS in 50m 15s\n- nova-next https://zuul.opendev.org/t/openstack/build/2134e24288f14360adac46cabbe3f570 : SUCCESS in 1h 07m 50s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/64600d18eef44ba491b93f7427dd3fcb : SUCCESS in 19m 13s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/221d662c7408475e9a29b60df75b78d3 : SUCCESS in 22m 26s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/d291acecf21442e09b90ce96d41e05cc : SUCCESS in 1h 41m 05s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/f26b44da322f4238b69a3a7e75817b17 : SUCCESS in 1h 55m 45s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d54ac0babd9342318155dc3e9ebebbfc : SUCCESS in 1h 01m 01s","accounts_in_message":[],"_revision_number":2},{"id":"d5fb6070675461ae89295151eae45a6427bcec81","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-09-03 17:56:49.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"157988a15c2cff360a6d4ddce07024fad1c1160e","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-03 18:22:16.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748514/3 : FAILURE in 10m 00s","accounts_in_message":[],"_revision_number":3},{"id":"a4fab8ad35bf14fcdefce9761d84f104de2c7fb5","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-09-03 18:25:57.000000000","message":"Patch Set 3:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/14/748514/3/check/pmem-tempest-plugin-filtered-multi-node/b4af5cf/ : RETRY_LIMIT in 5m 08s\n- devstack-networking-ovs-dpdk http://52.27.155.124/14/748514/3/check/devstack-networking-ovs-dpdk/8980ee9/ : RETRY_LIMIT in 1m 31s","accounts_in_message":[],"_revision_number":3},{"id":"0681e808a759bb9841be1463a6fa8d24ee8ec991","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 21:34:59.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c0b19bc004964021b51a45b3b6f1fc17 : SUCCESS in 1h 18m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/630e070c367e4b2e8a03524646201755 : SUCCESS in 17m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/15e0ec7d69fb49a982673e5835430ea0 : SUCCESS in 11m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e002882b6b3c454f82c4260cea454185 : SUCCESS in 10m 35s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ac5aca86e0c9465cb6c6d189f9c52fd0 : SUCCESS in 13m 54s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9d449a6ea4b94f41ade90b9d6f757f4e : SUCCESS in 12m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/63de06aab42e45cb9740758c0631218f : SUCCESS in 13m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7238e4b808474c0ba0758e37f1aaff7a : SUCCESS in 14m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/27988a7a2cfb46b78855e088205c57cc : SUCCESS in 8m 24s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7bff7f478cd94e20b2ad5a651156d07c : SUCCESS in 47m 46s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/31673abec08a4808923b8841d29f47d9 : SUCCESS in 1h 02m 22s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/d88de069690249feaa93c17903f96657 : SUCCESS in 1h 04m 20s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/1c10a4f1eee74a8db986a96e99da1b77 : SUCCESS in 1h 01m 30s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/05cc51cf01764183b18542ee79c9fe41 : SUCCESS in 46m 22s\n- nova-next https://zuul.opendev.org/t/openstack/build/3bacb9daa04144b58740cef86946a488 : SUCCESS in 1h 08m 51s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/93d87bbf0c4147bbadf56e5c8d2c9ada : SUCCESS in 18m 21s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/8a5c22606eaa42fa9a3c909b7de8306c : SUCCESS in 18m 14s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/19299ac5d1db4fcb8385ba397acb353a : SUCCESS in 1h 32m 42s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/21c4242080234d6aa1e7bcd1cd3fdc39 : FAILURE in 1h 57m 19s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/c45cfa3ac7d949919ca209ccaa63ef1d : SUCCESS in 40m 00s","accounts_in_message":[],"_revision_number":3},{"id":"d78ddef13b8b34682f811bd251bdda1c5e4017cc","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-04 02:22:09.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/3/check/tempest-dsvm-full-bionic/5c1ed27/ : TIMED_OUT in 2h 37m 42s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/3/check/tempest-dsvm-full-bionic-py3/af293b3/ : SUCCESS in 1h 38m 38s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/3/check/grenade-dsvm-bionic/f885a73/ : POST_FAILURE in 1h 20m 00s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7f4eafc8bd5372230cb6f5df44f926ad2c8725ad","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-09-04 10:44:44.000000000","message":"Patch Set 3: Code-Review+2\n\nClean cherry pick of the bugfix from Train, where the patch has merged.  LGTM.","accounts_in_message":[],"_revision_number":3},{"id":"51c884dfe38bfaa19b7c930e9885be2de4e95314","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2020-09-04 10:44:59.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"f147da152784fbc69498cab2cbee9d45a55ed6d0","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-04 10:59:08.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/748514/3 : FAILURE in 9m 33s","accounts_in_message":[],"_revision_number":3},{"id":"2d2ceafffef2202159a63a9c8e713a8b92c40e26","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-09-04 11:05:37.000000000","message":"Patch Set 3:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/14/748514/3/check/pmem-tempest-plugin-filtered-multi-node/8d58e32/ : RETRY_LIMIT in 4m 13s\n- devstack-networking-ovs-dpdk http://52.27.155.124/14/748514/3/check/devstack-networking-ovs-dpdk/7fbb94b/ : RETRY_LIMIT in 1m 53s","accounts_in_message":[],"_revision_number":3},{"id":"360f2040909545fedbc4024a6796ccdbc397ca37","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 13:02:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/99529cc0377a4ae6abb8fa6896483bc9 : SUCCESS in 1h 08m 06s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3f0e6455e1dc4ea299d0799180d59f3e : SUCCESS in 17m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fe559ea5b1c743ea92c375181d9944d0 : SUCCESS in 15m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8a77fd0059648149d14be1776934032 : SUCCESS in 9m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/70d278d696aa42609ca07433dc4227f4 : SUCCESS in 12m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/0c742eaed29a4a26a9c1ba0e9bd873cc : SUCCESS in 21m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6f724efd7e1247de96d1c417f1810a7a : SUCCESS in 10m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8e975713bd2b4041acad44ed0a3da514 : SUCCESS in 21m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a2d34bb913c24dd1b2fde2710366eb3b : SUCCESS in 8m 00s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/15c133de054a4bb8b3ca91d7ef9b5636 : SUCCESS in 53m 53s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/e79a45882f8d49418bb2134919e00511 : SUCCESS in 1h 11m 04s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/5bd5f27d550841ebb0a0dd88e8fd94ac : SUCCESS in 59m 18s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/a022250bbcad4f9f94b1f28035c19174 : SUCCESS in 1h 08m 51s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4ef663678e624465a9fc01d32ff4d31c : SUCCESS in 47m 22s\n- nova-next https://zuul.opendev.org/t/openstack/build/ed3323746f0c432cb93090b30e39a639 : SUCCESS in 1h 09m 24s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/e85956cf2f8049f6b09d0030a7bf0a74 : SUCCESS in 19m 17s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/17c136438b504c0ab6d1cbac2c31c48a : SUCCESS in 23m 30s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/21134508a73542eda9b1602d0dd3ba9a : SUCCESS in 1h 29m 46s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/4fba51fa70974e4188272269ac7b85db : SUCCESS in 2h 03m 43s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/52feac581f344690ab6f8e17485d9fcf : SUCCESS in 1h 00m 03s","accounts_in_message":[],"_revision_number":3},{"id":"77659ef5d22389e5acb78322179ef9dfbc7874f4","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-04 13:43:20.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/3/check/tempest-dsvm-full-bionic/c378de0/ : TIMED_OUT in 2h 43m 50s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/3/check/tempest-dsvm-full-bionic-py3/c2ca790/ : SUCCESS in 1h 43m 05s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/748514/3/check/grenade-dsvm-bionic/15fa210/ : POST_FAILURE in 1h 22m 30s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"35c54118e559bf9d9980076f0b55e2faaee61bc7","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2020-09-04 20:44:08.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nClean backport from train, LGTM","accounts_in_message":[],"_revision_number":3},{"id":"e23fcf0fe18f61e844282bf28143fb4c223807e0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 21:01:49.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"39a179efa879aa5b31727e94f109bfb0dd486c94","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 23:33:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"d3fad752ae602887ba7df5d822d9c855c55db61d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 23:33:26.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/35af6b54ddf446f5a2f2dc4f7d569638 : SUCCESS in 1h 11m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/369e982c8e2143e780701e14e4869355 : SUCCESS in 13m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/31deaf051ea8446ca743c7e6ab87b681 : SUCCESS in 9m 48s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a29b800685b4408ba6799ef8ff09b24b : SUCCESS in 15m 26s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/92863fba9be24474b6001d332b8fdebc : SUCCESS in 13m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/feb30a8a4dc940159586e2cab3f2b89b : SUCCESS in 14m 27s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2978b41fb81e416281aca6075be9a696 : SUCCESS in 12m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b376de508995418aa1db6803c36a1ec0 : SUCCESS in 8m 49s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/bfb0313e74814c9fb84f7560290f05b8 : SUCCESS in 1h 16m 36s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/fa380778fab9407fb703b143ccfea5ca : SUCCESS in 1h 00m 23s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/01cb9e56158e4c9c9709d412bed72df0 : SUCCESS in 13m 24s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/e2e3306e8aec4494bf0291be3cf3124c : SUCCESS in 18m 40s\n- nova-next https://zuul.opendev.org/t/openstack/build/c8ee87338a024c5797c3bccb4b4516b0 : SUCCESS in 1h 30m 31s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/41d1038f76864405a7efe79e0df1a453 : SUCCESS in 1h 25m 50s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/5634f62ebdd646299aa30216bd1e027c : SUCCESS in 54m 53s","accounts_in_message":[],"_revision_number":3},{"id":"9867c463d9e98181ac8f481a47f3563f54a0a7d4","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 23:36:21.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/43313e5cfd0a4028bfb665273499a799 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6007c41aa830e1d1e227a8c66285b2eb32fe9a7c","revisions":{"ee5a553803d324bf0c2f867decf9447ea9f3f68c":{"kind":"REWORK","_number":1,"created":"2020-08-27 18:39:05.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/14/748514/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/748514/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/748514/1"}}},"commit":{"parents":[{"commit":"fd0db0174616edcfc7f44c7a1e76c82297e1a856","subject":"WIP Add regression tests for bug #1889108","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fd0db0174616edcfc7f44c7a1e76c82297e1a856"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-27 18:27:24.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-08-27 18:38:30.000000000","tz":60},"subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","message":"compute: Don\u0027t delete the original attachment during pre LM rollback\n\nI0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live\nmigration with cinderv3 volume attachments during Queens. This initial\nsupport handled failures in pre_live_migration directly by removing any\nattachments created on the destination and reverting to the original\nattachment ids before re-raising the caught exception to the source\ncompute. It also added rollback code within the main\n_rollback_live_migration method but missed that this would also be\ncalled during a pre_live_migration rollback.\n\nAs a result after a failure in pre_live_migration\n_rollback_live_migration will attempt to delete the source host volume\nattachments referenced by the bdm before updating the bdms with the now\nnon-existent attachment ids, leaving the volumes in an `available` state\nin Cinder as they have no attachment records associated with them\nanymore.\n\nThis change aims to resolve this within _rollback_volume_bdms by\nensuring that the current and original attachment_ids are not equal\nbefore requesting that the current attachment referenced by the bdm is\ndeleted. When called after a failure in pre_live_migration this should\nresult in no attempt being made to remove the original source host\nattachments from Cinder.\n\nNote that the following changes muddy the waters slightly here but\nintroduced no actual changes to the logic within\n_rollback_live_migration:\n\n* I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error\n  handling in Rocky but isn\u0027t the source of the issue here.\n\n* Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked\n  _rollback_live_migration to use the provided source_bdms.\n\n* I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored\n  _rollback_live_migration, moving the logic into a self contained\n  _rollback_volume_bdms method.\n\nCloses-Bug: #1889108\nChange-Id: I9edb36c4df1cc0d8b529e669f06540de71766085\n(cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)\n(cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)\n(cherry picked from commit fa707a508220c76dba87a62dd0fc0eac302d859e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ee5a553803d324bf0c2f867decf9447ea9f3f68c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ee5a553803d324bf0c2f867decf9447ea9f3f68c"}]},"branch":"refs/heads/stable/stein"},"4b4deffc017ac7c9fa2d0e084ab50c7b4086c9f5":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2020-08-27 19:11:31.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/14/748514/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/748514/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/748514/2"}}},"commit":{"parents":[{"commit":"b46f7fa6a4c807416e7525cd5196899b3aa07b27","subject":"Add regression tests for bug #1889108","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b46f7fa6a4c807416e7525cd5196899b3aa07b27"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-27 18:27:24.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-08-27 19:10:57.000000000","tz":60},"subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","message":"compute: Don\u0027t delete the original attachment during pre LM rollback\n\nI0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live\nmigration with cinderv3 volume attachments during Queens. This initial\nsupport handled failures in pre_live_migration directly by removing any\nattachments created on the destination and reverting to the original\nattachment ids before re-raising the caught exception to the source\ncompute. It also added rollback code within the main\n_rollback_live_migration method but missed that this would also be\ncalled during a pre_live_migration rollback.\n\nAs a result after a failure in pre_live_migration\n_rollback_live_migration will attempt to delete the source host volume\nattachments referenced by the bdm before updating the bdms with the now\nnon-existent attachment ids, leaving the volumes in an `available` state\nin Cinder as they have no attachment records associated with them\nanymore.\n\nThis change aims to resolve this within _rollback_volume_bdms by\nensuring that the current and original attachment_ids are not equal\nbefore requesting that the current attachment referenced by the bdm is\ndeleted. When called after a failure in pre_live_migration this should\nresult in no attempt being made to remove the original source host\nattachments from Cinder.\n\nNote that the following changes muddy the waters slightly here but\nintroduced no actual changes to the logic within\n_rollback_live_migration:\n\n* I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error\n  handling in Rocky but isn\u0027t the source of the issue here.\n\n* Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked\n  _rollback_live_migration to use the provided source_bdms.\n\n* I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored\n  _rollback_live_migration, moving the logic into a self contained\n  _rollback_volume_bdms method.\n\nCloses-Bug: #1889108\nChange-Id: I9edb36c4df1cc0d8b529e669f06540de71766085\n(cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)\n(cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)\n(cherry picked from commit c6c3483a41c2a53bcfafdfe3475283b0379f7f1d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4b4deffc017ac7c9fa2d0e084ab50c7b4086c9f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4b4deffc017ac7c9fa2d0e084ab50c7b4086c9f5"}]},"branch":"refs/heads/stable/stein"},"6007c41aa830e1d1e227a8c66285b2eb32fe9a7c":{"kind":"NO_CHANGE","_number":3,"created":"2020-09-03 17:56:49.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/14/748514/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/748514/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/748514/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/748514/3"}}},"commit":{"parents":[{"commit":"06d9d0d70542f2f9846ca8f40aef531cec0329a2","subject":"Add regression tests for bug #1889108","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/06d9d0d70542f2f9846ca8f40aef531cec0329a2"}]}],"author":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-07-27 18:27:24.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2020-09-03 17:56:31.000000000","tz":60},"subject":"compute: Don\u0027t delete the original attachment during pre LM rollback","message":"compute: Don\u0027t delete the original attachment during pre LM rollback\n\nI0bfb11296430dfffe9b091ae7c3a793617bd9d0d introduced support for live\nmigration with cinderv3 volume attachments during Queens. This initial\nsupport handled failures in pre_live_migration directly by removing any\nattachments created on the destination and reverting to the original\nattachment ids before re-raising the caught exception to the source\ncompute. It also added rollback code within the main\n_rollback_live_migration method but missed that this would also be\ncalled during a pre_live_migration rollback.\n\nAs a result after a failure in pre_live_migration\n_rollback_live_migration will attempt to delete the source host volume\nattachments referenced by the bdm before updating the bdms with the now\nnon-existent attachment ids, leaving the volumes in an `available` state\nin Cinder as they have no attachment records associated with them\nanymore.\n\nThis change aims to resolve this within _rollback_volume_bdms by\nensuring that the current and original attachment_ids are not equal\nbefore requesting that the current attachment referenced by the bdm is\ndeleted. When called after a failure in pre_live_migration this should\nresult in no attempt being made to remove the original source host\nattachments from Cinder.\n\nNote that the following changes muddy the waters slightly here but\nintroduced no actual changes to the logic within\n_rollback_live_migration:\n\n* I0f3ab6604d8b79bdb75cf67571e359cfecc039d8 reworked some of the error\n  handling in Rocky but isn\u0027t the source of the issue here.\n\n* Ibe9215c07a1ee00e0e121c69bcf7ee1b1b80fae0 reworked\n  _rollback_live_migration to use the provided source_bdms.\n\n* I6bc73e8c8f98d9955f33f309beb8a7c56981b553 then refactored\n  _rollback_live_migration, moving the logic into a self contained\n  _rollback_volume_bdms method.\n\nCloses-Bug: #1889108\nChange-Id: I9edb36c4df1cc0d8b529e669f06540de71766085\n(cherry picked from commit 2102f1834a6ac9fd870bfb457b28a2172f33e281)\n(cherry picked from commit 034b2fa8fea0e34fed95a2ba728e4387ce4e78de)\n(cherry picked from commit c6c3483a41c2a53bcfafdfe3475283b0379f7f1d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6007c41aa830e1d1e227a8c66285b2eb32fe9a7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6007c41aa830e1d1e227a8c66285b2eb32fe9a7c"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
