)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3927fba66d9c5db595b3caee2eee661cb78fca15","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-08-31 11:36:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Rebase qcow2 images when unshelving an instance\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1732428"},{"line_number":10,"context_line":"Closes-Bug: #1893618"},{"line_number":11,"context_line":"This reverts commit 8953a689467f8c3e996086392251de67953a45ba."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_2df1e502","line":8,"updated":"2020-08-31 12:26:56.000000000","message":"you need to explain why this is being reverted\n\nnamely \n\n Traceback (most recent call last):\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]   File \"/usr/lib/python3.6/site-packages/nova/compute/manager.py\", line 6609, in _unshelve_instance\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]     block_device_info\u003dblock_device_info)\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]   File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/driver.py\", line 3672, in spawn\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]     block_device_info\u003dblock_device_info)\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]   File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/driver.py\", line 4067, in _create_image\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]     injection_info, fallback_from_host)\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]   File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/driver.py\", line 4198, in _create_and_inject_local_root\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]     self._finalize_unshelve_qcow2_image(context, instance, backend)\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]   File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/driver.py\", line 4218, in _finalize_unshelve_qcow2_image\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]     root_fname \u003d imagecache.get_cache_fname(base_image_ref)\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]   File \"/usr/lib/python3.6/site-packages/nova/virt/libvirt/imagecache.py\", line 52, in get_cache_fname\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f]     return hashlib.sha1(image_id.encode(\u0027utf-8\u0027)).hexdigest()\n2020-08-30 08:35:09.848 7 ERROR nova.compute.manager [instance: 8455720e-e1f4-415e-a3dd-005ec131528f] AttributeError: \u0027NoneType\u0027 object has no attribute \u0027encode\u0027\n\nso for some reason the image_id is None and we are deferincing it.","commit_id":"1df136d0d3e37660762240fc39b65ed44c011f74"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa0500a2e4db7fa132fcb8c158d70e8154a05981","unresolved":false,"context_lines":[{"line_number":4136,"context_line":"            # disk image to its original image_ref. Disk backing file will"},{"line_number":4137,"context_line":"            # then represent back image_ref instead of shelved image."},{"line_number":4138,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED and"},{"line_number":4139,"context_line":"                   isinstance(backend, imagebackend.Qcow2)):"},{"line_number":4140,"context_line":"                self._finalize_unshelve_qcow2_image(context, instance, backend)"},{"line_number":4141,"context_line":""},{"line_number":4142,"context_line":"            if need_inject:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6d92bd5a","side":"PARENT","line":4139,"range":{"start_line":4139,"start_character":19,"end_line":4139,"end_character":58},"updated":"2020-08-31 12:30:31.000000000","message":"should this also be done for flat by the way.","commit_id":"8953a689467f8c3e996086392251de67953a45ba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3927fba66d9c5db595b3caee2eee661cb78fca15","unresolved":false,"context_lines":[{"line_number":4157,"context_line":"        # created/resized by first fetch call."},{"line_number":4158,"context_line":"        base_dir \u003d self.image_cache_manager.cache_dir"},{"line_number":4159,"context_line":"        base_image_ref \u003d instance.system_metadata.get(\u0027image_base_image_ref\u0027)"},{"line_number":4160,"context_line":"        root_fname \u003d imagecache.get_cache_fname(base_image_ref)"},{"line_number":4161,"context_line":"        base_backing_fname \u003d os.path.join(base_dir, root_fname)"},{"line_number":4162,"context_line":""},{"line_number":4163,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8d68f187","side":"PARENT","line":4160,"range":{"start_line":4160,"start_character":7,"end_line":4160,"end_character":63},"updated":"2020-08-31 12:26:56.000000000","message":"the excpeiton is being raised by this call\nsince base_image_ref is None\n\nit just does \n\n return hashlib.sha1(image_id.encode(\u0027utf-8\u0027)).hexdigest()\nso if base_image_ref is None image_id is None and .encode raises an attribute error.\n\nthat means that \n\nbase_image_ref \u003d instance.system_metadata.get(\u0027image_base_image_ref\u0027)\n\nreturned none.\n\nlooking at the ci logs for the failure\n\nhttps://logserver.rdoproject.org/openstack-component-compute/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-compute-master/b346467/logs/\n\nits just using qcow image backend so no ceph or bfv\n\nthis should have been populated here orginally during create\nhttps://github.com/openstack/nova/blob/197dac3c78a458302ccbda00b992879b2b2ffef1/nova/compute/api.py#L1898\n\nthis is not set anywhere else so i dont see how this can be None\n\nhttp://codesearch.openstack.org/?q\u003dimage_base_image_ref\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dopenstack/nova","commit_id":"8953a689467f8c3e996086392251de67953a45ba"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa0500a2e4db7fa132fcb8c158d70e8154a05981","unresolved":false,"context_lines":[{"line_number":4157,"context_line":"        # created/resized by first fetch call."},{"line_number":4158,"context_line":"        base_dir \u003d self.image_cache_manager.cache_dir"},{"line_number":4159,"context_line":"        base_image_ref \u003d instance.system_metadata.get(\u0027image_base_image_ref\u0027)"},{"line_number":4160,"context_line":"        root_fname \u003d imagecache.get_cache_fname(base_image_ref)"},{"line_number":4161,"context_line":"        base_backing_fname \u003d os.path.join(base_dir, root_fname)"},{"line_number":4162,"context_line":""},{"line_number":4163,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4d8ff92d","side":"PARENT","line":4160,"range":{"start_line":4160,"start_character":7,"end_line":4160,"end_character":63},"in_reply_to":"9f560f44_8d68f187","updated":"2020-08-31 12:30:31.000000000","message":"by the way the only way i can think of to have the image ref be none would be for  an image that was booted form a data volume that was not orginally created form an image.\n\nthat is definetly not what happened in the ci.","commit_id":"8953a689467f8c3e996086392251de67953a45ba"}]}