)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72944238c02c6104778d8ac261eb2b5bfca2ef28","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        context\u003dcontext,"},{"line_number":381,"context_line":"        instance\u003dinstance_ref,"},{"line_number":382,"context_line":"        audit_period\u003daudit_period,"},{"line_number":383,"context_line":"        bandwidth\u003d[])"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    notification \u003d instance_notification.InstanceExistsNotification("},{"line_number":386,"context_line":"        context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f65232a_3e9f66b5","line":383,"range":{"start_line":383,"start_character":18,"end_line":383,"end_character":20},"updated":"2020-10-21 13:37:43.000000000","message":"OK, this keeps the notification interface compatible.","commit_id":"1224a905dcce0064c17a6254abd886b4bbbe4c2c"}],"nova/notifications/base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72944238c02c6104778d8ac261eb2b5bfca2ef28","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    payload[\"audit_period_ending\"] \u003d null_safe_isotime(audit_end)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    # add bw usage info:"},{"line_number":193,"context_line":"    # TODO(stephenfin): Remove this, the feature is dead"},{"line_number":194,"context_line":"    payload[\"bandwidth\"] \u003d {}"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    # add old display name if it is changed"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f65232a_feb4ce37","line":193,"updated":"2020-10-21 13:37:43.000000000","message":"it will need a notification version major bump.","commit_id":"1224a905dcce0064c17a6254abd886b4bbbe4c2c"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72944238c02c6104778d8ac261eb2b5bfca2ef28","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    fields \u003d {"},{"line_number":301,"context_line":"        \u0027state_update\u0027: fields.ObjectField(\u0027InstanceStateUpdatePayload\u0027),"},{"line_number":302,"context_line":"        \u0027audit_period\u0027: fields.ObjectField(\u0027AuditPeriodPayload\u0027),"},{"line_number":303,"context_line":"        # TODO(stephenfin): Remove this field in 2.0"},{"line_number":304,"context_line":"        \u0027bandwidth\u0027: fields.ListOfObjectsField(\u0027BandwidthPayload\u0027),"},{"line_number":305,"context_line":"        \u0027old_display_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":306,"context_line":"        \u0027tags\u0027: fields.ListOfStringsField(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f65232a_1e91ca9a","line":303,"updated":"2020-10-21 13:37:43.000000000","message":"Yes","commit_id":"1224a905dcce0064c17a6254abd886b4bbbe4c2c"}],"nova/objects/bandwidth_usage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72944238c02c6104778d8ac261eb2b5bfca2ef28","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from nova.objects import fields"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# TODO(stephenfin): Remove after W, once we no longer need to worry about the"},{"line_number":19,"context_line":"# versioned notification framework using this"},{"line_number":20,"context_line":"@base.NovaObjectRegistry.register"},{"line_number":21,"context_line":"class BandwidthUsage(base.NovaPersistentObject, base.NovaObject):"},{"line_number":22,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f65232a_5e36a2b6","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":45},"updated":"2020-10-21 13:37:43.000000000","message":"as far as I see this is not used by the notification framework after this patch. So I think this can be removed.","commit_id":"1224a905dcce0064c17a6254abd886b4bbbe4c2c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b6ebd4790ad09c30e90d2ba49bd607dd9614ffd8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from nova.objects import fields"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# TODO(stephenfin): Remove after W, once we no longer need to worry about the"},{"line_number":19,"context_line":"# versioned notification framework using this"},{"line_number":20,"context_line":"@base.NovaObjectRegistry.register"},{"line_number":21,"context_line":"class BandwidthUsage(base.NovaPersistentObject, base.NovaObject):"},{"line_number":22,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_c4296837","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":45},"in_reply_to":"3f65232a_5e36a2b6","updated":"2020-11-16 14:01:54.000000000","message":"I have this proposed at [1] but it\u0027s not passing yet. Can we move ahead with this, on the assumption that we\u0027ll drop this eventually with a working version of [1]?\n\n[1] https://review.opendev.org/#/c/759114/2","commit_id":"1224a905dcce0064c17a6254abd886b4bbbe4c2c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"72944238c02c6104778d8ac261eb2b5bfca2ef28","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self._from_db_object(self._context, self, db_bw_usage)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# TODO(stephenfin): Remove after W, once we no longer need to worry about the"},{"line_number":78,"context_line":"# versioned notification framework using this"},{"line_number":79,"context_line":"@base.NovaObjectRegistry.register"},{"line_number":80,"context_line":"class BandwidthUsageList(base.ObjectListBase, base.NovaObject):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f65232a_de491233","line":78,"range":{"start_line":76,"start_character":0,"end_line":78,"end_character":45},"updated":"2020-10-21 13:37:43.000000000","message":"ditto","commit_id":"1224a905dcce0064c17a6254abd886b4bbbe4c2c"}]}