)]}'
{"id":"openstack%2Fnova~749698","triplet_id":"openstack%2Fnova~stable%2Fussuri~I74d3402d564abd5b042024d59c7a55511afa6bf9","project":"openstack/nova","branch":"stable/ussuri","topic":"bug/1893751","hashtags":[],"change_id":"I74d3402d564abd5b042024d59c7a55511afa6bf9","subject":"Reject resize operation for accelerator","status":"ABANDONED","created":"2020-09-03 10:00:24.000000000","updated":"2020-09-03 10:26:40.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88562b509522753742eed490148aa7656bd56995","_number":749698,"virtual_id_number":749698,"owner":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"date":"2020-09-03 10:25:31.000000000","_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":-1,"date":"2020-09-03 10:13:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"date":"2020-09-03 10:10:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"date":"2020-09-03 10:10:35.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-03 10:10:18.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2020-09-03 10:10:35.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-09-03 10:13:42.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"}],"messages":[{"id":"325df6a4c2f0ac8d3646dc57231bc03107b26474","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-03 10:00:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c3d8ea18b7189b5aebdfd1daf8fcde01af591823","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-03 10:04:51.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nA very sensible fix, IMO. Conflicts are noted. Needs the cherry-pick metadata though","accounts_in_message":[],"_revision_number":1},{"id":"bdf16b0267680db6ab079cee25dede30a6d3ee3b","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-03 10:08:28.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nThanks Stephenfin, fast review.","accounts_in_message":[],"_revision_number":1},{"id":"da4963addac1bd6a4cdb2c0bfa4a8da2ce350ec7","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-03 10:08:34.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0cffa62bc2afbb3866867ff2d6b8bb84c6dd7e59","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-03 10:13:42.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"67bc385e51c18c8f5c23e04442a1d6feb0ac4127","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-03 10:25:31.000000000","message":"Patch Set 2:\n\n(1 comment)\n\ngreate guideline.","accounts_in_message":[],"_revision_number":2},{"id":"f348080cd10fbca794a3b3d8880fa29740614b32","author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"date":"2020-09-03 10:26:40.000000000","message":"Abandoned\n\nchaged to Ie20a620588e3b0d18055c34ec7671e91e6bf6ee0","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"edfef526b538f2bd349eaeed2ee2d39cfb056a96","revisions":{"dbb1aa41ef172688d34592cf29f3928f86ece383":{"kind":"REWORK","_number":1,"created":"2020-09-03 10:00:24.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/98/749698/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/98/749698/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/749698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/749698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/749698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/98/749698/1"}}},"commit":{"parents":[{"commit":"1c28a88afdfd012fa8b962a25a4b75f0198ada1b","subject":"Merge \"Removes the delta file once image is extracted\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1c28a88afdfd012fa8b962a25a4b75f0198ada1b"}]}],"author":{"name":"Zuul","email":"zuul@review.opendev.org","date":"2020-09-03 09:04:37.000000000","tz":0},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2020-09-03 09:48:43.000000000","tz":480},"subject":"Reject resize operation for accelerator","message":"Reject resize operation for accelerator\n\nWhen resize with a new flavor with accelerator, we should raise\nforbidden exception to reject the resize operation.\nAdd related unit test.\nFollow up the comment:\nhttps://review.opendev.org/#/c/715326/22/nova/compute/api.py@3907\n\nCo-Authored-By: Wenping Song \u003csongwenping@inspur.com\u003e\n\nCloses-Bug: #1893751\n\nConflicts:\n  nova/compute/api.py\n  nova/tests/unit/compute/test_compute_api.py\n\nNOTE(brinzhang): Conflicts are due to change\neef4b5435e7cdfe53ee9d9265d96c7dd278d9e93 (\"api: Reject\nnon-spawn operations for vTPM\") which is change to the\nsame location.\n\nChange-Id: I74d3402d564abd5b042024d59c7a55511afa6bf9\nSigned-off-by: zhangbailin \u003czhangbailin@inspur.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dbb1aa41ef172688d34592cf29f3928f86ece383"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dbb1aa41ef172688d34592cf29f3928f86ece383"}]},"parents_data":[{"branch_name":"refs/heads/stable/ussuri","commit_id":"1c28a88afdfd012fa8b962a25a4b75f0198ada1b","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/ussuri"},"edfef526b538f2bd349eaeed2ee2d39cfb056a96":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-09-03 10:08:34.000000000","uploader":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"ref":"refs/changes/98/749698/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/98/749698/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/749698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/749698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/98/749698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/98/749698/2"}}},"commit":{"parents":[{"commit":"1c28a88afdfd012fa8b962a25a4b75f0198ada1b","subject":"Merge \"Removes the delta file once image is extracted\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1c28a88afdfd012fa8b962a25a4b75f0198ada1b"}]}],"author":{"name":"Zuul","email":"zuul@review.opendev.org","date":"2020-09-03 09:04:37.000000000","tz":0},"committer":{"name":"zhangbailin","email":"zhangbailin@inspur.com","date":"2020-09-03 10:06:27.000000000","tz":480},"subject":"Reject resize operation for accelerator","message":"Reject resize operation for accelerator\n\nWhen resize with a new flavor with accelerator, we should raise\nforbidden exception to reject the resize operation.\nAdd related unit test.\nFollow up the comment:\nhttps://review.opendev.org/#/c/715326/22/nova/compute/api.py@3907\n\nConflicts:\n  nova/compute/api.py\n  nova/tests/unit/compute/test_compute_api.py\n\nNOTE(brinzhang): Conflicts are due to change\neef4b5435e7cdfe53ee9d9265d96c7dd278d9e93 (\"api: Reject\nnon-spawn operations for vTPM\") which modified the same code.\n\nCo-Authored-By: Wenping Song \u003csongwenping@inspur.com\u003e\nCloses-Bug: #1893751\n\nChange-Id: I74d3402d564abd5b042024d59c7a55511afa6bf9\nSigned-off-by: zhangbailin \u003czhangbailin@inspur.com\u003e\n(cherry picked from commit dbb1aa41ef172688d34592cf29f3928f86ece383)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/edfef526b538f2bd349eaeed2ee2d39cfb056a96"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/edfef526b538f2bd349eaeed2ee2d39cfb056a96"}]},"parents_data":[{"branch_name":"refs/heads/stable/ussuri","commit_id":"1c28a88afdfd012fa8b962a25a4b75f0198ada1b","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}