)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0b7bb2e239a13549e6c0b0270ecfd967becbac7d","unresolved":false,"context_lines":[{"line_number":1869,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE, fair\u003dTrue)"},{"line_number":1870,"context_line":"    def claim_pci_devices("},{"line_number":1871,"context_line":"        self, context, pci_requests, instance_numa_topology\u003dNone"},{"line_number":1872,"context_line":"    ):"},{"line_number":1873,"context_line":"        \"\"\"Claim instance PCI resources"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"        :param context: security context"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_510c0feb","line":1872,"updated":"2020-09-10 09:36:22.000000000","message":"nit : looks unnecessary, but meh","commit_id":"9f108c622da54144958887941c8642630b0347a7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f9e14159cfae075279c088bf27f26fd4f83f29c","unresolved":false,"context_lines":[{"line_number":1869,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE, fair\u003dTrue)"},{"line_number":1870,"context_line":"    def claim_pci_devices("},{"line_number":1871,"context_line":"        self, context, pci_requests, instance_numa_topology\u003dNone"},{"line_number":1872,"context_line":"    ):"},{"line_number":1873,"context_line":"        \"\"\"Claim instance PCI resources"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"        :param context: security context"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c1f04c6a","line":1872,"in_reply_to":"9f560f44_510c0feb","updated":"2020-09-10 13:40:54.000000000","message":"it is but stephen is slowly trying to change our coding style to always place the closeing of the fucntion arges list on a new line so that it aligns with his preference for wehn type annotations are used.\n\nbut i want this to merge and dont want to pick that fight now\nbut i will proably add automatic code formating to the ptg adgenda.\n\ni really do think we should start using it.\nplroably not black but something more configurable so we can more close match or existing style and still pass pep8 without changing our current job rules.","commit_id":"9f108c622da54144958887941c8642630b0347a7"}],"nova/objects/instance.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f67464ad0779603d81c2b0fc3d49bf3d719c0801","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"            pci_req for pci_req in self.pci_requests.requests"},{"line_number":1223,"context_line":"            if pci_req.request_id !\u003d pci_device.request_id]"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"    def add_pci_device_and_request(self, pci_device, pci_request):"},{"line_number":1226,"context_line":"        self.pci_requests.requests.append(pci_request)"},{"line_number":1227,"context_line":"        self.pci_devices.objects.append(pci_device)"},{"line_number":1228,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ec6aaa7e","line":1225,"updated":"2020-09-10 10:12:12.000000000","message":"It\u0027s a massive nit, but I\u0027d have placed \u0027add_\u0027 before \u0027remove_\u0027 /o\\","commit_id":"9f108c622da54144958887941c8642630b0347a7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0b7bb2e239a13549e6c0b0270ecfd967becbac7d","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    def add_pci_device_and_request(self, pci_device, pci_request):"},{"line_number":1226,"context_line":"        self.pci_requests.requests.append(pci_request)"},{"line_number":1227,"context_line":"        self.pci_devices.objects.append(pci_device)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":""},{"line_number":1230,"context_line":"def _make_instance_list(context, inst_list, db_inst_list, expected_attrs):"},{"line_number":1231,"context_line":"    get_fault \u003d expected_attrs and \u0027fault\u0027 in expected_attrs"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_71f4b3cf","line":1228,"updated":"2020-09-10 09:36:22.000000000","message":"++","commit_id":"9f108c622da54144958887941c8642630b0347a7"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f67464ad0779603d81c2b0fc3d49bf3d719c0801","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def _attach_port(self, instance_uuid, port_id):"},{"line_number":241,"context_line":"        self.api.attach_interface("},{"line_number":242,"context_line":"            instance_uuid,"},{"line_number":243,"context_line":"            {\u0027interfaceAttachment\u0027: {\u0027port_id\u0027: port_id}})"},{"line_number":244,"context_line":"        fake_notifier.wait_for_versioned_notifications("},{"line_number":245,"context_line":"            \u0027instance.interface_attach.end\u0027)"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0c09dedb","line":243,"updated":"2020-09-10 10:12:12.000000000","message":"nit: would fit on the next line too","commit_id":"9f108c622da54144958887941c8642630b0347a7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5f9e14159cfae075279c088bf27f26fd4f83f29c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    def _attach_port(self, instance_uuid, port_id):"},{"line_number":241,"context_line":"        self.api.attach_interface("},{"line_number":242,"context_line":"            instance_uuid,"},{"line_number":243,"context_line":"            {\u0027interfaceAttachment\u0027: {\u0027port_id\u0027: port_id}})"},{"line_number":244,"context_line":"        fake_notifier.wait_for_versioned_notifications("},{"line_number":245,"context_line":"            \u0027instance.interface_attach.end\u0027)"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_c195ece5","line":243,"in_reply_to":"9f560f44_0c09dedb","updated":"2020-09-10 13:40:54.000000000","message":"you mean previous","commit_id":"9f108c622da54144958887941c8642630b0347a7"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0b7bb2e239a13549e6c0b0270ecfd967becbac7d","unresolved":false,"context_lines":[{"line_number":1643,"context_line":"        self.assertNotIn(pci_device, instance.pci_devices)"},{"line_number":1644,"context_line":"        self.assertNotIn(pci_request, instance.pci_requests.requests)"},{"line_number":1645,"context_line":"        self.assertIn(other_device, instance.pci_devices)"},{"line_number":1646,"context_line":"        self.assertIn(other_request, instance.pci_requests.requests)"},{"line_number":1647,"context_line":""},{"line_number":1648,"context_line":""},{"line_number":1649,"context_line":"class TestRemoteInstanceObject(test_objects._RemoteTest,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_51252f5b","line":1646,"updated":"2020-09-10 09:36:22.000000000","message":"++","commit_id":"9f108c622da54144958887941c8642630b0347a7"}]}