)]}'
{"nova/virt/libvirt/guest.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c0f095af1aa9fbe5f441e6fa2e364c83d298a2f7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.error(\u0027Error launching a defined domain \u0027"},{"line_number":159,"context_line":"                          \u0027with XML: %s\u0027,"},{"line_number":160,"context_line":"                          self._encoded_xml, errors\u003d\u0027ignore\u0027, exc_info\u003d1)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def poweroff(self):"},{"line_number":163,"context_line":"        \"\"\"Stops a running guest.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0196c43e","line":160,"updated":"2020-09-10 13:30:31.000000000","message":"We have this in a couple of places but it does seem to be hit and miss. Please educate me: given we re-raise this exception already, which will result in the traceback being printed, is there a particular reason we also want to log it? Don\u0027t these things typically end up in the same place?\n\nAlso, would LOG.exception be clearer?","commit_id":"b18084b07c6d3a76c43f07f55bdf08c4d0095a4b"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"3d489a051413a67a0ef17d9fe3e303d5efe14722","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.error(\u0027Error launching a defined domain \u0027"},{"line_number":159,"context_line":"                          \u0027with XML: %s\u0027,"},{"line_number":160,"context_line":"                          self._encoded_xml, errors\u003d\u0027ignore\u0027, exc_info\u003d1)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def poweroff(self):"},{"line_number":163,"context_line":"        \"\"\"Stops a running guest.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d4d91656","line":160,"in_reply_to":"9f560f44_0196c43e","updated":"2020-09-11 09:12:04.000000000","message":"This is indeed equivalent to LOG.exception. Thanks for pointing it out Stephen. I\u0027ll fix it.\n\nI found the traceback of this exception on the nova server fault.details field when getting server details, but not in the nova CPU log files. This is OK in most of the cases but I wanted the traceback tagged with a timestamp for better understanding the order of the events while investigating on a bug I found on my DevStack CI setup for CentOS 8 [1].\n\n[1] (test_migrate_server) https://98d3d94d4cd260078126-ab9965a682a78200f296c9df29ce08ed.ssl.cf1.rackcdn.com/740929/74/check/tobiko-devstack-faults-centos-8/067fa8c/test_results_01_create_resources_scenario.html","commit_id":"b18084b07c6d3a76c43f07f55bdf08c4d0095a4b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5605d48a3901d0900163a2b342412d3b967556a5","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            return self._domain.createWithFlags(flags)"},{"line_number":156,"context_line":"        except Exception:"},{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.exception(\u0027Error launching a defined domain \u0027"},{"line_number":159,"context_line":"                              \u0027with XML: %s\u0027,"},{"line_number":160,"context_line":"                              self._encoded_xml, errors\u003d\u0027ignore\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def poweroff(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7f4f4391","line":159,"range":{"start_line":158,"start_character":30,"end_line":159,"end_character":45},"updated":"2020-09-11 10:41:49.000000000","message":"nit: could take this opportunity to wrap this nicer, e.g.\n\n  LOG.exception(\n      \u0027Error launching a defined domain with XML: %s\u0027,\n      self._encoded_xml, errors\u003d\u0027ignore\u0027)","commit_id":"9eeb55716d75fba516621b6b8977b5bfd029ca24"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"9cd8a4483aa21d29c5a430531dfee0757690efe3","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            return self._domain.createWithFlags(flags)"},{"line_number":156,"context_line":"        except Exception:"},{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.exception(\u0027Error launching a defined domain \u0027"},{"line_number":159,"context_line":"                              \u0027with XML: %s\u0027,"},{"line_number":160,"context_line":"                              self._encoded_xml, errors\u003d\u0027ignore\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def poweroff(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_45139201","line":159,"range":{"start_line":158,"start_character":30,"end_line":159,"end_character":45},"in_reply_to":"9f560f44_7f4f4391","updated":"2020-09-11 11:48:59.000000000","message":"Done","commit_id":"9eeb55716d75fba516621b6b8977b5bfd029ca24"}]}