)]}'
{"id":"openstack%2Fnova~750993","triplet_id":"openstack%2Fnova~stable%2Fqueens~If0fbae33ce2af198188c91638afef939256c2556","project":"openstack/nova","branch":"stable/queens","topic":"bug/1879787","hashtags":[],"change_id":"If0fbae33ce2af198188c91638afef939256c2556","subject":"post live migration: don\u0027t call Neutron needlessly","status":"ABANDONED","created":"2020-09-10 13:33:25.000000000","updated":"2021-03-29 14:32:32.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4c867e51b7a6d41ffa5c2178fdf31e89307845ed","_number":750993,"virtual_id_number":750993,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-09-10 19:38:41.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"date":"2020-09-10 15:12:57.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2020-09-10 20:24:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"date":"2020-09-10 15:39:07.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-09-10 16:48:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-10 15:12:57.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-09-10 15:39:07.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-09-10 16:48:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-10 19:38:41.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-10 20:24:58.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ec48bf19bf65077c1338b7ce743f9aca6456e328","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-10 13:33:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b7f4cbe95e245f7c3ab0f24b85c4a9d41b7c01b","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-09-10 13:33:51.000000000","message":"Topic set to bug/1879787","accounts_in_message":[],"_revision_number":1},{"id":"ab1d465d0590c45b5fb9e4aeea19e66750448b27","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-10 15:12:57.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/750993/1 : FAILURE in 13m 04s","accounts_in_message":[],"_revision_number":1},{"id":"6472f75453bd36a614f9c548774f4203b9563cec","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-09-10 15:39:07.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node pmem-tempest-plugin-filtered-multi-node : NODE_FAILURE in 0s\n- devstack-networking-ovs-dpdk devstack-networking-ovs-dpdk : ERROR Unable to find role in /tmp/tmph_d086d3/ad67cbc43d4742fbbf246853c4d0c55f/ansible/pre_playbook_4/role_0/neutron","accounts_in_message":[],"_revision_number":1},{"id":"6294f777ed9defa09efc9f76b225b7ebd7355e01","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-10 16:48:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef9f90c4076e4ed5bfdc168a80f3b404 : FAILURE in 8m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fe501ee849924963ba2f9653b3ba4733 : SUCCESS in 9m 28s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/596ffb2592c64abc9f34b79368c8953d : SUCCESS in 15m 21s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/d4d0016331c34b939534e460c36c8ec6 : SUCCESS in 9m 26s\n- tempest-full https://zuul.opendev.org/t/openstack/build/0f582ef92ce9407a9ee7e8a7fc66fa59 : SUCCESS in 1h 18m 45s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/36029dcc60cf48daa0958efebd8d6cab : SUCCESS in 1h 00m 12s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/e1dddb09a1014bd995c2edfd95a1fd37 : SUCCESS in 1h 45m 00s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/03bb5b75b1aa4821a93b4794628aec12 : SUCCESS in 49m 01s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/6d56b9b6943140608742fb78e8c526d1 : SUCCESS in 47m 13s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/47ce51979d1346e284ab2b8265e3ebea : SUCCESS in 1h 08m 04s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5241c68bfb5f4aa89080a334f1fa3e81 : SUCCESS in 49m 29s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/2fa719be84254485a5e44a1438b58ac8 : SUCCESS in 1h 18m 50s\n- nova-next https://zuul.opendev.org/t/openstack/build/226945e75de24fc1b23290ed11ef50ba : SUCCESS in 1h 16m 14s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/8ff0f77935414b3892fd5116feafa00e : SUCCESS in 1h 52m 02s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/76aecb85ed0a4c8daa4706037b826653 : SUCCESS in 14m 23s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/afcf656abf794a238b03f904db185445 : SUCCESS in 21m 20s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/e840fcc18df84e228c392b5c85716003 : SUCCESS in 58m 00s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/eeea0cbc6d864bdcad4b9c037726dff2 : FAILURE in 1h 26m 21s (non-voting)\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/645e62b056f34bfaae9ee7d63f76da1f : SUCCESS in 1h 47m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a56d5f7abf105a10d309ef9d07464d01fcc73705","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-09-10 19:38:41.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/750993/1/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/95e014f : FAILURE in 22m 46s","accounts_in_message":[],"_revision_number":1},{"id":"ada78603093d9d6f16d13c904fca335647b31ba8","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-10 20:24:58.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- legacy-tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/93/750993/1/check/legacy-tempest-dsvm-full-xenial/b062446/ : TIMED_OUT in 2h 31m 58s\n- legacy-tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/93/750993/1/check/legacy-tempest-dsvm-full-xenial-py3/ae1f867/ : FAILURE in 1h 19m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4c867e51b7a6d41ffa5c2178fdf31e89307845ed","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2021-03-29 14:32:32.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d292edf7725b8e432f03ec1c06ab8074e79987e1","revisions":{"d292edf7725b8e432f03ec1c06ab8074e79987e1":{"kind":"REWORK","_number":1,"created":"2020-09-10 13:33:25.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/93/750993/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/750993/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/750993/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/750993/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/750993/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/750993/1"}}},"commit":{"parents":[{"commit":"8f7dc3d8700a37956abf567d170ad42863baa4d7","subject":"Merge \"objects: Update keypairs when saving an instance\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8f7dc3d8700a37956abf567d170ad42863baa4d7"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-08-21 17:06:58.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-09-09 14:42:53.000000000","tz":-240},"subject":"post live migration: don\u0027t call Neutron needlessly","message":"post live migration: don\u0027t call Neutron needlessly\n\nIn bug 1879787, the call to network_api.get_instance_nw_info() in\n_post_live_migration() on the source compute manager eventually calls\nout to the Neutron REST API. If this fails, the exception is\nunhandled, and the migrating instance - which is fully running on the\ndestination at this point - will never be updated in the database.\nThis update normally happens later in\npost_live_migration_at_destination().\n\nThe network_info variable obtained from get_instance_nw_info() is used\nfor two things: notifications - which aren\u0027t critical - and unplugging\nthe instance\u0027s vifs on the source - which is very important!\n\nIt turns out that at the time of the get_instance_nw_info() call, the\nnetwork info in the instance info cache is still valid for unplugging\nthe source vifs. The port bindings on the destination are only\nactivated by the network_api.migrate_instance_start() [1] call that\nhappens shortly *after* the problematic get_instance_nw_info() call.\nIn other words, get_instance_nw_info() will always return the source\nports. Because of that, we can replace it with a call to\ninstance.get_network_info().\n\nConflict in nova/tests/unit/compute/test_compute_mgr.py due to\ndifferent mocks in the context and\nabsence of test_post_live_migration_unplug_with_stashed_source_vifs\n(which is part of the context and confuses git)\n\n[1] https://opendev.org/openstack/nova/src/commit/d9e04c4ff0b1a9c3383f1848dc846e93030d83cb/nova/network/neutronv2/api.py#L2493-L2522\n\nChange-Id: If0fbae33ce2af198188c91638afef939256c2556\nCloses-bug: 1879787\n(cherry picked from commit 6488a5dfb293831a448596e2084f484dd0bfa916)\n(cherry picked from commit 2c949cb3eea9cd9282060da12d32771582953aa2)\n(cherry picked from commit 7ace26e4bcd69a0a3d780cfae9f6745e4177b6c2)\n(cherry picked from commit 703c8ef4e6d282ce26c3527ecbbe6dc3f47b363f)\n(cherry picked from commit a1d3ae3876eb394bf594625e3c3cd1f0892d9ea6)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d292edf7725b8e432f03ec1c06ab8074e79987e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d292edf7725b8e432f03ec1c06ab8074e79987e1"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}