)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ba3c9ca7bcdc80b1580c4f6c800eee1ee4f3ab29","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tox: Enable parallel docs build"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This significantly speeds up our doc build process. This requires a"},{"line_number":10,"context_line":"newer version of \u0027sphinx-feature-classification\u0027 and some tweaks to our"},{"line_number":11,"context_line":"own in-tree extensions. While we\u0027re here, we drop the \u0027-d DOCTREE_DIR\u0027"},{"line_number":12,"context_line":"parameter since it\u0027s of no use when we blast away our previously built"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a30df3e8_edce8c5d","line":9,"updated":"2021-01-27 17:02:57.000000000","message":"Any ballpark idea of the time difference? Looking at recent builds [1] it looks like the job typically takes around 10 minutes.\n\n[1] https://zuul.openstack.org/builds?job_name\u003dopenstack-tox-docs\u0026project\u003dopenstack%2Fnova","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2784b8314204bfd04bac46a6e22068b13ebf393","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tox: Enable parallel docs build"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This significantly speeds up our doc build process. This requires a"},{"line_number":10,"context_line":"newer version of \u0027sphinx-feature-classification\u0027 and some tweaks to our"},{"line_number":11,"context_line":"own in-tree extensions. While we\u0027re here, we drop the \u0027-d DOCTREE_DIR\u0027"},{"line_number":12,"context_line":"parameter since it\u0027s of no use when we blast away our previously built"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"af0c17b5_0b54ef1e","line":9,"in_reply_to":"a30df3e8_edce8c5d","updated":"2021-01-27 17:39:35.000000000","message":"The docs job runs both the docs and pdf-docs tox target. I don\u0027t have a LaTeX environment set up to validate the latter, but the former is about 30-40% faster, based on the following (with an already prepped tox virtualenv):\n\n  $ rm -rf doc/build/; time tox -e docs\n\nBefore:\n\n  real    0m43.931s\n  user    0m39.463s\n  sys     0m5.249s\n\nAfter:\n\n  real    0m28.885s\n  user    0m48.333s\n  sys     0m6.421s\n\nWe\u0027ll have to wait and see what the impact on the gate is, but I suspect it\u0027ll shave a minute or so off at least. It can\u0027t do much more since the LaTeX toolchain is likely causing most of the delays","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"}],"doc/ext/extra_specs.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ba3c9ca7bcdc80b1580c4f6c800eee1ee4f3ab29","unresolved":true,"context_lines":[{"line_number":227,"context_line":"    def merge_domaindata(self, docnames, otherdata):"},{"line_number":228,"context_line":"        for target, docname in otherdata[\u0027extra_specs\u0027].items():"},{"line_number":229,"context_line":"            if docname in docnames:"},{"line_number":230,"context_line":"                self.data[\u0027extra_specs\u0027][target] \u003d docname"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":2,"id":"24e45d25_ce7c51dc","line":230,"updated":"2021-01-27 17:02:57.000000000","message":"What\u0027s this ^? (later) I see now that it\u0027s required for parallel sphinx build.","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2784b8314204bfd04bac46a6e22068b13ebf393","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def merge_domaindata(self, docnames, otherdata):"},{"line_number":228,"context_line":"        for target, docname in otherdata[\u0027extra_specs\u0027].items():"},{"line_number":229,"context_line":"            if docname in docnames:"},{"line_number":230,"context_line":"                self.data[\u0027extra_specs\u0027][target] \u003d docname"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":2,"id":"95f32a58_22b6ee84","line":230,"in_reply_to":"24e45d25_ce7c51dc","updated":"2021-01-27 17:39:35.000000000","message":"Yes, this is a required method for parallel builds and Sphinx will cry if it\u0027s not present. All this is doing is collecting data from the different runners into one central location.","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"}],"tox.ini":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"c450a8c11b84ce249ed4b16dc8119b716447e7fa","unresolved":true,"context_lines":[{"line_number":182,"context_line":"# to install (test-)requirements.txt for docs."},{"line_number":183,"context_line":"deps \u003d"},{"line_number":184,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":185,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/html doc/build/doctrees"},{"line_number":188,"context_line":"  sphinx-build -W --keep-going -b html -j auto doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3ee211ef_4cefc7c9","line":185,"range":{"start_line":185,"start_character":2,"end_line":185,"end_character":36},"updated":"2021-01-27 18:05:24.000000000","message":"I was thinking about this re: oslo.config \u003e\u003d 8.4.0. Why wouldn\u0027t we want to put the requirement in here?","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9152b973c10a4996491d18e5eaf87cbe373c7a2b","unresolved":true,"context_lines":[{"line_number":182,"context_line":"# to install (test-)requirements.txt for docs."},{"line_number":183,"context_line":"deps \u003d"},{"line_number":184,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":185,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/html doc/build/doctrees"},{"line_number":188,"context_line":"  sphinx-build -W --keep-going -b html -j auto doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5b0027bd_e03c4229","line":185,"range":{"start_line":185,"start_character":2,"end_line":185,"end_character":36},"in_reply_to":"3ee211ef_4cefc7c9","updated":"2021-01-27 21:10:26.000000000","message":"pip does technical allow this, but the lower-constraints job won\u0027t because the lower bound specified in \u0027lower-constraints.txt\u0027 won\u0027t match the minimum in \u0027doc/requirements.txt\u0027. More importantly, who would this actually help? It won\u0027t help tox users, since pip will always try to use the latest version of a dependency allowed by upper-constraints anyway (run \u0027tox -e docs\u0027 now - oslo.config 8.4.0, i.e. the latest version, will be installed). It won\u0027t help packagers either, since there\u0027s generally a separate \u0027-doc\u0027 package in addition to the main package, and those would need to use the new oslo.config version for both, use two different oslo.config versions for the different packages (can you even do that in e.g. an RPM-based system?), or use the older oslo.config version for both and build docs serially. I seriously expect they\u0027ll do the latter since that is obviously what they\u0027ve been doing all along.\n\nI can just bump the version in requirement.txt if you\u0027d like, but I do think what I\u0027ve proposed will work graaaand","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a71091419b8013ba302f34c6553ed67517f41615","unresolved":true,"context_lines":[{"line_number":182,"context_line":"# to install (test-)requirements.txt for docs."},{"line_number":183,"context_line":"deps \u003d"},{"line_number":184,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":185,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/html doc/build/doctrees"},{"line_number":188,"context_line":"  sphinx-build -W --keep-going -b html -j auto doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"2bb2056b_af2309b7","line":185,"range":{"start_line":185,"start_character":2,"end_line":185,"end_character":36},"in_reply_to":"5b0027bd_e03c4229","updated":"2021-01-27 21:33:48.000000000","message":"Thanks. I was missing that it wouldn\u0027t work because of lower-constraints. I was just thinking why wouldn\u0027t we put the requirement in doc/requirements.txt if there is a requirement? I understand now.","commit_id":"7062e1db8bc71ecf881f70fc149a27ca1532061d"}]}