)]}'
{"id":"openstack%2Fnova~751368","triplet_id":"openstack%2Fnova~stable%2Ftrain~I26b050c402f5721fc490126e9becb643af9279b4","project":"openstack/nova","branch":"stable/train","topic":"bug/1879878","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-09-01 16:55:00.000000000","reason":"Change was abandoned"},"10135":{"account":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"last_update":"2023-09-01 16:55:00.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I26b050c402f5721fc490126e9becb643af9279b4","subject":"Move confirm resize under semaphore","status":"ABANDONED","created":"2020-09-11 17:20:55.000000000","updated":"2023-09-01 16:55:00.000000000","total_comment_count":5,"unresolved_comment_count":4,"has_review_started":true,"meta_rev_id":"986b34f86a87b69a0046e67d32ba0f89cbcd13a2","_number":751368,"virtual_id_number":751368,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-02-05 00:04:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"recommended":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2022-06-15 12:12:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":1,"date":"2021-02-09 19:10:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-14 11:11:21.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-18 14:39:47.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-09-18 16:57:57.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-09-18 18:41:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-18 21:15:19.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-04 17:13:23.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2021-02-09 19:10:44.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2022-06-15 12:12:10.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"0e51b1673165510708233e41ad2b8a7fc6f83e66","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-11 17:20:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"75f1f2838037d4d8a77a52a30d0e40926101a57b","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-11 17:36:37.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/751368/1 : FAILURE in 1m 08s","accounts_in_message":[],"_revision_number":1},{"id":"6fb659a6d05d0822e698c1c3107fba5e7701ac32","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-11 19:37:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/30484f827a8344af9ff2f8629085db9a : SUCCESS in 1h 08m 37s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/1633842401394508a9723d65b3ea1c03 : SUCCESS in 1h 21m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f23c8ffd8ae54fde90f5d9e749d5b1c1 : SUCCESS in 16m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/297bc56b1fc44c3f94d4217ce1d04c54 : SUCCESS in 18m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0a0fc153d36b4a498b05fd547ccf2e48 : FAILURE in 12m 38s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/47f7b39158e34643a8ff1d0291e05405 : SUCCESS in 14m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c90a964c8eca499280ddbcc29ada5662 : SUCCESS in 13m 55s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/cffce0be54604a0c93db1a4e0431309e : SUCCESS in 15m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ce79200f58644e62bfd01eee3777cd72 : SUCCESS in 8m 38s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ba02fcf3b9cd47ba9b4537e72f747270 : SUCCESS in 1h 19m 02s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/33f2f5b61fa948c4aef4812f0947531d : FAILURE in 1h 17m 36s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/0feac70b87f845ad9246f8f8e7a1f120 : SUCCESS in 1h 06m 11s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/89988f986c9f41f1b68aab27fd5950d8 : SUCCESS in 49m 48s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/31d71cd647db4c84af64054e00d75938 : SUCCESS in 57m 14s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/d3a35ed9e3de4d1187f9e0515d35c775 : SUCCESS in 1h 26m 26s\n- nova-next https://zuul.opendev.org/t/openstack/build/1159b1a098204eaf8123de55191c5935 : SUCCESS in 1h 23m 06s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/2a57448c5e08428fb2794965a7dcca61 : FAILURE in 23m 56s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/615939b7f4a041e6a5dfab64679858a8 : FAILURE in 17m 57s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/4467eb54d64b4916a262bf6c0e8e604f : SUCCESS in 2h 04m 20s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/f615e39f91c047b1959eb32fd8c56c40 : SUCCESS in 59m 35s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a7d06e3de8404c4bbb530dc7ba7ce5af : SUCCESS in 1h 05m 26s","accounts_in_message":[],"_revision_number":1},{"id":"032320bfcdb35d595d431d16b0e08f5f121c609d","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-09-12 01:50:35.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/751368/1/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/91a2ee4 : FAILURE in 27m 58s","accounts_in_message":[],"_revision_number":1},{"id":"21a00103d91ecf8d1d737e92befd914771e7f602","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-12 12:25:19.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/1/check/tempest-dsvm-full-bionic/7940db5/ : TIMED_OUT in 2h 39m 37s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/1/check/tempest-dsvm-full-bionic-py3/ed0f1bd/ : SUCCESS in 1h 38m 58s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/1/check/grenade-dsvm-bionic/28001ae/ : POST_FAILURE in 1h 34m 10s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"cc977b1b4c6b8f1061031f1fb3770e88943b7e0e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-14 10:40:12.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"c7f3d75b7cf9defdd624e72771407f10b4a3fe93","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2020-09-14 11:11:21.000000000","message":"Patch Set 2:\n\nTesting failed ubuntu-bionic-s390x. For rechecking only on the ubuntu-bionic-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x http://extbasicopstackcilog01.podc.sl.edst.ibm.com/zkvm_test_logs/production/751368/2/check-tempest-dsvm-neutron-full-ubuntu-bionic-s390x/aa76164 : FAILURE in 27m 04s","accounts_in_message":[],"_revision_number":2},{"id":"71e00e4851ec80218286931c66bb968be4499587","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-09-14 12:15:08.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/68/751368/2/check/pmem-tempest-plugin-filtered-multi-node/8ec1377/ : RETRY_LIMIT in 4m 28s\n- devstack-networking-ovs-dpdk http://52.27.155.124/68/751368/2/check/devstack-networking-ovs-dpdk/612133e/ : RETRY_LIMIT in 1m 55s","accounts_in_message":[],"_revision_number":2},{"id":"113a756f7849a34a40644bed75982eeafbf6799c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 13:06:55.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/eb1ccc4c558b4e8683c0640602b5c559 : SUCCESS in 50m 54s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0787d6624ae141f784960c8dbb9a2063 : SUCCESS in 1h 18m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c762929fc3774a30a882a3ac39454784 : SUCCESS in 18m 04s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/802a95b5897b4b9d878595aa9017d60f : SUCCESS in 14m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ddb51f0a44b5402ba7df6b88ba4f2b01 : FAILURE in 12m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a80d7b7a29a148c9b3cbfb2d346eae44 : SUCCESS in 18m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/02ab4c5d79ee406f9ecc452b0f10cf4b : SUCCESS in 12m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f35e9b40c1664d5f926bbf1e5ef9bd5a : SUCCESS in 14m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5ce77260a51842a795ef9d1e41d94537 : SUCCESS in 10m 33s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/f192efa1a38647d7b9c70387ca466157 : SUCCESS in 1h 07m 53s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/c623aa19c6a04fbdaa06a74e9c8f466d : FAILURE in 1h 05m 20s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/4221102306c24c40926c084994b7737d : SUCCESS in 1h 07m 49s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/a628e9d645aa48b68cac049f054f2898 : SUCCESS in 1h 07m 44s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6e304a12781544f395a0692f332b2890 : SUCCESS in 55m 34s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/031470cef6854b5c8091b8aa9b1f11e6 : SUCCESS in 1h 30m 55s\n- nova-next https://zuul.opendev.org/t/openstack/build/503bc023e75e4cb2bd77255cc1cd6b35 : SUCCESS in 1h 23m 35s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/9664677aa7244715b7f26a16c0edbb14 : SUCCESS in 21m 05s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9f13427a19424353914a7be9f0c8f27c : SUCCESS in 17m 36s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/d5b9cb4d016a4863a33e857d39c8d21a : SUCCESS in 2h 01m 55s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/e7218c87c65f4fb18645fdbd3cdd7a44 : SUCCESS in 55m 37s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/277ddfde5a12483a81f317e0420aef54 : SUCCESS in 46m 22s","accounts_in_message":[],"_revision_number":2},{"id":"0713672977095dec3a63a4d7c5af5bdc832b66b2","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-14 13:28:13.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/751368/2 : FAILURE in 2h 30m 49s","accounts_in_message":[],"_revision_number":2},{"id":"bf30153be92ea51135e35728594d2f8471885898","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-14 14:18:30.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/2/check/tempest-dsvm-full-bionic/50fbe77/ : TIMED_OUT in 2h 40m 02s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/2/check/tempest-dsvm-full-bionic-py3/23cf6f5/ : SUCCESS in 1h 53m 35s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/2/check/grenade-dsvm-bionic/026d98a/ : POST_FAILURE in 1h 22m 42s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b22e3f8a40d652286f1acab48f94eb77f2631ba3","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-18 14:14:08.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"a2ba644487fa090158d2156a77f38797555efb16","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-09-18 14:39:47.000000000","message":"Patch Set 2:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/68/751368/2/check/pmem-tempest-plugin-filtered-multi-node/19b65b8/ : RETRY_LIMIT in 4m 03s","accounts_in_message":[],"_revision_number":2},{"id":"4171f7f160f2204007926d72a41b7435d91661d0","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-09-18 16:57:57.000000000","message":"Patch Set 2:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/751368/2 : FAILURE in 2h 37m 26s","accounts_in_message":[],"_revision_number":2},{"id":"982f496e91ba6289414e1da6e832e2e2098141d3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 18:41:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/45c73156ca9e4b1e8ddcbc99a5d1ad77 : SUCCESS in 1h 04m 16s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/c4483d8b778b4672a8c93ccfb6210782 : SUCCESS in 1h 12m 38s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/67481690082d4e89b603e7fa17ca89fb : SUCCESS in 17m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0c85fee07e6d4b3cbdc4df68c029a67c : SUCCESS in 13m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d6ced04f56af42c196c8504faf4dcb9d : SUCCESS in 11m 17s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2c7ab6fcf3b54b6cbc84dd627c938113 : SUCCESS in 13m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/06c9d1c0f9254be0b9484975660c679d : SUCCESS in 12m 01s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e662a6da192c4257912c98f6e81eb6f6 : SUCCESS in 12m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/84926390a3ae4be7a8d86c49c6efe4ad : SUCCESS in 16m 33s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/3ff75f782a734bee8b6cf0b8f3e39722 : SUCCESS in 1h 17m 07s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/b6a65905c21544aa9ca8830dde49a1ca : FAILURE in 1h 06m 51s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/0b94e47aeb1f4808b125f5e7d08d026e : SUCCESS in 1h 18m 00s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/20a7580af4ff4c54a39378b3ec7aac43 : SUCCESS in 1h 11m 18s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/63f18fe53b434177ad4e90747bc6ba21 : SUCCESS in 54m 24s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ba8bc4fe36ac474cba18e48a3dc782dc : SUCCESS in 1h 26m 23s\n- nova-next https://zuul.opendev.org/t/openstack/build/a36fedbc1d344388ae610eb1ff60d662 : SUCCESS in 1h 18m 17s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/cbf3d0118d1f4a00aa160fd9e166abad : SUCCESS in 21m 09s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/56647a63e3354f9390e38448d0c26c0f : SUCCESS in 16m 14s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/89a0fe5577a046bca571ab25f39a0424 : SUCCESS in 2h 20m 38s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/5f0501ed88a04408b6323968bc478c85 : SUCCESS in 1h 04m 00s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/863ad06c8bf949b99103759c2a25feab : SUCCESS in 59m 32s","accounts_in_message":[],"_revision_number":2},{"id":"3bd75b77158488c59d2bbf36663ec4fa029e5113","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-09-18 21:15:19.000000000","message":"Patch Set 2:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/2/check/tempest-dsvm-full-bionic/eaaa9f3/ : TIMED_OUT in 2h 39m 35s\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/2/check/tempest-dsvm-full-bionic-py3/88e7aa0/ : SUCCESS in 1h 29m 52s\n- grenade-dsvm-bionic https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/68/751368/2/check/grenade-dsvm-bionic/7d2db78/ : POST_FAILURE in 1h 22m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9c08d6d66632521e89abf75e901bdaafa6d57800","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2021-02-04 17:13:23.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"329c3f00d3f61aa90a4e10d50326a41cea17f0f5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-02-04 19:48:06.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/751368/3/iscsi : FAILURE in 11m 20s","accounts_in_message":[],"_revision_number":3},{"id":"baf5b999805b06588bbf56f22f198a6446be5dab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-05 00:04:47.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/37b323f5de564955a6a256fadd0aeba4 : SUCCESS in 1h 21m 03s\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/56ebf22b4c9a49cabbfa163cdf42e766 : SUCCESS in 1h 12m 02s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ee3370ff5d5041bdaf2003349eb56a3e : SUCCESS in 17m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8021dc19fc1a452c950faecb8d0b4cba : SUCCESS in 14m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/303d41b91c02484eadfc2fe8cbc6ec7a : SUCCESS in 11m 19s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7d1b6e789e464e28af6fead0c709c644 : SUCCESS in 13m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/57511417f26b4d7f928ae5d87a920237 : SUCCESS in 11m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/54ff221d9ce94f789c19128daa1aa35c : SUCCESS in 16m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1d1b7855c1a64338ad399662aa1ac555 : SUCCESS in 10m 23s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/7fa6018602a14a0d88557dbd60e9171a : SUCCESS in 1h 08m 36s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/11de70c023aa4153811a540313db7e56 : SUCCESS in 1h 16m 21s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/b46f97bd8dd44d9596d8e6b9c6118a82 : SUCCESS in 1h 01m 28s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/254b43ba40d1421aac8984f565d919c9 : SUCCESS in 1h 33m 09s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/ae90bcf2cc574f84931382e52ebf55ec : SUCCESS in 54m 29s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/7551f850f9ea4b8e9dc3f8a65893e96e : SUCCESS in 1h 20m 27s\n- nova-next https://zuul.opendev.org/t/openstack/build/62f987bd254f4a3f8ed4e49390b5def0 : SUCCESS in 1h 16m 09s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bdb0bd9b5a65489cad701d5c62a0498e : SUCCESS in 21m 28s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/88b9d465a05448259645d8d81e9bf80b : SUCCESS in 20m 17s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/62f3d52b645742dab64f861709a94ac0 : SUCCESS in 2h 22m 36s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/e4511648867d47209589b860ecc19a58 : SUCCESS in 54m 10s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3300c76862ab4cdc883b13d34e00db43 : SUCCESS in 53m 16s","accounts_in_message":[],"_revision_number":3},{"id":"9e72f179038e5f89a30da34da3b5917f618e645f","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-02-09 19:10:44.000000000","message":"Patch Set 3: Code-Review+1\n\n(4 comments)\n\nI was hesitant: due to the missing \u0027fair lock\u0027 patch, whether we introduce some regression with this patch (causing an issue similar to the described in patch Ia5e521e0f0c7a78b5ace5de9f343e84d872553f9), but if I understand correctly the lock is already there, the lock is \u0027just\u0027 extended to         contain the migration status update + save + instance.drop_migration_context() calls.\n\nAnyway, giving just +1 but ready to give +2 if another stable core confirms that my above thinking is correct and we don\u0027t introduce regression.\n\nOtherwise, the backport looks OK to me, merged in Ussuri, conflicts noted (for the next reviewers: see my extra comments for the conflicts inline).","accounts_in_message":[],"_revision_number":3},{"id":"1787a890483a0328fd9e3dbc85b40c3067f94883","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-06-15 12:12:10.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"986b34f86a87b69a0046e67d32ba0f89cbcd13a2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:55:00.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c957bd81bae1f23b566b6a51ae96bdca89897719","revisions":{"78a4ec49bf735cba5477b030537074a627032e55":{"kind":"REWORK","_number":1,"created":"2020-09-11 17:20:55.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/68/751368/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/751368/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/751368/1"}}},"commit":{"parents":[{"commit":"d9cdf4659d86bb7f9f2c443f69e0e0cd502e8a27","subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d9cdf4659d86bb7f9f2c443f69e0e0cd502e8a27"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-21 15:54:16.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-09-11 17:17:45.000000000","tz":60},"subject":"Move confirm resize under semaphore","message":"Move confirm resize under semaphore\n\nThe \u0027ResourceTracker.update_available_resource\u0027 periodic task builds\nusage information for the current host by inspecting instances and\nin-progress migrations, combining the two. Specifically, it finds all\ninstances that are not in the \u0027DELETED\u0027 or \u0027SHELVED_OFFLOADED\u0027 state,\ncalculates the usage from these, then finds all in-progress migrations\nfor the host that don\u0027t have an associated instance (to prevent double\naccounting) and includes the usage for these.\n\nIn addition to the periodic task, the \u0027ResourceTracker\u0027 class has a\nnumber of helper functions to make or drop claims for the inventory\ngenerated by the \u0027update_available_resource\u0027 periodic task as part of\nthe various instance operations. These helpers naturally assume that\nwhen making a claim for a particular instance or migration, there\nshouldn\u0027t already be resources allocated for same. Conversely, when\ndropping claims, the resources should currently be allocated. However,\nthe check for *active* instances and *in-progress* migrations in the\nperiodic task means we have to be careful in how we make changes to a\ngiven instance or migration record. Running the periodic task between\nsuch an operation and an attempt to make or drop a claim can result in\nTOCTOU-like races.\n\nThis generally isn\u0027t an issue: we use the \u0027COMPUTE_RESOURCE_SEMAPHORE\u0027\nsemaphore to prevent the periodic task running while we\u0027re claiming\nresources in helpers like \u0027ResourceTracker.instance_claim\u0027 and we make\nour changes to the instances and migrations within this context. There\nis one exception though: the \u0027drop_move_claim\u0027 helper. This function is\nused when dropping a claim for either a cold migration, a resize or a\nlive migration, and will drop usage from either the source host (based\non the \"old\" flavor) for a resize confirm or the destination host (based\non the \"new\" flavor) for a resize revert or live migration rollback.\nUnfortunately, while the function itself is wrapped in the semaphore, no\nchanges to the state or the instance or migration in question are\nprotected by it.\n\nConsider the confirm resize case, which we\u0027re addressing here. If we\nmark the migration as \u0027confirmed\u0027 before running \u0027drop_move_claim\u0027, then\nthe periodic task running between these steps will not account for the\nusage on the source since the migration is allegedly \u0027confirmed\u0027. The\ncall to \u0027drop_move_claim\u0027 will then result in the tracker dropping usage\nthat we\u0027re no longer accounting for. This \"set migration status before\ndropping usage\" is the current behaviour for both same-cell and\ncross-cell resize, via the \u0027ComputeManager.confirm_resize\u0027 and\n\u0027ComputeManager.confirm_snapshot_based_resize_at_source\u0027 functions,\nrespectively. We could reverse those calls and run \u0027drop_move_claim\u0027\nbefore marking the migration as \u0027confirmed\u0027, but while our usage will be\nmomentarily correct, the periodic task running between these steps will\nre-add the usage we just dropped since the migration isn\u0027t yet\n\u0027confirmed\u0027. The correct solution is to close this gap between setting\nthe migration status and dropping the move claim to zero. We do this by\nputting both operations behind the \u0027COMPUTE_RESOURCE_SEMAPHORE\u0027, just\nlike the claim operations.\n\nConflicts:\n  nova/compute/manager.py\n  nova/compute/resource_tracker.py\n  nova/conductor/tasks/cross_cell_migrate.py\n  nova/tests/unit/compute/test_compute_mgr.py\n\nNOTE(stephenfin): The bulk of the conflicts are due to the absence of\nvarious cross-cell resize related patches. The only exception is the\nconflict in \u0027nova/compute/resource_tracker.py\u0027, which is due to the\nabsence of change Ia5e521e0f0c7a78b5ace5de9f343e84d872553f9 (\"Use fair\nlocks in resource tracker\") which we can\u0027t backport since it requires a\nfeature only found in newer versions of \u0027oslo.concurrency\u0027 and mandates\na lower constraint bump.\n\nChange-Id: I26b050c402f5721fc490126e9becb643af9279b4\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nPartial-Bug: #1879878\n(cherry picked from commit a57800d3825ef2fb833d8024c6f7e5c550f55e2f)\n(cherry picked from commit 4fcada57d6c569a3b9c8094cdfb37b77ec2a8cb5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78a4ec49bf735cba5477b030537074a627032e55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/78a4ec49bf735cba5477b030537074a627032e55"}]},"branch":"refs/heads/stable/train"},"602a219f26cbe0cae34b68f69b2398e0042338d5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-09-14 10:40:12.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/68/751368/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/751368/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/751368/2"}}},"commit":{"parents":[{"commit":"d45ca76a045bf3f8fbfd865bb7add7026b192a07","subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d45ca76a045bf3f8fbfd865bb7add7026b192a07"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-21 15:54:16.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-09-14 10:39:32.000000000","tz":60},"subject":"Move confirm resize under semaphore","message":"Move confirm resize under semaphore\n\nThe \u0027ResourceTracker.update_available_resource\u0027 periodic task builds\nusage information for the current host by inspecting instances and\nin-progress migrations, combining the two. Specifically, it finds all\ninstances that are not in the \u0027DELETED\u0027 or \u0027SHELVED_OFFLOADED\u0027 state,\ncalculates the usage from these, then finds all in-progress migrations\nfor the host that don\u0027t have an associated instance (to prevent double\naccounting) and includes the usage for these.\n\nIn addition to the periodic task, the \u0027ResourceTracker\u0027 class has a\nnumber of helper functions to make or drop claims for the inventory\ngenerated by the \u0027update_available_resource\u0027 periodic task as part of\nthe various instance operations. These helpers naturally assume that\nwhen making a claim for a particular instance or migration, there\nshouldn\u0027t already be resources allocated for same. Conversely, when\ndropping claims, the resources should currently be allocated. However,\nthe check for *active* instances and *in-progress* migrations in the\nperiodic task means we have to be careful in how we make changes to a\ngiven instance or migration record. Running the periodic task between\nsuch an operation and an attempt to make or drop a claim can result in\nTOCTOU-like races.\n\nThis generally isn\u0027t an issue: we use the \u0027COMPUTE_RESOURCE_SEMAPHORE\u0027\nsemaphore to prevent the periodic task running while we\u0027re claiming\nresources in helpers like \u0027ResourceTracker.instance_claim\u0027 and we make\nour changes to the instances and migrations within this context. There\nis one exception though: the \u0027drop_move_claim\u0027 helper. This function is\nused when dropping a claim for either a cold migration, a resize or a\nlive migration, and will drop usage from either the source host (based\non the \"old\" flavor) for a resize confirm or the destination host (based\non the \"new\" flavor) for a resize revert or live migration rollback.\nUnfortunately, while the function itself is wrapped in the semaphore, no\nchanges to the state or the instance or migration in question are\nprotected by it.\n\nConsider the confirm resize case, which we\u0027re addressing here. If we\nmark the migration as \u0027confirmed\u0027 before running \u0027drop_move_claim\u0027, then\nthe periodic task running between these steps will not account for the\nusage on the source since the migration is allegedly \u0027confirmed\u0027. The\ncall to \u0027drop_move_claim\u0027 will then result in the tracker dropping usage\nthat we\u0027re no longer accounting for. This \"set migration status before\ndropping usage\" is the current behaviour for both same-cell and\ncross-cell resize, via the \u0027ComputeManager.confirm_resize\u0027 and\n\u0027ComputeManager.confirm_snapshot_based_resize_at_source\u0027 functions,\nrespectively. We could reverse those calls and run \u0027drop_move_claim\u0027\nbefore marking the migration as \u0027confirmed\u0027, but while our usage will be\nmomentarily correct, the periodic task running between these steps will\nre-add the usage we just dropped since the migration isn\u0027t yet\n\u0027confirmed\u0027. The correct solution is to close this gap between setting\nthe migration status and dropping the move claim to zero. We do this by\nputting both operations behind the \u0027COMPUTE_RESOURCE_SEMAPHORE\u0027, just\nlike the claim operations.\n\nConflicts:\n  nova/compute/manager.py\n  nova/compute/resource_tracker.py\n  nova/conductor/tasks/cross_cell_migrate.py\n  nova/tests/unit/compute/test_compute_mgr.py\n\nNOTE(stephenfin): The bulk of the conflicts are due to the absence of\nvarious cross-cell resize related patches. The only exception is the\nconflict in \u0027nova/compute/resource_tracker.py\u0027, which is due to the\nabsence of change Ia5e521e0f0c7a78b5ace5de9f343e84d872553f9 (\"Use fair\nlocks in resource tracker\") which we can\u0027t backport since it requires a\nfeature only found in newer versions of \u0027oslo.concurrency\u0027 and mandates\na lower constraint bump.\n\nChange-Id: I26b050c402f5721fc490126e9becb643af9279b4\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nPartial-Bug: #1879878\n(cherry picked from commit a57800d3825ef2fb833d8024c6f7e5c550f55e2f)\n(cherry picked from commit 4fcada57d6c569a3b9c8094cdfb37b77ec2a8cb5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/602a219f26cbe0cae34b68f69b2398e0042338d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/602a219f26cbe0cae34b68f69b2398e0042338d5"}]},"branch":"refs/heads/stable/train"},"c957bd81bae1f23b566b6a51ae96bdca89897719":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-02-04 17:13:23.000000000","uploader":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"ref":"refs/changes/68/751368/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/751368/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/751368/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/751368/3"}}},"commit":{"parents":[{"commit":"75f9b288f8edfd24affe5ecbc1f3efb6a63726e4","subject":"Don\u0027t unset Instance.old_flavor, new_flavor until necessary","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/75f9b288f8edfd24affe5ecbc1f3efb6a63726e4"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-08-21 15:54:16.000000000","tz":60},"committer":{"name":"Lee Yarwood","email":"lyarwood@redhat.com","date":"2021-02-04 17:12:49.000000000","tz":0},"subject":"Move confirm resize under semaphore","message":"Move confirm resize under semaphore\n\nThe \u0027ResourceTracker.update_available_resource\u0027 periodic task builds\nusage information for the current host by inspecting instances and\nin-progress migrations, combining the two. Specifically, it finds all\ninstances that are not in the \u0027DELETED\u0027 or \u0027SHELVED_OFFLOADED\u0027 state,\ncalculates the usage from these, then finds all in-progress migrations\nfor the host that don\u0027t have an associated instance (to prevent double\naccounting) and includes the usage for these.\n\nIn addition to the periodic task, the \u0027ResourceTracker\u0027 class has a\nnumber of helper functions to make or drop claims for the inventory\ngenerated by the \u0027update_available_resource\u0027 periodic task as part of\nthe various instance operations. These helpers naturally assume that\nwhen making a claim for a particular instance or migration, there\nshouldn\u0027t already be resources allocated for same. Conversely, when\ndropping claims, the resources should currently be allocated. However,\nthe check for *active* instances and *in-progress* migrations in the\nperiodic task means we have to be careful in how we make changes to a\ngiven instance or migration record. Running the periodic task between\nsuch an operation and an attempt to make or drop a claim can result in\nTOCTOU-like races.\n\nThis generally isn\u0027t an issue: we use the \u0027COMPUTE_RESOURCE_SEMAPHORE\u0027\nsemaphore to prevent the periodic task running while we\u0027re claiming\nresources in helpers like \u0027ResourceTracker.instance_claim\u0027 and we make\nour changes to the instances and migrations within this context. There\nis one exception though: the \u0027drop_move_claim\u0027 helper. This function is\nused when dropping a claim for either a cold migration, a resize or a\nlive migration, and will drop usage from either the source host (based\non the \"old\" flavor) for a resize confirm or the destination host (based\non the \"new\" flavor) for a resize revert or live migration rollback.\nUnfortunately, while the function itself is wrapped in the semaphore, no\nchanges to the state or the instance or migration in question are\nprotected by it.\n\nConsider the confirm resize case, which we\u0027re addressing here. If we\nmark the migration as \u0027confirmed\u0027 before running \u0027drop_move_claim\u0027, then\nthe periodic task running between these steps will not account for the\nusage on the source since the migration is allegedly \u0027confirmed\u0027. The\ncall to \u0027drop_move_claim\u0027 will then result in the tracker dropping usage\nthat we\u0027re no longer accounting for. This \"set migration status before\ndropping usage\" is the current behaviour for both same-cell and\ncross-cell resize, via the \u0027ComputeManager.confirm_resize\u0027 and\n\u0027ComputeManager.confirm_snapshot_based_resize_at_source\u0027 functions,\nrespectively. We could reverse those calls and run \u0027drop_move_claim\u0027\nbefore marking the migration as \u0027confirmed\u0027, but while our usage will be\nmomentarily correct, the periodic task running between these steps will\nre-add the usage we just dropped since the migration isn\u0027t yet\n\u0027confirmed\u0027. The correct solution is to close this gap between setting\nthe migration status and dropping the move claim to zero. We do this by\nputting both operations behind the \u0027COMPUTE_RESOURCE_SEMAPHORE\u0027, just\nlike the claim operations.\n\nConflicts:\n  nova/compute/manager.py\n  nova/compute/resource_tracker.py\n  nova/conductor/tasks/cross_cell_migrate.py\n  nova/tests/unit/compute/test_compute_mgr.py\n\nNOTE(stephenfin): The bulk of the conflicts are due to the absence of\nvarious cross-cell resize related patches. The only exception is the\nconflict in \u0027nova/compute/resource_tracker.py\u0027, which is due to the\nabsence of change Ia5e521e0f0c7a78b5ace5de9f343e84d872553f9 (\"Use fair\nlocks in resource tracker\") which we can\u0027t backport since it requires a\nfeature only found in newer versions of \u0027oslo.concurrency\u0027 and mandates\na lower constraint bump.\n\nChange-Id: I26b050c402f5721fc490126e9becb643af9279b4\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nPartial-Bug: #1879878\n(cherry picked from commit a57800d3825ef2fb833d8024c6f7e5c550f55e2f)\n(cherry picked from commit 4fcada57d6c569a3b9c8094cdfb37b77ec2a8cb5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c957bd81bae1f23b566b6a51ae96bdca89897719"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c957bd81bae1f23b566b6a51ae96bdca89897719"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}