)]}'
{"nova/tests/functional/regressions/test_bug_1894966.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5f450397e9fc975188340252f5218bc0918104b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.api \u003d api_fixture.api"},{"line_number":33,"context_line":"        self.api.microversion \u003d \u00272.63\u0027  # the last version with the bug"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_create_with_empty_policies(self):"},{"line_number":36,"context_line":"        exc \u003d self.assertRaises("},{"line_number":37,"context_line":"            client.OpenStackApiException,"},{"line_number":38,"context_line":"            self.api.post_server_groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_94c2ac85","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":46},"updated":"2020-09-16 13:38:57.000000000","message":"I did not know we had test for 500 :)","commit_id":"32c43fc8017ee89d4e6cdf79086d87735a00f0c0"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dce352106876a35d3d3d6ef5b73b7ad70bda9dd6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            client.OpenStackApiException,"},{"line_number":38,"context_line":"            self.api.post_server_groups,"},{"line_number":39,"context_line":"            {\u0027name\u0027: \u0027test group\u0027, \u0027policies\u0027: []})"},{"line_number":40,"context_line":"        self.assertEqual(400, exc.response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_48ba3d6e","line":40,"updated":"2020-09-16 10:40:53.000000000","message":"https://docs.openstack.org/nova/pike/contributor/microversions.html\n\nA microversion is needed when the contract to the user is changed. The user contract covers many kinds of information such as:\n\nthe Response\n\n* changing a status code on a particular response\n\n* Example: changing the return code of an API from 501 to 400.","commit_id":"32c43fc8017ee89d4e6cdf79086d87735a00f0c0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b5f450397e9fc975188340252f5218bc0918104b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            client.OpenStackApiException,"},{"line_number":38,"context_line":"            self.api.post_server_groups,"},{"line_number":39,"context_line":"            {\u0027name\u0027: \u0027test group\u0027, \u0027policies\u0027: []})"},{"line_number":40,"context_line":"        self.assertEqual(400, exc.response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f4d3285e","line":40,"in_reply_to":"9f560f44_48ba3d6e","updated":"2020-09-16 13:38:57.000000000","message":"Brin, we do not need microversion for this case when any error code (500) is changed to existing returned error code[1]. If newly changed error code is new to that API then we need but 400, 403, 404 and, 415 are universal error code every API return in various sceanrio. \n\n[1] https://docs.openstack.org/nova/pike/contributor/microversions.html#id2","commit_id":"32c43fc8017ee89d4e6cdf79086d87735a00f0c0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f8f219cb31d36aae3e4b326eb37f8e85fa22f493","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            client.OpenStackApiException,"},{"line_number":38,"context_line":"            self.api.post_server_groups,"},{"line_number":39,"context_line":"            {\u0027name\u0027: \u0027test group\u0027, \u0027policies\u0027: []})"},{"line_number":40,"context_line":"        self.assertEqual(400, exc.response.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_34df603b","line":40,"in_reply_to":"9f560f44_f4d3285e","updated":"2020-09-16 13:44:42.000000000","message":"This is absolutely correct and the docs are clear :\n\"Fixing a bug so that a 400+ code is returned rather than a 500 or 503 does not require a microversion change.\"\nhttps://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion","commit_id":"32c43fc8017ee89d4e6cdf79086d87735a00f0c0"}]}